The property was introduced with PR #870 but it missed to convert network byte order to host byte order, so the comparison
wasn't working correctly and the corresponding unit test failed. @marek-safar erroneously "fixed" the test in 27e07c7.
This is the corrected implementation and the original test now works as intended.
Modulo the GUID in the assembly and the GUID embedded in some
field initializers that use the assembly GUID for their name, the
assemblies are idential before and after the patch.
* System.Net/System.Net.Sockets/SocketException_2_1.cs:
* System.Net/System.Net/WebClient_2_1.cs:
* System.Net/System.Net/WebRequest_2_1.cs:
* System/System.Net.Sockets/Socket_2_1.cs:
* System/System.Net/Cookie.cs:
* System/System.Net/DnsEndPoint.cs:
* System/System.Net/EndPoint.cs:
* System/System.Net/IPAddress.cs:
* System/System.Net/IPEndPoint.cs:
* System/System.Net/SocketAddress.cs:
Remove all red ! from corcompare in System.Net.dll (Silverlight
4 profile) to make it easier to pinpoint other errors/warnings.
* IPAddress.cs: handle sign extension for the high byte when using the
byte[] ctor for an IPv4 address.
Fixes bug #467472.
svn path=/trunk/mcs/; revision=123856
* Uri.cs: Use exception-less operations.
2008-08-06 Miguel de Icaza <[email protected]>
* IPAddress.cs (ParseIPV6): Use an exception-less parser for ipv6
addresses.
* IPv6Address.cs: Rewrite most of the parsing code to not use that
incredibly fragile, hacky and hacky implementation.
(TryParse): Provide a exception-less parsing path.
svn path=/trunk/mcs/; revision=109802
* IPAddress.cs : several IPv4 parsing fix exposed by bug #411920.
* IPAddressTest.cs : added test strings for bug #411920 as well as
enabling some ipv4ParseOK strings.
svn path=/trunk/mcs/; revision=109737
(TryParse): Changed argument name to match MS.
(ParseIPV4): Only treat zero-length or " " address as empty on 1.0
profile. On 2.0 profile, only ignore characters after blank if last
part is valid hex string.
* IPv6Address.cs: Removed extra spaces and tabs.
* IPAddressTest.cs: Remove use of deprecated Assertion. Improved
existing tests.
svn path=/trunk/mcs/; revision=94052
ctor. Added null checks for the address passed in the ctors.
* IPAddressTest.cs: Added 4-byte and null address tests.
svn path=/trunk/mcs/; revision=70191
* IPAddress.cs: The condition in 1.1 was broken, it only allowed
16-byte addresses, and never 4-byte addresses (only 2.0 had
them).
Keep a single code path.
Also, remove all the NET_1_1 defines, we realistically only
distinguish between 1.1 and 2.0, we wont likely support 1.0, 1.1
and 2.0, so remove the 1.0 vs 1.1 conditionals.
Fixes 76792
svn path=/trunk/mcs/; revision=70174
* IPAddress.cs : ugh, I was testing with run-test-ondotnet, not
run-test. Those IPv6 properties needed to be reimplemented.
* IPAddressTest.cs : actually #11 in TryParse() is not working.
added more tests on IsIPv6Blah properties.
svn path=/trunk/mcs/; revision=58634
* IPAddress.cs : added NET_2_0 TryParse() and IPv6 related properties.
* IPAddressTest.cs : added some tests for TryParse() and IPv6 related
properties.
svn path=/trunk/mcs/; revision=58613
* Uri.cs: Pragma disable warning 612 (Obsolete methods are being
used by us internally).
Ponder: should we instead move our methods to use new versions of
the Obsoleted ones?
2006-03-11 Miguel de Icaza <[email protected]>
* CodeNamespaceImportCollection.cs: It turns out that a lot of the
errors flagged with "!" were just missing explicit interface
implementations.
Implement.
2006-03-11 Miguel de Icaza <[email protected]>
* CodeDomConfigurationHandler.cs: Comment out unused methods.
* TempFileCollection.cs: Implement explicitly some interface
methods to get rid of the "!" errors on CorCompare.
2006-03-11 Miguel de Icaza <[email protected]>
* Queue.cs: Flag as serializable.
* LinkedList.cs (OnDeserialization): Fix signature.
* SortedList.cs: Implement explicitly a few methods that were
flagged by corcompare.
2006-03-11 Miguel de Icaza <[email protected]>
* IOrderedDictionary.cs: Flag GetEnumerator as a "new" method to
avoid warning.
2006-03-11 Miguel de Icaza <[email protected]>
* ConfigurationSettings.cs (ChangeConfigurationSettings): Make
internal to avoid warnings. This routine is called from
System.Web with MethodInfo.Invoke.
2006-03-11 Miguel de Icaza <[email protected]>
* DeflateStream.cs: Comment out DllImport that was not being
used.
2006-03-11 Miguel de Icaza <[email protected]>
* y
* SerialPort.cs: Remove unused variable (writeBuffer).
* SerialPortStream.cs (Dispose): override, not new.
2006-03-11 Miguel de Icaza <[email protected]>
* WebClient.cs: Only expose the right methods to avoid warnings.
* FtpDataStream.cs (Dispose): Fix signature.
* FtpWebResponse.cs: Comment out keepAlive field (unused, sounds
like we are missing features here).
* IPAddress.cs: Move m_HashCode property to the end, and set
pragmas to disable warnings.
2006-03-11 Miguel de Icaza <[email protected]>
* MailAddress.cs: Comment out unused field to remove warning.
2006-03-11 Miguel de Icaza <[email protected]>
* NetworkChange.cs: Use pragmas to eliminate warnings from events
that we do not trigger yet.
This is a candidate for using Aaron's NetworkManager code. But
would make us depend on d-bus.
* NetworkInformationException.cs: Use error_code for ErrorCode,
instead of NativeErrorCode. Fixes warning.
2006-03-11 Miguel de Icaza <[email protected]>
* AuthenticatedStream.cs: Fixed normative parameter names (yes, we
need to do this everywhere one day).
(Close): actually obey the "leaveInnerStreamOpen" setting from the
constructor.
2006-03-11 Miguel de Icaza <[email protected]>
* NetworkStream.cs (Dispose): Use the right signature depending on
the profile being built.
2006-03-11 Miguel de Icaza <[email protected]>
* X509Chain.cs: Flagged member as internal to avoid unused warning.
* X500DistinguishedName.cs: Comment out unused names and move
temporary unused variables inside the comments that were removed
svn path=/trunk/mcs/; revision=57836
particular, " foo" and ".1.1.6" weren't being caught (" foo" because it
started with a space, and ".1.1.6" because the split string accepted a
0-length portion, which would make 1...6 valid, but isn't valid based on
similar test cases).
svn path=/trunk/mcs/; revision=39265
* IPAddress.cs: the icalls for sockets are endianness-aware. So I
changed a few things. Also included a workaround for bug #23547.
svn path=/trunk/mcs/; revision=3867
* IPAddress.cs: use System.BitConverter.IsLittleEndian (suggested
by Paolo) instead of guessing the endianness.
* SocketAddress.cs: implemented Equals() and GetHashcode().
svn path=/trunk/mcs/; revision=3834
* IPAddress.cs: finished all MonoTODO's. Use network order to store
the address. Check for max and min values in Address:set. IsLoopback()
returns now true for all 127.x.y.z. Some more checks in Parse ().
svn path=/trunk/mcs/; revision=3816