This test requires a simple single mapping for Hostname<->IP with one IP and reverse DNS. Using EC2-hosted sites doesn't work as they don't have valid reverse DNS. Use the Jenkins subdomain, since that fits the criteria.
The latter is now hosted on a different IP behind a CDN and the IP may change depending on location.
Using xamarin.com instead fixes the tests for now.
The TestTimeoutPropertyWithServerThatDoesntExist test sometimes failed with a 'ConnectFailure' instead of a 'Timeout'.
As per the discussion in PR #1145, the test should actually check that a ConnectFailure is thrown before the timeout is reached.
This proved unreliable with the 10.128.200.100 IP address, as it was up to the networking stack to decide whether the endpoint can be reached,
which can take quite a long time (sometimes >100secs).
Instead, we now use the loopback address with a port where no service listens, which should be equivalent.
Additionally, the assert which checks for the correct exception switched the 'expected' and 'actual' parameter, which resulted in the wrong output, this is fixed as well.
By using StringAssert we get a more descriptive error message when the test fails, i.e. the expected vs. the actual string value instead of just true/false.
Tests that UploadStringAsync triggers UploadStringCompleted with Cancelled == true.
Tests that UploadDataAsync triggers UploadDataCompleted with Cancelled == true.
Tests that UploadValuesAsync triggers UploadValuesCompleted with Cancelled == true.
Tests that UploadFileAsync triggers UploadFileCompleted with Cancelled == true.
From Dick Porter:
The IPv6 address parser misses some syntax errors, and can become confused by
addresses that at first glance look IPv4 compatible. The attach patch contains
the following fixes:
Don't fail to parse an address if we mistakenly thought it was IPv4 compatible
or mapped, just treat it as IPv6.
Fix IPv4-compatible and mapped address formatting in ToString().
Fix parsing of colons - specifically occurrences of ':::'.
Make sure blocks of digits are no longer than 4 characters.
Add some more parsing tests to Mono's NUnit test suite.
Add a NUnit test for bogus IPv6 addresses.
Previously, many tests just had a return statement when the test shouldn't
be executed (e.g. Unix-only). This made it look like the test was successful
when in fact it wasn't executed at all.
Assert.Ignore() is now used instead to correctly exclude those tests.
The property was introduced with PR #870 but it missed to convert network byte order to host byte order, so the comparison
wasn't working correctly and the corresponding unit test failed. @marek-safar erroneously "fixed" the test in 27e07c7.
This is the corrected implementation and the original test now works as intended.
Test Case Failures:
1) MonoTests.System.Net.DnsTest.GetHostByName : Should raise a SocketException (assuming that 'www.unlikely.novell.com' does not exist)
at MonoTests.System.Net.DnsTest.GetHostByName () [0x00089] in /Users/jon/Development/mono-HEAD/mono/mcs/class/System/Test/System.Net/DnsTest.cs:212
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00054] in /Users/jon/Development/mono-HEAD/mono/mcs/class/corlib/System.Reflection/MonoMethod.cs:230
As it happens, 'www.unlikely.novell.com' DOES exist:
$ ping www.unlikely.novell.com
PING www.unlikely.novell.com (199.101.28.20): 56 data bytes
64 bytes from 199.101.28.20: icmp_seq=0 ttl=57 time=29.399 ms
Apparently it's due to the "www." prefix; remove "www." and the site
isn't found, as expected:
$ ping unlikely.novell.com
ping: cannot resolve unlikely.novell.com: Unknown host
Update DnsTest.noneExistingSite so that the DnsTest.GetHostByName()
test passes.
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=13343
There are some Industrial Automation Hardware devices which return a
'\'-prefixed path to the FTP PWD command, which would break:
System.UriFormatException: Invalid URI: The hostname could not be parsed.
at System.Uri.Parse (UriKind kind, System.String uriString)
at System.Uri.ParseUri (UriKind kind)
at System.Uri..ctor (System.String uriString, Boolean dontEscape)
at System.Uri..ctor (System.String uriString) [0x0000
at System.Net.FtpWebRequest.GetRemoteFolderPath (System.Uri uri)
at System.Net.FtpWebRequest.CWDAndSetFileName (System.Uri uri)
at System.Net.FtpWebRequest.ProcessMethod ()
at System.Net.FtpWebRequest.ProcessRequest ()
There was an error connecting to the FTP Server.
The problem was this statement:
Uri initial = new Uri ("ftp://dummy-host" + initial_path);
Since the FTP server was returning "\" to the PWD command,
`initial_path` was "\", and the above was equivalent to:
Uri initial = new Uri (@"ftp://dummy-host\");
This results in the UriFormatException.
The solution is to not assume that `initial_path` will start with '/',
and instead use UriBuilder.
* Updated the tests to reflect .NET 4.5's new improved behavior.
* Fixed subdomain matching rules.
* Added some very simple sanity checks, such as same origin and
public suffixes.
This is far from perfect, but the tests now pass with .NET 4.5
and this also fixes a Monotouch bug from one of our customers.
TODO:
* Using 'Cookie.Version = 1' (RFC 2109 compliance) apparently got
broken in .NET 4.5; I disabled the corresponding tests / made
them use the default 'Version = 0' where possible.
* Same origin has not been tested for security (it previously
didn't exist at all) and we should probably use the list at
publicsuffix.org; but .NET 4.5 also allows you to set a cookie
.co.uk (haven't tested their web stack, thoug - it's possible
that they have additional checks there).