Commit Graph
16 Commits
Author SHA1 Message Date
Alan McGovern d6396791ce [corlib] Remove the DebuggerDisplay attribute from KeyValuePair and DictionaryEntry
This attribute gives us a horrible debugging experience when the
'Value' of the KeyValuePair is null. By using this attribute, the
user is told that the KeyValuePair itself is null when they inspect
something like 'new KeyValuePair<string, string> (null, null)'.
This is very confusing.

We should just let the ToString method be invoked, which returns a
nicely formatted string. This is also the behaviour observed when
debugging using Visual Studio.
2012-11-01 15:59:23 +00:00
Marek Safar f9bea41458 2010-05-15 Marek Safar <[email protected]>
* KeyValuePair.cs: Initialize fields definitely.


svn path=/trunk/mcs/; revision=157385
2010-05-15 21:18:13 +00:00
Chris Toshok 8718686805 in class/corlib/System.Collections.Generic/:
2009-12-06  Chris Toshok  <[email protected]>

	* KeyValuePair.cs: we need setters for Key and Value so they can
	be set via reflection from
	System.ServiceModel.System.Runtime.Serialization.Json.TypeMap.cs.

in class/System.ServiceModel.Web/System.Runtime.Serialization.Json/:
2009-12-06  Chris Toshok  <[email protected]>

	* JsonSerializationReader.cs (DeserializeGenericCollection): this
	is jb's (iirc) patch, actually.  Types subclassing from
	ICollection<T> need to be supported, and since it's an interface
	the implementation might be explicit.  So instead of groveling
	around in the actual type, we need to dispatch through the
	interface's method.

	* TypeMap.cs (CreateDefaultTypeMap): we need to include non-public
	properties, since KeyValuePair items must be able to write to Key
	and Value properties.

	* JsonReader.cs (ReadContent): for builtin values (null, true,
	false), use TryReadString instead of individual ReadChar's, since
	they aren't reversible if the string didn't match.  In the default
	case, if we're LameSilverlightLiseralParser, we need to push back
	the current character onto the stream -- this is because for
	netflix's AppConfig.json we were parsing "frameRatePolicy" as
	"rameRatePolicy" (the 'f' was triggering the "false" parsing).
	(class PushBackReader): add this class to unify all the pushing
	back of characters we need to do.  1 character (JsonReader's old
	"saved_char") isn't enough given that you could have a property
	named, e.g., "falsifiable", and we'd need 4 characters worth of
	pushback to recognize that correctly.

svn path=/trunk/mcs/; revision=147766
2009-12-07 07:39:17 +00:00
Marek Safar 511cd3ef88 2009-10-20 Marek Safar <[email protected]>
* List.cs, CollectionDebuggerView.cs, KeyValuePair.cs, Dictionary.cs
	Improve debugging experience.


svn path=/trunk/mcs/; revision=144437
2009-10-20 10:32:19 +00:00
Miguel de Icaza 0204abe803 Drop more obsolete defines
svn path=/trunk/mcs/; revision=144304
2009-10-17 01:35:27 +00:00
Andreas N 29f3b5d24a 2008-04-02 Andreas Nahr <[email protected]>
* KeyNotFoundException.cs
	* KeyValuePair.cs: Fix parameter names

svn path=/trunk/mcs/; revision=99647
2008-04-02 17:02:20 +00:00
Kamil Skalski a56d49c9a4 Change Key and Value in System.Collections.Generic.KeyValuePair to properties to match .NET 2.0 July CTP. Update its use in Dictionary, since now we cannot write to them.
svn path=/trunk/mcs/; revision=48217
2005-08-10 08:44:08 +00:00
Martin Baulig 00d6ed169c Applied a patch from David Waite <[email protected]> containing some collection updates.
svn path=/trunk/mcs/; revision=46043
2005-06-15 14:10:38 +00:00
Zoltan Varga 6c053c73bd 2005-05-06 Zoltan Varga <[email protected]>
* *.cs: Remove CLSCompliant(false) attributes.

svn path=/trunk/mcs/; revision=44139
2005-05-06 15:53:52 +00:00
Duncan Mak 13d1764537 Add license and copyright to all source files in corlib
svn path=/trunk/mcs/; revision=29249
2004-06-11 02:09:36 +00:00
Martin Baulig 9558365e84 Use NET_2_0', not GENERICS'.
svn path=/trunk/mcs/; revision=26325
2004-04-29 18:30:34 +00:00
Martin Baulig c1dfb34e6d They're not CLS-compliant.
svn path=/trunk/mcs/; revision=25197
2004-04-07 21:20:39 +00:00
Martin Baulig 06cf56a582 2003-12-08 Martin Baulig <[email protected]>
* *.cs: require GENERICS.

svn path=/trunk/mcs/; revision=20894
2003-12-08 19:47:45 +00:00
Miguel de Icaza 0b4938b5a6 Kill GENERICS as the define to use to build the GENERICS build, that is now
part of the NET_1_2 build.

svn path=/trunk/mcs/; revision=20152
2003-11-18 05:33:34 +00:00
Ben Maurer 0bc8e387ca get #if stuff right
svn path=/trunk/mcs/; revision=19741
2003-11-08 19:35:16 +00:00
Ben Maurer 09da513959 more interfaces
svn path=/trunk/mcs/; revision=19720
2003-11-07 22:05:06 +00:00