Commit Graph
44 Commits
Author SHA1 Message Date
marcos henrich b124b68759 FileInfo members that rely on System.Security.AccessControl are now inside a conditional block !MOBILE 2014-05-30 16:55:52 +01:00
marcos henrich 77b1aacb9d Removed NET_2_1 conditional blocks from FileInfo. Fixes #19862. 2014-05-28 18:24:16 +01:00
Rodrigo Kumpera b96d05dac3 Kill the MOONLIGHT define in corlib. 2013-02-11 16:03:28 -05:00
James Bellinger 9322e0d16b ACLs now work on Windows. Tests all the way up to DirectorySecurityTest and FileSecurityTest.
NativeObjectSecurity is implemented.
I've done it in such a way that, for OSes that do not have a unified API for all ACLs,
overrides can be done in subclasses such as FileSystemSecurity without trouble.

ObjectSecurity, CommonObjectSecurity, and DirectoryObjectSecurity all implemented.
MutexSecurity, PipeSecurity, etc. all just add type specialization and nothing else. Implemented all of these as well.

Access and Audit rules now correctly use NTAccount in their string overloads (see unit tests).
The constructors all provide correct AccessMasks now. In other words, these classes are all now un-broken/no longer stubs.

More unit tests for CommonSecurityDescriptor and fixes to pass them.
A few had checks that were redundant (implemented by (Authorization|Audit|Access)Rule) as well. These have been removed.
The Allow Everyone Full Access default for null DiscretionaryAcls in CommonSecurityDescriptor is, I think,
properly implemented. This required some changes to GenericSecurityDescriptor as well, but now Mono matches
MS.NET on GetSddl/GetBinaryForm for null DiscretionaryAcl including roundtrip.

What's still missing:
(1) CommonAcl's RemoveAccess/RemoveAudit. RemoveAll and RemoveSpecific work so it's not a big issue.
(2) CommonAcl merging will not yet try to merge a CommonAce together with an ObjectAce.
(3) The various *Security constructors. Get/SetAccessControl work on files and directories.
However, you still have to create and then set. I am not too familiar with Mono runtime internal
calls, but to someone who is: If the SECURITY_ATTRIBUTES parameter to Create*'s lpSecurityDescriptor
pointed to the output of GenericSecurityDescriptor's GetBinaryForm, that would be a complete
implementation.
2012-07-07 18:45:06 -04:00
Sebastien Pouliot 3a383eff31 2010-04-21 Sebastien Pouliot <[email protected]>
* FileInfo.cs: Ensure elevated trust when calling Delete on 
	Moonlight.


svn path=/trunk/mcs/; revision=155869
2010-04-21 12:40:57 +00:00
Sebastien Pouliot e6fd69e444 2010-04-16 Sebastien Pouliot <[email protected]>
* Directory.cs: Ensure elevated trust when calling on 
	Moonlight.
	* DirectoryInfo.cs: Ensure elevated trust when calling a .ctor 
	on Moonlight.
	* File.cs: Ensure elevated trust when calling a .ctor on 
	Moonlight.
	* FileInfo.cs: Ensure elevated trust when calling a .ctor on 
	Moonlight.
	* FileStream.cs: Ensure elevated trust when calling a .ctor on 
	Moonlight. Name property returns "[Unknown]" unless a Moonlight
	application is executed with elevated trust.
	* Path.cs: Ensure elevated trust when calling a GetTempPath,
	GetTempFileName or GetFullPath on Moonlight. Add a shared 
	internal method to validate paths to reduce code duplication.


svn path=/trunk/mcs/; revision=155643
2010-04-16 17:29:07 +00:00
Sebastien Pouliot c02f14af40 2010-03-29 Sebastien Pouliot <[email protected]>
* DirectoryInfo.cs, FileInfo.cs: Moonlight needs the default ctor
	to decorate them with [SecuritySafeCritical] for corclr 
	inheritance rules


svn path=/trunk/mcs/; revision=154364
2010-03-29 11:56:03 +00:00
Miguel de Icaza fe09fc6f64 More 4.0 work
svn path=/trunk/mcs/; revision=145674
2009-11-08 18:32:52 +00:00
Miguel de Icaza 8363715456 svn path=/trunk/mcs/; revision=145672 2009-11-08 18:23:53 +00:00
Miguel de Icaza 0204abe803 Drop more obsolete defines
svn path=/trunk/mcs/; revision=144304
2009-10-17 01:35:27 +00:00
Sebastien Pouliot 2203a2bb29 2009-09-18 Sebastien Pouliot <[email protected]>
* Directory.cs: Avoid imperative CAS checks and remove 
	AccessControl types for NET_2_1
	* DirectoryInfo.cs: Remove AccessControl types for NET_2_1
	* File.cs: Remove AccessControl types for NET_2_1
	* FileInfo.cs: Remove AccessControl types for NET_2_1
	* FileStream.cs: Remove AccessControl types for NET_2_1
	* Path.cs: Avoid imperative CAS checks for NET_2_1


svn path=/trunk/mcs/; revision=142197
2009-09-18 15:57:32 +00:00
Miguel de Icaza 6a3ddad347 2009-05-05 Miguel de Icaza <[email protected]>
* Contribution from David Uvalle <[email protected]> that
	implements FileInfo.Replace.

svn path=/trunk/mcs/; revision=133617
2009-05-05 22:58:16 +00:00
Sebastien Pouliot d07a33dde5 2008-11-27 Sebastien Pouliot <[email protected]>
* FileInfo.cs: Change ToString (in 2.1) not to return the full path
	of the filename (since it's not SecurityCritical).


svn path=/trunk/mcs/; revision=120172
2008-11-27 18:57:42 +00:00
Gert Driesen 5d4e8d2ce4 * DirectoryInfo.cs: Added new internal ctor, which takes a bool that
indicates whether the original path should only container the last
part of the directory. Moved logic for determining the Name and
Parent to Initialize method, to allow it to be re-used on
deserialization. Renamed argument names to fix corcompare issues.
Added missing argument checks.
* Directory.cs (CreateDirectoriesInternal): Use internal ctor for
DirectoryInfo to ensure OriginalPath only contains last part of
the directory.
* File.cs: Removed redundant checks from Create. On 2.0 profile, pass
FileOptions to FileStream. Removed redundant directory check from
Delete and modified exceptions to more closely match MS.
* FileInfo.cs: Added argument check to ctor to match MS. Added missing
deserialization ctor. Modified argument checks in MoveTo, and removed
redundant checks. Added missing argument checks in CopyTo. Code
formatting.
* FileSystemInfo.cs: Modified argument checks in CheckPath to more
closely match MS.
* MonoIO.cs: Added msg that does not disclose filename for
ERROR_FILE_EXISTS.
* Path.cs: Use String.Length instead of comparing with String.Empty.
Removed exceptions argument names to match MS.
* File.cs: Added/improved tests for Create and Move.
* DirectoryInfoTest.cs: No longer derive from deprecated Assertion
class. Improved tests for ctor, Create, Name, Parent, ...
* FileInfoTest.cs: No longer derive from deprecated Assertion class.
Improved/added tests, 
* PathTest.cs: Added tests for IsPathRooted and GetFullPath.
* FileSystemInfoTest.cs: Fixed test. Now passes on both Mono and MS.

svn path=/trunk/mcs/; revision=101006
2008-04-17 15:04:25 +00:00
Dick Porter 5b79519900 2007-04-30 Dick Porter <[email protected]>
* Directory.cs: 
	* FileShare.cs: 
	* DirectoryNotFoundException.cs: 
	* SeekOrigin.cs: 
	* FileAttributes.cs: 
	* IOException.cs: 
	* MemoryStream.cs: 
	* FileMode.cs: 
	* BinaryWriter.cs: 
	* TextWriter.cs: 
	* File.cs: 
	* BinaryReader.cs: 
	* TextReader.cs: 
	* UnmanagedMemoryStream.cs: 
	* StringWriter.cs: 
	* FileAccess.cs: 
	* FileLoadException.cs: 
	* BufferedStream.cs: 
	* Stream.cs: 
	* FileInfo.cs: 
	* FileStream.cs:
	* StringReader.cs: 
	* StreamWriter.cs: 
	* EndOfStreamException.cs: 
	* DriveInfo.cs: 
	* StreamReader.cs: 
	* PathTooLongException.cs: 
	* DriveType.cs: 
	* FileNotFoundException.cs: 2.0 profile updates



svn path=/trunk/mcs/; revision=76495
2007-04-30 14:05:12 +00:00
Sebastien Pouliot ff518b0de4 2006-12-22 Sebastien Pouliot <[email protected]>
* File.cs: Add stubs for Encrypt and Decrypt that throws 
	NotSupportedException just like non-NTFS file systems would with MS.
	Remove nested #if NET_2_0.
	* FileInfo.cs: Add stubs for Encrypt and Decrypt that throws 
	NotSupportedException just like non-NTFS file systems would with MS.


svn path=/trunk/mcs/; revision=69956
2006-12-22 18:21:25 +00:00
Miguel de Icaza 5b97fe374e 2006-12-15 Miguel de Icaza <[email protected]>
* FileInfo.cs: Empty implementations for Encrypt and Decrypt

svn path=/trunk/mcs/; revision=69523
2006-12-15 05:24:32 +00:00
Gonzalo Paniagua Javier 511182b2ed 2006-09-21 Gonzalo Paniagua Javier <[email protected]>
* Test/System.IO/FileInfoTest.cs:
	* System.IO/FileInfo.cs: added 2.0 IsReadOnly. Patch by Joel Reed.


svn path=/trunk/mcs/; revision=65802
2006-09-22 02:54:31 +00:00
Gonzalo Paniagua Javier 035a14b73c 2006-09-21 Gonzalo Paniagua Javier <[email protected]>
* FileInfo.cs: eol-style.


svn path=/trunk/mcs/; revision=65801
2006-09-22 02:50:24 +00:00
Lluis Sanchez 981b80cf8d 2006-08-30 Lluis Sanchez Gual <[email protected]>
* FileInfo.cs: OpenRead should open the file using the Read share mode.


svn path=/trunk/mcs/; revision=64550
2006-08-30 13:00:30 +00:00
Dick Porter 55e8d9fe73 2004-07-05 Dick Porter <[email protected]>
* CheckPermission.cs:
	* File.cs:
	* FileInfo.cs:
	* MonoIO.cs:
	* FileStream.cs: Give the filename when throwing
	FileNotFoundException.  Fixes bug 61120, based on patch from
	Carlos Alberto Cesario <[email protected]>.

svn path=/trunk/mcs/; revision=30744
2004-07-05 15:05:43 +00:00
Duncan Mak 13d1764537 Add license and copyright to all source files in corlib
svn path=/trunk/mcs/; revision=29249
2004-06-11 02:09:36 +00:00
Atsushi Eno 7e8678f8c6 2004-05-26 Atsushi Enomoto <[email protected]>
* FileInfo.cs,
	  DirectoryInfo.cs : ToString() should return constructor arg as is.
	  This fixes bug #58804.

svn path=/trunk/mcs/; revision=28120
2004-05-26 03:54:51 +00:00
Duncan Mak 955c3bbef4 Fix embarrassing typo.
svn path=/trunk/mcs/; revision=28001
2004-05-24 20:27:58 +00:00
Duncan Mak adac222648 * DirectoryInfo.cs:
* FileInfo.cs: Reformat the whole file to use DOS line endings.
(MoveTo): Return if the destination of Move is the same as the file's
current location.

svn path=/trunk/mcs/; revision=27996
2004-05-24 19:49:18 +00:00
Atsushi Eno 9c425d8ca9 2004-05-16 Atsushi Enomoto <[email protected]>
* FileInfo.cs: ToString() returns not full path but just the file name.

svn path=/trunk/mcs/; revision=27481
2004-05-16 14:53:53 +00:00
Lluis Sanchez b1f6ebcee7 * FileSystemInfo.cs: Added InternalRefresh, a virtual method that derived
classes can override to perform class specific refreshing.
	* FileInfo.cs: Refresh existence flag when Refresh is called.
	* TextWriter.cs: Applied patch by Benjamin Jemlich for bug #52512.
	  The method Write(char) should do nothing by default.

svn path=/trunk/mcs/; revision=24901
2004-04-01 13:29:53 +00:00
Dick Porter 49e62eba9e 2003-07-16 Dick Porter <[email protected]>
* FileInfo.cs: Update path info when a file is moved.  Patch by
	John Luke <[email protected]>, fixes bug 44253.

svn path=/trunk/mcs/; revision=16311
2003-07-16 16:14:53 +00:00
Nick Drochak 0d13cab5ce 2003-06-02 Nick Drochak <[email protected]>
* FileInfo.cs (MoveTo): Throw exceptions when dest exists, and check
	for null too.

svn path=/trunk/mcs/; revision=15070
2003-06-02 14:18:03 +00:00
Ville Palo aa71caf8c6 2003-05-06 Ville Palo <[email protected]>
* BufferedStream.cs:
	  - Removed unusefull code.
	  - Added ObjectDisposedException to Position
	  - Dont flush if stream is allready closed.
	  - Flush throws also ObjectDisposedException.
	* Directory.cs:
	  - GetFileSystemEtries: ArgumentNullException if pattern is null
	* DirectoryInfo.cs: Fixed little MoveTo () bug.
	* FileInfo.cs:
	  - Exists: If file does not exists when instance is created the
	  value of the Exists property does not change even if file is created
	  afterwards.
	  - Delete: If path is a directory UnauthorizedException is thrown.
	  - CopyTo: Now we can overwrite file if wanted.
	* Path.cs:
	  - GetFullPath: Now throws exception when path is "   ".

svn path=/trunk/mcs/; revision=14370
2003-05-07 14:43:29 +00:00
Dick Porter 542709a35c 2002-10-31 Dick Porter <[email protected]>
* FileStream.cs: Fix buffering properly this time.  Also kludge
	around broken pipe errors, treating them as EOF instead of
	throwing an IO exception.

	* MonoIO.cs: Return the error status in a parameter, as the
	GetLastError() value has long since been blown away if we try and
	look it up in a subsequent internal call invocation.

	* Process.cs:
	* Environment.cs:
	* FileSystemInfo.cs:
	* FileInfo.cs:
	* File.cs:
	* Directory.cs: MonoIO methods now have an error parameter

2002-10-31  Dick Porter  <[email protected]>

	* list.unix: Added MonoIO and MonoIOError to the build

svn path=/trunk/mcs/; revision=8712
2002-10-31 15:55:48 +00:00
Gonzalo Paniagua Javier e01b1ec454 2002-07-18 Gonzalo Paniagua Javier <[email protected]>
* FileInfo.cs: fixes buglet #27940

svn path=/trunk/mcs/; revision=5893
2002-07-18 14:04:36 +00:00
Miguel de Icaza 4e9b084e2d 2002-05-07 Mike Gray <[email protected]>
* FileInfo.cs (Create): Implement missing method.

svn path=/trunk/mcs/; revision=4356
2002-05-07 01:41:03 +00:00
Piers Haken 610d7923ac added missing [Serializable] attribute
svn path=/trunk/mcs/; revision=3540
2002-04-01 20:22:40 +00:00
Dan Lewis d6e7b06471 2002-03-27 Dan Lewis <[email protected]>
corlib/

	* corlib.build: removed seperate windows/linux builds. excluded
	wrapper and PAL classes from all builds.

corlib/System/

	* Console.cs: Modified to get std handles from MonoIO.
	* Environment.cs: removed PAL dependencies.

corlib/System.IO/

	* Directory.cs, File.cs, FileSystemInfo.cs, FileInfo.cs,
	DirectoryInfo.cs, Path.cs: Modified to use MonoIO class instead of
	wrapper and PAL classes.

	* MonoIO.cs, MonoIOStat.cs, MonoIOError.cs: Added.

svn path=/trunk/mcs/; revision=3379
2002-03-27 00:51:39 +00:00
Miguel de Icaza 99a1e34e98 2002-01-23 Miguel de Icaza <[email protected]>
* Unix/Errno.cs: Added

	* Unix/Wrapper.cs: Updated to new Wrapper

2002-01-23  Miguel de Icaza  <[email protected]>

	* FileInfo.c (CopyTo, MoveTo): Implement.

	* FileStream.cs: Add argument checking to the constructor.

	* File.cs: Rewrote most of the file.  Implement Copy, Open, Create,
	OpenText, OpenWrite, Move.  Made pending methods flagged as MonoTODO.

	* Directory.cs (Delete): reimplement without using DirectoryInfo.
	(Delete): Implement the recursive version.
	(GetCreationTime, GetLastWriteTime, GetLastAccessTime): Implement.
	(Move): Reimplement.
	(getNames): dead code removal.

	* Path.cs: define an internal DirectorySeparatorStr that we use in
	a few spots.

	* Wrapper.cs: Updated to new version.

	* DirectoryInfo (Delete): Implement using the Directory API.

2002-01-23  Miguel de Icaza  <[email protected]>

	* DateTime.cs (UnixEpoch): The Begining of the Unix epoch.

svn path=/trunk/mcs/; revision=2138
2002-01-24 00:59:13 +00:00
Miguel de Icaza 96b7ca21ac 2002-01-23 Miguel de Icaza <[email protected]>
* DirectoryInfo.cs (GetFiles, GetDirectories, GetFileSystemInfos,
	Delete, Create, Parent, Exists, MoveTo): Implement.

	* Directory.cs (GetListing): implement new utility function.
	(GetDirectories): Implement.
	(GetFileSystemEntries): Implement.
	(GetFiles): Implement.

	* CheckArgument.cs (Path): Do not allow null by default.

2002-01-23  Miguel de Icaza  <[email protected]>

	* Unix/Wrapper.cs: Updated to new Wrapper

svn path=/trunk/mcs/; revision=2132
2002-01-23 20:05:45 +00:00
Paolo Molaro 68cb0d715e Tue Jan 22 22:54:18 CET 2002 Paolo Molaro <[email protected]>
* IReflect.cs: corrected GetMember() return type.
	* InterfaceMapping.cs, TypeDelegator.cs: implemented.


Tue Jan 22 23:01:11 CET 2002 Paolo Molaro <[email protected]>

	* EnumBuilder.cs, TypeBuilder.cs: updates for changes in Type.cs.
	* ModuleBuilder.cs: fix lookup of nested types.


Tue Jan 22 22:53:23 CET 2002 Paolo Molaro <[email protected]>

	* DirectoryInfo.cs, FileInfo.cs: do not use Debug from the system
	assembly in corlib.


Tue Jan 22 22:51:48 CET 2002 Paolo Molaro <[email protected]>

	* MonoType.cs, Type.cs: many updates, corrected implementation,
	completed stubs.


Tue Jan 22 22:50:29 CET 2002 Paolo Molaro <[email protected]>

	* Linux.cs: comment out call to Debug.Assert(): stuff from the System
	assembly cannot be used in corlib.

svn path=/trunk/mcs/; revision=2095
2002-01-22 18:09:47 +00:00
Ravi Pratap M de8d750995 2002-01-04 Ravi Pratap <[email protected]>
* CheckArgument.cs, CheckPermission.cs, Directory.cs: MonoTODO
	attribute decorations.

	* DirectoryInfo.cs, File.cs, FileInfo.cs, FileSystemInfo.cs,
	Path.cs, TextReader.cs, TextWriter.cs : Ditto.

	* FileLoadException.cs, FileNotFoundException.cs, StreamReader.cs:
	Ditto.

svn path=/trunk/mcs/; revision=1832
2002-01-04 15:46:38 +00:00
Sean MacIsaac 6d11b05caa Removing old build files. NAnt doesn't use them.
svn path=/trunk/mcs/; revision=969
2001-09-26 09:11:29 +00:00
Jim Richardson 08ba173da1 added additional implementation
svn path=/trunk/mcs/; revision=778
2001-09-10 09:09:07 +00:00
Jim Richardson d8fc82a8da I suppose it helps when using CodeWright with C# to look at the output
for errors because the status line that says No Errors found "lies"
Fixed the compiler errors and vow to be more careful with copy/paste

svn path=/trunk/mcs/; revision=583
2001-08-23 01:16:08 +00:00
Jim Richardson a986601643 Implemented various methods that were previously just do nothing stubs.
Verified compilation and added files to common.src

svn path=/trunk/mcs/; revision=577
2001-08-23 00:00:46 +00:00
Jim Richardson fa145bef84 Added stubbed implementations for classes.
svn path=/trunk/mcs/; revision=476
2001-08-14 02:30:47 +00:00