Commit Graph
9 Commits
Author SHA1 Message Date
James Bellinger 9322e0d16b ACLs now work on Windows. Tests all the way up to DirectorySecurityTest and FileSecurityTest.
NativeObjectSecurity is implemented.
I've done it in such a way that, for OSes that do not have a unified API for all ACLs,
overrides can be done in subclasses such as FileSystemSecurity without trouble.

ObjectSecurity, CommonObjectSecurity, and DirectoryObjectSecurity all implemented.
MutexSecurity, PipeSecurity, etc. all just add type specialization and nothing else. Implemented all of these as well.

Access and Audit rules now correctly use NTAccount in their string overloads (see unit tests).
The constructors all provide correct AccessMasks now. In other words, these classes are all now un-broken/no longer stubs.

More unit tests for CommonSecurityDescriptor and fixes to pass them.
A few had checks that were redundant (implemented by (Authorization|Audit|Access)Rule) as well. These have been removed.
The Allow Everyone Full Access default for null DiscretionaryAcls in CommonSecurityDescriptor is, I think,
properly implemented. This required some changes to GenericSecurityDescriptor as well, but now Mono matches
MS.NET on GetSddl/GetBinaryForm for null DiscretionaryAcl including roundtrip.

What's still missing:
(1) CommonAcl's RemoveAccess/RemoveAudit. RemoveAll and RemoveSpecific work so it's not a big issue.
(2) CommonAcl merging will not yet try to merge a CommonAce together with an ObjectAce.
(3) The various *Security constructors. Get/SetAccessControl work on files and directories.
However, you still have to create and then set. I am not too familiar with Mono runtime internal
calls, but to someone who is: If the SECURITY_ATTRIBUTES parameter to Create*'s lpSecurityDescriptor
pointed to the output of GenericSecurityDescriptor's GetBinaryForm, that would be a complete
implementation.
2012-07-07 18:45:06 -04:00
James Bellinger 3a7601b97c Implemented SystemAcl. Common shared functionality moved to CommonAcl. Only missing implementation now is RemoveAccess/RemoveAudit.
Unit tests included - for SystemAcl they are based on DiscretionaryAcl's mostly,
with one extra and one somewhat changed since AuditFlags merge together unlike Allow/Deny.

Anyway, it should be practical to implement CommonSecurityDescriptor and friends with these classes working.
2012-07-03 15:40:01 -04:00
James Bellinger 95db8e694e SecurityIdentifier's CompareTo now works like MS.Net. CommonAcl is supposed to sort groupings of canonical ACEs using SecurityIdentifier's CompareTo, so this was important to do.
I determined the behavior of CompareTo by first writing unit tests for
CommonAcl (instantiated as DiscretionaryAcl but using RawAcl instead of
DiscretionaryAcl methods to do the manipulation to keep DiscretionaryAcl
out of the loop). I developed and ran these unit tests on MS.NET using
MonoDevelop...

Anyway, CompareTo appears to compare authority, then the *number* of
subauthorities, and lastly the subauthorities. I'd be curious if there
is more detail, but so far this seems to cover it. It's definitely
*not* just a comparison of the string.

This patch also modifies CommonAcl to take advantage of this new sorting,
so now it should sort groups of explicit ACEs (access deny, access allow)
in canonical ACLs correctly.

With that down, I've got two unit tests that still fail on Mono.
2012-07-02 23:18:25 -04:00
James Bellinger bcad1d9688 Implemented much of CommonAcl.cs
Some tests still fail because sorting is not implemented yet.
I'll need to alter SecurityIdentifier CompareTo.
2012-07-02 23:18:24 -04:00
Kenneth Bell 6cb0994257 Implement RawSecurityDescriptor.
* Marshals to/from SDDL and binary form.

 * Supports 'Common' ACEs and 'Object' ACEs
2011-01-26 18:00:29 -05:00
Miguel de Icaza 3c39ac4586 Jumbo patch for NET_2_0, mscorlib is now clean
svn path=/trunk/mcs/; revision=145621
2009-11-06 22:23:59 +00:00
Marek Safar cc9c53a109 Warnings cleanup
svn path=/trunk/mcs/; revision=111713
2008-08-27 15:40:13 +00:00
Atsushi Eno 001d97de25 2007-09-21 Atsushi Enomoto <[email protected]>
* AccessRule.cs AceEnumerator.cs AuditRule.cs AuthorizationRule.cs
	  AuthorizationRuleCollection.cs CommonAce.cs CommonAcl.cs
	  CommonObjectSecurity.cs CompoundAce.cs CryptoKeyAccessRule.cs
	  CryptoKeyAuditRule.cs CryptoKeySecurity.cs CustomAce.cs
	  DirectoryObjectSecurity.cs DirectorySecurity.cs
	  DiscretionaryAcl.cs EventWaitHandleAccessRule.cs
	  EventWaitHandleAuditRule.cs EventWaitHandleSecurity.cs
	  FileSecurity.cs FileSystemAccessRule.cs FileSystemAuditRule.cs
	  FileSystemSecurity.cs GenericAce.cs GenericAcl.cs KnownAce.cs
	  MutexAccessRule.cs MutexAuditRule.cs MutexSecurity.cs
	  NativeObjectSecurity.cs ObjectAccessRule.cs ObjectAce.cs
	  ObjectAuditRule.cs ObjectSecurity.cs QualifiedAce.cs
	  RawAcl.cs RegistryAccessRule.cs RegistryAuditRule.cs
	  RegistrySecurity.cs SystemAcl.cs :
	  they are not still functional, but being implemented.


svn path=/trunk/mcs/; revision=86129
2007-09-21 09:19:42 +00:00
Dick Porter e046a41d7d 2006-07-06 Dick Porter <[email protected]>
* corlib.dll.sources: Added
          System.Security.AccessControl/AccessControlModification.cs
          System.Security.AccessControl/AccessControlType.cs
          System.Security.AccessControl/AccessRule.cs
          System.Security.AccessControl/AceEnumerator.cs
          System.Security.AccessControl/AceFlags.cs
          System.Security.AccessControl/AceQualifier.cs
          System.Security.AccessControl/AceType.cs
          System.Security.AccessControl/AuditFlags.cs
          System.Security.AccessControl/AuditRule.cs
          System.Security.AccessControl/AuthorizationRule.cs
          System.Security.AccessControl/AuthorizationRuleCollection.cs
          System.Security.AccessControl/CommonAce.cs
          System.Security.AccessControl/CommonAcl.cs
          System.Security.AccessControl/CommonSecurityDescriptor.cs
          System.Security.AccessControl/CompoundAce.cs
          System.Security.AccessControl/CompoundAceType.cs
          System.Security.AccessControl/ControlFlags.cs
          System.Security.AccessControl/CryptoKeyAccessRule.cs
          System.Security.AccessControl/CryptoKeyAuditRule.cs
          System.Security.AccessControl/CryptoKeyRights.cs
          System.Security.AccessControl/CustomAce.cs
          System.Security.AccessControl/DirectoryObjectSecurity.cs
          System.Security.AccessControl/DiscretionaryAcl.cs
          System.Security.AccessControl/EventWaitHandleAccessRule.cs
          System.Security.AccessControl/EventWaitHandleAuditRule.cs
          System.Security.AccessControl/FileSecurity.cs
          System.Security.AccessControl/FileSystemAccessRule.cs
          System.Security.AccessControl/FileSystemAuditRule.cs
          System.Security.AccessControl/FileSystemRights.cs
          System.Security.AccessControl/FileSystemSecurity.cs
          System.Security.AccessControl/GenericAce.cs
          System.Security.AccessControl/GenericAcl.cs
          System.Security.AccessControl/GenericSecurityDescriptor.cs
          System.Security.AccessControl/InheritanceFlags.cs
          System.Security.AccessControl/KnownAce.cs
          System.Security.AccessControl/MutexAccessRule.cs
          System.Security.AccessControl/MutexAuditRule.cs
          System.Security.AccessControl/ObjectAccessRule.cs
          System.Security.AccessControl/ObjectAce.cs
          System.Security.AccessControl/ObjectAceFlags.cs
          System.Security.AccessControl/ObjectAuditRule.cs
          System.Security.AccessControl/PrivilegeNotHeldException.cs
          System.Security.AccessControl/PropagationFlags.cs
          System.Security.AccessControl/QualifiedAce.cs
          System.Security.AccessControl/RawAcl.cs
          System.Security.AccessControl/RawSecurityDescriptor.cs
          System.Security.AccessControl/RegistryAccessRule.cs
          System.Security.AccessControl/RegistryAuditRule.cs
          System.Security.AccessControl/RegistryRights.cs
          System.Security.AccessControl/RegistrySecurity.cs
          System.Security.AccessControl/ResourceType.cs
          System.Security.AccessControl/SecurityInfos.cs
          System.Security.AccessControl/SystemAcl.cs

2006-07-06  Dick Porter  <[email protected]>

        * System.dll.sources: Added
        System.Security.AccessControl/SemaphoreAccessRule.cs
        System.Security.AccessControl/SemaphoreAuditRule.cs


2006-07-06  Dick Porter  <[email protected]>

        * Completely stubbed the System.Security.AccessControl namespace
        for the 2.0 profile.




svn path=/trunk/mcs/; revision=62321
2006-07-06 15:35:13 +00:00