Commit Graph
23 Commits
Author SHA1 Message Date
Jeffrey Stedfast 51b648a118 Fixed build breakage from my previous commit 2013-08-12 12:12:47 -04:00
Jeffrey Stedfast b1d7375726 Fixed System.Text.Decoder.GetChars(byte*,int,char*,int,bool) to copy output into the char* buffer. 2013-08-12 08:22:49 -04:00
Atsushi Eno 132a16ca07 Revert "Merge pull request #622 from killabytenow/master"
This reverts commit 392bae3c45, reversing
changes made to 61cd9ee8b6.
2013-07-13 23:56:59 +09:00
Gerardo García Peña a0a12c128d Refactorized convert(byte[], int, ...), now uses the pointer version. 2013-04-03 17:21:58 +02:00
Rodrigo Kumpera abe9dc6206 Revert "Fix object::GetType when remoting is enabled."
This reverts commit 93e2d1dc48.
2013-03-01 10:54:09 -05:00
Rodrigo Kumpera 93e2d1dc48 Fix object::GetType when remoting is enabled. 2013-03-01 10:52:03 -05:00
Martin Potter 643d8b8b3a System.Text.Decoder throws ArgumentOutOfRangeException when it should not. Fixes Bug #10789
Similar to previously reported bug #6404, according to the documentation at http://msdn.microsoft.com/en-us/library/h6w985hz.aspx, System.Text.Encoder throws ArgumentOutOfRangeExceptions when it should not. From the documentation, an ArgumentOutOfRangeException should be thrown when:

charIndex, charCount, byteIndex, or byteCount is less than zero.
-or-
The length of chars - charIndex is less than charCount.
-or-
The length of bytes - byteIndex is less than byteCount.

To reproduce, run the following code:

int charsUsed, bytesUsed;
bool completed;
byte[] bytes = new byte[4096];
char[] chars = new char[4096];
System.Text.Encoding.UTF8.GetDecoder().Convert(bytes, 0, 0, chars, 4096, 0, false, out bytesUsed, out charsUsed, out completed);

Expected:

The code runs, charsUsed equals zero, bytesUsed equals zero and completed is true.

Actual:

Mono throws an ArgumentOutOfRangeException for charIndex.

There are also other behavioral differences between Mono and Microsoft's implementation for the GetChars(Byte[], Int32, Int32, Char[], Int32, Boolean) method, such as:

byte[] bytes = new byte[4096];
char[] chars = new char[10];
int charactersWritten = System.Text.Encoding.UTF8.GetDecoder().GetChars(bytes, 0, 0, chars, 10, false);

On Mono, this results in an ArgumentOutOfRangeException for charIndex, where for Microsoft charactersWritten = 0.

Similarly:

byte[] bytes = new byte[4096];
char[] chars = new char[10];
int charactersWritten = System.Text.Encoding.UTF8.GetDecoder().GetChars(bytes, 0, 4096, chars, 10, false);

On Mono, this results in the same ArgumentOutOfRangeException for charIndex, where Microsoft throws and ArgumentException. since "chars does not have enough capacity from charIndex to the end of the array to accommodate the resulting characters."
2013-03-01 05:05:34 -08:00
Miguel de Icaza 53d746c7a1 2009-11-02 Miguel de Icaza <[email protected]>
* Jumbo patch to drop support for pre-NET_2_0 code:

        Remove NET_2_0 defines assuming the value is true.


svn path=/trunk/mcs/; revision=145232
2009-11-03 00:27:28 +00:00
Gert Driesen b136e2077e * ASCIIEncoding.cs: Marked class ComVisible (true) on 2.0 profile.
Marked 2.0-only members as ComVisible (false).
* Decoder.cs: Marked class ComVisible (true) on 2.0 profile. Marked
2.0-only members as ComVisible (false).
* Encoder.cs: Marked class ComVisible (true) on 2.0 profile. Marked
2.0-only members as ComVisible (false).
* Encoding.cs: Marked class ComVisible (true) on 2.0 profile. Marked
2.0-only members as ComVisible (false).
* NormalizationForm.cs: Marked ComVisible (true).
* StringBuilder.cs: Marked class ComVisible (true) on 2.0 profile.
Marked 2.0-only methods as ComVisible (false).
* UnicodeEncoding.cs: GetString (byte[], int, int) is only available
in 2.0 profile. Marked 2.0-only methods ComVisible (false). Added
missing ctor in 2.0 profile, and marked in MonoTODO.
* UTF7Encoding.cs: Marked class ComVisible (true) on 2.0 profile.
* UTF8Encoding.cs: Marked 2.0-only methods as ComVisible (false).

svn path=/trunk/mcs/; revision=61250
2006-05-30 09:02:37 +00:00
Atsushi Eno 20ef4631cf 2006-03-30 Atsushi Enomoto <[email protected]>
* Encoder.cs, Decoder.cs : implemented Convert(). Also added argument
	  check in some methods.

	* EncoderTest.cs, DecoderTest.cs : new tests, for Convert().

	* corlib_test.dll.sources: added EncoderTest.cs and DecoderTest.cs.


svn path=/trunk/mcs/; revision=58819
2006-03-30 19:08:18 +00:00
Atsushi Eno d8f75ff7ec 2006-01-20 Atsushi Enomoto <[email protected]>
* Decoder.cs : ditto.


svn path=/trunk/mcs/; revision=55833
2006-01-20 14:26:17 +00:00
Atsushi Eno 260a309975 2005-11-28 Atsushi Enomoto <[email protected]>
* Encoder.cs : added new GetByteCount()/GetBytes() overloads.
	  Added FallbackBuffer.
	* Decoder.cs : added new GetCharCount()/GetChars() overloads.


svn path=/trunk/mcs/; revision=53548
2005-11-28 12:25:41 +00:00
Atsushi Eno e14f1bcad3 2005-11-16 Atsushi Enomoto <[email protected]>
* Decoder.cs : added FallbackBuffer property.
	* UTF8Encoding.cs : In NET_2_0, use DecoderFallbackBuffer instead of
	  "throwOnInvalid".

	* UTF8EncodingTest.cs : Simply replaced all ArgumentException with
	  switched alias (it is DecodefFallbackException in NET_2_0).


svn path=/trunk/mcs/; revision=53137
2005-11-16 18:37:52 +00:00
Atsushi Eno 86544b0077 2005-11-15 Atsushi Enomoto <[email protected]>
* corlib_test.dll.sources: added new tests for
	  DecoderReplacementFallback and EncoderReplacementFallback.

	* Encoding.cs : Added IsReadOnly, DecoderFallback and EncoderFallback.
	* Encoder.cs : Added Fallback property.
	* Decoder.cs : Added Fallback property.

	* TestEncoding.cs,
	  DecoderReplacementFallbackTest.cs,
	  EncoderReplacementFallbackTest.cs : new 2.0 tests.


svn path=/trunk/mcs/; revision=53050
2005-11-15 12:12:12 +00:00
Miguel de Icaza a8dea00dfb Fixed licenses
svn path=/trunk/mcs/; revision=30382
2004-06-25 14:42:22 +00:00
Duncan Mak 13d1764537 Add license and copyright to all source files in corlib
svn path=/trunk/mcs/; revision=29249
2004-06-11 02:09:36 +00:00
Paolo Molaro 6c10f94827 Mon Aug 26 16:44:54 CEST 2002 Paolo Molaro <[email protected]>
* *.cs: change to conform to mono coding style.

svn path=/trunk/mcs/; revision=7050
2002-08-26 14:46:37 +00:00
Gonzalo Paniagua Javier 851bbb86ad 2002-08-24 Gonzalo Paniagua Javier <[email protected]>
* ASCIIEncoding.cs:
	* Decoder.cs:
	* Encoder.cs:
	* Encoding.cs:
	* UTF7Encoding.cs:
	* UTF8Encoding.cs:
	* UnicodeEncoding.cs: added Serializable attribute.

svn path=/trunk/mcs/; revision=7001
2002-08-24 17:49:22 +00:00
Paolo Molaro feee3a2d52 Wed Aug 21 20:02:04 CEST 2002 Paolo Molaro <[email protected]>
* *.cs: imported the code donated by Rhys Weatherley
	<[email protected]>.

svn path=/trunk/mcs/; revision=6863
2002-08-21 18:04:52 +00:00
Martin Baulig 89dc4ec342 2002-05-19 Martin Baulig <[email protected]>
* Encoder.cs (IConvEncoder.GetByteCount, IConvEncoder.GetBytes):
	Added exception handling.

	* Decoder.cs (IConvDecoder.GetCharCount, IConvDecoder.GetChars):
	Added exception handling.

svn path=/trunk/mcs/; revision=4761
2002-05-19 12:27:15 +00:00
Piers Haken 610d7923ac added missing [Serializable] attribute
svn path=/trunk/mcs/; revision=3540
2002-04-01 20:22:40 +00:00
Dietmar Maurer 12d3d0ce8c unicode support (using iconv)
svn path=/trunk/mcs/; revision=1801
2002-01-04 06:32:08 +00:00
Dietmar Maurer 01fb3e5f74 new abstract classes
svn path=/trunk/mcs/; revision=1619
2001-12-18 09:15:00 +00:00