List<T>.Enumerator is a struct so current Dispose() implementation was causing mutability on it.
Depending on this behaviour may seem overkill but some codebases may implement IEnumerator<T> themselves by caching the enumerator of their initial readonly list.
Making Dispose() not do anything may seem incorrect, but it is not. For a good read about this, take a look at Stephen Cleary's first comment in:
http://social.msdn.microsoft.com/Forums/en/netfxbcl/thread/f5a59eac-4a3e-4417-99a8-83d4a6a9e41d
(Added NUnit tests that demonstrate the issue too.)
For a good example: this fix makes a simple HelloWorld System.Web.IHttpHandler work in Mono within the OpenRasta framework (at least tested with the stable branch).
2010-01-24 Robert Jordan <[email protected]>
* Dictionary.cs: Fix deserialization compatibility with MS.NET.
Fixes bug #474009.
In Test/System.Collections.Generic:
2010-01-24 Robert Jordan <[email protected]>
* DictionaryTest.cs: Add test case for bug #474009.
svn path=/trunk/mcs/; revision=150089
* System.Collections.Generic/Dictionary.cs (CopyToCheck, Do_CopyTo):
Carve out of ...
(CopyTo): ... this.
(Do_ICollectionCopyTo): Carve out of ICollection.CopyTo. Convert
type-cast exceptions to ArgumentExceptions.
(KeyCollection.CopyTo): Use them.
(ValueCollection.CopyTo): Use them.
* Test/System.Collections.Generic/DictionaryTest.cs (ICollectionCopyTo):
Test various odd scenarios where .NET CopyTo does _not_ throw an exception.
(ICollectionCopyTo_ex1..4): Ensure that ArgumentExceptions are
thrown in appropriate cases.
svn path=/trunk/mcs/; revision=142427
* List.cs (IList.this.set): Convert NullReference and InvalidCast
exceptions into ArgumentExceptions.
(IList.Add, IList.Contains, IList.IndexOf, IList.Insert, IList.Remove):
Convert NullReferenceException to ArgumentException.
* ListTest.cs: Add a few testcases for IList interface, using null
values with a List<int>.
svn path=/trunk/mcs/; revision=139159
* DictionaryTest.cs (KeyEnumerator_Current): New test. Test the
Keys slice enumerator.
(ValueEnumerator_Current): Likewise, for the Values slice.
svn path=/trunk/mcs/; revision=139117
* System.Collections.Generic/List.cs (Enumerator.current): New.
(Enumerator.MoveNext): Update it.
(Enumerator.Current): Don't verify any invariants.
(Enumerator.Dispose): Set 'l' to null.
* Test/System.Collections.Generic/ListTest.cs (Enumerator_Current):
New test, includes relevant parts of #491858 and #517415.
svn path=/trunk/mcs/; revision=139087
* System.Collections.Generic/Dictionary.cs (Enumerator.current): New.
(Enumerator.MoveNext): Update it.
(Enumerator.Current): Don't verify any invariants.
* Test/System.Collections.Generic/DictionaryTest.cs (Enumerator_Current):
New test, includes relevant parts of #491858 and #517415.
svn path=/trunk/mcs/; revision=139082
2007-10-10 Juraj Skripsky <[email protected]>
* Dictionary.cs (Enumerator.MoveNext): Handle the case where we
had already reached the end. Fixes bug #332534.
svn path=/trunk/mcs/; revision=88534
* List.cs (FindAll): Optimize FindAll using a bitmask to
* determine
the number of positive matches, this increases the performance
in
all cases below 10,000,000 elements extensively:
100 elements:
old method: 00:00:00.0126610 (26x)
stackalloc bit method: 00:00:00.0004750 (1x)
array bit method: 00:00:00.0010700 (2x)
heap bit method: 00:00:00.0038830 (8x)
1,000 elements:
old method: 00:00:00.0139250 (24x)
stackalloc bit method: 00:00:00.0005670 (1x)
array bit method: 00:00:00.0010890 (2x)
heap bit method: 00:00:00.0034920 (6x)
10,000 elements:
old method: 00:00:00.0136110 (12x)
stackalloc bit method: 00:00:00.0011240 (1x)
array bit method: 00:00:00.0016450 (1.4x)
heap bit method: 00:00:00.0043110 (3x)
50,000 elements:
old method: 00:00:00.0175970 (3x)
stackalloc bit method: 00:00:00.0085630 (1.5x)
array bit method: 00:00:00.0055010 (1x)
heap bit method: 00:00:00.0099590 (1.8x)
100,000 elements:
old method: 00:00:00.0210330 (2x)
array bit method: 00:00:00.0100430 (1x)
heap bit method: 00:00:00.0154150 (1.5x)
1,000,000 elements:
old method: 00:00:00.1243730 (1.2x)
array bit method: 00:00:00.0973110 (1x)
heap bit method: 00:00:00.1285650 (1.3x)
10,000,000 elements:
old method: 00:00:00.9252570 (1x)
array bit method: 00:00:00.9632300 ( 1.05x)
heap bit method: 00:00:01.1098490 (1.20x)
svn path=/trunk/mcs/; revision=74694
* List.cs: Fix the case where List.set_Item(int index) throws
inappropriate exception when index is equal to List.Count
List.IndexOf(object item) and IList.Contains(object item) throw
exceptions when given invalid types.
IList.Add(object item) throws InvalidCastException when item is
not of the correct type.
svn path=/trunk/mcs/; revision=73976
* Dictionary.cs: An instance of Dictionary<TKey,TValue> is
supposed to throw a KeyNotFoundException when
the user attempts to retrieve the value associated with a key that
is not in the dictionary.
On the other hand, an instance of IDictionary is supposed to
return null in similar circumstances.
svn path=/trunk/mcs/; revision=73764
Increment version whenever _items is modified; this fixes version
checks in Enumerator.
* ListTest.cs: Added tests for binary serialization, and Enumerator
version checks.
svn path=/trunk/mcs/; revision=66698
* ArrayTest.cs : use proper comparer in IndexOf() and LastIndexOf().
Patch by Kazuki Oikawa. Fixed bug #77277.
* List.cs : use proper comparer in Contains(), IndexOf() and
LastIndexOf(). Patch by Kazuki Oikawa. Fixed bug #77277.
* ArrayTest.cs : test for bug #77277 by Kazuki Oikawa.
* ListTest.cs : test for bug #77277 by Kazuki Oikawa.
svn path=/trunk/mcs/; revision=60396
* List.cs (CheckIndex): Check for -ve indices and allow index == size.
(Insert): Use CheckIndex.
In class/corlib/Test/System.Collections.Generic:
* ListTest.cs: Add some tests for InsertRange.
svn path=/trunk/mcs/; revision=58069
Speed up remove. Use 'dict[k]=v' as a self-tuning hint.
* Dictionary.cs (GetSlot): Move data-structure traversal to ...
(GetPrev): ... this. Returns the slot prior to the place we're
looking for, or null if that place is the head of the chain.
(Remove): Use it.
(this.set): Use it. Implement move-to-front on set.
* Dictionary.cs (ToTKey, ToTValue): New helpers to convert from
type 'object'.
(IDictionary.this, IDictionary.Add): Use them.
(IDictionary.Contains, IDictionary.Remove): If the types don't
match, do nothing.
In Test/System.Collections.Generic:
* DictionaryTest.cs (IDictionary_*): Add a few tests for the
IDictionary explicit implementation.
svn path=/trunk/mcs/; revision=55946