Commit Graph
235 Commits
Author SHA1 Message Date
Gert Driesen c231373769 * DataColumn.cs: Fixed ParamName of ArgumentNullException. Modified
exception message for invalid DateTimeMode value to match MS. Code
formatting.
* DbDataPermissionAttribute.cs: In KeyRestrictionBehavior, reuse
ExceptionHelper.CheckEnumValue.   
* ExceptionHelper.cs: Use same exception message for both 1.0 and 2.0.
* Index.cs: Fixed compiler warnings. Code formatting.
* SqlCommand.cs: Use ExceptionHelper.CheckEnumValue for enum checks.
* OleDbCommand.cs: Use ExceptionHelper.CheckEnumValue for enum checks.
* DBDataPermissionAttributeTest.cs: Improved test for invalid
KeyRestrictionBehavior. Fixed line endings.
* DataColumnTest.cs: No longer derive from deprecated Assertion class.
Code formatting. Added test for DateTimeMode.

svn path=/trunk/mcs/; revision=87866
2007-10-21 13:26:43 +00:00
Gert Driesen 3930b4b9cf * System.Data_test.dll.sources: Added DbDataAdapterTest.cs,
OdbcCommandTest.cs, OdbcConnectionTest.cs, OdbcDataAdapterTest.cs, 
OleDbCommandTest.cs, OleDbConnectionTest.cs, OleDbDataAdapterTest.cs, 
SqlDataAdapterTest.cs.
* DbDataAdapter.cs: Implemented UpdateBatchSize setter.
* DataAdapter.cs: In FillLoadOption setter, ensure value is valid.
Modified MissingMappingAction and MissingSchemaAction setters to use
ExceptionHelper.CheckEnumValue to validate value. Spaces to tabs and
code formatting.
* ExceptionHelper.cs: Added CheckEnumValue method and modified
InvalidEnumValueException method to return AORE on 2.0 profile. Added
ConnectionClosed method that returns an InvalidOperationException.
* OleDbDataAdapter.cs: In default ctor, set SelectCommand to null.
Only initialize SelectCommand in ctors. Use direct assignment in
IDbDataAdapter implementation.
* OleDbCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Added implementation for UpdatedRowSource.
* OleDbConnection.cs: Moved initialization of gda to Open ().
Avoid unnecessary initialization. Return zero-length string if
ConnectionString is null. If getters to Database, DataSource and
Provider return zero-length string if the connection is closed.
In ServerVersion, BeginTransaction and GetSchema, throw an
InvalidOperationException if connection is closed.
* OdbcCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Spaces to tabs and code formatting.
* OdbcError.cs: Fixed typo in exception message.
* OdbcConnection.cs: Return zero-length string if ConnectionString is
null. In getters for Database, DataSource and Driver return a
zero-length string if connection is closed. In BeginTransaction and
GetSchema throw InvalidOperationException if connection is closed.
Added override for GetSchema (string, string []). Use string.Empty
instead of "".
* OdbcDataAdapter.cs: Avoid unnecessary initializations. Use direct
assignment in IDbDataAdapter implementation. In default ctor, set
SelectCommand to null.
* SqlCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Use ExceptionHelper.InvalidEnumValueException
to avoid code duplication. Spaces to tabs and code formatting.
* SqlConnection.cs: Use different default package size on 2.0 profile.
Added constants for default values, instead of using magic numbers.
Avoid unnecessary initialization. In PacketSize, return default or
configured packet size when connection is not open. Use 
ExceptionHelper.ConnectionClosed instead of local method. Removed   
use of some hardcoded values in SetDefaultConnectionParameters, and
use Environment.MachineName as default WorkstationId instead of 
DNS host name. Code formatting.
* SqlDataAdapter.cs: In default ctor, set SelectCommand to null.
Avoid unnecessary initializations. Use direct assignment in   
IDbDataAdapter implementation. Fixed exception message for negative
UpdateBatchSize. In Dispose override, make sure to invoke base
method.
* DbDataAdapterTest.cs: Added test for UpdateBatchSize.
* DataAdapterTest.cs: Added tests for AcceptChangesDuringFile,   
AcceptChangesDuringUpdate, ContinueUpdateOnError, FillLoadOption,
MissingMappingAction, MissingSchemaAction and                      
ReturnProviderSpecificTypes.
* OdbcDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OdbcDataReaderTest.cs: fixed line endings.
* OdbcCommandTest.cs: Added tests for ctors and CommantText.
* OdbcConnectionTest.cs: Removed original test that relied on MySQL.
Added ctor tests. Added tests for BeginTransaction, GetSchema and 
ServerVersion with connection that is closed.
* OleDbDataAdapterTest.cs: Added tests for ctors, DeleteCommand, 
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OleDbCommandTest.cs: Added tests for ctors and CommandText.
* OleDbConnectionTest.cs: Added tests for ctors and ConnectionString. 
Added tests for BeginTransaction, GetSchema and ServerVersion with connection that is closed.
* SqlCommandTest.cs: Added tests for ctors and CommantText. 
* SqlConnectionTest.cs: Added tests for ctors, ConnectionString and 
ServerVersion.
* SqlDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand, UpdateBatchSize and 
Dispose.

svn path=/trunk/mcs/; revision=87859
2007-10-20 23:16:52 +00:00
Gert Driesen e2681602c2 * DbTransaction.cs: Do not perform a rollback in Dispose (bool).
Leaves it up to deriving classes to override Dispose (bool) and
perform a rollback if necessary. Fixes bug #325397. Code formatting.
* ExceptionHelper.cs: Added TransactionNotUsable method that constructs
an InvalidOperationException to be thrown by IDbTransaction
implementations when the transaction is no longer open.
* OdbcTransaction.cs: Keep state of the transaction, and update it
when performing commit or rollback. In Dispose (bool), only perform
a rollback if transaction was not committed or rollback before.
In Commit and Rollback, throw an InvalidOperationException if
transaction is no longer open.
* SqlTransaction.cs: Avoid unnecessary initialization. Remove
isRolledBack since its essentially the same as isOpen. Use
ExceptionHelper.TransactionNotUsable instead of duplicating code.
On 2.0 profile, ignore call to Rollback when transaction was already
disposed.
* OleDbTransaction.cs: Keep track of whether transaction is open and
whether it's disposed. In Commit an Rollback, throw an IOE if the
transaction is no longer open. In Dispose (bool), perform a rollback
if the transaction is still open.

svn path=/trunk/mcs/; revision=87835
2007-10-19 16:04:39 +00:00
Nagappan Alagappan d6b5b3c2df * DbDataAdapter.cs: Added MonoTODO in appropriate place.
* DbCommandBuilder.cs (initializeCommand): Implemented missing API.

svn path=/trunk/mcs/; revision=86517
2007-09-27 17:28:40 +00:00
Nagappan Alagappan ed44256006 2007-09-25 Nagappan A <[email protected]>
* DbConnection.cs: 2.0 attribute fixes.

	* DataColumnMapping.cs: 2.0 attribute fixes.

	* DbParameterCollection.cs: Code alignment.

	* DataAdapter.cs: 2.0 attribute fixes.

	* DataTableMapping.cs: 2.0 attribute fixes.

	* RowUpdatingEventArgs.cs (BaseCommand): Code alignment.


svn path=/trunk/mcs/; revision=86296
2007-09-25 05:23:45 +00:00
Konstantin Triger 283716cb20 DbEnumerator.cs, DbDataRecord.cs: refactoring; DbDataRecord.cs: GetValue() should return null instead of DBNull
svn path=/trunk/mcs/; revision=86257
2007-09-24 14:44:35 +00:00
Nagappan Alagappan ca43995a30 2007-08-10 Nagappan A <[email protected]>
* DbDataAdapter.cs (Fill): Fixed method signature.


svn path=/trunk/mcs/; revision=83797
2007-08-10 05:17:19 +00:00
Nagappan Alagappan 724a84ebf5 2007-07-26 Nagappan A <[email protected]>
* DbConnection.cs: Removed bogus TODO.


svn path=/trunk/mcs/; revision=82768
2007-07-26 13:06:23 +00:00
Nagappan Alagappan 5c266b32df 2007-07-22 Nagappan A <[email protected]>
* DbConnection.cs: 2.0 missing features.

	* DbDataAdapter.cs: 2.0 missing features.


svn path=/trunk/mcs/; revision=82422
2007-07-22 06:42:40 +00:00
Gert Driesen 53332a431f * DbDataAdapter.cs: Marked ICloneable.Clone obsolete to match MS.
svn path=/trunk/mcs/; revision=81108
2007-06-30 13:58:00 +00:00
Nagappan Alagappan af7c96b67e 2007-06-21 Nagappan A <[email protected]>
* DbConnectionStringBuilder.cs (Add): Fixed exception error message.


svn path=/trunk/mcs/; revision=80470
2007-06-21 13:15:51 +00:00
Nagappan Alagappan 354842e304 2007-06-21 Nagappan A <[email protected]>
* DbConnectionStringBuilder.cs (Init): Modified the dictionary to
	use StringComparer.InvariantCultureIgnoreCase.
	(Add, ContainsKey): Checks whether argument is null or empty string.


svn path=/trunk/mcs/; revision=80465
2007-06-21 13:09:49 +00:00
Konstantin Triger cde03727d8 provide docs for unsupported functionality
svn path=/trunk/mcs/; revision=78212
2007-05-30 14:10:21 +00:00
Konstantin Triger 4db1a31f35 improve exception message
svn path=/trunk/mcs/; revision=78211
2007-05-30 14:09:15 +00:00
Konstantin Triger 6c1d4bcd52 TARGET_JVM: the attribute is not needed anymore
svn path=/trunk/mcs/; revision=78177
2007-05-30 09:28:02 +00:00
Adar Wesley b9fcdffeb5 2007-05-08 Adar Wesley <[email protected]>
* DbProviderFactory.cs: minor refactoring for throwing exceptions

        * OleDbCommandBuilder.cs: added missing methods QuoteIdentifier,
        UnquoteIdentifier.

        * OleDbConnection.cs: added missing method ResetState.

        * OleDbDataReader.cs: added missing method GetData.

        * OleDbError.cs: added missing method ToString.

        * OleDbErrorCollection.cs: added missing method strongly typed
        CopyTo.

        * OleDbFactory.cs: added missing method CreatePermission.

        * OleDbParameter.cs: added missing methods ResetOleDbType,
        ResetDbType.

        * OleDbParameterCollection.cs: added missing methods strongly
        typed AddRange, IndexOf.



svn path=/trunk/mcs/; revision=76940
2007-05-08 15:14:49 +00:00
Konstantin Triger 954d065539 TARGET_JVM: SkipJavaOutputValidation for DataAdapter.Fill
svn path=/trunk/mcs/; revision=76491
2007-04-30 13:40:52 +00:00
Marek Habersack d105ea0838 2007-04-30 Marek Habersack <[email protected]>
* ConnectionStringsExpressionBuilder.cs: support expressions with
	suffixes .ProviderName and .ConnectionString (case-insensitie) and
	generate a call to GetConnectionStringProviderName in the former
	case. Fixes bug #81490

2007-04-30  Marek Habersack  <[email protected]>

	* SqlDataSource.cs: do not catch the exception if ProviderName is
	not null or empty (as per docs and what MS.NET does).

2007-04-30  Marek Habersack  <[email protected]>

	* DbProviderFactories.cs: throw the same exception MS.NET does.

svn path=/trunk/mcs/; revision=76486
2007-04-30 11:02:24 +00:00
Konstantin Triger e1123c3b45 use Invariant culture for string manipulations
svn path=/trunk/mcs/; revision=75441
2007-04-05 13:53:23 +00:00
Gert Driesen e86ef7ce8d * app_test_2.0.config: Modified DbProviderFactories to allow testing
of clear and remove nodes.
* DbProviderFactoriesConfigurationHandler.cs: Added support for
clear node.
* DbProviderFactoriesConfigurationHandlerTest.cs: Changed test to also
verify behavior for clear and remove nodes.

svn path=/trunk/mcs/; revision=73663
2007-03-03 20:15:49 +00:00
Gert Driesen a789895532 * DbProviderFactoriesConfigurationHandlerTest.cs: Fixed tests to
pass on MS. Added NotWorking test to check whether DbProviderFactories
that are defined on machine config are available.
* ConnectionStringsSectionHandler.cs: Removed since the 2.0 config
API is in place.
* DbProviderFactoriesConfigurationHandler.cs: Fixed name of DataSet
to match MS. Removed SupportedClasses column since this is no longer
part of 2.0 profile (removed during beta). Throw
ConfigurationErrorsException for unrecognized elements. Mark methods
private, and refactor them. Added FIXMEs for missing checks for
unrecognized attributes.
* DbProviderFactories.cs: Marked constants internal. Replaced spaces
with tabs. Use ConfigurationManager.GetSection instead of deprecated
ConfigurationSettings.GetConfig.
* app_test_2.0.config: Fixed assembly qualified names of config
handler. Removed usage of ConnectionStringsSectionHandler, since
this is now handled by 2.0 config system. Spaces to tabs.
* System.Data.dll.sources: Removed ConnectionStringsSectionHandler.

svn path=/trunk/mcs/; revision=73659
2007-03-03 15:09:07 +00:00
Atsushi Eno b3b740544f 2007-02-26 Atsushi Enomoto <[email protected]>
* DbProviderFactoriesConfigurationHandler.cs : there was a config
	  test that used to be broken.


svn path=/trunk/mcs/; revision=73432
2007-02-26 15:06:22 +00:00
Atsushi Eno 049e7be6cd 2007-02-26 Atsushi Enomoto <[email protected]>
* DbProviderFactoriesConfigurationHandler.cs : remove "support"
	  attribute check, as it does not really do anything.


svn path=/trunk/mcs/; revision=73417
2007-02-26 09:43:16 +00:00
Atsushi Eno a57b6ac702 2007-02-19 Atsushi Enomoto <[email protected]>
* DbProviderFactoriesConfigurationHandler.cs : "support" attribute is
	  optional. Fixed bug #80894.

	* DbProviderFactoriesConfigurationHandlerTest.cs : test for #80894.


svn path=/trunk/mcs/; revision=73093
2007-02-19 07:32:05 +00:00
Marek Habersack a9cc4931de really revert teh changes
svn path=/trunk/mcs/; revision=72881
2007-02-15 00:59:18 +00:00
Marek Habersack 20b450f9b8 Revert this one too
svn path=/trunk/mcs/; revision=72880
2007-02-15 00:54:29 +00:00
Marek Habersack f877231cae The SupportedClasses column is no longer valid
svn path=/trunk/mcs/; revision=72878
2007-02-15 00:08:16 +00:00
Nagappan Alagappan 92a3f2f5aa 2007-02-09 Nagappan A <[email protected]>
* DbProviderFactory.cs: Derived class has to implement all the
	methods of this class.

	* DbProviderFactoriesConfigurationHandler.cs (Create): Removed
	bogus MonoTODO


svn path=/trunk/mcs/; revision=72538
2007-02-09 13:51:10 +00:00
Nagappan Alagappan d4903c8aca 2007-01-08 Nagappan A <[email protected]>
* DataTableMappingCollection.cs (AddRange):  Implemented missing
	NET 2.0 API.

	* DbConnection.cs (GetSchema): Implemented missing NET 2.0 API,
	based on SqlClient implementation.

	* DbConnectionStringBuilder.cs (AppendKeyValuePair): Implemented
	missing API.

	* DbDataReader.cs (GetData): Implemented missing API.
	(GetDbDataReader): Implemented missing API.

	* DbCommandBuilder.cs (BuildCache, BuildInformation)
	(IncludedInInsert, IncludedInUpdate, IncludedInWhereClause)
	(CreateDeleteCommand, CreateInsertCommand, CreateNewCommand)
	(CreateUpdateCommand, CreateParameter): Added private methods.
	(QuotedTableName, GetQuotedString, CatalogLocation)
	(CatalogSeparator, ConflictOption, DataAdapter, QuotePrefix)
	(QuoteSuffix, SchemaSeparator): Implemented public properties.
	(SourceCommand): Implemented private property.
	(Dispose, RowUpdatingHandler): Implemented protected methods.
	(GetDeleteCommand, GetInsertCommand, GetUpdateCommand)
	(QuoteIdentifier, UnquoteIdentifier, RefreshSchema): Implemented
	public methods.

	* DbProviderFactory.cs: Removed MonoTODO's as the derived class
	has to implement all the methods in this class.

	* DataAdapter.cs (Fill): Implemented missing method.

	* DbDataAdapter.cs (FillCommandBehavior): Implemented property.


svn path=/trunk/mcs/; revision=70620
2007-01-08 05:55:18 +00:00
Nagappan Alagappan 947def72f2 2006-12-20 Nagappan A <[email protected]>
* DataColumnMapping.cs (GetDataColumnBySchemaAction): Implemented
	2.0 profile method.

	* DbDataReader.cs: Removed TODO's where ever the implementation is
	available.

	* RowUpdatedEventArgs.cs: Removed TODO's where ever the
	implementation is available.

	* DataAdapter.cs (FillInternal): Moved from DbDataAdapater.cs to
	here.
	(BuildSchema): Moved from DbDataAdapter.cs.
	(FillTable): Moved from DbDataAdapter.cs.
	(OnFillErrorInternal): Implemented new internal method to raise an
	event.
	(SetupSchema): Moved from DbDataAdapter.cs.
	(FillInterl): Moved common implementation from DbDataAdapter.cs.
	Removed TODO's where ever the implementation is available.

	* DbDataAdapter.cs (OnRowUpdated): Implemented protected method.
	(OnRowUpdating): Implemented protected method.
	(CreateFillErrorEvent): Moved to DataAdapter.cs.
	(Fill): Moved common implementation to DataAdapter.cs.
	(FillTable): Moved to DataAdapter.cs.
	(BuildSchema): Moved to DataAdapter.cs.
	(SetupSchema): Moved to DataAdapter.cs.


svn path=/trunk/mcs/; revision=69818
2006-12-20 17:17:24 +00:00
Miguel de Icaza cf3eed8712 2006-12-11 Miguel de Icaza <[email protected]>
* DataAdapter.cs: Removed TODO, NotSupportedException was the
	correct implementation. 


svn path=/trunk/mcs/; revision=69344
2006-12-11 18:26:48 +00:00
Nagappan Alagappan 5a6557b7c7 2006-11-28 Nagappan A <[email protected]>
* DbDataAdapter.cs: Removed bogus MonoTODOs

	* DataAdapter.cs: Removed bogus MonoTODOs


svn path=/trunk/mcs/; revision=68578
2006-11-28 13:21:25 +00:00
Nagappan Alagappan 43c40ea6e8 2006-11-15 Nagappan A <[email protected]>
* DbDataAdapter.cs (FillFromReader): Implemented missing API to
	handle FillErrorEventHandler
	(DataAdapter): Implemented missing .NET 2.0 function
	(GetDeleteCommand): Returns DbDataAdapter deleteCommand internal
	variable.
	(GetInsertCommand): Returns DbDataAdapter insertCommand internal
	variable.
	(GetUpdateCommand): Returns DbDataAdapter updateCommand internal
	variable.


svn path=/trunk/mcs/; revision=67900
2006-11-15 12:13:18 +00:00
Konstantin Triger 9e28dfd1d1 added basic implementation for some 2.0 features
svn path=/trunk/mcs/; revision=64991
2006-09-06 10:32:17 +00:00
Vladimir Krasnov c7fad184fe * DbProviderFactories.cs: added TARGET_JVM block to not supported functionality
svn path=/trunk/mcs/; revision=64306
2006-08-24 14:18:44 +00:00
Kornél Pál 2d604bc51e Converted ChangeLogs to UTF-8 and recovered incorrectly encoded characters.
svn path=/trunk/mcs/; revision=63835
2006-08-16 19:42:08 +00:00
Konstantin Triger 4add96619f DbDataReader.Dipose(bool) - implemented
svn path=/trunk/mcs/; revision=63410
2006-08-06 13:46:58 +00:00
Konstantin Triger e3b371d95f TARGET_JVM ifdef
svn path=/trunk/mcs/; revision=63409
2006-08-06 13:46:24 +00:00
Konstantin Triger 7266665f4d refactoring to adapt to build system changes
svn path=/trunk/mcs/; revision=63247
2006-08-02 13:05:08 +00:00
Senganal T ee861e25e7 2006-07-17 Senganal T <[email protected]>
* Test/System.Data/DataViewTest2.cs :
		- Tests for ToTable overloads
		- Test for Equals method
		- Tests to check for the Sort, RowFilter values when
		DataView is created and when Table is set.
	* Test/System.Data/DataViewTest_IBindingList.cs :
		- Ensure tests do not depend on the order of
		execution.
	* Test/System.Data/DataViewTest_IBindingListView.cs : New
		- Tests for IBindingListView interface methods
	* System.Data.Common/Index.cs :
		- GetAllRows : Added. Returns all the rows in the current
		index.
		- GetDistinctRows :Added. Returns all the distinct rows (based
		in Key Columns) in the index.
	* System.Data.dll.sources:
		- Added to build :
			Test/System.Data/DataViewTest_IBindingListView.cs
	* System.Data/DataView.cs :
		- ToTable : Implemented all the overloads
		- Equals : Implemented 
		- IBindingListView : Implemented the interface


svn path=/trunk/mcs/; revision=62669
2006-07-17 11:58:10 +00:00
Senganal T dbcfcb27fe 2006-07-13 Senganal T <[email protected]>
* Test/System.Data.Common/DBDataPermissionTest.cs : Removed invalid tests

	* System.Data.Common/SchemaInfo.cs DbDataAdapter.cs DbConnectionOptions.cs DbParameter.cs 
	DbMetaDataColumnNames.cs DbTransaction.cs DataTableMapping.cs DataAdapter.cs 
	FieldNameLookup.cs DbDataRecord.cs DataColumnMappingCollection.cs DbCommand.cs 
	DbDataPermission.cs DbProviderFactory.cs DbCommandBuilder.cs DbConnectionString.cs 
	RowUpdatedEventArgs.cs DbDataReader.cs DbConnectionStringBuilder.cs DbConnection.cs 
	DataTableMappingCollection.cs :
		2.0 Api fixes

	* System.Data.SqlClient/SqlClientFactory.cs SqlCommand.cs SqlConnectionFactory.cs 
	SqlClientPermission.cs SqlParameterCollection.cs SqlDataReader.cs 
	SqlConnection.cs SqlParameter.cs SqlTransaction.cs :
		2.0 Api fixes

	* System.Data.Odbc/OdbcTransaction.cs OdbcCommand.cs OdbcConnectionFactory.cs 
	OdbcPermission.cs OdbcDataReader.cs OdbcParameterCollection.cs 
	OdbcConnection.cs OdbcFactory.cs OdbcParameter.cs :
		2.0 Api fixes

	* System.Data.OleDb/OleDbCommand : 2.0 Api fixes

	* System.Data.dll.sources: 
		- Added to build :
			System.Data.Common/DbMetaDataColumnNames.cs
		- Removed from build :
			System.Data.Common/DbCommandOptionalFeatures.cs
			System.Data.Common/DbCommandSet.cs
			System.Data.Common/DbProviderSupportedClasses.cs
			System.Data.Common/SchemaLocation.cs
			System.Data.Odbc/OdbcConnectionFactory.cs
			System.Data.SqlClient/SqlConnectionFactory.cs
			System.Data.ProviderBase/DbCommandBase.cs
			System.Data.ProviderBase/DbConnectionBase.cs
			System.Data.ProviderBase/DbConnectionFactory.cs
			System.Data.ProviderBase/DbConnectionInternal.cs
			System.Data.ProviderBase/DbConnectionPoolCounters.cs
			System.Data.ProviderBase/DbConnectionPoolOptions.cs
			System.Data.ProviderBase/DbDataReaderBase.cs
			System.Data.ProviderBase/DbMetaDataFactory.cs
			System.Data.ProviderBase/DbParameterBase.cs
			System.Data.ProviderBase/DbParameterCollectionBase.cs
			System.Data.ProviderBase/DbReferenceCollection.cs

	* Makefile : Add System.Transactions library reference to net_2_0 PROFILE


svn path=/trunk/mcs/; revision=62561
2006-07-13 14:19:17 +00:00
Senganal T 87cff09075 2006-06-15 Senganal T <[email protected]>
* Test/System.Data/DataSetTest2.cs : Test the behavior of EnforceConstraints 
	* Test/System.Data/DataViewTest_IBindingList.cs : Test to ensure the correct index is 
	used for comparision
	* Test/System.Data/DataRowTest2.cs : Test to ensure the RowErrors and ColumnErrors are
	filled correctly.

	* System.Data.Common/Key.cs : 
		-Equals : Check for Equality of Sort Order too.
		
	* System.Data/DataSet.cs :
		- InternalEnforceConstraints : Check if any null constraints 
		are violated. Throw ConstraintException only after all the errors
		are filled.
	* System.Data/DataTable.cs :
		- EnforceConstraints : Move away the logic to check for 
		NullConstraintViolation.
		- AssertNotNullConstraint : Checks for Null Constraint
		Violation.
		- EndLoadData : Do not throw any exceptions here. All the
		errors have to be found and RowErrors set before throwing the
		exception.
	* System.Data/DataRow.cs :
		- ImportRecrod : Check the values of the row for any null
		values.
		- SetColumnError : If the error for column is already set,
		do not add a new error but edit the existing error. 
		- CheckValue : Set the NullConstraintViolation flag if either
		table is being loaded or if EnforceConstraints is set to
		false.
	* System.Data/Constraint.cs : Do not throw exception when EnforceConstraints is
	set to false or table is being loaded.
	* System.Data/UniqueConstraint.cs : Correct the error message. Set ColumnErrors
	along with the RowError.


svn path=/trunk/mcs/; revision=61744
2006-06-15 06:56:16 +00:00
Senganal T bd85b69021 2006-04-07 Senganal T <[email protected]>
* Test/ProviderTests/System.Data.SqlClient/SqlCommandBuilderTest.cs :
		- Corrected the testcase to check for queries corresponding to
		ms.net 2.0
		- verify that columns that do not allow nulls are not included
		in the null-checks.
		- Added testcase to check for DBConcurrencyException for
		Delete Command. 
		- Check the DataType of the null-check parameters
	* System.Data.Common/DbDataAdapter.cs :
		* Update () : If the Update/Delete Query has a null check,
		then populate the parameter value correctly.
	*  System.Data.SqlClient/SqlCommandBuilder.cs :
		* CreateDeleteCommand () 
		* CreateUpdateCommand () 
		* CreateInsertCommand () 
			- Changed the signature. Do not need DataRow parameter 
			as the Query generated is parametric.
			- Correct the null-check term in the WhereClause, set the
			correct properties for null-check parameter
			fixes #78027
			- Modified the generated query to match the query as
			generated by 2.0. We now ignore null-check in the
			whereclause if the Column does not allow nulls.
		* ctor () : Set QuotePrefix and QuoteSuffix for 2.0 profile
		* GetUpdateCommand ()
		* GetInsertCommand ()
		* GetDeleteCommand ()
			- Do not create new command everytime. Create only if
			not already created.
		* RefreshSchema : Reset the commands.


svn path=/trunk/mcs/; revision=59175
2006-04-07 12:46:57 +00:00
Senganal T b58ac4f522 2006-03-20 Senganal T <[email protected]>
* System.Data.Common/DataAdapter.cs :
		- Ctor () : Set Default Values for DataAdapter members
	* System.Data.Common/DbDataAdapter.cs : 
		- Update () : Call row.AcceptChanges only if AcceptChangesDuringUpdate
		is true. Fixes bug #77776


svn path=/trunk/mcs/; revision=58185
2006-03-20 14:18:25 +00:00
Senganal T f8abdf3c60 2006-03-09 Senganal T <[email protected]>
* Test/System.Data/DataRowCollectionTest2.cs :
	* Test/System.Data/DataTableTest2.cs : 
		- Fixed NotWorking tests.
	* System.Data.Common/Index.cs :
		- Update () : Add the new record in the correct position
	* System.Data/DataRow.cs :
		- RejectChanges () :  Add the row to index, if it was in deleted state and
		Update the index if in Modified State.
		- AcceptChanges () : Do not update the Indexes.
		- EndEdit () : Update the indexes even if BeginLoadData has been called
		on the table. Ideally, indexes should not be maintained during DataLoad,
		but this needs to handled in multiple places correctly. For now, just maintain
		the index to ensure correct operation.
	

svn path=/trunk/mcs/; revision=57725
2006-03-09 13:00:43 +00:00
Senganal T d915d0690b 2006-03-07 Senganal T <[email protected]>
* Test/System.Data/DataRowCollectionTest2.cs :
	* Test/System.Data/DataTableTest2.cs :
		- Added failing testcases as NotWorking tests.
	* System.Data.Common/Key.cs : 
		Reverted the changes from the prev patch.


svn path=/trunk/mcs/; revision=57653
2006-03-07 10:22:01 +00:00
Senganal T 08c7b22113 2006-02-22 Senganal T <[email protected]>
* Test/System.Data/DataRowCollectionTest2.cs : Check if index is maintained for row on calling RejectChanges. 
	* Test/System.Data/DataTableTest2.cs : Check if data is loaded and merged (if key exists) correctly.
	* Test/System.Data/ForeignKeyConstraintTest.cs : Check if a ParentColumn value can be modified
		when the row is in 'Added' State. Also, check if child col values are
		updated correctly.
	* Test/ProviderTests/System.Data.SqlClient/SqlAdapterTest.cs : Added testcases for verifying FillError Behavior
	* System.Data.Common/DbDataAdapter.cs :
		- FillTable : Move BeginLoadData, EndLoadData outside the loop. Also,
		move EndLoadData outsidet try,catch block. FillError is only for errors
		occuring during loading the data into datatable.
	* System.Data.Common/Key.cs :
		- Set Default value of RowStateFilter to (CurrentRos | OriginalRows).
		- ContainsVersion : If RowStateFilter is set to default value, return true
		for Modified Rows as they can contain Default/Original versions.
	* System.Data/DataRow.cs 
		- RejectChanges : Do not remove Row from Indexes when state is Deleted.
		- CheckChildRows : When checking for the ChildRows, use the current value
		and not the original value.


svn path=/trunk/mcs/; revision=57149
2006-02-22 10:03:03 +00:00
Raja R Harinath 1d72d9b102 * DbConnectionStringBuilder.cs (ICollection.CopyTo): Use
_dictionary, not 'this' in cast.

svn path=/trunk/mcs/; revision=57033
2006-02-18 18:23:45 +00:00
Chris Toshok 3a793df5f4 2006-02-17 Chris Toshok <[email protected]>
* DbDataAdapter.cs: more 2.0 cleanup.


svn path=/trunk/mcs/; revision=57017
2006-02-17 20:11:29 +00:00
Chris Toshok 6a5801f910 2006-02-17 Chris Toshok <[email protected]>
* DataAdapter.cs, DataColumnMappingCollection.cs,
	DataColumnMapping.cs, DataTableMappingCollection.cs,
	DataTableMapping.cs, DbCommandBuilder.cs,
	DbConnectionStringBuilder.cs, DbParameterCollection.cs,
	DbParameter.cs: pretty major attribute work.


svn path=/trunk/mcs/; revision=57016
2006-02-17 19:49:17 +00:00