* Makefile (net_2_0_dirs): added System.Web - it now depends on
System.Core, so it needs to be recompiled one more time after
System.Core is done.
2009-01-22 Marek Habersack <[email protected]>
* System.Web.dll.sources: added
System.Web.Compilation/BuildManagerCacheItem.cs,
System.Web.Compilation/BuildManagerDirectoryBuilder.cs,
System.Web.Compilation/BuildProviderGroup.cs
* Makefile (SYSTEMCORE_DEP): added. Defines SYSTEMCORE_DEP on the
mcs command line when System.Core is present.
Added the DEVEL define, which defines DEVEL on the mcs command
line. This is used to conditionally compile development helper code in
System.Web.Util.FileUtils (and possibly other stuff later on)
2009-01-22 Marek Habersack <[email protected]>
* XsdBuildProvider.cs: added missing BuildProviderAppliesTo
attribute.
* BuildProvider.cs: added new internal virtual method,
ExtractDependencies() whose purpose is to extract virtual path
dependencies without compiling the code, if possible.
* TemplateBuildProvider.cs: implemented the new
ExtractDependencies () method which uses regular expressions to
extract file dependencies from the source without having to
compile the file.
* CompilationException.cs: added a new public property, Results,
which returns the compilation results.
* BuildProviderGroup.cs: added. A simple class descending from
List <BuildProvider> which is used to hold a compilation batch -
that is a collection of BuildProvider instances.
* BuildManagerDirectoryBuilder.cs: new class which takes care of
generating compilation batches for the requested virtual path. A
set of batches is generated from files found in the same virtual
directory as the requested virtual path and all of the
dependencies of those files. All files are grouped in batches
within which no file depends upon its siblings. An attempt is made
to sort the batches from the "least dependent" to the "most
dependent" batches - i.e. the batches which do not depend on other
batches go to the top.
Code generating the batches now correctly detects dependency loops
and throws an exception when one is encountered.
Batches are represented as instances of a new class -
BuildProviderGroup.
* BuildManagerCacheItem.cs: added. Contains all the compilation
result information needed by BuildManager. See below.
* BuildManager.cs: complete batch building rewrite:
- only one build lock is held instead of a set of compilation
tickets. Only one thread can compile anything at one given
time.
- retrieving types from the build cache now uses a slim rw lock,
so that readers aren't blocked while compilation is in
progress. Writer lock is acquired only when adding a newly
compiled type to the build cache and when removing it after its
dependencies made it invalid.
- assembly references for each compilation are now collected
dynamically as the source is being compiled, this removed a lot
of complexity in dealing with assembles containing conflicting
types. As a consequence right now there may exist several
loaded assemblies containing the same type, but only the latest
of them will be used in new compiles.
- the thread compiling code can recurse into the Build method
which causes the recursively referenced code to be compiled
into a separate, uniquely named, assembly. This deals with all
recursion loops and dependency problems.
- automatic app domain restart after a certain number of compiles
is enabled now.
- improved compilation error handling. If a compilation error
occurs, the code attempts to recompile the assembly up to 3
times, each time removing from the batch the files/virtual
paths which failed parsing/compilation. If the attempts failed,
another one is made to compile only the virtual path requested
by the calling code. Only should that fail a compilation
exception is thrown. All the compilation errors are written to
stdout if the application is in the debug mode.
- changed assembly naming. It now generates assembly names based
on whether the compilation is recursive and whether the batch
being compiled contains more than one code unit or
not.
- compilation results are now stored in the cache as instances of
the new BuildManagerCacheItem class, which contains all the
information required by BuildManager to return types,
assemblies, dependencies etc.
- GetReferencedAssemblies now correctly returns only the
assemblies defined in the .config files.
- GetVirtualPathDependencies does not need to compile code
anymore in order to extract virtual path dependencies. New code
in BuildProvider.ExtractDependencies () takes care of that.
- a BuildManagerDirectoryBuilder class instance is used to
generate compilation batches.
* AssemblyBuilder.cs: added support for keeping track of which
code unit was generated by which BuildProvider andr which
BuildProvider produced a given source file. Both changes serve the
purpose of dealing with compilation errors in BuildManager.
* ApplicationFileBuildProvider.cs: added missing
BuildProviderAppliesTo attribute
2009-01-22 Marek Habersack <[email protected]>
* FileUtils.cs: added two conditionally compiled methods (they
require DEVEL to be defined) which output lines to a log file.
2009-01-22 Marek Habersack <[email protected]>
* WebTest.cs: Run () sets the internal field
BuildManager.suppressDebugModeMessages to true.
2009-01-22 Marek Habersack <[email protected]>
* Web.mono.config: added numRecompilesBeforeAppRestart attribute
to the compilation element, set to 100000, to avoid appdomain
restarts during tests.
svn path=/trunk/mcs/; revision=124179
* AspGenerator.cs: implemented a work around which allows the
server controls embedded in client tag attributes to be parsed and
compiled.
svn path=/trunk/mcs/; revision=123397
* CodeBuilder.cs, RootBuilder.cs, CollectionBuilder.cs: updates
related to ControlBuilder cleanup.
* ControlBuilder.cs: code cleanup - no field should be visible
outside the class unless it's a constant or a read-only field.
2009-01-13 Marek Habersack <[email protected]>
* XmlBuilder.cs: updates related to ControlBuilder cleanup.
2009-01-13 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs, AspGenerator.cs, BaseCompiler.cs,
GlobalAsaxCompiler.cs, PageThemeCompiler.cs: updates related to
ControlBuilder cleanup.
svn path=/trunk/mcs/; revision=123229
* LiteralStringControlBuilder.cs: added. Fixes bug #461214
* ControlBuilder.cs: added location tracking for literal string
children. Fixes bug #461214
* TemplateParser.cs: line pragmas are on by default. Fixes bug
#460479
2009-01-12 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: the LiteralStringControlBuilder
class is now used to track the location of the plain strings being
output to the generated code. Fixes bug #461214
* AspGenerator.cs: AppendLiteralString is called with the current
parser location as one of its parameters in FlushText (). Fixes
bug #461214
2009-01-12 Marek Habersack <[email protected]>
* System.Web.dll.sources: added
System.Web.UI/LiteralStringControlBuilder.cs
svn path=/trunk/mcs/; revision=123106
* TemplateParser.cs: in the 2.0 profile when a custom control is
registered, do not compile it right away but store the tag name in
a registry to be compiled at a later stage.
2008-12-11 Marek Habersack <[email protected]>
* BaseCompiler.cs: added a new method, InitializeType, to be
overriden in child classes when any class initialization needs to
be performed before methods, constructors and fields are created.
* TemplateControlCompiler.cs: if the parser has any custom
controls registered, compile them here - in the InitializeType
method.
svn path=/trunk/mcs/; revision=121262
* MasterPageParser.cs: do not compile anything while
parsing. MasterType virtual path is not compiled, but stored for
later. It is compiled when the MasterType property is requested
from within MasterPageCompiler.
* PageParser.cs: do not compile anything while
parsing. MasterPageFile, MasterType and PreviousPageType virtual
paths aren't compiled but checked for existence and stored for
later. Actual compilation happens when the MasterType and
PreviousPageType are requested from within PageCompiler.
* BaseParser.cs: added a new helper method, ThrowParseFileNotFound.
2008-12-10 Marek Habersack <[email protected]>
* ParseException.cs: made serializable.
* PageCompiler.cs: CreateStronglyTypedProperty calls
AddReferencedAssembly to add type's assembly to the unit's
references after the typed property has been created.
* BaseCompiler.cs: added a new helper method,
AddReferencedAssembly to be used whenever an assembly location
needs to be added to the compilation unit's list after the parsing
is done (e.g. when processing PreviousPageType or MasterPageType
properties in PageParser)
2008-12-10 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/MissingMasterFile.aspx
* System.Web_test.dll.sources: added System.Web.UI/PageParserTest.cs
2008-12-10 Marek Habersack <[email protected]>
* NunitWebResources/MissingMasterFile.aspx: added
2008-12-10 Marek Habersack <[email protected]>
* PageParserTest.cs: added
svn path=/trunk/mcs/; revision=121181
* NunitWebResources/ValidPropertyBind5.aspx: added
* NunitWebResources/ReadWritePropertyControl.ascx: added a
writable string property.
2008-12-08 Marek Habersack <[email protected]>
* TemplateControlCompilerTest.cs: added another valid Bind
expression test.
2008-12-08 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: use the correct regex match group
index in SanitizeBindCall (), fixes bug #457011
svn path=/trunk/mcs/; revision=120988
* BuildManager.cs: attempt to enter the compilation critical
section with a timeout up to 3 times before giving up. This avoids
deadlocks in situations where there are two virtual directores
each containing user controls referencing user controls from the
other directory.
svn path=/trunk/mcs/; revision=120861
* TemplateControlCompiler.cs: instead of adding ContentPlaceHolder
instances to the ContentPlaceHolders collection when the
placeholder is instantiated in the control build method, collect
the ids and store them in ContentPlaceHolders inside the
constructor. Fixes bug #449970
For each content placeholder generate a public virtual property
named "Template_PLACEHOLDERID", this is compatible with what .NET
does.
* BaseCompiler.cs: added new virtual method,
AddStatementsToConstructor, which is called just before
CreateConstructor returns.
2008-12-01 Marek Habersack <[email protected]>
* MasterPage.cs: use List <string> for ContentPlaceHolders instead
of ArrayList.
CreateMasterPage now directly accesses the ContentPlaceHolders as
it is now a list of strings
svn path=/trunk/mcs/; revision=120353
* System.Web.dll.sources: added
System.Web.Compilation/AspComponent.cs
2008-11-25 Marek Habersack <[email protected]>
* RootBuilder.cs: use new API in AspComponentFoundry to retrieve
registered control type.
* TemplateControlParser.cs: AddControlImports () removed. Its
functionality is now implemented in ControlBuilder.AddChild in a
more elegant, fine grained and correct way.
* TemplateParser.cs: replaced some "" with String.Empty
* ControlBuilder.cs: AddChild now adds an import for child's
namespace if the control being added has been registered in the
web.config file. Possible fix for #447896 and #447898
* PageParser.cs, MasterPageParser.cs: do not call
AddControlImports, it no longer exists.
2008-11-25 Marek Habersack <[email protected]>
* AspComponentFoundry.cs: GetComponentType methods replaced with
GetComponent returning an instance of AspComponent which fully
describes the registered item. Components are cached, indexed by
full tag name.
* AspComponent.cs: added
svn path=/trunk/mcs/; revision=119893
* TemplateControlCompiler.cs: make the Bind regex stricter.
When creating Eval expression from Bind, replace single quotes
with double quotes. Fixes bug #447597
When processing Bind expressions and the regex doesn't match,
throw an exception.
2008-11-21 Marek Habersack <[email protected]>
* ControlBuilder.cs: in BindingContainerType if builder is a
RootBuilder and no naming container is found, return typeof
(Page). In the TemplateBuilder case return cb.ControlType, not
this.ControlType.
svn path=/trunk/mcs/; revision=119661
* AspTokenizer.cs: if there's a newline between the opening server tag
and any other special character, treat the block as a code-render
block.
Bug #445889 fixed.
svn path=/trunk/mcs/; revision=119126
* TemplateControlCompiler.cs: If BindingDirection of the parent
template builder is OneWay in
RegisterBindingInfo, do not throw an exception but simply do not
register the binding.
svn path=/trunk/mcs/; revision=118813
* TemplateControlCompiler.cs: treat Eval and Bind expressions as
verbatim code. The only difference between the two is that in the
latter case Bind is replaced with Eval in the output code. Fixes
bug #444725
2008-11-14 Marek Habersack <[email protected]>
* DataBinder.cs: if Eval doesn't find the indicated property, try
to find an indexer property on the object and use the expression
value as its parameter. Fixes#444725
svn path=/trunk/mcs/; revision=118799
* TemplateControlCompiler.cs: IsWritablePropertyOrField doesn't
use PropertyInfo.CanWrite to check whether the property is
writable anymore, it calls GetSetMethod (false) instead.
svn path=/trunk/mcs/; revision=115941
* MonoSettingsSection.cs: added - a section for mono-specific
settings.
2008-10-09 Marek Habersack <[email protected]>
* BuildManager.cs: if monoSettings section is found in the
system.web section in web.config, use its contents to augment
compiler configuration. Used to work around the issue reported in
bug #433806
2008-10-09 Marek Habersack <[email protected]>
* System.Web.dll.sources: added System.Web.Configuration_2.0/MonoSettingsSection.cs
svn path=/trunk/mcs/; revision=115337
* TemplateControlCompiler.cs: templates must be instantiated even
for builders which process children as properties.
svn path=/trunk/mcs/; revision=115217
* AssemblyBuilder.cs: use CodeBase to get to the original assembly
path because Location might point the the shadow copy. Bug #409646
and others fixed.
svn path=/trunk/mcs/; revision=115151
* TemplateParser.cs: make sure the generated class name is a valid
language independent identifier. Fixes bug #431622
2008-10-03 Marek Habersack <[email protected]>
* BuildManager.cs: if an assembly fails to build out of a batch of
files, extract the virtual path that was requested by the client
and attempt to compile it alone.
svn path=/trunk/mcs/; revision=114732
* OutputCacheModule.cs: invalidate cache entries when the
corresponding source file (.as?x) is recompiled by hooking up to
System.Web.Compilation.BuildManager's build cache entry removal
event. Fixes bug #429926
2008-09-29 Marek Habersack <[email protected]>
* BuildManagerRemoveEntryEventHandler.cs: added
* BuildManager.cs: added a static event to notify interested
parties when an entry is removed from the buildCache. Fixes bug
#429926.
svn path=/trunk/mcs/; revision=114369
* BuildManager.cs: when creating a cache entry for a virtual path,
make it depend on a list of files built recursively from all the
virtual path's dependencies. Fixes bug #430114
svn path=/trunk/mcs/; revision=114205
the end string, append the original text instead of the end string,
because the casing might not match between the two. Fixes#320445
2008-09-24 Andreia Gaita <[email protected]>
svn path=/trunk/mcs/; revision=113972
* AspGenerator.cs: ignore whitespace only if it's between
CodeRender blocks, not between DataBinding and
CodeRenderExpression.
svn path=/trunk/mcs/; revision=113844
* ControlBuilder.cs: CreatePropertyBuilder now correctly processes
property names with prefixes (e.g. 'prefix:PropertyName').
Original, parsed, tag name is stored to properly handle closing
tags.
2008-09-01 Marek Habersack <[email protected]>
* AspGenerator.cs:
CloseControl uses ControlBuilder's OriginalTagName property,
should the property/tag name be prefixed with 'prefix:'
svn path=/trunk/mcs/; revision=112003
* TemplateControl.cs: changed the way in which ParseControl is
implemented for the 2.0+ profile. Still not quite there, but
better and closer to .NET
2008-09-01 Marek Habersack <[email protected]>
* BaseCompiler.cs: AssignAppRelativeVirtualPath works with
null/empty parser.InputFile now.
* AspGenerator.cs: AddTypeToCache works checks whether inputFile
is null or empty and does not assume the dependencies ArrayList is
present.
* CachingCompiler.cs: expect the dependencies ArrayList to be null
or empty.
svn path=/trunk/mcs/; revision=111998
* TemplateControlCompiler.cs:
Templates are processed before anything else, so that children
which may depend on parent's templates can get access to them.
2008-08-31 Marek Habersack <[email protected]>
* Control.cs: improved FillControlCache
* ControlBuilder.cs:
Added a cache for children of TemplateBuilder, used later in
TemplateControlCompiler.
svn path=/trunk/mcs/; revision=111990
* TemplateParser.cs: added support for the LinePragmas directive
attribute.
* ControlBuilder.cs: if this instance is a TemplateBuilder do not
call MyNamingContainer, so that our own ContainerType can be used
as the binding container (if present).
2008-08-31 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: trust builder.BindingContainerType
in the 2.0+ profile - do not use container properties to detect
the type.
Added a helper method, compiled only when DEBUG is defined, to
generate Console.WriteLine CodeDOM calls.
* BaseCompiler.cs: add line pragmas only if enabled for the
current file.
svn path=/trunk/mcs/; revision=111983
* ThemeDirectoryBuildProvider.cs: theme directory dependencies
should use only virtual paths for CSS files. Fixes bug #397187
svn path=/trunk/mcs/; revision=110941
* TemplateControlCompiler.cs: process expression when they are
used used in values of attributes without associated
properties. Fixes bug #417883
* ResourceExpressionBuilder.cs: added two overloads of
CreateGetLocalResourceObject to encompass cases when the generated
expression is not assigned to a property but rather used as a
parameter to the SetAttribute method. Fixes bug #417883
svn path=/trunk/mcs/; revision=110844
* TemplateControlCompiler.cs: .NET allows for whitespace between
the directive start (<%) and the directive type character. Added
code which copes with such situations correctly.
svn path=/trunk/mcs/; revision=110441
* TemplateControlCompiler.cs: rewrote the Bind regular expressions
to allow for single quotes and an optional second parameter to the
"call".
Added an Eval regular expression.
Both Bind and Eval calls in data expressions are now converted
into a CodeDOM method invocations, to allow support for possible
languages which use a different call format (previously code
snippets were used)
Added a method to construct the Eval invoke expression which
simplifies code in other areas.
2008-08-13 Marek Habersack <[email protected]>
* TemplateBuilder.cs: use a generic List to store the bindings on
2.0+
2008-08-13 Marek Habersack <[email protected]>
* HttpException.cs: do not use StringBuilder.AppendFormat when
there is no need.
svn path=/trunk/mcs/; revision=110385