* ListBox.cs, CheckBoxList.cs, ListControl.cs: VerifyMultiSelect
is not part of the official API. MultiSelect capability validation
is performed using an internal virtual method MultiSelectOk ().
* BaseDataList.cs: OnPagePreLoad is not part of the official API
* BaseDataBoundControl.cs, BaseDataList.cs, DataListItem.cs,
ValidationSummary.cs: implemented 4.0 SupportsDisabledAttribute
property.
svn path=/trunk/mcs/; revision=160305
* ListControl.cs: OnDataBinding must call base implementation
before performing the binding, so that DataSource can be assigned
from within the handler.
svn path=/trunk/mcs/; revision=144947
* DataBoundControl.cs: Initialize sets RequiresDataBinding
properly, only when we're not data-bound already, when we aren't
in postback or when we are in postback, but with viewstate
enabled. Fixes bug #542076
svn path=/trunk/mcs/; revision=142798
* ImageMap.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in Render ().
* DropDownList.cs, ListBox.cs: validate the event in LoadPostData ().
* TextBox.cs: validate the event in LoadPostData ().
Register for event validation in AddAttributesToRender ().
* HiddenField.cs: validate the event in RaisePostDataChangedEvent.
Register for event validation in Render ().
* RadioButton.cs: validate the event in LoadPostData ().
Register for event validation in InternalAddAttributesToRender.
* CheckBox.cs, RadioButtonList.cs: validate the event in
RaisePostDataChangedEvent.
* Menu.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in GetClientEvent ().
* DetailsView.cs, GridView.cs: validate the event in
RaisePostBackEvent ().
Register for validation in GetCallbackScript () and in OnPreRender
* Button.cs, Table.cs, BulletedList.cs, Calendar.cs, LinkButton.cs,
ImageButton.cs, TreeView.cs: validate the event in RaisePostBackEvent ().
2008-10-17 Marek Habersack <[email protected]>
* Control.cs: added the ValidateEvent internal method, used by
classes descending from Control to automatically trigger event
validation.
* Page.cs: removed the CheckForValidationSupport method. It moved
to Control.cs
RaisePostBackEvent no longer validates the events, this
functionality has been moved to Control.ValidateEvent.
2008-10-17 Marek Habersack <[email protected]>
* HtmlInputHidden.cs: validate the event in LoadPostDataInternal.
* HtmlInputButton.cs: validate the event in
RaisePostBackEventInternal ().
Register for event validation in RenderAttributes ()
* HtmlTextArea.cs: validate the event in
RaisePostBackDataChangedEvent ().
* HtmlButton.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ()
* HtmlAnchor.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ().
* HtmlInputRadioButton.cs, HtmlSelect.cs: validate the event in
LoadPostData.
* HtmlInputText.cs, HtmlInputImage.cs, HtmlInputCheckBox.cs,
HtmlInputPassword.cs: validate the event in
RaisePostDataChangedEvent ().
2008-10-17 Marek Habersack <[email protected]>
* MenuAdapterTest.cs: work around event validation failure in the
test environment.
2008-10-17 Marek Habersack <[email protected]>
* PageTest.cs: use a custom version of HtmlInputHidden control to
work around the new event validation code which doesn't work in
this instance.
svn path=/trunk/mcs/; revision=116231
* BulletedList.cs: Avoid calling ToString on a string.
* ButtonField.cs: Throw, not just create, the exceptions.
* HyperLinkField.cs: Throw, not just create, the exceptions.
* ImageField.cs: Throw, not just create, the exception. Avoid calling
ToString on a string.
* ListControl.cs: Avoid calling ToString on a string.
[All issues were found using Gendarme]
svn path=/trunk/mcs/; revision=102571
* ListControl.cs: make sure the owned items' Enabled property is
set to the same value what ListControl's. Fixes bug #377703
* ListItemCollection.cs: fixed SetDirty to store the index of the
last dirtied item properly. Fixes bug #377703
For the 2.0 profile, set the ListItem instances Enabled property
to the value of the owning ListControl (internal ItemsEnabled
property was added to make it possible). Fixes bug #377703
svn path=/trunk/mcs/; revision=100296
* add new resources:
PageWithAdapter.aspx for PageTest and PageAdapterTest.
TestCapability.browser for AppBrowsersTest.
* NunitWebResources/adapters.browser,
NunitWebResources/AppBrowsersTest.browser: modified to support
testing reference nodes with captures, and adapters.
* NunitWeb/NunitWeb/WebTest.cs: ensure that, during AppDomain
unload, no new requests are sent to the app host and any
pending requests are completed before the the unload occurs.
Also added WebTest.AppUnloaded event that tests can use to wait
for the app to unload (e.g. after touching Global.asax), and
WebTest.CleanApp() which can be called to restart the app with
the a skeleton directory structure. Tests which add files that
could effect other tests (e.g. App_Browsers/*.browser files) should
call WebTest.CleanApp() during TearDown to return the app to a
pristine environment.
++ Test/mainsoft/MainsoftWebTest/ChangeLog (working copy)
* HtmlAgilityPack/AssemblyInfo.cs: made assembly delay signed so that
tests can access System.Web internals now that System.Web is
InternalsVisibleTo this assembly.
++ Test/System.Web/ChangeLog (working copy)
* AppBrowsersTest.cs: added. Includes tests for Control.Adapter,
Control.ResolveAdapter, Control.TagWriter, and
Control.CreateHtmlTextWriter, when using App_Browsers/*.browser files.
AppBrowsersTest is currently tagged [Ignore], pending a fix for
bug #351878.
* HttpRuntimeTest.cs: added. Includes test for
HttpRuntime.UnloadAppDomain(). Marked [Ignore], pending a fix for
bug #351878.
++ Test/System.Web.UI.Adapters/ChangeLog (revision 0)
* PageAdapterTest.cs: added tests for PageAdapter.
* ControlAdapterTest.cs (ConfigCapabilitiesNotCalled): added test to
ensure that HttpCapabilitiesBase.ConfigCapabilities() is not called
during normal page processing if no files are in App_Browsers.
* ControlAdapterTest.cs: added tests for ControlAdapter.
++ Test/System.Web.UI/ChangeLog (working copy)
* PageTest.cs: add tests for using a PageAdapter.
* ControlTest.cs: moved commented out ResolveAdapter_1 test to
../System.Web/AppBrowsersTest.cs. Fixed typo in test name.
Added Customcontroladapter.Adapter property for use by AppBrowsersTest.
++ Test/System.Web.UI.WebControls.Adapters/ChangeLog (revision 0)
* MenuAdapterTest.cs: added
* WebControlAdapterTest.cs, HierarchicalDataBoundControlAdapterTest.cs,
DataBoundControlAdapterTest.cs, HideDisabledControlAdapterTest.cs: added
++ Test/System.Web.UI.WebControls/ChangeLog (working copy)
* MenuTest.cs (Menu_RenderStaticItems): added tests to check that
result was the same when using the base MenuAdapter as when using
no adapter.
* MenuTest.cs (Menu_RenderStaticItemsWithAdapter): added test
to ensure that MenuAdapter.RenderItem() is called.
* HierarchicalDataBoundControlTest.cs, WebControlTest.cs,
DataBoundControlTest.cs: added test for use of ControlAdapters
when present.
* WebControl.cs: added test for IsEnabled.
++ System.Web/ChangeLog (working copy)
* HttpApplicationFactory.cs: Added support for detecting
App_Browsers/*.browser files and using them to determine capabilities.
Also restart the app if the App_Browsers, App_Code, or App_GlobalResources
directories are created.
* BrowserCapabilities.cs (TagWriter): get value via internal virtual
GetTagWriter() method, which is overridden in nBrowser.Result.
* HttpRequest.cs (BrowserMightHaveSpecialWriter, BrowserMightHaveAdapters):
internal properties added to allow Page and Control methods to avoid
accessing Request.Browser to get browser-specific HtmlTextWriters or
ControlAdapters. Those things only exist when there are App_Browsers
files.
++ System.Web.UI.Adapters/ChangeLog (working copy)
* ControlAdapter.cs: made control field internal so
derived internal classes can access it without using base.Control
which can involved several typecasts.
* PageAdapter.cs: implemented all members.
* ControlAdapter.cs: implemented all members.
* PageAdapter.cs, ControlAdapter.cs: add MonoTODO's.
++ System.Web.UI/ChangeLog (working copy)
* Page.cs (SavePageControlState, LoadPageControlState): save/load
adapter state in 2.0 profile.
* Page.cs (CreateHtmlTextWriter): call Browser.CreateHtmlTextWriter()
in 2.0 profile.
* Page.cs (RenderPage): call CreateHtmlTextWriter() to get the writer
in 2.0 profile.
* Page.cs (DeterminePostBackMode, InitOutputCache,
RenderClientScriptFormDeclaration, InternalProcessRequest,
PageStatePersister): added support for PageAdapters.
* Control.cs (Adapter, ResolveAdapter): implemented. Adapter calls
ResolveAdapter and remembers result. ResolveAdapter checks for adapters
of the Type hierarchy until it finds one.
* Control.cs (SaveViewStateRecursive, LoadViewStateRecursive): save/load
adapter state in 2.0 profile.
* HtmlTextWriter.cs (BeginRender, EndRender): added empty virtual methods
required by 2.0 profile. These are called by corresponding methods of
System.Web.UI.Adapters.ControlAdapter.
* Page.cs, Control.cs: don't access Request.Browser if it couldn't have
any adapters/writers because there are no files in App_Browsers/.
++ Assembly/ChangeLog (working copy)
* AssemblyInfo.cs: made InternalsVisibleTo System.Web.test_net_2_0.dll
to support ControlAdapterTest.ConfigCapabilitiesNotCalled().
++ ChangeLog (working copy)
* System.Web_test.dll.sources: added
System.Web.UI.WebControls.Adapters/MenuAdapterTest.cs
System.Web.UI.WebControls.Adapters/WebControlAdapterTest.cs
System.Web.UI.WebControls.Adapters/HierarchicalDataBoundControlAdapterTest.cs
System.Web.UI.WebControls.Adapters/DataBoundControlAdapterTest.cs
System.Web.UI.WebControls.Adapters/HideDisabledControlAdapterTest.cs
System.Web.UI.Adapters/PageAdapterTest.cs
System.Web.UI.Adapters/ControlAdapterTest.cs
* Makefile (RESOURCE_FILES_2): added
System.Web.Configuration_2.0/RandomRoboBotKeywords.txt
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/PageWithAdapter.aspx
* System.Web.dll.sources: added
System.Web.Configuration_2.0/CapabilitiesBuild.cs
System.Web.Configuration_2.0/CapabilitiesChecksum.cs
System.Web.Configuration_2.0/CapabilitiesResult.cs
System.Web.Configuration_2.0/ICapabilitiesProcess.cs
System.Web.Configuration_2.0/nBrowser/Result.cs
System.Web.Configuration_2.0/nBrowser/NodeTypes.cs
System.Web.Configuration_2.0/nBrowser/Identification.cs
System.Web.Configuration_2.0/nBrowser/File.cs
System.Web.Configuration_2.0/nBrowser/Build.cs
System.Web.Configuration_2.0/nBrowser/Node.cs
System.Web.Configuration_2.0/nBrowser/Exception.cs
++ System.Web.UI.WebControls.Adapters/ChangeLog (working copy)
* WebControlAdapter.cs, HierarchicalDataBoundControlAdapter.cs,
DataBoundControlAdapter.cs: changed to use ControlAdapter.control
instead of using base.Control or using a new control field.
* MenuAdapter.cs: added internal constructor that takes a Menu
parameter. The constructor is used when writing unit tests.
* MenuAdapter.cs (OnInit, OnPreRender, RenderBeginTag,
RenderContents, RenderEndTag): delegate to base instead of
Control.
* MenuAdapter.cs (LoadAdapterControlState, SaveAdapterControlState,
RaisePostBackEvent, RenderItem): implemented.
* WebControlAdapter.cs (RenderContents): changed to call
control.RenderContents() instead of control.Render().
* WebControlAdapter.cs, HierarchicalDataBoundControlAdapter.cs,
DataBoundControlAdapter.cs, HideDisabledControlAdapter.cs: added
internal constructor that takes a parameter of the corresponding
Control type. The construct is used when writing unit tests.
++ System.Web.Configuration_2.0/ChangeLog (working copy)
* nBrowser/Result.cs, nBrowser/NodeTypes.cs, nBrowser/Identification.cs,
nBrowser/File.cs, nBrowser/Build.cs, nBrowser/Node.cs,
nBrowser/Exception.cs: added. The code under nBrowser handles *.browser
files. It is based on Owen "Ocean" Brady's code, with the following
changes and improvements. Replaced Result.Adapter
property with AdapterTypeMap property which maps control Type to adapter
Type. Added Result.MarkupTextWriter property. Added overrides for
Result.GetAdapters and Result.GetTagWriter to return MarkupTextWriter
and AdapterTypeMap, resp. Changed tree building algorithm to not
depend on nodes with id="Default" and to inject defaultBrowser nodes
as parents of regular nodes with the same ids. Changed Node.cs to use
Item instead of Add when adding a capability or sample header, so that
values get replaced instead of appended. Added support for reference
nodes (ie. nodes with refID="someID").
* CapabilitiesResult.cs: load RandomRoboBotKeywords.txt resource
using the correct name.
* RandomRoboBotKeywords.txt: added
* HttpCapabilitiesBase.cs (CreateHtmlWriter, Adapters): Added
support for *.browsers. Adapters property calls internal virtual
GetAdapters() method which is overrided in nBrowser.Result
returned by nBrowser code. CreateHtmlWriter uses type specified
by TagWriter property.
++ System.Web.UI.WebControls/ChangeLog (working copy)
* DetailsView.cs, ListControl.cs, DataBoundControl.cs,
FormView.cs, HierarchicalDataBoundControl.cs, WebControl.cs:
added support for using ControlAdapters when present.
* WebControl.cs: fixed implementation of IsEnabled to match
documentation.
* Menu.cs (RenderMenuBody): call Adapter.RenderItem() instead of
RenderMenuItem() if an adapter is present. MenuAdapter.RenderItem()
calls back to new Menu.RenderItem() internal method which calls
RenderMenuItem() with the appropriate parameters.
++ System.Web.Configuration/ChangeLog (working copy)
* HttpCapabilitiesBase.cs: changed to use nBrowser for *.browser
support. Also added internal GetConfigCapabilities_called
flag used by ControlAdapterTest.ConfigCapabilitiesNotCalled() to
test that GetConfigCapabilities() is not called during normal page
processing when there are no files in App_Browsers/.
svn path=/trunk/mcs/; revision=97824
* ListItem.cs: fixed Load/SaveViewState, added selected state storing
* ListItemCollection.cs: fixed Load/SaveViewState, added flag to not rebuild the collection if wasnt changed
svn path=/trunk/mcs/; revision=91518
* ListControl.cs:
SelectedValue/SelectedIndex is set during DataBinding always.
2007-11-06 Igor Zelmanovich <[email protected]>
* ListControlTest.cs:
Added new tests.
svn path=/trunk/mcs/; revision=88954
* ListControl.cs: partially restored r85314
whenever a property that can affect data binding
is set, make sure to set RequiresDataBinding.
svn path=/trunk/mcs/; revision=85410
* DataBoundControl.cs: make sure no data binding is done after
OnPagePreload has executed.
* ListControl.cs: whenever a property that can affect data binding
is set, make sure to set RequiresDataBinding.
svn path=/trunk/mcs/; revision=85314
* ListItem.cs:
* ListItemCollection.cs: controls based on ListControl should not save view state before than TrackViewState called
svn path=/trunk/mcs/; revision=81396
* WebControl.cs: Revert r80368, as it wasn't the correct
fix. Fixes bug #81945.
* ListControl.cs: if there are no items in the collection, do not
return an empty ArrayList from GetSelectedIndicesInternal. Fixes
bug #81945 and properly fixes bug #78533.
* ListItemCollection.cs: if there are no items in collection,
return null.
svn path=/trunk/mcs/; revision=81170
* Table.cs: render rows, not controls
* HyperLink.cs: RenderContents must check if the render method
delegate is present and, if yes, call the base RenderContents.
* LinkButton.cs: as above.
* Label.cs: as above.
* TableCell.cs: as above.
This change makes the HeaderTemplate in the Wizard control work.
2007-05-10 Marek Habersack <[email protected]>
* Control.cs: small formatting change
svn path=/trunk/mcs/; revision=77164
* ListControl.cs: fixed: when is used with DataSourceID data bind is not
perfomed on PostBack because Items collection is restored from View state.
svn path=/trunk/mcs/; revision=70112
* Rationalize the user of MonoTODOs.
- Removed all the TODOs that were only overwritten methods
and had no further information.
- Methods that threw exceptions now have the message "Not
implemnted".
- Methods that return some constant are declared like
that.
- Removed a bunch of stale MonoTODOs that had not been
removed.
svn path=/trunk/mcs/; revision=68620
VewState saving and restoring rolled back to 1.1 implementation
(fixed corresponding test), corrected public interface (there are no
overriden methods SaveControlState, LoadControlState and OnInit),
implemented CausesValidation and ValidationGroup properties.
svn path=/trunk/mcs/; revision=65579
* UI/UserControl.cs: fixed ParseChildren attribute to be compliant to .net
* WebControls/Content.cs:
* WebControls/Label.cs:
* WebControls/ListControl.cs:
* WebControls/MultiView.cs:
* WebControls/WebControl.cs: fixed ParseChildren attribute to be compliant to .net
* HtmlControls/HtmlTable.cs:
* HtmlControls/HtmlTableRow.cs: fixed ParseChildren attribute to be compliant to .net
svn path=/trunk/mcs/; revision=63490
* ListControl.cs (OnDataBinding): in 2.0, only clear our items if
AppendDataBoundItems != false. Also, split all the databinding
logic out to DoDataBinding, which we call from here only if
!NET_2_0.
(DoDataBinding): new function. actually perform the binding.
(PerformDataBinding): implement.
(PerformSelect): chain up to base class.
svn path=/trunk/mcs/; revision=56683
* ListControl.cs: bound checking for Items when loading the control
state, as the number might have been changed on the fly. Patch by
Elliott Draper.
svn path=/trunk/mcs/; revision=56007
* ListControl.cs: made GetSelectedIndices() internal.
* ListBox.cs: html-encode the item text. Fixed single and multiple
selection handling. All the tests pass now. Closes bug #76478.
svn path=/trunk/mcs/; revision=51998
* ListControl.cs: SelectedIndex/SelectedValue can be set before
DataBinding () is called on the control, so we have to keep this values
around and use them after the data is read. If both properties are
used, they must refer to the same item.
svn path=/trunk/mcs/; revision=50814
2005-09-22 Miguel de Icaza <[email protected]>
* DataBindingCollection.cs: Raise the event, remove MonoTODO.
* MinimizableAttributeTypeConverter.cs: Fix warning, compare to a
string.
svn path=/trunk/mcs/; revision=50544
* ListControl.cs (SelectedIndex): add comment about how you'd
think OnSelectedIndexChanged would be called.. and you'd be wrong.
(Text): implement in terms of SelectedValue.
(TagKey): do the HAVE_CONTROL_ADAPTERS two-step.
(LoadControlState): implement - this is where the selected index
ArrayList gets stuffed in 2.0.
(OnInit): call Page.RegisterRequiresControlState.
(OnTextChanged): implement.
(RenderContents): for now just chain up to base.RenderContents.
(SaveControlState): save our control state properly.
(GetSelectedIndices): split this out from SaveViewState to it can
be used by both that and SaveControlState.
(SaveViewState): mangle this function so it works in both 2.0 and
1.0.
(LoadViewState): same.
svn path=/trunk/mcs/; revision=49612