* [System.ServiceMode] Create unit test for #46917
* [System.ServiceModel.Discovery] Fix messages validation
The current validations are not correct and throws an exception calling
GetVideoSources API in an ONVIF media client. This API
is a combination of a first message with an input parameter and
a second message with the reply that is not void.
Removing this checks makes the client work correctly.
Fixes#46917
NET_2_1 is also defined whenever we define MOBILE, so they have the same effect. Silverlight was 2.1 but it's been dead for a while now, and we do not even support it.
The problem already starts when creating the OperationDescription; we need
to also look at the End* method here to correctly parse the reply parameters.
Then ClientRuntimeChannel.Process needs to distinguish between sync/async
and copy the out/byref parameters when needed.
Fixes: http://bugzilla.xamarin.com/show_bug.cgi?id=1164
The breakage reported in #1164 was caused by commit 106fdeb4, which
fixed bxc206. The problem is that in fixing bxc206, response messages
of a type having a MessageContractAttribute custom attribute were
changed to have a `void` return type, according to the
MessageDescription's Body.ReturnValue.Type property.
This fix is correct, in that it's what .NET does, but it broke XML
deserialization which expected the "actual" return type to exist, not
`void`.
Case in point: the added IService1.EndJSMGetDatabases() method will
have a MessageDescription with a Body.ReturnValue.Type=typeof(void).
The problem is that deserializing this message will fail:
System.Runtime.Serialization.SerializationException: Deserializing
type 'System.Void'. Expecting state 'EndElement'. Encountered state
'Text' with name '' with namespace ''.
Obviously this is not good. ;-)
The fix is simple: don't use the MessageDescription's ReturnValue if
it's `typeof(void)`.
There are two added wrinkles:
1. Writing a test case for the above.
2. The test case broke with another error: a NRE within
BaseMessagesFormatter.MessageObjectToParts(). This is because
when ContractDescriptionGenerator.GetMessage() sets the
ReturnValue for a response message, it doesn't set
MessagePartDescription.MemberInfo.
BaseMessagesFormatter.MessageObjectToParts(), meanwhile, was
checking the ReturnValue's MemberInfo...which was null.
Add a null check here so that the actual bug can be tested.
XmlMessagesFormatter will be used in Sys.Xml.Serialization.dll and this
type should not be excluded by !NET_2_1 or !MOONLIGHT. It is not doable
if this class is in BaseMessagesFormatter.cs.
* OperationDescription.cs : add contract origin flags to identify
which operation should be used for client operations (and dispatch
too in the future).
* MessageDescription.cs : add IsRequest flag to indicate if it is
for request or not.
* ServiceContractGenerator.cs, ContractDescriptionGenerator.cs :
make use of above changes.
* ContractDescription.cs : don't create extraneous ClientOperations
in irrelevant message direction.
* EndpointDispatcher.cs, BaseMessagesFormatter.cs:
Now MessageDescription.Direction is differentiated from "IsRequest"
property, to precisely identify request/reply in callbacks. Also
now we don't have to create extraneous ContractDescription for
callbacks.
* DuplexClientRuntimeChannel.cs : do not create and use extraneous
ContractDescription for callback contract. Non-callback ones now
works fine.
This fixes service part of bug #567672, IsOneWay = true case.
svn path=/trunk/mcs/; revision=158454
* BaseMessagesFormatter.cs : hasParameter check is incorrectly
restrictive to reject some kinds of pairs.
* CustomPeerResolverServiceTest.cs : enabled all disabled tests.
svn path=/trunk/mcs/; revision=154781
* BaseMessagesFormatter.cs : add internal OperationFormatter type
for moonlight/silverlight-sdk compatibility. It mostly wraps
the existing the return value by BaseMessagesFormatter.Create().
* DispatchOperation.cs, ClientOperation.cs, EndpointDispatcher.cs:
use above new type.
svn path=/trunk/mcs/; revision=153493