Commit Graph
7 Commits
Author SHA1 Message Date
Alexander Köplinger 5f5676ae50 [System.ServiceModel] Switch tests to use embedded test resources 2018-09-27 22:47:07 +02:00
Alexander Köplinger 69b3397c8e [System.ServiceModel] Recognize 'faultactor' in SOAP fault message
It's an optional element according to [1] and we were simply
throwing a NotImplementedException when encountering it.

Fixed by reading the element value instead. I noticed that we
had a 'details' variable that was never assigned, so the check
for `details == null` was always true and can be removed.
This makes inlining the body of the CreateFault() call easier
since we no longer need to choose different overloads and makes
the code consistent with the CreateFault12 method.
Also added a better exception in case of an unrecognized element.

The CreateFault12 method (handles SOAP 1.2) does not need a similar
fix since actor is not an element in that version [2].

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=42226

[1] https://www.w3.org/TR/soap11/#_Toc478383507
[2] https://www.w3.org/TR/soap12/#soapfault
2016-11-04 16:18:46 +01:00
Atsushi Eno 789dc0be76 2010-03-29 Atsushi Enomoto <[email protected]>
* MessageFault.cs : cosmetic method name clarification.

	* MessageFaultTest.cs : enable previous test.

	(made wrong commit in the previous test changelog)


svn path=/trunk/mcs/; revision=154356
2010-03-29 08:41:07 +00:00
Atsushi Eno c1fba935ca 2010-03-26 Atsushi Enomoto <[email protected]>
* FaultConverterTest.cs, MessageFaultTest.cs : add new and not-working
	  tests.


svn path=/trunk/mcs/; revision=154286
2010-03-26 16:06:02 +00:00
Atsushi Eno efe6f6d540 2009-12-21 Atsushi Enomoto <[email protected]>
* MessageFault.cs : support EnvelopeVersion.None as well, as almost
	  the same as SOAP12.

	* MessageFaultTest.cs : add CreateFault test with MessageVersion.None.


svn path=/trunk/mcs/; revision=148797
2009-12-21 06:10:47 +00:00
Atsushi Eno 31009113d4 2009-05-19 Atsushi Enomoto <[email protected]>
* MessageFault.cs : fix several SOAP12 fault deserialization in xml
	  parsing.

	* MessageFaultTest.cs : added more SOAP 12 fault parser tests.
	* soap-fault.xml, soap-fault-incomplete4.xml : new test files.


svn path=/trunk/mcs/; revision=134389
2009-05-19 12:01:20 +00:00
Atsushi Eno a22727c329 2009-05-15 Atsushi Enomoto <[email protected]>
* MessageFault.cs : Reason is mandatory. raise XmlException, and
	  CommunicationException in each CreateFault().

	* soap-fault-incomplete.xml : new test file.
	* MessageFaultTest.cs : new test.

	* System.ServiceModel.dll_test.sources: added MessageFaultTest.cs.


svn path=/trunk/mcs/; revision=134197
2009-05-15 11:27:39 +00:00