When a control is a naming container and an attempt to find a control with non-segmented id (e.g. 'myControl') is made,
the search continues to the control's naming container if pathOffset is 0, that is we're at the start of the search.
Control.AddedControl will call the new control's LoadRecursive which would trigger its OnLoad
handler. OnLoad must be called only if control hasn't already been loaded.
This commit implements the ability to programmatically set the name of the output cache provider
to hold cached control data.
* OutputCache.cs: added DefaultProvider internal property to return whatever default provider is
configured.
Added GetProvider() method to return instance of a named provider
* BasePartialCachingControl.cs: cache key and cached data are store in instance fields.
Added 4.0 internal property ProviderName which names the output cache provider to use for storage.
Removed OnInit from 4.0 profile, replaced with an override of Control's InitRecursive. Control is
created only when cached data is not found in the provider.
* Control.cs: made InitRecursive virtual for the benefit of BasePartialCachingControl above.
* ControlCachePolicy.cs: added 4.0 property ProviderName
* Wizard.cs: made rendering 100% compliant with .NET (button IDs,
2.0+)
Implemented LayoutTemplate (4.0+)
* LinkButton.cs: render id first
* CreateUserWizard.cs: CreateUserNavigationContainer.UpdateState
doesn't add a previous button if we're on the first step.
svn path=/trunk/mcs/; revision=160657
* Control.cs: moved 4.0 ClientID code to a separate method, so
that the ID_SET flag isn't set when necessary.
2010-07-13 Marek Habersack <[email protected]>
* Wizard.cs: wizard table doesn't contain any instances of
HtmlAnchor or Image controls. Moved rendering of the skip link
anchor to the TableCellNamingContainer class, which does that in
RenderChildren by directly writing to the passed writer. Fixes 4.0
rendering and all the failing Wizard tests.
svn path=/trunk/mcs/; revision=160304
* Control.cs: if generating a predictable ID and the current
control is a naming container, ensure that an ID is generated if
not specified by user.
svn path=/trunk/mcs/; revision=160050
fail to work on .NET 4.0 as well, for the most part. I will fix them next week.
2010-07-02 Marek Habersack <[email protected]>
* TemplateControlParser.cs: added support for ClientIDMode
property
* Control.cs: implemented 4.0 features - ClientIDMode and
RenderingCompatibility.
* ClientIDMode.cs, IDataKeysControl.cs: added
2010-07-02 Marek Habersack <[email protected]>
* Menu.cs: 4.0 API updates.
* GridView.cs: implemented 4.0 properties -
SortedAscendingCellStyle, SortedAscendingHeaderStyle,
SortedDescendingCellStyle, SortedDescendingHeaderStyle,
ClientIDRowSuffix, ClientIDRowSuffixDataKeys, ShowHeaderWhenEmpty
along with associated rendering changes.
* DetailsView.cs, FormView.cs, GridView.cs: 4.0 API changes -
renamed ShowPage to SetPageIndex and made it public.
Added 4.0 interfaces to inheritance list and implemented them.
* DataKeyArray.cs: added internal constructor which accepts IList
instead of ArrayList. Changed the 'keys' field type to IList.
* ContainedTable.cs: the 'id' attribute must be rendered last.
* CheckBox.cs, CheckBoxList.cs, SiteMapPath.cs, Table.cs,
TableStyle.cs, TextBox.cs, WebControl.cs: 4.0 rendering changes.
* Calendar.cs, CompositeControl.cs, DropDownList.cs, HyperLink.cs,
Image.cs, ImageButton.cs, Label.cs, LinkButton.cs, LoginName.cs,
Panel.cs, Table.cs, TableCell.cs, TableRow.cs:
added new 4.0 property, SupportsDisabledAttribute.
2010-07-02 Marek Habersack <[email protected]>
* VersionConverter.cs: added support for checking whether the
passed version is equal or more than a specified minimal version.
* PagesSection.cs: added two 4.0 properties - ClientIDMode and
ControlRenderingCompatibilityVersion
2010-07-02 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: added support for ClientIDMode 4.0
property
* PageCompiler.cs, UserControlCompiler.cs: AddStatementsToInitTop
must call the base implementation.
svn path=/trunk/mcs/; revision=159826
* AssemblyInfo.cs: this assembly should be signed with winfx.pub
2010-05-15 Marek Habersack <[email protected]>
* HttpResponse.cs: added internal Context property
* HttpRequest.cs: added a setter to the internal Context property
* HttpContext.cs: set request and response Context properties to
'this' in the constructor.
2010-05-15 Marek Habersack <[email protected]>
* Control.cs: implemented 4.0 GetRouteUrl overloads and
GetUniqueIDRelativeTo
2010-05-15 Marek Habersack <[email protected]>
* RouteValueExpressionBuilder.cs: added
* RouteUrlExpressionBuilder.cs: implemented
svn path=/trunk/mcs/; revision=157378
* Control.cs: control cache must be filled using the local
_controls collection instead of the virtual Controls
property. Fixes bug #594238
Check if _controls isn't null before using it.
2010-04-07 Marek Habersack <[email protected]>
* ControlTest.cs: added test for bug #594238
2010-04-07 Marek Habersack <[email protected]>
* Makefile: moved App_* test resources to separate variables -
whatever is contained in those variables is preprocessed before
embedding as resource to include appropriate resource name prefix
(App_Code/, App_GlobalResources/ for now). This is used in WebTest
to automatically populate the relevant directories when running
the test suite.
2010-04-07 Marek Habersack <[email protected]>
* WebTest.cs: introduced concept of prefixed resources and added
an API which handles them - CopyPrefixedResources. All the
manifest resource names are checked for match with the given
prefix, and all the matching ones are copied to the specified
subdirectory of the test directory.
svn path=/trunk/mcs/; revision=154948
* HttpRequest.cs: added internal property ClientFilePath, which
may have a different value than FilePath when virtual path has
been rewritten, but the caller specified that the client paths
should still be constructed using the original url.
* HttpContext.cs: RewritePath always sets Request.FilePath,
Request.ClientFilePath is set only when setClientFilePath is
true. This makes client urls work correctly when url rewriting is
being used.
2009-10-30 Marek Habersack <[email protected]>
* Control.cs: ResolveClientUrl takes base path from
Request.ClientFilePath, so that it works correctly for rewritten
urls.
2009-10-30 Marek Habersack <[email protected]>
* HtmlForm.cs: action is built using Request.ClientFilePath
(instead of Request.FilePath) and ResolveClientUrl, so that it's
correct even if url rewriting is being used.
svn path=/trunk/mcs/; revision=145069
2009-10-09 Marek Habersack <[email protected]>
* Control.cs: implemented the LoadViewStateByID property as well
as saving/restoring the view state by control's ID.
svn path=/trunk/mcs/; revision=143855
* ControlBuilder.cs: Location property makes a copy of assigned
ILocation now.
2009-08-20 Marek Habersack <[email protected]>
* ControlAdapter.cs: check if Control isn't null before using it.
CreateChildControls () must forward call to the control. Fixes bug
#517172
2009-08-20 Marek Habersack <[email protected]>
* ControlAdapterTest.cs: added test for bug #517172
svn path=/trunk/mcs/; revision=140299
* Control.cs: AppRelativeResourceDirectory no longer returns a
hard-coded "~/" when template control's virtual path cannot be
determined. It returns application relative version of
TemplateSourceDirectory instead.
svn path=/trunk/mcs/; revision=129676
* Control.cs: clear the controls cache on control removal. This
ensures that a subsequent FindControl call won't return the
removed control.
svn path=/trunk/mcs/; revision=129234
* Control.cs: partially restore the ViewStateShouldBeSaved method
in order to introduce a small optimization - when the control's
EnableViewState is false, there is no point in checking all the
child controls.
svn path=/trunk/mcs/; revision=126037
and use it to determine if viewstate needs to be saved instead of
the newly introduced ViewStateShouldBeSaved. Remove
ViewStateShouldBeSaved.
svn path=/trunk/mcs/; revision=126025
* Control.cs: if a control has been added to the controls
collection, removed and added again do not call OnInit (). At the
same time OnInit() should be called more than once if a control is
added to a container which, in turn, is then added to another
control. To achieve that a new state mask flag has been added -
REMOVED. Fixes bug #471305
svn path=/trunk/mcs/; revision=125798
* Control.cs: update of the fix for bug #470993 - view state of
the child controls isn't saved when any of their parents has it
disabled.
svn path=/trunk/mcs/; revision=125663
* ContentPlaceHolder.cs, Content.cs, FormViewPagerRow.cs,
ChangePassword.cs, DetailsViewPagerRow.cs: implements
INonBindingContainer interface.
* Wizard.cs: implement INonBindingContainer interface for several
private/internal classes.
2008-11-15 Marek Habersack <[email protected]>
* INonBindingContainer.cs: added
* Control.cs: BindingContainer now checks if a control implements
INonBindingContainer interface in addition to the
BINDING_CONTAINER mask check.
* UserControl.cs: implements INonBindingContainer
* ControlBuilder.cs: use the new INonBindingContainer interface to
determine the binding container type in the BindingContainerType
property. If TemplateBuilder's ContainerType implements that
interface, the NamingContainer is queried for the binding
container type. If ContainerType is null, we return our own
ControlType (if we're TemplateBuilder)
2008-11-15 Marek Habersack <[email protected]>
* System.Web.dll.sources: added System.Web.UI/INonBindingContainer.cs
svn path=/trunk/mcs/; revision=118917
* ImageMap.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in Render ().
* DropDownList.cs, ListBox.cs: validate the event in LoadPostData ().
* TextBox.cs: validate the event in LoadPostData ().
Register for event validation in AddAttributesToRender ().
* HiddenField.cs: validate the event in RaisePostDataChangedEvent.
Register for event validation in Render ().
* RadioButton.cs: validate the event in LoadPostData ().
Register for event validation in InternalAddAttributesToRender.
* CheckBox.cs, RadioButtonList.cs: validate the event in
RaisePostDataChangedEvent.
* Menu.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in GetClientEvent ().
* DetailsView.cs, GridView.cs: validate the event in
RaisePostBackEvent ().
Register for validation in GetCallbackScript () and in OnPreRender
* Button.cs, Table.cs, BulletedList.cs, Calendar.cs, LinkButton.cs,
ImageButton.cs, TreeView.cs: validate the event in RaisePostBackEvent ().
2008-10-17 Marek Habersack <[email protected]>
* Control.cs: added the ValidateEvent internal method, used by
classes descending from Control to automatically trigger event
validation.
* Page.cs: removed the CheckForValidationSupport method. It moved
to Control.cs
RaisePostBackEvent no longer validates the events, this
functionality has been moved to Control.ValidateEvent.
2008-10-17 Marek Habersack <[email protected]>
* HtmlInputHidden.cs: validate the event in LoadPostDataInternal.
* HtmlInputButton.cs: validate the event in
RaisePostBackEventInternal ().
Register for event validation in RenderAttributes ()
* HtmlTextArea.cs: validate the event in
RaisePostBackDataChangedEvent ().
* HtmlButton.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ()
* HtmlAnchor.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ().
* HtmlInputRadioButton.cs, HtmlSelect.cs: validate the event in
LoadPostData.
* HtmlInputText.cs, HtmlInputImage.cs, HtmlInputCheckBox.cs,
HtmlInputPassword.cs: validate the event in
RaisePostDataChangedEvent ().
2008-10-17 Marek Habersack <[email protected]>
* MenuAdapterTest.cs: work around event validation failure in the
test environment.
2008-10-17 Marek Habersack <[email protected]>
* PageTest.cs: use a custom version of HtmlInputHidden control to
work around the new event validation code which doesn't work in
this instance.
svn path=/trunk/mcs/; revision=116231
* Control.cs: SaveViewStateRecursive must return view state even
if EnableViewState is false. This is apparently what .NET does, as
some commercial ASP.NET controls take advantage of that via
reflection.
2008-10-14 Marek Habersack <[email protected]>
* CompositeDataBoundControl.cs: renamed the itemcount ViewState
item from "_ItemCount" to "_!ItemCount" for .NET
compatibility. This item is accessed and used by some commercial
ASP.NET controls.
* DataBoundControl.cs: OnPagePreLoad must force databinding also
when the request is not a postback.
svn path=/trunk/mcs/; revision=115766
* TemplateControlCompiler.cs:
Templates are processed before anything else, so that children
which may depend on parent's templates can get access to them.
2008-08-31 Marek Habersack <[email protected]>
* Control.cs: improved FillControlCache
* ControlBuilder.cs:
Added a cache for children of TemplateBuilder, used later in
TemplateControlCompiler.
svn path=/trunk/mcs/; revision=111990
* Control.cs: if adapter exists for the given control, use it for
rendering. Patch from Christian Hergert
<[email protected]>, thanks!
svn path=/trunk/mcs/; revision=107708
* Page.cs: Context is protected internal in .NET 3.5
* Control.cs: in 2.0 we should return the context associated with
the current page. In 1.0 we ignore the never set field _context
and keep walking up the parent chain. Also, Context is protected
internal in .NET 3.5
svn path=/trunk/mcs/; revision=106876
* Control.cs: refactoring - IdSeparator property is internally
present also in 1.1.
2008-04-10 Marek Habersack <[email protected]>
* RadioButton.cs: adjust 'name' and 'value' attribute values to
match MS.NET. Fixes bug #378024
svn path=/trunk/mcs/; revision=100302
* add new resources:
PageWithAdapter.aspx for PageTest and PageAdapterTest.
TestCapability.browser for AppBrowsersTest.
* NunitWebResources/adapters.browser,
NunitWebResources/AppBrowsersTest.browser: modified to support
testing reference nodes with captures, and adapters.
* NunitWeb/NunitWeb/WebTest.cs: ensure that, during AppDomain
unload, no new requests are sent to the app host and any
pending requests are completed before the the unload occurs.
Also added WebTest.AppUnloaded event that tests can use to wait
for the app to unload (e.g. after touching Global.asax), and
WebTest.CleanApp() which can be called to restart the app with
the a skeleton directory structure. Tests which add files that
could effect other tests (e.g. App_Browsers/*.browser files) should
call WebTest.CleanApp() during TearDown to return the app to a
pristine environment.
++ Test/mainsoft/MainsoftWebTest/ChangeLog (working copy)
* HtmlAgilityPack/AssemblyInfo.cs: made assembly delay signed so that
tests can access System.Web internals now that System.Web is
InternalsVisibleTo this assembly.
++ Test/System.Web/ChangeLog (working copy)
* AppBrowsersTest.cs: added. Includes tests for Control.Adapter,
Control.ResolveAdapter, Control.TagWriter, and
Control.CreateHtmlTextWriter, when using App_Browsers/*.browser files.
AppBrowsersTest is currently tagged [Ignore], pending a fix for
bug #351878.
* HttpRuntimeTest.cs: added. Includes test for
HttpRuntime.UnloadAppDomain(). Marked [Ignore], pending a fix for
bug #351878.
++ Test/System.Web.UI.Adapters/ChangeLog (revision 0)
* PageAdapterTest.cs: added tests for PageAdapter.
* ControlAdapterTest.cs (ConfigCapabilitiesNotCalled): added test to
ensure that HttpCapabilitiesBase.ConfigCapabilities() is not called
during normal page processing if no files are in App_Browsers.
* ControlAdapterTest.cs: added tests for ControlAdapter.
++ Test/System.Web.UI/ChangeLog (working copy)
* PageTest.cs: add tests for using a PageAdapter.
* ControlTest.cs: moved commented out ResolveAdapter_1 test to
../System.Web/AppBrowsersTest.cs. Fixed typo in test name.
Added Customcontroladapter.Adapter property for use by AppBrowsersTest.
++ Test/System.Web.UI.WebControls.Adapters/ChangeLog (revision 0)
* MenuAdapterTest.cs: added
* WebControlAdapterTest.cs, HierarchicalDataBoundControlAdapterTest.cs,
DataBoundControlAdapterTest.cs, HideDisabledControlAdapterTest.cs: added
++ Test/System.Web.UI.WebControls/ChangeLog (working copy)
* MenuTest.cs (Menu_RenderStaticItems): added tests to check that
result was the same when using the base MenuAdapter as when using
no adapter.
* MenuTest.cs (Menu_RenderStaticItemsWithAdapter): added test
to ensure that MenuAdapter.RenderItem() is called.
* HierarchicalDataBoundControlTest.cs, WebControlTest.cs,
DataBoundControlTest.cs: added test for use of ControlAdapters
when present.
* WebControl.cs: added test for IsEnabled.
++ System.Web/ChangeLog (working copy)
* HttpApplicationFactory.cs: Added support for detecting
App_Browsers/*.browser files and using them to determine capabilities.
Also restart the app if the App_Browsers, App_Code, or App_GlobalResources
directories are created.
* BrowserCapabilities.cs (TagWriter): get value via internal virtual
GetTagWriter() method, which is overridden in nBrowser.Result.
* HttpRequest.cs (BrowserMightHaveSpecialWriter, BrowserMightHaveAdapters):
internal properties added to allow Page and Control methods to avoid
accessing Request.Browser to get browser-specific HtmlTextWriters or
ControlAdapters. Those things only exist when there are App_Browsers
files.
++ System.Web.UI.Adapters/ChangeLog (working copy)
* ControlAdapter.cs: made control field internal so
derived internal classes can access it without using base.Control
which can involved several typecasts.
* PageAdapter.cs: implemented all members.
* ControlAdapter.cs: implemented all members.
* PageAdapter.cs, ControlAdapter.cs: add MonoTODO's.
++ System.Web.UI/ChangeLog (working copy)
* Page.cs (SavePageControlState, LoadPageControlState): save/load
adapter state in 2.0 profile.
* Page.cs (CreateHtmlTextWriter): call Browser.CreateHtmlTextWriter()
in 2.0 profile.
* Page.cs (RenderPage): call CreateHtmlTextWriter() to get the writer
in 2.0 profile.
* Page.cs (DeterminePostBackMode, InitOutputCache,
RenderClientScriptFormDeclaration, InternalProcessRequest,
PageStatePersister): added support for PageAdapters.
* Control.cs (Adapter, ResolveAdapter): implemented. Adapter calls
ResolveAdapter and remembers result. ResolveAdapter checks for adapters
of the Type hierarchy until it finds one.
* Control.cs (SaveViewStateRecursive, LoadViewStateRecursive): save/load
adapter state in 2.0 profile.
* HtmlTextWriter.cs (BeginRender, EndRender): added empty virtual methods
required by 2.0 profile. These are called by corresponding methods of
System.Web.UI.Adapters.ControlAdapter.
* Page.cs, Control.cs: don't access Request.Browser if it couldn't have
any adapters/writers because there are no files in App_Browsers/.
++ Assembly/ChangeLog (working copy)
* AssemblyInfo.cs: made InternalsVisibleTo System.Web.test_net_2_0.dll
to support ControlAdapterTest.ConfigCapabilitiesNotCalled().
++ ChangeLog (working copy)
* System.Web_test.dll.sources: added
System.Web.UI.WebControls.Adapters/MenuAdapterTest.cs
System.Web.UI.WebControls.Adapters/WebControlAdapterTest.cs
System.Web.UI.WebControls.Adapters/HierarchicalDataBoundControlAdapterTest.cs
System.Web.UI.WebControls.Adapters/DataBoundControlAdapterTest.cs
System.Web.UI.WebControls.Adapters/HideDisabledControlAdapterTest.cs
System.Web.UI.Adapters/PageAdapterTest.cs
System.Web.UI.Adapters/ControlAdapterTest.cs
* Makefile (RESOURCE_FILES_2): added
System.Web.Configuration_2.0/RandomRoboBotKeywords.txt
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/PageWithAdapter.aspx
* System.Web.dll.sources: added
System.Web.Configuration_2.0/CapabilitiesBuild.cs
System.Web.Configuration_2.0/CapabilitiesChecksum.cs
System.Web.Configuration_2.0/CapabilitiesResult.cs
System.Web.Configuration_2.0/ICapabilitiesProcess.cs
System.Web.Configuration_2.0/nBrowser/Result.cs
System.Web.Configuration_2.0/nBrowser/NodeTypes.cs
System.Web.Configuration_2.0/nBrowser/Identification.cs
System.Web.Configuration_2.0/nBrowser/File.cs
System.Web.Configuration_2.0/nBrowser/Build.cs
System.Web.Configuration_2.0/nBrowser/Node.cs
System.Web.Configuration_2.0/nBrowser/Exception.cs
++ System.Web.UI.WebControls.Adapters/ChangeLog (working copy)
* WebControlAdapter.cs, HierarchicalDataBoundControlAdapter.cs,
DataBoundControlAdapter.cs: changed to use ControlAdapter.control
instead of using base.Control or using a new control field.
* MenuAdapter.cs: added internal constructor that takes a Menu
parameter. The constructor is used when writing unit tests.
* MenuAdapter.cs (OnInit, OnPreRender, RenderBeginTag,
RenderContents, RenderEndTag): delegate to base instead of
Control.
* MenuAdapter.cs (LoadAdapterControlState, SaveAdapterControlState,
RaisePostBackEvent, RenderItem): implemented.
* WebControlAdapter.cs (RenderContents): changed to call
control.RenderContents() instead of control.Render().
* WebControlAdapter.cs, HierarchicalDataBoundControlAdapter.cs,
DataBoundControlAdapter.cs, HideDisabledControlAdapter.cs: added
internal constructor that takes a parameter of the corresponding
Control type. The construct is used when writing unit tests.
++ System.Web.Configuration_2.0/ChangeLog (working copy)
* nBrowser/Result.cs, nBrowser/NodeTypes.cs, nBrowser/Identification.cs,
nBrowser/File.cs, nBrowser/Build.cs, nBrowser/Node.cs,
nBrowser/Exception.cs: added. The code under nBrowser handles *.browser
files. It is based on Owen "Ocean" Brady's code, with the following
changes and improvements. Replaced Result.Adapter
property with AdapterTypeMap property which maps control Type to adapter
Type. Added Result.MarkupTextWriter property. Added overrides for
Result.GetAdapters and Result.GetTagWriter to return MarkupTextWriter
and AdapterTypeMap, resp. Changed tree building algorithm to not
depend on nodes with id="Default" and to inject defaultBrowser nodes
as parents of regular nodes with the same ids. Changed Node.cs to use
Item instead of Add when adding a capability or sample header, so that
values get replaced instead of appended. Added support for reference
nodes (ie. nodes with refID="someID").
* CapabilitiesResult.cs: load RandomRoboBotKeywords.txt resource
using the correct name.
* RandomRoboBotKeywords.txt: added
* HttpCapabilitiesBase.cs (CreateHtmlWriter, Adapters): Added
support for *.browsers. Adapters property calls internal virtual
GetAdapters() method which is overrided in nBrowser.Result
returned by nBrowser code. CreateHtmlWriter uses type specified
by TagWriter property.
++ System.Web.UI.WebControls/ChangeLog (working copy)
* DetailsView.cs, ListControl.cs, DataBoundControl.cs,
FormView.cs, HierarchicalDataBoundControl.cs, WebControl.cs:
added support for using ControlAdapters when present.
* WebControl.cs: fixed implementation of IsEnabled to match
documentation.
* Menu.cs (RenderMenuBody): call Adapter.RenderItem() instead of
RenderMenuItem() if an adapter is present. MenuAdapter.RenderItem()
calls back to new Menu.RenderItem() internal method which calls
RenderMenuItem() with the appropriate parameters.
++ System.Web.Configuration/ChangeLog (working copy)
* HttpCapabilitiesBase.cs: changed to use nBrowser for *.browser
support. Also added internal GetConfigCapabilities_called
flag used by ControlAdapterTest.ConfigCapabilitiesNotCalled() to
test that GetConfigCapabilities() is not called during normal page
processing when there are no files in App_Browsers/.
svn path=/trunk/mcs/; revision=97824
* TraceContext.cs:
* TraceData.cs:
make trace considers control state info.
2007-12-26 Igor Zelmanovich <[email protected]>
* Control.cs:
* Page.cs:
make Trace considers control state info.
svn path=/trunk/mcs/; revision=91898