* TreeView.js: removed nodeText parameter from the JS calls.
* TreeView.cs: encode | characters into U+007C, so that
RaiseCallbackEvent doesn't get confused.
Removed nodeText parameter from the JS calls.
svn path=/trunk/mcs/; revision=131196
* TreeNode.cs: reset the path data for all child nodes too.
* TreeView.cs: HtmlAttribute encode the node text. When rebuilding the
node tree, set the correct index for the nodes so that the Path is
correct.
svn path=/trunk/mcs/; revision=131186
* HttpRuntime.cs: added a new internal static property
IsDebuggingEnabled
* HttpContext.cs: IsDebuggingEnabled now calls
HttpRuntime.IsDebuggingEnabled
2009-04-06 Marek Habersack <[email protected]>
* Page.cs: ProcessRaiseCallbackEvent and ProcessGetCallbackResult
now return full exception trace if one is caught and we're running
in debugging mode.
2009-04-06 Marek Habersack <[email protected]>
* TreeView.js: TreeView_ToggleExpand now takes more parameters - a
full definition of treeview's node contents.
Added new function, TreeView_PopulateNode, which partially takes
over role of the PopulateNode function generated in
TreeView.OnPreRender (see below). Fixes bug #492307
* TreeView.cs: RaiseCallbackEvent needs to recreate the event
target's parental tree all the way from the root to the node and
populate only the leaf (requested) node. This avoids calling the
TreeNodePopulate handler more times than needed. Fixes bug #492307
OnPreRender: moved the script code to constants and the script
body is now generated using StringBuilder instead of a series of
String.Format calls.
GetClientExpandEvent: adjusted code for new TreeView JavaScript
API.
svn path=/trunk/mcs/; revision=131137
* Unit.cs: introduced a field to tell the difference between empty
(as in Unit.Empty) and 0px units.
2009-03-17 Marek Habersack <[email protected]>
* UnitTest.cs: added a test for equality with Unit.Empty
svn path=/trunk/mcs/; revision=129620
* ImageButton.cs: AddAttributesToRender renders the onclick
attribute only if any of the following is true:
- OnClientClick is not empty
- Validation is enabled for the control
- PostBackUrl is used
PostBackOptions now indicate that control requires the javascript
protocol for the handler.
RaisePostBackEvent passes String.Empty as the argument.
Fixes bug #463939
2009-02-10 Marek Habersack <[email protected]>
* ImageButtonTest.cs: added test for bug #46393
svn path=/trunk/mcs/; revision=126482
* ObjectDataSourceViewTest.cs: added test for bug #471767
2009-02-09 Marek Habersack <[email protected]>
* ObjectDataSourceView.cs: ExecuteSelect returns a single-item
array of objects containing the result, if the result isn't one of
DataSet, DataTable or IEnumerable. Fixes bug #471767
svn path=/trunk/mcs/; revision=126371
* Style.cs: if CssClass is null, return String.Empty. Fixes bug
#473303
Added a range check to the BorderStyle property.
2009-02-06 Marek Habersack <[email protected]>
* StyleTest.cs: added tests for CssClass and BorderStyle.
Renamed the Style_CssClass method to Style_RegisteredCssClass.
svn path=/trunk/mcs/; revision=126051
* CodeBuilder.cs, RootBuilder.cs, CollectionBuilder.cs: updates
related to ControlBuilder cleanup.
* ControlBuilder.cs: code cleanup - no field should be visible
outside the class unless it's a constant or a read-only field.
2009-01-13 Marek Habersack <[email protected]>
* XmlBuilder.cs: updates related to ControlBuilder cleanup.
2009-01-13 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs, AspGenerator.cs, BaseCompiler.cs,
GlobalAsaxCompiler.cs, PageThemeCompiler.cs: updates related to
ControlBuilder cleanup.
svn path=/trunk/mcs/; revision=123229
* Style.cs: WriteStyleAttributes must not use the fontinfo field
directly, it has to be done via the Font property. Fixes bug
#449793
svn path=/trunk/mcs/; revision=120345
* ContentPlaceHolder.cs, Content.cs, FormViewPagerRow.cs,
ChangePassword.cs, DetailsViewPagerRow.cs: implements
INonBindingContainer interface.
* Wizard.cs: implement INonBindingContainer interface for several
private/internal classes.
2008-11-15 Marek Habersack <[email protected]>
* INonBindingContainer.cs: added
* Control.cs: BindingContainer now checks if a control implements
INonBindingContainer interface in addition to the
BINDING_CONTAINER mask check.
* UserControl.cs: implements INonBindingContainer
* ControlBuilder.cs: use the new INonBindingContainer interface to
determine the binding container type in the BindingContainerType
property. If TemplateBuilder's ContainerType implements that
interface, the NamingContainer is queried for the binding
container type. If ContainerType is null, we return our own
ControlType (if we're TemplateBuilder)
2008-11-15 Marek Habersack <[email protected]>
* System.Web.dll.sources: added System.Web.UI/INonBindingContainer.cs
svn path=/trunk/mcs/; revision=118917
* ImageMap.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in Render ().
* DropDownList.cs, ListBox.cs: validate the event in LoadPostData ().
* TextBox.cs: validate the event in LoadPostData ().
Register for event validation in AddAttributesToRender ().
* HiddenField.cs: validate the event in RaisePostDataChangedEvent.
Register for event validation in Render ().
* RadioButton.cs: validate the event in LoadPostData ().
Register for event validation in InternalAddAttributesToRender.
* CheckBox.cs, RadioButtonList.cs: validate the event in
RaisePostDataChangedEvent.
* Menu.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in GetClientEvent ().
* DetailsView.cs, GridView.cs: validate the event in
RaisePostBackEvent ().
Register for validation in GetCallbackScript () and in OnPreRender
* Button.cs, Table.cs, BulletedList.cs, Calendar.cs, LinkButton.cs,
ImageButton.cs, TreeView.cs: validate the event in RaisePostBackEvent ().
2008-10-17 Marek Habersack <[email protected]>
* Control.cs: added the ValidateEvent internal method, used by
classes descending from Control to automatically trigger event
validation.
* Page.cs: removed the CheckForValidationSupport method. It moved
to Control.cs
RaisePostBackEvent no longer validates the events, this
functionality has been moved to Control.ValidateEvent.
2008-10-17 Marek Habersack <[email protected]>
* HtmlInputHidden.cs: validate the event in LoadPostDataInternal.
* HtmlInputButton.cs: validate the event in
RaisePostBackEventInternal ().
Register for event validation in RenderAttributes ()
* HtmlTextArea.cs: validate the event in
RaisePostBackDataChangedEvent ().
* HtmlButton.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ()
* HtmlAnchor.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ().
* HtmlInputRadioButton.cs, HtmlSelect.cs: validate the event in
LoadPostData.
* HtmlInputText.cs, HtmlInputImage.cs, HtmlInputCheckBox.cs,
HtmlInputPassword.cs: validate the event in
RaisePostDataChangedEvent ().
2008-10-17 Marek Habersack <[email protected]>
* MenuAdapterTest.cs: work around event validation failure in the
test environment.
2008-10-17 Marek Habersack <[email protected]>
* PageTest.cs: use a custom version of HtmlInputHidden control to
work around the new event validation code which doesn't work in
this instance.
svn path=/trunk/mcs/; revision=116231
* Control.cs: SaveViewStateRecursive must return view state even
if EnableViewState is false. This is apparently what .NET does, as
some commercial ASP.NET controls take advantage of that via
reflection.
2008-10-14 Marek Habersack <[email protected]>
* CompositeDataBoundControl.cs: renamed the itemcount ViewState
item from "_ItemCount" to "_!ItemCount" for .NET
compatibility. This item is accessed and used by some commercial
ASP.NET controls.
* DataBoundControl.cs: OnPagePreLoad must force databinding also
when the request is not a postback.
svn path=/trunk/mcs/; revision=115766
* ControlParameter.cs: Evaluate calls DataBinder.Eval to do the
evaluation now. This makes it support complex expressions.
2008-10-08 Marek Habersack <[email protected]>
* DataBinder.cs: in Eval expression needs to be trimmed before
checking whether it's an empty string.
GetIndexedPropertyValue must explicitly look for the "Item"
property, the lack of the DefaultMember attribute on type must not
throw exceptions.
2008-10-08 Marek Habersack <[email protected]>
* ControlParameterTest.cs: added a test for ControlParameter
evaluating a complex property expression.
svn path=/trunk/mcs/; revision=115193
* XmlDataSource.cs: Make sure the result of the multiplication is a
long (not an integer casted into a long since it could overflow).
[Found using Gendarme's ReviewCastOnIntegerMultiplicationRule]
svn path=/trunk/mcs/; revision=114339
* System.Web.dll.sources: added System.Web.UI/IAutoFieldGenerator.cs
and System.Web.UI.WebControls/IPersistedSelector.cs.
* IPersistedSelector.cs : new in 3.5 SP1.
* IAutoFieldGenerator.cs : new in 3.5 SP1.
svn path=/trunk/mcs/; revision=112940
* DataBoundControl.cs: set RequiresDataBinding to true in
Initialize only if not in a postback, if not data bound and if the
view state is enabled. Fixes bug #398318
UpdateViewData removes the OnDataSourceViewChanged handler before
connecting to the datasource and restores it before returning to
the caller.
OnLoad gets the data source before initialization, to avoid
premature OnDataSourceViewChanged triggers. Fixes bug #398318
svn path=/trunk/mcs/; revision=111526
* TreeView.cs: when TreeView is displaying a site map and there is
no node selected by the user, select the node corresponding to the
current page, if any.
svn path=/trunk/mcs/; revision=109040
* DataGrid.cs: removed the private class TableID and moved its
code to ChildTable.cs (see below). 2.0 instantiates teh ChildTable
with the owner parameter now. Fixes bug #400377
* ChildTable.cs: refactoring - moved code from TableID previously
defined in DataGrid.cs to here and made the class available under
different names for both 1.x and 2.x profiles. Fixes bug #400377
svn path=/trunk/mcs/; revision=108638
* MailDefinition.cs: look for the mail body file in the correct
path. Patch from Jackson Harper <[email protected]>,
thanks! Fixes bug #408699
* PasswordRecovery.cs: do not ask password recovery question if
it's disabled. Patch from Jackson Harper <[email protected]>,
thanks! Fixes bug #408696
svn path=/trunk/mcs/; revision=108636
* GridView.cs: minor optimizations (removed a foreach loop,
replaced calls to Array.Length with a variable containing the
length).
svn path=/trunk/mcs/; revision=107043
* BaseDataBoundControl.cs, ChangePassword.cs, CustomValidator.cs,
DataControlFieldCollection.cs, DataControlField.cs,
PasswordRecovery.cs, PagerSettings.cs: do not use synthetized
event accessors (to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* AnonymousIdentificationModule.cs, FormsAuthenticationModule.cs,
DefaultAuthenticationModule.cs, MembershipProvider.cs,
WindowsAuthenticationModule.cs, PassportAuthenticationModule.cs,
RoleManagerModule.cs: do not use synthetized event accessors (to
avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* HttpApplication.cs, HttpCachePolicy.cs, SiteMapProvider.cs,
TraceContext.cs: do not use synthetized event accessors (to avoid
locks).
2008-05-30 Marek Habersack <[email protected]>
* SessionStateModule.cs: do not use synthetized event accessors
(to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* ProfileModule.cs: do not use synthetized event accessors (to
avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* SessionStateModule.cs: do not use synthetized event accessors
(to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* DataBindingCollection.cs, ExpressionBindingCollection.cs: do not
use synthetized event accessors (to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* ClientBuildManager.cs: do not use synthetized event accessors
(to avoid locks).
2008-05-30 Marek Habersack <[email protected]>
* CacheDependency.cs: do not use synthetized event accessors (to
avoid locks).
svn path=/trunk/mcs/; revision=104569
* HierarchicalDataBoundControl.cs: Modified GetData method to check if
DataSource implements IHierarchicalEnumerable and if so constructs and
returns a new instance of ReadOnlyDataSourceView. This provides functional
compatibility with the Microsoft.NET framework. Fixes bug
#395209. Patch contributed by James Fitzsimons
<[email protected]>, thanks!
2008-05-18 Marek Habersack <[email protected]>
* HierarchicalDataBoundControlTest.cs: Added
TestIHierarchicalEnumerableDataSource to test change made to
GetData method to make functionally compatibile with Microsoft.NET
framework. Patch contributed by James Fitzsimons
<[email protected]>, thanks!
2008-05-28 Marek Habersack <[email protected]>
* ReadOnlyDataSourceView.cs: added. Patch contributed by James
Fitzsimons <[email protected]>, thanks!
svn path=/trunk/mcs/; revision=104329
* Calendar.cs: do not create dateInfo in the constructor - culture
might be not set yet at this point. Fixes bug #323566
Added a private property, DateInfo, which creates the dateInfo
when requested.
2008-05-06 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: compatibility - added the
__stringResource static field to the generated class and a call to
SetStringResourcePointer to the FrameworkInitialize method.
* PageCompiler.cs: __fileDependencies should also be defined in
the 1.x profile.
Page properties assigned in the page directive should be set
inside BuildControlTree in the 2.0 profile.
svn path=/trunk/mcs/; revision=102573
* BulletedList.cs: Avoid calling ToString on a string.
* ButtonField.cs: Throw, not just create, the exceptions.
* HyperLinkField.cs: Throw, not just create, the exceptions.
* ImageField.cs: Throw, not just create, the exception. Avoid calling
ToString on a string.
* ListControl.cs: Avoid calling ToString on a string.
[All issues were found using Gendarme]
svn path=/trunk/mcs/; revision=102571