* EncryptedXml.cs: Add proper null check inside methods.
* SignedXml.cs: GetIdElement returns null if either of its parameter
is null.
* Transform.cs: Comment compatibility-NRE in GetDigestedOutput.
* XmlDecryptionTransform.cs: IsTargetElement returns null if either
of its parameter is null.
* XmlDsigC14NTransform.cs: Comment compatibility-NRE in
GetDigestedOutput.
* XmlDsigExcC14NTransform.cs: Comment compatibility-NRE in
GetDigestedOutput.
[Found using Gendarme CheckParametersNullityInVisibleMethodsRule]
svn path=/trunk/mcs/; revision=117622
* XmlDsigEnvelopedTransformTest.cs: Added test for .ctor (bool). Use
Assert class. Improved properties tests.
* XmlDsigC14TransformTest.cs: Added test for .ctor (bool).
* XmlDsigExcC14NTransformTest.cs: Added .ctor tests and added asserts
IncludsiveNamespacesPrefixList
* XmlDsigExcC14NWithCommentsTransformTest.cs: Added basic .ctor and
properties tests.
* XmlDsigC14NWithCommentsTransformTest.cs: Fixed line endings.
* XmlLicenseTransformTest.cs: Added basic .ctor and properties tests.
* XmlDsigBase64Transform.cs: Use constant for Algorithm namespace.
* XmlDsigExcC14NTransform.cs: Fixed ctors to use WithComments
algorithm if includeComments is true. Assign includeNamespacesPrefixList
to instance field.
* XmlDsigExcC14NWithCommentsTransform.cs: Remove unnecessary
assignment to Algorithm now that base ctor is fixed.
* XmlDsigC14NWithCommentsTransform.cs: Remove unnecessary assignment
to Algorithm now that base ctor is fixed.
* XmlDsigC14NTransform.cs: In default ctor, just invoke .ctor (bool).
In .ctor (bool), assign WithComments algorithm if includeComments is
true. Use constants for Algorithm namespace.
* XmlDsigEnvelopedSignatureTransform.cs: Use constant for Algorithm
namespace.
* XmlDsigXPathTransform.cs: Use constant for Algorithm namespace.
* XmlDsigXsltTransform.cs: Use constant for Algorithm namespace.
* XmlLicenseTransform.cs: Assign Algorithm in ctor.
* XmlSignature.cs: Added constant for XmlLicenseTransform algorithm.
* System.Security_test.dll.sources: Added XmlLicenseTransformTest.cs
and XmlDsigExcC14NWithCommentsTransformTest.cs.
svn path=/trunk/mcs/; revision=115803
* EnvelopedCms.cs, SignedCms.cs: Remove unneeded field
initialization to their default values.
[Found using Gendarme AvoidUnneededFieldInitializationRule]
svn path=/trunk/mcs/; revision=115569
* EncryptedReference.cs, EncryptedType.cs: Remove unneeded field
initialization to their default values.
[Found using Gendarme AvoidUnneededFieldInitializationRule]
svn path=/trunk/mcs/; revision=115568
* DataProtectionPermissionAttribute.cs, DataProtectionPermission.cs:
Remove unneeded field initialization to their default values.
[Found using Gendarme AvoidUnneededFieldInitializationRule]
svn path=/trunk/mcs/; revision=115567
* SignedXmlTest.cs: Add test cases for HMACSHA[256|384|512] and
HMACRIPEMD160 which are supported in 2.0. Based on test case from
Fredrik Olsson on bug #425724.
svn path=/trunk/mcs/; revision=113345
* SignedXmlTest.cs: Add support for signing XML using HMACSHA256,
HMACSHA384, HMACSHA512 and HMACRIPEMD160.
[Fix bug #425724]
svn path=/trunk/mcs/; revision=113344
* XmlDecryptionTransform.cs,
* XmlDsigBase64Transform.cs,
* XmlDsigC14NTransform.cs,
* XmlDsigEnvelopedSignatureTransform.cs,
* XmlDsigExcC14NTransform.cs,
* XmlDsigXPathTransform.cs,
* XmlDsigXsltTransform.cs,
* XmlLicenseTransform.cs: Don't use lock(this). In fact remove locking
since the worse that can happen is two copies of the same data.
[Found using Gendarme]
svn path=/trunk/mcs/; revision=104039
* XmlDsigBase64TransformTest.cs: Add test case for InputTypes
* XmlDsigExcC14NTransformTest.cs: Add test case for InputTypes
svn path=/trunk/mcs/; revision=104038
* Makefile (_boot_): Orchestrate the net_2_1 bootstrap.
(net_2_1_bootstrap_SUBDIRS, net_2_1_raw_SUBDIRS): New.
In build:
* profiles/net_2_1_bootstrap.make: New.
* profiles/net_2_1_raw.make: New. The untuned 2.1 profile.
* profiles/net_2_1.make: New. The tuned 2.1 profile.
* Makefile (PROFILES): Update.
In class:
* Makefile (net_3_5_dirs): Remove System.Xml.Linq, now that it's
built in the 2.0 profile.
In class/System:
* Makefile (CYCLIC_DEPS): New macro.
(CYCLIC_DEP_FILES): Use it to clean up handling of cyclic dependencies.
* net_2_1_raw_System.dll.sources: Rename from net_2_1_System.dll.sources.
* net_2_1_bootstrap_System.dll.sources: New.
In class/corlib:
* Makefile (LIBRARY_COMPILE) [net_2_1]: Remove special case.
In errors:
* Makefile: Enable testing net_2_1 profile.
In mcs:
* Makefile (GMCS_PROFILE): Remove.
(COMPILER_NAME): New helper.
In tests:
* Makefile: Enable smcs testing.
In tools:
* Makefile (net_2_1_raw_SUBDIRS): New.
In tools/compiler-tester:
* Makefile [PROFILE=net_2_1]: Copy file from net_2_1_raw profile.
* compiler-tester.cs: Work better with 'net_2_1' profiles.
In tools/tuner:
* Makefile: Improve. Update to new net_2_1 profiles. Specify
more dependencies. Do work only when necessary.
* Descriptors/smcs.xml: Add CompilerCallableEntryPoint.
svn path=/trunk/mcs/; revision=95989
* NativeDapiProtection.cs: Don't call GetLastWin32Error so late and
use the value we already have from a previous call. Found using
Gendarme.
svn path=/trunk/mcs/; revision=95404
* ReferenceList.cs: Avoid infinite recursion when setting [].
Found by Gendarme.
* XmlDsigXPathTransform.cs: Fix direct comparison with NaN. Found
by Gendarme.
svn path=/trunk/mcs/; revision=92756
* XmlCanonicalizer.cs : fill prefixes which should be actually
written. It must be actually done before canonicalization (so
that node list filtering still takes spec-conformant effect).
* Transform.cs, XmlDsigC14NTransform.cs, XmlDsigExcC14NTransform.cs :
handle PropagatedNamespaces.
* XmlDsigC14NTransformTest.cs : added test for xmlns attribute
completion for input nodes, as well as test for
PropagatedNamespaces (ignored so far).
svn path=/trunk/mcs/; revision=74812
* SignedXml.cs : for internal URI (#blah) resolution, use
GetIdElement() so that any derived class which overrides this
method could resolve the reference correctly.
svn path=/trunk/mcs/; revision=72119
* SignedXml.cs : for DataObject, copy namespaces in Data into Object
element itself. I haven't solved the puzzle on why it is needed
though.
* SignedXmlTest.cs : enable SignElementWithPrefixedNamespace().
svn path=/trunk/mcs/; revision=71658
* DataObject.cs : it should not append created DataObject element to
the owner document. It affects on XPath selection, though currently
SignedXml.GetReferenceHash() is bogus so I cannot add meaningful
tests for it.
* XmlCanonicalizer.cs : in Canonicalize(XmlNodeList), nodes [0] could
be XmlDocument and thus it could cause NullReferenceException.
svn path=/trunk/mcs/; revision=71540
* XmlCanonicalizer.cs : it should be reset before being reused.
* SignedXmlTest.cs :
run the transformation in yesterday's test twice.
svn path=/trunk/mcs/; revision=71529
* XmlDsigExcC14NTransformTest.cs, XmlDsigC14NTransformTest.cs,
SignedXmlTest.cs : added some more tests which blocks indigo.
svn path=/trunk/mcs/; revision=71462
* XmlCanonicalizer.cs : don't output default namespace when the node's
namespace is not empty. Check "visibly utilized" namespace nodes in
exc-c14n. Also, in exc-c14n, rendered namespaces are not written.
Added InclusiveNamespaces PrefixList field (not in use yet).
* XmlDsigExcC14NTransform.cs :
re-imported from XmlDsigC14NTransform.cs.
* System.Security_test.dll.sources : added
XmlDsigExcC14NTransformTest.cs.
* XmlDsigExcC14NTransformTest.cs : new tests, mostly copied from
non-exc test.
* xmldsig.cs : exc-c14n tests could be run under 2.0 profile (and
they are not working correctly yet).
* Makefile : Added net_2_0 profile support.
svn path=/trunk/mcs/; revision=71220
* SignedXml.cs : when there is an envelope document and no referenced
DataObject was found, then look for the target element from the
envelope.
* SignedXmlTest.cs : added DataReferenceToNonDataObject().
* xmldsig.cs : signature-big.xml also depends on the input document.
svn path=/trunk/mcs/; revision=70919
* DataObject.cs : don't clear attributes or children unnecessarily.
* DataObjectTest.cs : test to make sure to not clear attributes or
children unnecessarily.
svn path=/trunk/mcs/; revision=70916
* SignedXml.cs : actually ComputeSignature() itself does not raise
silly exception. It always use CryptographicException.
Added another check; malformed reference object.
* SignedXmlTest.cs : fixed ComputeSignatureNoSigningKey() to not
expect silly exception. Added test for malformed reference.
svn path=/trunk/mcs/; revision=70911
* Makefile: Execute PKITS tests only if the data is installed locally.
See System.dll unit tests for details.
* System.Security_test.dll.sources: Add some PKITS unit tests to the
build.
svn path=/trunk/mcs/; revision=69543
* PkitsTest.cs: New. Common test code to use the PKITS test data.
* Pkits_4_01_SignatureVerification.cs: New. Test signature on S/MIME
using the PKITS test data (if available).
svn path=/trunk/mcs/; revision=69541
* System.Security_test.dll.sources: Added unit and CAS tests for
System.Security.Cryptography.X509Certificates.X509Certificate2UI
svn path=/trunk/mcs/; revision=67535
* X509Certificate2UICas.cs: New (2.0) CAS tests for X509Certificate2UI
* X509Certificate2UITest.cs: New (2.0) unit tests for
X509Certificate2UI
svn path=/trunk/mcs/; revision=67534
* SignedXml.cs : when SigningMethod does not match the algorithm that
the key actually supports, it raises an error.
* SignedXmlTest.cs : added a test for signature method mismatch.
svn path=/trunk/mcs/; revision=66535
* EncryptedXml.cs : use Padding member instead of const ISO10126 (though
I doubt it should be there). Use it in DecryptData().
* EncryptedXmlTest.cs, EncryptedXmlSample3.xml :
another decryption test for padding sanity.
* Makefile:
Added Test/S.S.C.Xml/EncryptedXmlSample3.xml to EXTRA_DISTFILES.
svn path=/trunk/mcs/; revision=65804