* ImageButton.cs: AddAttributesToRender renders the onclick
attribute only if any of the following is true:
- OnClientClick is not empty
- Validation is enabled for the control
- PostBackUrl is used
PostBackOptions now indicate that control requires the javascript
protocol for the handler.
RaisePostBackEvent passes String.Empty as the argument.
Fixes bug #463939
2009-02-10 Marek Habersack <[email protected]>
* ImageButtonTest.cs: added test for bug #46393
svn path=/trunk/mcs/; revision=126482
* ObjectDataSourceViewTest.cs: added test for bug #471767
2009-02-09 Marek Habersack <[email protected]>
* ObjectDataSourceView.cs: ExecuteSelect returns a single-item
array of objects containing the result, if the result isn't one of
DataSet, DataTable or IEnumerable. Fixes bug #471767
svn path=/trunk/mcs/; revision=126371
* Style.cs: if CssClass is null, return String.Empty. Fixes bug
#473303
Added a range check to the BorderStyle property.
2009-02-06 Marek Habersack <[email protected]>
* StyleTest.cs: added tests for CssClass and BorderStyle.
Renamed the Style_CssClass method to Style_RegisteredCssClass.
svn path=/trunk/mcs/; revision=126051
* Makefile (net_2_0_dirs): added System.Web - it now depends on
System.Core, so it needs to be recompiled one more time after
System.Core is done.
2009-01-22 Marek Habersack <[email protected]>
* System.Web.dll.sources: added
System.Web.Compilation/BuildManagerCacheItem.cs,
System.Web.Compilation/BuildManagerDirectoryBuilder.cs,
System.Web.Compilation/BuildProviderGroup.cs
* Makefile (SYSTEMCORE_DEP): added. Defines SYSTEMCORE_DEP on the
mcs command line when System.Core is present.
Added the DEVEL define, which defines DEVEL on the mcs command
line. This is used to conditionally compile development helper code in
System.Web.Util.FileUtils (and possibly other stuff later on)
2009-01-22 Marek Habersack <[email protected]>
* XsdBuildProvider.cs: added missing BuildProviderAppliesTo
attribute.
* BuildProvider.cs: added new internal virtual method,
ExtractDependencies() whose purpose is to extract virtual path
dependencies without compiling the code, if possible.
* TemplateBuildProvider.cs: implemented the new
ExtractDependencies () method which uses regular expressions to
extract file dependencies from the source without having to
compile the file.
* CompilationException.cs: added a new public property, Results,
which returns the compilation results.
* BuildProviderGroup.cs: added. A simple class descending from
List <BuildProvider> which is used to hold a compilation batch -
that is a collection of BuildProvider instances.
* BuildManagerDirectoryBuilder.cs: new class which takes care of
generating compilation batches for the requested virtual path. A
set of batches is generated from files found in the same virtual
directory as the requested virtual path and all of the
dependencies of those files. All files are grouped in batches
within which no file depends upon its siblings. An attempt is made
to sort the batches from the "least dependent" to the "most
dependent" batches - i.e. the batches which do not depend on other
batches go to the top.
Code generating the batches now correctly detects dependency loops
and throws an exception when one is encountered.
Batches are represented as instances of a new class -
BuildProviderGroup.
* BuildManagerCacheItem.cs: added. Contains all the compilation
result information needed by BuildManager. See below.
* BuildManager.cs: complete batch building rewrite:
- only one build lock is held instead of a set of compilation
tickets. Only one thread can compile anything at one given
time.
- retrieving types from the build cache now uses a slim rw lock,
so that readers aren't blocked while compilation is in
progress. Writer lock is acquired only when adding a newly
compiled type to the build cache and when removing it after its
dependencies made it invalid.
- assembly references for each compilation are now collected
dynamically as the source is being compiled, this removed a lot
of complexity in dealing with assembles containing conflicting
types. As a consequence right now there may exist several
loaded assemblies containing the same type, but only the latest
of them will be used in new compiles.
- the thread compiling code can recurse into the Build method
which causes the recursively referenced code to be compiled
into a separate, uniquely named, assembly. This deals with all
recursion loops and dependency problems.
- automatic app domain restart after a certain number of compiles
is enabled now.
- improved compilation error handling. If a compilation error
occurs, the code attempts to recompile the assembly up to 3
times, each time removing from the batch the files/virtual
paths which failed parsing/compilation. If the attempts failed,
another one is made to compile only the virtual path requested
by the calling code. Only should that fail a compilation
exception is thrown. All the compilation errors are written to
stdout if the application is in the debug mode.
- changed assembly naming. It now generates assembly names based
on whether the compilation is recursive and whether the batch
being compiled contains more than one code unit or
not.
- compilation results are now stored in the cache as instances of
the new BuildManagerCacheItem class, which contains all the
information required by BuildManager to return types,
assemblies, dependencies etc.
- GetReferencedAssemblies now correctly returns only the
assemblies defined in the .config files.
- GetVirtualPathDependencies does not need to compile code
anymore in order to extract virtual path dependencies. New code
in BuildProvider.ExtractDependencies () takes care of that.
- a BuildManagerDirectoryBuilder class instance is used to
generate compilation batches.
* AssemblyBuilder.cs: added support for keeping track of which
code unit was generated by which BuildProvider andr which
BuildProvider produced a given source file. Both changes serve the
purpose of dealing with compilation errors in BuildManager.
* ApplicationFileBuildProvider.cs: added missing
BuildProviderAppliesTo attribute
2009-01-22 Marek Habersack <[email protected]>
* FileUtils.cs: added two conditionally compiled methods (they
require DEVEL to be defined) which output lines to a log file.
2009-01-22 Marek Habersack <[email protected]>
* WebTest.cs: Run () sets the internal field
BuildManager.suppressDebugModeMessages to true.
2009-01-22 Marek Habersack <[email protected]>
* Web.mono.config: added numRecompilesBeforeAppRestart attribute
to the compilation element, set to 100000, to avoid appdomain
restarts during tests.
svn path=/trunk/mcs/; revision=124179
* NunitWeb/Makefile (NunitWeb.dll): added NunitWeb/CustomSection.cs
* NunitWebResources/CustomSectionEmptyCollection.aspx: added
2008-12-23 Marek Habersack <[email protected]>
* WebConfigurationManagerTest.cs: added new test.
2008-12-23 Marek Habersack <[email protected]>
* CustomSection.cs: added. Implementation of custom configuration
elements for WebConfigurationManager tests.
2008-12-23 Marek Habersack <[email protected]>
* Web.mono.config: added CustomTags section definition, used in
WebConfiguratioManager tests.
2008-12-23 Marek Habersack <[email protected]>
* WebConfigurationManager.cs: GetSection should call
OpenWebConfiguration using the actual directory path, not a file
path. If it fails to do so, System.Configuration may treat the
top-level Web.config file as a child one which, in turn, in
certain circumstances will lead to duplicate keys inserted in
collections.
2008-12-23 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added Test/mainsoft/NunitWebResources/CustomSectionEmptyCollection.aspx
* System.Web_test.dll.sources: added mainsoft/NunitWeb/NunitWeb/CustomSection.cs
svn path=/trunk/mcs/; revision=122024
* MasterPageParser.cs: do not compile anything while
parsing. MasterType virtual path is not compiled, but stored for
later. It is compiled when the MasterType property is requested
from within MasterPageCompiler.
* PageParser.cs: do not compile anything while
parsing. MasterPageFile, MasterType and PreviousPageType virtual
paths aren't compiled but checked for existence and stored for
later. Actual compilation happens when the MasterType and
PreviousPageType are requested from within PageCompiler.
* BaseParser.cs: added a new helper method, ThrowParseFileNotFound.
2008-12-10 Marek Habersack <[email protected]>
* ParseException.cs: made serializable.
* PageCompiler.cs: CreateStronglyTypedProperty calls
AddReferencedAssembly to add type's assembly to the unit's
references after the typed property has been created.
* BaseCompiler.cs: added a new helper method,
AddReferencedAssembly to be used whenever an assembly location
needs to be added to the compilation unit's list after the parsing
is done (e.g. when processing PreviousPageType or MasterPageType
properties in PageParser)
2008-12-10 Marek Habersack <[email protected]>
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWebResources/MissingMasterFile.aspx
* System.Web_test.dll.sources: added System.Web.UI/PageParserTest.cs
2008-12-10 Marek Habersack <[email protected]>
* NunitWebResources/MissingMasterFile.aspx: added
2008-12-10 Marek Habersack <[email protected]>
* PageParserTest.cs: added
svn path=/trunk/mcs/; revision=121181
* NunitWebResources/ValidPropertyBind5.aspx: added
* NunitWebResources/ReadWritePropertyControl.ascx: added a
writable string property.
2008-12-08 Marek Habersack <[email protected]>
* TemplateControlCompilerTest.cs: added another valid Bind
expression test.
2008-12-08 Marek Habersack <[email protected]>
* TemplateControlCompiler.cs: use the correct regex match group
index in SanitizeBindCall (), fixes bug #457011
svn path=/trunk/mcs/; revision=120988
* System.Web_test.dll.sources: added System.Web.UI/DataBinderTest.cs
2008-12-03 Marek Habersack <[email protected]>
* DataBinderTest.cs: added
2008-12-03 Marek Habersack <[email protected]>
* DataBinder.cs: clean up Eval for good this time.
GetIndexedPropertyValue should throw an exception when a string
indexer expression is used and the container is an IList.
svn path=/trunk/mcs/; revision=120590
* Makefile (TEST_RESOURCE_FILES): added
Test/mainsoft/NunitWeb/NunitWeb/Resources/Web.mono.config.1.1
2008-12-02 Marek Habersack <[email protected]>
* WebTest.cs: for 1.1, copy the Web.mono.config.1.1 resource
2008-12-02 Marek Habersack <[email protected]>
* Web.config: added ASP.NET AJAX 1.0 configuration entries
* Web.config.1.1: copied from the last revision before the above
changes, so that 1.1 tests don't fail.
* Web.mono.config.1.1: copied from revision before the AJAX
changes below, so that 1.1 tests don't fail.
svn path=/trunk/mcs/; revision=120442
* ApplicationHostTest.cs: ignore the CachePath test. We are settig it
to DynamicBase to make all the temporary and shadow-copied files go
into the same directory.
svn path=/trunk/mcs/; revision=117535
* ImageMap.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in Render ().
* DropDownList.cs, ListBox.cs: validate the event in LoadPostData ().
* TextBox.cs: validate the event in LoadPostData ().
Register for event validation in AddAttributesToRender ().
* HiddenField.cs: validate the event in RaisePostDataChangedEvent.
Register for event validation in Render ().
* RadioButton.cs: validate the event in LoadPostData ().
Register for event validation in InternalAddAttributesToRender.
* CheckBox.cs, RadioButtonList.cs: validate the event in
RaisePostDataChangedEvent.
* Menu.cs: added the SupportsEventValidation attribute to the
class.
Validate the event in RaisePostBackEvent ().
Register for event validation in GetClientEvent ().
* DetailsView.cs, GridView.cs: validate the event in
RaisePostBackEvent ().
Register for validation in GetCallbackScript () and in OnPreRender
* Button.cs, Table.cs, BulletedList.cs, Calendar.cs, LinkButton.cs,
ImageButton.cs, TreeView.cs: validate the event in RaisePostBackEvent ().
2008-10-17 Marek Habersack <[email protected]>
* Control.cs: added the ValidateEvent internal method, used by
classes descending from Control to automatically trigger event
validation.
* Page.cs: removed the CheckForValidationSupport method. It moved
to Control.cs
RaisePostBackEvent no longer validates the events, this
functionality has been moved to Control.ValidateEvent.
2008-10-17 Marek Habersack <[email protected]>
* HtmlInputHidden.cs: validate the event in LoadPostDataInternal.
* HtmlInputButton.cs: validate the event in
RaisePostBackEventInternal ().
Register for event validation in RenderAttributes ()
* HtmlTextArea.cs: validate the event in
RaisePostBackDataChangedEvent ().
* HtmlButton.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ()
* HtmlAnchor.cs: validate the event in RaisePostBackEvent ().
Register for event validation in RenderAttributes ().
* HtmlInputRadioButton.cs, HtmlSelect.cs: validate the event in
LoadPostData.
* HtmlInputText.cs, HtmlInputImage.cs, HtmlInputCheckBox.cs,
HtmlInputPassword.cs: validate the event in
RaisePostDataChangedEvent ().
2008-10-17 Marek Habersack <[email protected]>
* MenuAdapterTest.cs: work around event validation failure in the
test environment.
2008-10-17 Marek Habersack <[email protected]>
* PageTest.cs: use a custom version of HtmlInputHidden control to
work around the new event validation code which doesn't work in
this instance.
svn path=/trunk/mcs/; revision=116231
* WebTest.cs: made the Host property internal. It is used to
access the host's application domain when necessary in some
tests.
* MyTemplateControls.cs: added
2008-10-09 Marek Habersack <[email protected]>
* NunitWebResources/TemplateControlParsingTest.aspx: added
2008-10-09 Marek Habersack <[email protected]>
* TemplateControlCompilerTest.cs: compile the file on 1.1 as well.
Added a test for template parsing in compound controls.
svn path=/trunk/mcs/; revision=115324
* ControlParameter.cs: Evaluate calls DataBinder.Eval to do the
evaluation now. This makes it support complex expressions.
2008-10-08 Marek Habersack <[email protected]>
* DataBinder.cs: in Eval expression needs to be trimmed before
checking whether it's an empty string.
GetIndexedPropertyValue must explicitly look for the "Item"
property, the lack of the DefaultMember attribute on type must not
throw exceptions.
2008-10-08 Marek Habersack <[email protected]>
* ControlParameterTest.cs: added a test for ControlParameter
evaluating a complex property expression.
svn path=/trunk/mcs/; revision=115193
* System.Web.UI.HtmlControls/HtmlImage.cs: Do not render the src
attribute if it is null or empty. An empty src attribute makes
browsers download the current page url as the url of the image.
* Test/System.Web.UI.HtmlControls/HtmlImageTest.cs: Add test to
make sure the src attribute is not rendered when it is empty.
svn path=/trunk/mcs/; revision=115158
* MasterPage.cs: decouple processing of content templates in
CreateMasterPage from checking whether all the content place
holder ids are defined. Fixes bug #325114
2008-07-28 Marek Habersack <[email protected]>
* StandardUrl.cs: added a new standard url -
PAGE_WITH_MASTER_INVALID_PLACE_HOLDER.
2008-07-28 Marek Habersack <[email protected]>
* MyPageWithMasterInvalidPlaceHolder.aspx: added
2008-07-28 Marek Habersack <[email protected]>
* MasterPageTest.cs: added a test for situations when a page tries
to use a content place holder not defined in the associated master
page (bug #325114)
2008-07-28 Marek Habersack <[email protected]>
* NunitWeb/Makefile (NunitWeb.dll): added dependency on
NunitWeb/Resources/MyPageWithMasterInvalidPlaceHolder.aspx, it is
also included in the resources.
svn path=/trunk/mcs/; revision=108975
* NunitWebResources/adapters.browser: added capabilities with
multiple substitutions and $ and % characters not associated
with substitutions.
++ Test/System.Web/ChangeLog (working copy)
* AppBrowsersTest.cs: Added tests for bug where capabilities
containing literal $ or % were dropped. Added test for bug
where capabilities with multiple $ substitutions only
had one applied.
++ System.Web.Configuration_2.0/ChangeLog (working copy)
* nBrowser/Node.cs nBrowser/Build.cs nBrowser/Identification.cs:
Fixed race condition in Node.Process() by removing mutating
functions from Identification and changing Node.Process() and
Node.BrowserIdentification() to maintain state in a List<Match>
instead of a List<Identification>.
* nBrowser/Node.cs: Fixed race condition associated with lookup of
adapter types.
* nBrowser/Node.cs: Removed duplicate call to
Node.BrowserIdentification() from Node.Process().
* nBrowser/Node.cs: Removed duplicate call to Result.AddAdaper()
from Node.Process().
* nBrowser/Node.cs: Fixed bug where capabilities containing literal
$ or % were dropped.
* nBrowser/Node.cs: Fixed bug where capabilities with multiple $
substitutions only had one applied.
svn path=/trunk/mcs/; revision=108861
Do not invoke Length property twice for seekable MemoryStream.
* LosFormatterTest.cs: Improved test for bug #411115.
svn path=/trunk/mcs/; revision=108506
* SqlDataSourceTest.cs: command parameters are constructed from
reversed order of keys in an IOrderedDictionary - fix the order in
some tests.
svn path=/trunk/mcs/; revision=107045
* UrlUtils.cs: optimize string usage (do not compare against "").
2008-06-16 Marek Habersack <[email protected]>
* UrlUtilsTest.cs: those tests can be ran only under the 2.0
runtime (System.Web.Util.UrlUtils is an internal class)
svn path=/trunk/mcs/; revision=105899
Removed extra check for target attribute in RenderAttributes. Use
string.Empty instead of "", and check string's Length instead of
comparison with "" or string.Empty. Minor code formatting.
* HtmlAnchorTest.cs: Added RenderAttributes tests for empty or null
HRef, Name, Target and Title.
svn path=/trunk/mcs/; revision=105270
* HierarchicalDataBoundControl.cs: Modified GetData method to check if
DataSource implements IHierarchicalEnumerable and if so constructs and
returns a new instance of ReadOnlyDataSourceView. This provides functional
compatibility with the Microsoft.NET framework. Fixes bug
#395209. Patch contributed by James Fitzsimons
<[email protected]>, thanks!
2008-05-18 Marek Habersack <[email protected]>
* HierarchicalDataBoundControlTest.cs: Added
TestIHierarchicalEnumerableDataSource to test change made to
GetData method to make functionally compatibile with Microsoft.NET
framework. Patch contributed by James Fitzsimons
<[email protected]>, thanks!
2008-05-28 Marek Habersack <[email protected]>
* ReadOnlyDataSourceView.cs: added. Patch contributed by James
Fitzsimons <[email protected]>, thanks!
svn path=/trunk/mcs/; revision=104329