* ReflectionPropertyDescriptor.cs: Don't cache getter and
setter properties. Cache instead the PropertyInfo objects
that defined them.
PropertyInfo::Get/SetValue is faster than calling the method
throught reflection.
svn path=/trunk/mcs/; revision=128235
* AttributeCollection.cs: this [Type] shouldn't throw a NREX when
attrList is null.
* TypeDescriptor.cs: GetConverter (Type) must throw
ArgumentNullException if the passed parameter is null.
FindDefaultConverterType should gracefully cope with type being
null.
2009-02-19 Marek Habersack <[email protected]>
* TypeDescriptorTests.cs: added a test for
TypeDescriptor.GetConverter (null) case.
svn path=/trunk/mcs/; revision=127343
* BindingList.cs: Add calls InsertItem which raises OnListChanged, so
don't raise a duplicate OnListChanged in AddNewCore.
svn path=/trunk/mcs/; revision=122896
* TypeDescriptor.cs: Added support for NullableConverter.
* TypeDescriptorTests.cs: Added a test for the NullableConverter support.
svn path=/trunk/mcs/; revision=120946
* BackgroundWorker.cs: If the user sets Cancel to true, but then
throws an exception in DoWork, we need to set Cancel back to false.
[Fixes bug #328830]
svn path=/trunk/mcs/; revision=112520
2008-09-01 Rodrigo Kumpera <[email protected]>
* PropertyDescriptorTest.cs: Tests for Get/Set Value of partial
overrides of virtual properties.
In System.ComponentModel:
2008-09-01 Rodrigo Kumpera <[email protected]>
* ReflectionPropertyDescriptor.cs (SetValue, GetValue) : Lookup
the MethodInfo for accessors in parent types in case of partial
overrides of virtual properties.
svn path=/trunk/mcs/; revision=112052
* DefaultValueAttribute.cs: Fix Equals (wrt boxing) and
GetHashCode (wrt NRE on null Value).
* PropertyChangedEventArgs.cs: Property PropertyName is not
virtual for NET_2_1
svn path=/trunk/mcs/; revision=109853
* TypeDescriptor.cs: Attributes precendence (higher to lower)
should be type -> base types -> interfaces and not
type -> interfaces -> base types.
svn path=/trunk/mcs/; revision=108190
* TypeDescriptor.cs:
- Refactor the default converters table not to be a Hashtable,
because the order of the keys is not preserved.
- Fix FindDefaultConverterType to properly make use of the default
converters.
svn path=/trunk/mcs/; revision=108121
* TypeDescriptor.cs:
- Fix GetConverter (Type) overload to have same logic as the
object one.
- Object-ReferenceConverter should be the last entry in the predefined
converters table, so that when we look up we don't end up with the wrong
converter for derived types.
* TypeDescriptorTests.cs: Add a test that both GetConverter
overloads return the same converter.
svn path=/trunk/mcs/; revision=108087
Apply patch from Achille Fouilleul (achille.fouilleul at gadz dot org)
* BackgroundWorker.cs: Ensure the async object is set to null before
calling RunWorkerCompleted, as IsBusy is based off the async object.
[Fixes bug #394365]
2008-07-16 Jonathan Pobst <[email protected]>
* BackgroundWorkerTest.cs: Add some asserts for bug #364365.
svn path=/trunk/mcs/; revision=108053
Apply patches from Jordan Callicoat (MonkeeSage at gmail dot com)
* AsyncCompleteEventArgs.cs: RaiseExceptionIfNecessary should throw
TargetInvocationException if there was an exception, and IOE if
the operation was cancelled.
* BackgroundWorker.cs: Do not call RunWorkerCompleted from CancelAsync,
setting cancel_pending to true is enough.
* RunWorkerCompletedEventArgs.cs: Raise exceptions when user tries
to access the Result if there are any exceptions.
[Fixes bugs #328830 and 373153]
2008-07-16 Jonathan Pobst <[email protected]>
* BackgroundWorkerTest.cs: Add tests for bugs 328830 and 373153.
svn path=/trunk/mcs/; revision=108039
IList. Added test for String indexer.
* PropertyDescriptorCollectionTests.cs: Improved test for Find and
merged CultureInsensitiveFindTest. Improved test for Find with null
name/key. Added test for String indexer.
* EventDescriptorCollection.cs: Fixed Empty to return read-only
collection. In a read-only collection, throw NotSupportedException
instead of InvalidOperationException when attempting to modify the
collection. Fixed find to use ordinal comparison on 2.0 profile.
Fixed IList's IsFixedSize and IsReadOnly.
* PropertyDescriptorCollection.cs (Find): Use key as argument name
when name is null. Silly compatiblity fix.
svn path=/trunk/mcs/; revision=106736
* EventDescriptorCollectionTests.cs: Added tests based on tests for
PropertyDescriptorCollection.
* PropertyDescriptorCollectionTests.cs: Added tests for Sort overloads.
Improved test for Find with null key.
* EventDescriptorCollection.cs: Fixed NRE in Sort overloads when order
string array is null.
* PropertyDescriptorCollection.cs: Fixed NRE in Sort overloads when
order string array is null.
svn path=/trunk/mcs/; revision=106733
* DateTimeConverter.cs : use MM for month instead of mm.
Fixed bug #396649, patch by Andy Hume.
* DateTimeConverterTest.cs : test for bug #396649 by Andy Hume.
svn path=/trunk/mcs/; revision=105573
* MemberDescriptor.cs, PropertyDescriptor.cs,
ReflectionPropertyDescriptor.cs: Implement FillAttributes.
* MemberDescriptor.cs:
- Attributes should be checked for duplicates based on their
TypeId and not Type.
- For duplicate attributes the last one added has higher precedence.
* ReflectionPropertyDescriptor.cs: Use the property type supplied
in the ctor instead of using reflection, because this won't work if
there are more then one property with the same name.
svn path=/trunk/mcs/; revision=104696
* TypeDescriptor.cs: GetAttributes must retrieve the attributes of
the type, the base types and the interfaces the type implements.
[Fix part of bug #394310]
* TypeDescriptorTests.cs: Add test that verifies that GetAttributes
retrieves the attributes of the type, the base types and the
interfaces the type implements.
svn path=/trunk/mcs/; revision=104438
* TypeDescriptor.cs: GetProperties should not return write-only
properties. Patch by James Fitzsimons <[email protected]>.
* TypeDescriptorTests.cs: Add test for handling write-only properties.
svn path=/trunk/mcs/; revision=102535
* PropertyTabAttribute.cs, BindingList.cs: replace
usages of new Type [0] with Type.EmptyTypes.
Found with Gendarme.
svn path=/trunk/mcs/; revision=101929
* ReferenceConverter.cs: fix ConvertFrom and ConvertTo when
converting from/to string - base must be called only if the
conversion target type is NOT string, otherwise the result of the
conversion will be the value type name.
2008-04-16 Marek Habersack <[email protected]>
* ComponentConverterTests.cs: added tests for
{Component, Reference}Converter ConvertFrom/ConvertTo changes.
2008-04-16 Marek Habersack <[email protected]>
* System_test.dll.sources: added
System.ComponentModel/ComponentConverterTests.cs
* Makefile (TEST_MCS_FLAGS): reference -r:System.Data for new
tests.
svn path=/trunk/mcs/; revision=100952
* ReflectionPropertyDescriptor.cs: ReadOnlyAttribute has a Default,
so there is no need for a null reference check. Fixes the attr_ro unused
value warning during compilation.
svn path=/trunk/mcs/; revision=100000
* TypeDescriptor.cs: Do not return parent type properties, where the child
has used "new" and also changed the property return type. The problem was that
Type.GetProperties returns both the child and parent property in this case.
* TypeDescriptorTests.cs: Add an unit test.
[Fixes bug #374334]
svn path=/trunk/mcs/; revision=99235
* DesignerAttribute.cs: For the TypeId strip type name only
of the base type to prevent AssemblyQualifiedName and not clashes.
* TypeDescriptor.cs: GetAttributes should ask for the inherited
attributes. I was wrong.
svn path=/trunk/mcs/; revision=98113
* TypeDescriptor.cs: GetAttributes should not ask the Type
for the inherited attributes. Until recently it didn't
make a difference if we did or not, because
Type.GetCustomAttributes never returned inherited such.
svn path=/trunk/mcs/; revision=97827
* Container.cs: On disposal unsite the component first before
disposing in order to prevent it from asking us to remove it
through the Site property.
[Fixes bugs #367653 and #367583]
svn path=/trunk/mcs/; revision=97611
* Component.cs: Do not set the Site to null on disposing as this
is the Containers job. Instead try to remove from Container if sited.
svn path=/trunk/mcs/; revision=97093
* PropertyDescriptor.cs:
- Implement CreateInstance and GetTypeFromName
and refactor GetEditor and Converter use them.
- Drop TypeDescriptor.GetTypeFromName as we also want to check the
ComponentType assembly, which it doesn't do.
* TypeDescriptor.cs: Make GetTypeFromName private as it is no longer
used from the outside.
* PropertyDescriptorTests.cs: Add Converter tests. Based on a
patch by Andy Hume <[email protected]> under the MIT/X11
license.
* System_test.dll.sources: Add Consts.cs so that tests can use it
(e.g for specifying assembly qualified type names in attributes).
svn path=/trunk/mcs/; revision=96687
* ReflectionPropertyDescriptor.cs: Use Attribute.GetCustomAttributes
instead of PropertyInfo.GetCustomAttributes as the latter will not
retrieve inherited attributes.
[Fixes bug #322464]
svn path=/trunk/mcs/; revision=96633