While working on PR #11829 I stress-tested the tests by running multiple test
runs in parallel, and it turned out that many tests were not parallel-safe,
because they used the same temporary file names and ended up stomping on
eachother.
So I implemented a helper method that creates a guaranteed unique temporary
directory, and I've changed all tests to use this new helper method.
* [System] Fix line endings for a few files.
Best reviewed by not showing whitespace changes (should be empty diff in that case).
* [System] Fix potential crash in CookieParserTests.
Socket.EndAccept can throw an exception, which will crash the process if it
happens on a threadpool. So handle any exceptions when calling
Socket.EndAccept, and propagate those exceptions out of any threadpool code.
* [System.Net.Http] Throw a PlatformNotSupported exception when using HttpClientHandler on watchOS.
* [System.Net.Http] Tweak tests after watchOS API change.
Unfortunately the [ExpectedException] attribute can't be put on an entire
class, so remove the [Category ("RequiresBSDSockets")] attribute on the class
and instead decorate each test with an [ExpectedException] attribute.
* [System] Extract the HttpListenerResponseHelper class to a separate file.
Extract the HttpListenerResponseHelper class to a separate file so that it's
easier to replace the HttpListenerResponse implementation by using a different
file.
* [System] Throw a PlatformNotSupported exception when using the networking stack on watchOS.
* [System] Tweak tests after watchOS API changes.
Unfortunately the [ExpectedException] attribute can't be put on an entire
class, so remove the [Category ("RequiresBSDSockets")] attribute on the class
and instead decorate each test with an [ExpectedException] attribute.
* [System] Fix potential crash in SocketAcceptAsyncTest.
Fix potential crash in SocketAcceptAsyncTest by catching any exceptions in
code executed on the threadpool so that we never end up with unhandled
exceptions (which may terminate the process).
* [System] Avoid logic in SetUp attributes in tests.
Any type of exception in [SetUp] attributes causes all tests to fail with that
exception.
This even happens for tests that do not need the logic in the [SetUp]
attribute.
So rewrite tests a bit to not use [SetUp] when we can reasonably avoid it, and
instead instantiate class-level variables on first use. This ensures that any
exceptions that occur when initializing those variables are attributed to the
corresponding test, and not all of them.
* [System] Make exception handler (for test) catch more exceptions to avoid unhandled exceptions causing process termination.
* [System] Remove Obsolete attribute on API that throws PNSE.
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=13343
There are some Industrial Automation Hardware devices which return a
'\'-prefixed path to the FTP PWD command, which would break:
System.UriFormatException: Invalid URI: The hostname could not be parsed.
at System.Uri.Parse (UriKind kind, System.String uriString)
at System.Uri.ParseUri (UriKind kind)
at System.Uri..ctor (System.String uriString, Boolean dontEscape)
at System.Uri..ctor (System.String uriString) [0x0000
at System.Net.FtpWebRequest.GetRemoteFolderPath (System.Uri uri)
at System.Net.FtpWebRequest.CWDAndSetFileName (System.Uri uri)
at System.Net.FtpWebRequest.ProcessMethod ()
at System.Net.FtpWebRequest.ProcessRequest ()
There was an error connecting to the FTP Server.
The problem was this statement:
Uri initial = new Uri ("ftp://dummy-host" + initial_path);
Since the FTP server was returning "\" to the PWD command,
`initial_path` was "\", and the above was equivalent to:
Uri initial = new Uri (@"ftp://dummy-host\");
This results in the UriFormatException.
The solution is to not assume that `initial_path` will start with '/',
and instead use UriBuilder.