* Test/ProviderTests/System.Data.SqlClient/SqlAdapterTest.cs : Added testcases for #77480
* System.Data.Common/DbDataAdapter.cs :
- FillSchema :
- Add table to schema only if MissingSchemaAction is not Ignore
Add schema to table if MissingSchemaAction is set to either of
Add or AddWithKey
- BuildSchema :
- Set the Schema values only if MissingSchemaAction is set to
AddWithKey
svn path=/trunk/mcs/; revision=56830
* Mono.Data.Tds/Mono.Data.Tds.Protocol/Tds.cs :
- Modified GetSqlMoney () , to set the precision and Scale correctly.
- Modified ProcessColumnDetails , to set the schema values correctly.
* Mono.Data.Tds/Mono.Data.Tds.Protocol/TdsDataColumn.cs : Added some default values for the column schema
* System.Data/Test/ProviderTests/ProviderIndependant/DataReaderTest : Corrected a failing testcase.
* System.Data/Test/ProviderTests/System.Data.SqlClient/SqlCommandBuilderTest.cs : corrected a failing testcase
* System.Data/System.Data.SqlTypes/SqlDateTime : Corrected the MaxValue for SqlDateTime
* System.Data/System.Data.Common/DbDataAdapter.cs :
- Modified schema population to follow MissingSchemaAction and MissingMappingAction
- Add a column to the Primary Key only if its not a hidden key
- Added some argument checks
- Removed some redundant code
* System.Data/System.Data.Common/DataAdapter :
- Added argument checks
* System.Data/System.Data.Common/ExceptionHelper :
- Added InvalidEnumException , a helper function to print error msg
* System.Data/System.Data.SqlClient/SqlCommandBuilder.cs :
- Modified CreateUpdateCommand,CreateDeleteCommand , to not include
column name in the query if its a expression col.
Also, modified the queries to match the generated queries in ms.net
* System.Data/System.Data.SqlClient/SqlCommand.cs :
- Modifed Prepare, to check if Parameter is explicitly initialized
* System.Data/System.Data.SqlClient/SqlParameter.cs :
- Added CheckIfInitialized : Checks if datatype is explicitly set and
non-zero size is set for variable datatypes.
* System.Data/System.Data.SqlClient/SqlDataReader.cs :
- Added code for GetSqlBinary ()
- Fixed GetFieldCount ()
- Added more checks and exceptions.
Fixes most of the failing SqlClient Provider Tests .
svn path=/trunk/mcs/; revision=56167
* Test/ProviderTests/System.Data.SqlClient/SqlDataAdapterTest.cs :
- Added Testcase for bug #76433.
* In System.Data.Common/DbDataAdapter.cs :
- BuildSchema() : Set the value of DataColumn Property 'AllowDBNull'
as returned by database. Fixes bug#76433.
svn path=/trunk/mcs/; revision=51791
2005-08-05 Sureshkumar T <[email protected]>
* DbDataAdapter.cs:
- Update (): set parameter values only after getting the
appropriate command from command builder. Close reader only if it
is not closed before. Use parameter's SourceVersion. Whitespace
corrections to comply with standard.
In System.Data.SqlClient:
2005-08-05 Sureshkumar T <[email protected]>
* SqlCommandBuilder.cs: Set SourceVersion property to the created
parameters as it is used by the Adapter's Update method.
In System.Data.Odbc:
2005-08-05 Sureshkumar T <[email protected]>
* OdbcDataReader.cs: RecordsAffected: get value from command.
GetSchemaTable (): set IsExpression based on BaseTableName. set
AllowDBNull to false if the column is PK.
* OdbcCommand.cs: correct UpdatedRowSource is returned. whitespace
changes to conform to standard.
* OdbcCommandBuilder.cs: Implemented.
* OdbcParameter.cs: Direction is set to Input by default.
svn path=/trunk/mcs/; revision=48043
2005-07-15 Sureshkumar T <[email protected]>
* DataTableMappingCollection.cs: GetTableMappingBySchemaAction:
meaningful error message if mapping is missing.
* DbDataAdapter.cs: Update: meaningful message if table is missing.
In System.Data.SqlClient:
2005-07-15 Sureshkumar T <[email protected]>
* SqlCommandBuilder.cs:
- set_DataAdapter: unsubscribe event if DataAdapter is reset.
- CreateInsertCommand, CreateUpdateCommand, CreateDeleteCommand:
if column mapping is missing, use the source column name. use
proper version to get the data.
- RowUpdatingHandler: set status to continue to actually process
the query.
svn path=/trunk/mcs/; revision=47340
2005-04-22 Sureshkumar T <[email protected]>
* DataTableLoadRowTest.cs: Added. A test case for testing
LoadDataRow method of DataTable. This tests for various
possiblities of row state and loadoption.
In System.Data.Common:
2005-04-22 Sureshkumar T <[email protected]>
* DbDataAdapter.cs: Moved FillTable and BuildSchema as static
methods as they are not operating on the current instance. This
could be reused to fill any table from a data reader.
* RecordCache.cs: While disposing records, make sure that the
record is not already disposed. i.e. to make sure later the same
record is not reused. Implemented a static method to compare two
version of records in a container.
In .:
2005-04-22 Sureshkumar T <[email protected]>
* System.Data_test.dll.sources: Added DataTableLoadRowTest.cs.
In System.Data:
2005-04-22 Sureshkumar T <[email protected]>
* LoadOption.cs: Changed the enums. Keeping old values for
migration.
* DataTable.cs: Implemented methods Load and its overloads. Also
implemented LoadDataRow.
* DataRowCollection.cs: Added a variation of the Find method to
return a row even if it is of state Deleted. This is required for
DataTable.LoadDataRow method.
* DataRow.cs: Implemented internal helper method Load for loading
values from an object array and given an LoadOption (2.0 feature).
* DataRowAction.cs: Added few more enums for .net 2.0. Sorted
alphabetically.
svn path=/trunk/mcs/; revision=43440
2005-04-18 Sureshkumar T <[email protected]>
* DataAdapter.cs: Implemenetd OnFillError handler.
* DbDataAdapter.cs: BuildSchema (): the table to be filled might
contain few additional columns as well. so mapping length should
be columns' length + fields' length.
In System.Data:
2005-04-18 Sureshkumar T <[email protected]>
* DataRow.cs: if there are no mapping fields, fill with default
value.
svn path=/trunk/mcs/; revision=43192
* DbDataAdapter.cs: For Update, disable ReadOnly constraint
temporarily before updating the row. Info from Ingo Bauersachs.
SkipAllRemainingRows should also skip current row (msdn).
svn path=/trunk/mcs/; revision=42186
* DbDataAdapter.cs: Update (): update the rows based on the
UpdateRowSource property. Process further based on the
RowUpdatedEvent handler argument's Status property.
Fixes bug #73587. Thanks to [email protected] (Ingo Bauersachs) for
bug report and patch.
svn path=/trunk/mcs/; revision=42094
* DbDataAdapter.cs (Update ()) :
- Check for one return result set and map the values back to
datatable.
- Check for output & return value parameters and update the value
back to mapped column
- check for recordsAffected only after closing the reader.
svn path=/trunk/mcs/; revision=40120
* DbDataAdapter.cs (BuildSchema): Add the primary key schema iff
MissingSchemaAction is set to AddWithKey. Also, Add auto increment
value from the source table. fixes bug #67757 and #69110.
svn path=/trunk/mcs/; revision=37567
* DbDataAdapter.cs: Fix for out of memory exceptions when trying to fill a dataset with a query which doesn't return a resultset like insert, delete or update.
svn path=/trunk/mcs/; revision=33127
* DataContainer.cs - added. Provides implementation for data containers that holds data in arrays of primitives or objects. Each data container belongs to specific DataColumn.
* DbDataAdapter.cs - changes to complete data storage redesign. Bug fix in FillTable ( to fetch exact number of records required ).
svn path=/trunk/mcs/; revision=27655
- Reader can have empty results (fo example from UPDATE or DELETE).
- Reader can have results with no rows (SELECT that returns 0 rows but have columns)
- In FillTable - skip rows only once for each table.
svn path=/trunk/mcs/; revision=25961
* DbDataAdapter.cs : Refactoring of Fill. New private method
FillTable does most of the work now. Use int[] instead of
hashtable for mapping. Move creation of tableArray[] outside
of loop.
svn path=/trunk/mcs/; revision=24031
* DbDataAdapter.cs: handle MissingShemaAction.AddWithKey, call
AcceptChanges in Update when a CommandBuilder is used and
correctly fill information about primary keys in FillSchema.
Patch from Sergei Malinin ([email protected]).
svn path=/trunk/mcs/; revision=21553
* DbDataAdapter.cs: Call command dispose in self dispose method. We
need to dispose the connections and other stuff stored in the
commands.
svn path=/trunk/mcs/; revision=20355
* DbDataAdapter.cs (Fill): Fixed an Exception from being thrown.
* DataRelation.cs (constructor): When the name of the relation is
null, it should return an empty, not "Relation".
* DataRow.cs (AcceptChanges): Added special case for
RowState.Detached.
(CancelEdit): Set editing flag to false.
(IsNull): Check that the value is DBNull.
* DataRowCollection.cs (Add): There was no check that the table of
the collection is owned by a DataSet.
* DataSet.cs (OnMergeFailed): Added.
* UniqueConstraint.cs (AssertConstraint): There was no check that
values in the row are not null, where it is a primary key
column. Also check that the row has a proposed version, if not,
get the current version when we compare the rows.
svn path=/trunk/mcs/; revision=18452
* DbDataAdapter.cs (Fill): Patch from Eran Domb, <[email protected]>.
Fixes a possible NullReferenceException, more details here:
* DataColumn.cs (Unique): Implemented.
* DataTable.cs:
* ConstraintCollection.cs:
* ForeignKeyConstraint.cs (_ensureUniqueConstraintExists): Fixes
an Exception thrown. Details:
http://lists.ximian.com/archives/public/mono-devel-list/2003-September/002130.html
* DataRowCollection.cs (Add): There is no checking that there is
no violation of the unique constrains.
* UniqueConstraint.cs (AssertConstraint): There is no checking on
all columns in the constraint.
svn path=/trunk/mcs/; revision=18298
* DbDataAdapter.cs: provide a Type for ToArray to avoid invalid cast
exception. Thanks to Mark Easton <[email protected]>.
svn path=/trunk/mcs/; revision=17622
* System.Data.Common/DbDataAdapter.cs:
Add the DataTable to the result set even if it contains
no rows. Based on report by Krieg Andreas.
svn path=/trunk/mcs/; revision=15436
* System.Data.SqlClient/SqlDataReader.cs: when
the data reader is closed, this SqlDataReader referenced
in SqlConnection needs to be null
* System.Data.Common/DbDataAdapter.cs: for SelectCommands executed that
have no result set, such as, DDL like CREATE TABLE or DML like INSERT,
the data reader needs to be immediately closed, and 0 returned
as the number of rows added or refreshed
svn path=/trunk/mcs/; revision=12403
* DbDataAdapter.cs: Added support for filling when schema is present.
Fixed incorrect behavior when ColumnMapping is present
when more than one fields have the same name. Implemented Dispose.
Fixed error when there is no ColumnMapping at all.
Still have some problems in finding the correct TableMapping
because the SourceTable name is not present in BuildSchema
svn path=/trunk/mcs/; revision=11963
* DbDataAdapter.cs: The original code might pass a null DataTableMapping
value which is then used to create a RowUpdatingEventArgs
instance. So RowUpdatingEvent handler (for instance
CommandBuilder) could get null DataTableMapping which
might be unexpected. The patch makes sure that a non-null
DataTableMapping is passed.
svn path=/trunk/mcs/; revision=11930
* list:
Add new internal tds classes
* System.Data.Common/DbDataAdapter.cs:
* System.Data.SqlClient/SqlDataAdapter.cs:
Change event calling system
* System.Data.SqlClient/SqlClientPermission.cs:
* System.Data.SqlClient/SqlClientPermissionAttribute.cs:
* System.Data.SqlClient/SqlDataReader.cs:
Add comments
* System.Data.SqlClient/SqlCommand.cs:
Some changes to make consistent with .NET based on Sql server traces
Implement command timeout
* System.Data.SqlClient/SqlCommandBuilder.cs:
Make sure that we only build a command if key info found
* System.Data.SqlClient/SqlConnection.cs:
Change event calling system
Some changes to make consistent with .NET based on Sql server traces
Implement connection timeout
* System.Data.SqlClient/SqlConnectionPool.cs:
Implement connection timeout
* System.Data.SqlClient/SqlError.cs:
Implement ToString ()
* System.Data.SqlClient/SqlException.cs:
Mucho implementation and cleanup
* System.Data.SqlClient/SqlParameter.cs:
Implement Clone ()
* System.Data.SqlClient/SqlParameterCollection.cs:
Code cleanup
* System.Data.SqlClient/SqlTransaction.cs:
Move some of the transaction creation to SqlConnection to be consistent
with .NET SQL traces
svn path=/trunk/mcs/; revision=8906
* System.Data/DataRow.cs:
* System.Data/DataTable.cs:
Some fix-ups related to the DbDataAdapter to make it work.
* System.Data.Common/DbDataAdapter.cs:
Fix the Fill () and Update () methods. These now work
fairly well. Need mucho testing.
* System.Data.SqlClient/SqlCommandBuilder.cs:
Support table mappings and parameter source versions now.
* System.Data.SqlClient/SqlConnection.cs:
* System.Data.SqlClient/SqlTransaction.cs:
Add set accessor for transaction so that SqlTransaction.Commit ()
will remove itself from the connection.
* System.Data.SqlClient/SqlDataAdapter.cs:
Update/Insert/Delete command should be null by default.
* System.Data.SqlClient/SqlException.cs:
Remove a TODO attribute
* System.Data.SqlClient/SqlRowUpdatingEventArgs.cs:
Properly handle the SqlCommand object
svn path=/trunk/mcs/; revision=8889
* System.Data.Common/DbDataAdapter.cs:
Remove NotImplementedException in Dispose
* System.Data.Common/FieldNameLookup.cs:
Should be sealed
* System.Data.SqlClient/SqlCommand.cs:
Fix CommandText accessor (stack overflow)
Implement DeriveParameters method
* System.Data.SqlClient/SqlCommandBuilder.cs:
Implement this class
* System.Data.SqlClient/SqlConnection.cs:
Change application name to "Mono SqlClient Data Provider"
* System.Data.SqlClient/SqlDataReader.cs:
Add new schema information
* System.Data.SqlClient/SqlError.cs:
* System.Data.SqlClient/SqlErrorCollection.cs:
Remove internal methods, TODO attributes
* System.Data.SqlClient/SqlParameter.cs:
Add new internal constructor for DeriveParameters use
* System.Data.SqlClient/SqlParameterConverter.cs:
Add missing methods based on class status
svn path=/trunk/mcs/; revision=8864
* System.Data.Common/DbDataAdapter.cs :
Fix handling of nulls
* System.Data.Common/DbDataRecord.cs :
Change GetFieldType ()
* System.Data.Common/DbEnumerator.cs :
Add new schema information
* System.Data.Common/FieldNameLookup.cs :
Change definition of schema
* System.Data.Common/SchemaInfo.cs :
Add more information
* System.Data.SqlClient/SqlDataReader.cs :
get more schema table data
* list :
Add Mono.Data.TdsClient.Internal.TdsSchemaInfo
svn path=/trunk/mcs/; revision=8722