Commit Graph
26 Commits
Author SHA1 Message Date
Marek Habersack 4caac12664 2008-09-15 Marek Habersack <[email protected]>
* SessionStateModule.cs: correctly let the handler know if an item
	is new when calling SetAndReleaseItemExclusive. Fixes bug #424797
	If handler's GetItem doesn't initialize storeLockId to a non-null
	value, initialize it to 0. Fixes bug #424797

svn path=/trunk/mcs/; revision=112997
2008-09-15 09:54:30 +00:00
Marek Habersack 2a10f9ae73 2008-07-29 Marek Habersack <[email protected]>
* SessionStateModule.cs: use Request.FilePath instead of
	Request.BaseVirtualDirectory to retrieve the cookie-less session
	identifier. Fixes bug #397418

2008-07-29  Marek Habersack  <[email protected]>

	* UrlUtils.cs: fixed a typo in HasSessionId which made it always
	return False. Fixes bug #397418

2008-07-29  Marek Habersack  <[email protected]>

	* SessionStateModule.cs: use Request.FilePath instead of
	Request.BaseVirtualDirectory to retrieve the cookie-less session
	identifier. Fixes bug #397418

2008-07-29  Marek Habersack  <[email protected]>

	* HttpRequest.cs: if the FilePath contains embedded cookie-less
	session identifier, remove it before computing the base virtual
	directory. Fixes bug #397418



svn path=/trunk/mcs/; revision=109156
2008-07-29 13:01:55 +00:00
Marek Habersack ae00a7ec53 2008-06-04 Marek Habersack <[email protected]>
* SessionStateModule.cs: set the application modifier path to bare
	session id.

2008-06-04  Marek Habersack  <[email protected]>

	* UrlUtils.cs: added internal method HasSessionId

2008-06-04  Marek Habersack  <[email protected]>

	* SessionStateModule.cs: set application path modifier string to
	the bare session ID.

2008-06-04  Marek Habersack  <[email protected]>

	* HttpResponse.cs: correctly modify virtual path to include the
	session ID in cookieless session mode. Fixes bug #396628.

svn path=/trunk/mcs/; revision=104861
2008-06-04 13:13:09 +00:00
Marek Habersack 0907975508 2008-05-30 Marek Habersack <[email protected]>
* BaseDataBoundControl.cs, ChangePassword.cs, CustomValidator.cs,
	DataControlFieldCollection.cs, DataControlField.cs,
	PasswordRecovery.cs, PagerSettings.cs: do not use synthetized
	event accessors (to avoid locks).

2008-05-30  Marek Habersack  <[email protected]>

	* AnonymousIdentificationModule.cs, FormsAuthenticationModule.cs,
	DefaultAuthenticationModule.cs, MembershipProvider.cs,
	WindowsAuthenticationModule.cs, PassportAuthenticationModule.cs,
	RoleManagerModule.cs: do not use synthetized event accessors (to
	avoid locks).

2008-05-30  Marek Habersack  <[email protected]>

	* HttpApplication.cs, HttpCachePolicy.cs, SiteMapProvider.cs,
	TraceContext.cs: do not use synthetized event accessors (to avoid
	locks).

2008-05-30  Marek Habersack  <[email protected]>

	* SessionStateModule.cs: do not use synthetized event accessors
	(to avoid locks).

2008-05-30  Marek Habersack  <[email protected]>

	* ProfileModule.cs: do not use synthetized event accessors (to
	avoid locks).

2008-05-30  Marek Habersack  <[email protected]>

	* SessionStateModule.cs: do not use synthetized event accessors
	(to avoid locks).

2008-05-30  Marek Habersack  <[email protected]>

	* DataBindingCollection.cs, ExpressionBindingCollection.cs: do not
	use synthetized event accessors (to avoid locks).

2008-05-30  Marek Habersack  <[email protected]>

	* ClientBuildManager.cs: do not use synthetized event accessors
	(to avoid locks).

2008-05-30  Marek Habersack  <[email protected]>

	* CacheDependency.cs: do not use synthetized event accessors (to
	avoid locks).


svn path=/trunk/mcs/; revision=104569
2008-05-30 22:20:14 +00:00
Marek Habersack 76e412a4c5 2008-04-24 Marek Habersack <[email protected]>
* SessionStateModule.cs: reset the storage data item timeout to
	the HttpApplication.Session.Timeout value after the Session_Start
	event is fired. Fixes bug #382644

svn path=/trunk/mcs/; revision=101632
2008-04-24 00:38:24 +00:00
Marek Habersack 222c5eb23c 2007-11-05 Marek Habersack <[email protected]>
* SessionStateModule.cs: use TimeSpan.TotalMinutes wherever a
	session timeout is required, so that sessions do not expire
	prematurely. Fixes bug #339026. Patch from Adriaan van Kekem
	<[email protected]>, thanks!

svn path=/trunk/mcs/; revision=88845
2007-11-05 09:40:29 +00:00
Marek Habersack 603db366d7 2007-10-17 Marek Habersack <[email protected]>
* SessionInProcHandler.cs: in certain situations the 'item'
	parameter passed to SetAndReleaseItemExclusive may be null. The
	issue was reported in bug #333898, but the reporter cannot provide
	a test case that triggers the issue. Added work around the problem
	in the way that should have the least impact on the rest of the
	code. If 'item' is null, then the new session item is created
	without the items and staticItems collections - they will be
	initialized to defaults when retrieving the session item. This is
	not a correct fix, but since there is no test case this is the
	best what can be done right now.

svn path=/trunk/mcs/; revision=87636
2007-10-17 08:09:38 +00:00
Juraj Skripsky 9d8f783fc9 2007-10-15 Juraj Skripsky <[email protected]>
* SessionStateModule.cs (Init): Use HttpApplication.LoadType,
	don't swallow TypeLoadException.


svn path=/trunk/mcs/; revision=87504
2007-10-15 12:48:57 +00:00
Marek Habersack f1886327a3 2007-10-15 Marek Habersack <[email protected]>
* SessionStateServerHandler.cs: adjust order of field
	initialization.

svn path=/trunk/mcs/; revision=87493
2007-10-15 09:42:03 +00:00
Marek Habersack cdf8842f67 2007-09-18 Marek Habersack <[email protected]>
* SessionStateModule.cs: preserve the query part of the url when
            redirecting with cookieless sessions active. Fixes bug #318790
2007-09-18  Marek Habersack  <[email protected]>

            * SessionIDManager.cs: preserve the query part of the url when
            redirecting with cookieless sessions active. Fixes bug #318790

svn path=/trunk/mcs/; revision=85955
2007-09-18 08:38:35 +00:00
Marek Habersack 108381ac5f 2007-09-07 Marek Habersack <[email protected]>
* SessionInProcHandler.cs: properly clone the
            ApplicationState.SessionObjects at the start of the request and
            use the copy when creating new storage items. That way session
            scope static objects are valid within a single session only. Fixes
            bug #82709

svn path=/trunk/mcs/; revision=85460
2007-09-07 00:26:12 +00:00
Marek Habersack de3974edad 2007-08-14 Marek Habersack <[email protected]>
* SessionStateServerHandler.cs: remove unused field.

2007-08-14  Marek Habersack  <[email protected]>

	* Control.cs: include the actual exception when reporting control
	id clash.

2007-08-14  Marek Habersack  <[email protected]>

	* Roles.cs: remove unused field.

	* SqlMembershipProvider.cs: remove unused variable.

2007-08-14  Marek Habersack  <[email protected]>

	* ObjectDataSourceView.cs: remove unused variable.

	* ChangePassword.cs: remove unused variable.

	* RoleGroupCollection.cs: OnValidate shouldn't be overridden.

2007-08-14  Marek Habersack  <[email protected]>

	* SqlProfileProvider.cs: remove unused variable.

2007-08-14  Marek Habersack  <[email protected]>

	* XmlSiteMapProvider.cs: do not hide this_lock.



svn path=/trunk/mcs/; revision=84041
2007-08-14 10:52:59 +00:00
Marek Habersack ee53884fda 2007-07-31 Marek Habersack <[email protected]>
* SessionInProcHandler.cs: initialize the static session objects
	collection from the application state instead of using
	SessionStateUtility.GetSessionStaticObjects. Fixes bug #82193
	* SessionStateServerHandler.cs: as above
	

svn path=/trunk/mcs/; revision=83072
2007-07-31 13:39:46 +00:00
Igor Zelmanovich a9287ab15f 2007-07-30 Igor Zelmanovich <[email protected]>
* SessionStateModule.cs:
	ensure release (save) session state at OnEndRequest.	


svn path=/trunk/mcs/; revision=82975
2007-07-30 11:44:23 +00:00
Marek Habersack 0b80ac0b50 2007-06-20 Marek Habersack <[email protected]>
* OutputCacheModule.cs: use Context.InternalCache.

	* Cache.cs: 2.0 profile uses generic containers to keep the cache
	entries.
	Gotten rid of the InsertPrivate and InsertInternal methods. The
	latter was moved to one of the Insert overloads.
	Private entries are no longer handled specifically, because the
	internal cache is now kept in a separate object.

2007-06-20  Marek Habersack  <[email protected]>

	* AppResourcesCompiler.cs: use HttpRuntime.InternalCache to keep
	private entries.
	* CachingCompiler.cs: as above
	* AspGenerator.cs: as above

2007-06-20  Marek Habersack  <[email protected]>

	* DataSourceCacheManager.cs: use HttpContext.Current.InternalCache
	to keep private entries.
	* XmlDataSource.cs: as above

2007-06-20  Marek Habersack  <[email protected]>

	* SessionInProcHandler.cs: use HttpRuntime.InternalCache to keep
	private entries.

2007-06-20  Marek Habersack  <[email protected]>

	* SessionInProcHandler.cs: use HttpRuntime.InternalCache to keep
	the internal entries.

2007-06-20  Marek Habersack  <[email protected]>

	* BasePartialCachingControl.cs: use HttpRuntime.InternalCache to
	keep the private entries.

2007-06-20  Marek Habersack  <[email protected]>

	* HttpRuntime.cs: added new internal property, InternalCache, to
	keep all the internal cache entries instead of mixing them with
	the public cache ones.
	Do not invoke Cache.InvokePrivateCallbacks - this method no longer
	exists.

	* HttpResponse.cs: private entries are now kept in
	Context.InternalCache.

	* HttpContext.cs: added new internal property, InternalCache,
	which returns the HttpRuntime.InternalCache value.

Fixes bug #81690


svn path=/trunk/mcs/; revision=80321
2007-06-20 15:42:36 +00:00
Marek Habersack 19f92c957d 2007-06-20 Marek Habersack <[email protected]>
* SessionStateModule.cs: if session is abandoned and the handler
	supports expiration, disable the handler's session expiration
	callback and call SessionStateUtility.RaiseSessionEnd
	directly. Fixes bug #81853.

svn path=/trunk/mcs/; revision=80308
2007-06-20 11:58:14 +00:00
Marek Habersack 5eae577076 2007-04-30 Marek Habersack <[email protected]>
* SessionInProcHandler.cs: do not end session when setting and
	releasing item in mid-session. Fixes bugs #81440, #81140 and
	#80723


svn path=/trunk/mcs/; revision=76490
2007-04-30 13:36:38 +00:00
Marek Habersack ef5770b5a3 2007-04-18 Marek Habersack <[email protected]>
* SessionInProcHandler.cs: added protection against raising early
	session end event when resetting item timeout. Fixes bug #81140

svn path=/trunk/mcs/; revision=75863
2007-04-18 09:31:03 +00:00
Konstantin Triger 18a158237c TARGET_J2EE: support only J2EE sessions
svn path=/trunk/mcs/; revision=74098
2007-03-12 07:30:47 +00:00
Marek Habersack 1f5af40908 Add graceful handling of various types of values in session removal callback
svn path=/trunk/mcs/; revision=73801
2007-03-06 11:46:47 +00:00
Marek Habersack 7fcf8ab762 Fix for bug 80682
svn path=/trunk/mcs/; revision=73773
2007-03-06 00:51:45 +00:00
Konstantin Triger f81faf1f33 call Session_End callback only if the handler does not support expiration
svn path=/trunk/mcs/; revision=73096
2007-02-19 07:59:31 +00:00
Miguel de Icaza 6b4c7232fd * SiteMapNode.cs (GetExplicitResourceString): implement.
* HttpContext.cs (GetGlobalResourceObject): remove unused variable.

        * StaticFileHandler.cs (ProcessRequest): remove unused variable.

        * HttpApplication.cs (ProcessError): Remove unused variable.

2007-01-20  Miguel de Icaza  <[email protected]>

        * ClientBuildManager.cs: Remove unused variable (this could be a
        real problem, we never use the appPhysicalTargetDir)

        * AssemblyBuilder.cs: Remove unused field.

        * AppResourceFilesCollection.cs: Remove unused field.

        * TemplateControlCompiler.cs (GetExpressionFromString): Remove
        unused variable.

        * AppResourcesCompiler.cs: Remove unused variable.

        * AppSettingsExpressionBuilder.cs (GetAppSetting): remove unused
        parameter.

        * PageCompiler.cs: Put InternalCreatePageProperty inside the
        NET_2_0 block to eliminate warnings.

2007-01-20  Miguel de Icaza  <[email protected]>

        * HandlerFactoryConfiguration.cs (LoadType): remove unused
        variable.
        (ctor): do not assign parent, we do not use it, keep the code for
        reference.

2007-01-20  Miguel de Icaza  <[email protected]>

        * ApplicationManager.cs: Remove unused variable.
        (ShutdownAll) remove unused variables.

        * ApplicationHost.cs: Protect create_dir lock

2007-01-20  Miguel de Icaza  <[email protected]>

        * SqlRoleProvider.cs: comment out unused code.

        * SqlMembershipProvider.cs: Removed unused variables.
        Remove unused variable.

        * AnonymousIdentificationModule.cs (ClearAnonymousIdentifier):
        remove unused variable.   This might be a real bug.

2007-01-20  Miguel de Icaza  <[email protected]>

        * SessionStateModule.cs: Removed unused variables.

2007-01-20  Miguel de Icaza  <[email protected]>

        * SessionDictionary.cs: Removed unused variable (dirty).

2007-01-20  Miguel de Icaza  <[email protected]>

        * XhtmlTextWriter.cs: comment out unused code.

        * ThemeProvider.cs: comment out unused code.

        * DataSourceView.cs: Comment unused variable.

        * ClientScriptManager.cs: Put the expandoAttributes inside the 2.0
        code

        * Control.cs: Put _templateControl inside the NET_2_0 ifdef

2007-01-20  Miguel de Icaza  <[email protected]>

        * HtmlHead.cs: comment out unused code, in particular metadata is
        commented out because nothing could have triggered its creation.

        * HtmlButton.cs: Move declaration of `csm' inside the 1.1 case.

2007-01-20  Miguel de Icaza  <[email protected]>

        * DataControlFieldCollection.cs (RemoveAt): remove unused
        variable.

        * RoleGroupCollection.cs (OnValidate): Flag as protected, as it
        should not show up.

        * RadioButton.cs (RaisePostDataChangedEvent): This method was not
        used in 1.0, so put the whole method in 2.0

2007-01-20  Miguel de Icaza  <[email protected]>

        * WebPart.cs: Remove

        * PersonalizableAttribute.cs: Remove extra API that was wrong as well.

2006-11-28  Miguel de Icaza  <[email protected]>

        * WebPart.cs:

2007-01-20  Miguel de Icaza  <[email protected]>

        * FileUtils.cs (CreateTemporaryFile): Remove unused variable.



svn path=/trunk/mcs/; revision=71399
2007-01-20 22:42:04 +00:00
Konstantin Triger c82553c225 Implemented raising of Session_OnEnd event, refactoring
svn path=/trunk/mcs/; revision=70595
2007-01-07 16:56:14 +00:00
Konstantin Triger c52feb2a1f * SessionIDManager.cs: Pass config to SessionStateModule.IsCookieLess.
* SessionStateStoreData.cs: fix constructor signature.
* SessionInProcHandler.cs, SessionStateServerHandler.cs: ensure has a default
	constructor to make instantiating same as for custom provider.
* SessionStateModule.cs: support custom providers.

svn path=/trunk/mcs/; revision=70128
2006-12-27 16:23:13 +00:00
Marek Habersack 1f6fa2cfbc Move changelog messages where they belong
svn path=/trunk/mcs/; revision=69831
2006-12-20 18:46:02 +00:00