Commit Graph
1173 Commits
Author SHA1 Message Date
Vladimir Krasnov 3318021525 * LinkButton.cs: fixed AddAttributesToRender, removed not needed language attribute
svn path=/trunk/mcs/; revision=57687
2006-03-08 09:42:38 +00:00
Vladimir Krasnov 4ae28b0a54 * TextBox.cs: fixed missing value validations,
fixed rendering of empty value attribute

svn path=/trunk/mcs/; revision=57686
2006-03-08 09:27:04 +00:00
Chris Toshok ca85ad3c1f In System.Web.UI:
2006-03-07  Chris Toshok  <[email protected]>

	* Page.cs (InitializeStyleSheet): load the style sheet theme using
	ThemeDirectoryCompiler.
	(InitializeTheme): load the page's theme using
	ThemeDirectoryCompiler.
	(InternalProcessRequest): call InitializeTheme after OnPreInit.
	(FrameworkInitialize): call InitializeStyleSheet.
	(PageTheme,StyleSheetPageTheme): new properties to get the
	respective themes.

	* Control.cs (ApplyStyleSheetSkin): new method.  Calls ApplySkin
	on the ControlSkin (if there is one) for this control in the
	page's StyleSheetSkin.
	(ApplyThemeRecursively): applies the page's theme recursively to
	the control hierarchy.  Must be done this way because the control
	tree is already present when we apply the theme (it has to be,
	since theme's override settings).

	* PageTheme.cs (GetControlSkin): add internal call to do the
	lookup for us.

	* PageThemeFileParser.cs: the parser object that represents each
	individual skin file.

	* PageThemeParser.cs: the parser object that represents the entire
	theme directory.

	* PageThemeBuilder.cs: this class generates the right exception on
	the right event, but it's not hooked up yet.

In System.Web.UI.WebControls:
2006-03-07  Chris Toshok  <[email protected]>

	* WebControl.cs (EnableTheming): leave the MonoTODO, but implement
	by chaining up to base.EnableTheming.


svn path=/trunk/mcs/; revision=57676
2006-03-07 22:39:43 +00:00
Vladimir Krasnov 0e70eec205 * DataList.cs: fixed CreateControlHierarchy, fixes 77693
svn path=/trunk/mcs/; revision=57650
2006-03-07 08:30:02 +00:00
Vladimir Krasnov 2beb1b975f * RadioButton.cs: added ValueAttribute property to store the button value when in list
* RadioButtonList.cs: fixed tab index when rendering.

svn path=/trunk/mcs/; revision=57605
2006-03-06 08:51:26 +00:00
Chris Toshok 9cd26e2c03 In System.Web.UI:
2006-03-02  Chris Toshok  <[email protected]>

	* Control.cs (ApplyStyleSheetTheme): remove the exception, and add
	a MonoTODO.

	* Page.cs (Theme): implement setter/getter.
	(StyleSheetTheme): same.
	
	* PageParser.cs (ProcessMainAttributes): parse the Theme and
	StyleSheetTheme attributes.

In System.Web.UI.WebControls:
2006-03-02  Chris Toshok  <[email protected]>

	* WebControl.cs (SkinID): implement setter/getter, and have them
	just chain up to base.SkinID.

In System.Web.Compilation:
2006-03-02  Chris Toshok  <[email protected]>

	* TemplateControlCompiler.cs (InitMethod): emit an assignment for
	SkinID just after the creation of our object, and right after that
	call "_ctrl.ApplyStyleSheetSkin (page)".
	(CreateAssignStatementsFromAttributes): split out the majority of
	this code to CreateAssignStatementFromAttribute, and change this
	method to simply a loop over the attribute keys.  In the 2.0 case,
	skip the SkinID property, since that's handled explicitly in
	InitMethod.

	* PageCompiler.cs (AddStatementsToInitMethod): emit assignments
	for Theme and StyleSheetTheme.


svn path=/trunk/mcs/; revision=57516
2006-03-02 19:30:08 +00:00
Chris Toshok c578941eaf In System.Web.UI:
2006-02-27  Chris Toshok  <[email protected]>

	* DataSourceView.cs: Name isn't virtual.

	* DataSourceControl.cs: beat this class over the head with the
	corcompare stick.

	* DataSourceControlBuilder.cs: new stubbed control builder for
	DataSourceControl.

In System.Web.UI.WebControls:
2006-02-27  Chris Toshok  <[email protected]>

	* SqlDataSource.cs: track change to DataSourceControl's protected
	methods.

	* AccessDataSource.cs: same.


svn path=/trunk/mcs/; revision=57342
2006-02-27 18:25:36 +00:00
Vladimir Krasnov 682ef77c88 * ListControl.cs: fixed SelectedIndex property, fixed selection reset on incorrect value
svn path=/trunk/mcs/; revision=57335
2006-02-27 17:35:36 +00:00
Vladimir Krasnov a34e681bc3 TableStyle.cs: fixed AddAttributesToRender function, style
BorderCollapse:Collapse was added if table's CellSpacing is zero

svn path=/trunk/mcs/; revision=57333
2006-02-27 17:19:15 +00:00
Chris Toshok 553bc8d055 In System.Web.Compilation:
2006-02-23  Chris Toshok  <[email protected]>

	* TemplateControlCompiler.cs (AddContentTemplateInvocation): track
	change from ContentControlBuilderInternal to
	ContentBuilderInternal.
	(AddCodeRender): same.

In System.Web.UI.WebControls:
	* CheckBox.cs, ContentControlBuilderInternal.cs, Content.cs,
	ContentPlaceHolderBuilder.cs, ContentPlaceHolder.cs,
	DataControlFieldHeaderCell.cs, DataGridColumn.cs,
	HierarchicalDataBoundControl.cs, HyperLinkField.cs,
	ImageButton.cs, ImageField.cs, Literal.cs,
	ObjectDataSourceView.cs, TextBox.cs: more corcompare work.


svn path=/trunk/mcs/; revision=57221
2006-02-23 23:04:09 +00:00
Chris Toshok 5cb4398967 In System.Web.UI:
2006-02-23  Chris Toshok  <[email protected]>

	* Page.cs (ProcessCallbackData): track change to
	ICallbackEventHandler iface.

	* ICallbackEventHandler.cs: enable the proper members of this
	interface.

	* DataSourceSelectArguments.cs: reformat getter/setters.
	
In System.Web.UI.WebControls:
2006-02-23  Chris Toshok  <[email protected]>

	* BaseCompareValidator.cs, BaseValidator.cs, Button.cs,
	DataControlField.cs, DetailsView.cs, FormView.cs, GridView.cs,
	HotSpot.cs, LinkButton.cs, Login.cs, SiteMapDataSource.cs,
	SqlDataSourceCommandType.cs, TableSectionStyle.cs,
	TemplateField.cs, TreeNodeCollection.cs, TreeNode.cs, TreeView.cs,
	ValidationSummary.cs, WizardStepBase.cs: fix tons of corcompare
	errors.  most were caused by a property/method being virtual when
	it shouldn't be, or vice versa.


svn path=/trunk/mcs/; revision=57203
2006-02-23 15:21:28 +00:00
Chris Toshok ddf9be5a96 2006-02-22 Chris Toshok <[email protected]>
* ObjectDataSource.cs: corcompare work.


svn path=/trunk/mcs/; revision=57192
2006-02-23 02:54:19 +00:00
Chris Toshok 885cbe5bda 2006-02-22 Chris Toshok <[email protected]>
* ParameterCollection.cs: add an EditorAttribute to the class.

	* Parameter.cs: cleanup, fix the Value property, and implement the
	Size property.

	* SqlDataSourceView.cs: clean things up a bit, and add handling
	for parameters.


svn path=/trunk/mcs/; revision=57191
2006-02-23 02:47:50 +00:00
Chris Toshok 148d6798c3 2006-02-22 Chris Toshok <[email protected]>
* SqlDataSourceFilteringEventArgs.cs: formatting.

	* SqlDataSourceSelectingEventArgs.cs: remove ExecutingSelectCount,
	both the property and ctor arg.

	* AccessDataSourceView.cs (ExecuteSelect): use SelectingEventArgs,
	not CommandEventArgs.  Also, cast the return value of
	oleCommand.ExecuteReader.

	* AccessDataSource.cs (.ctor): fix the ctors and remove FIXME
	comments.
	(GetDbProviderFactory): implement naively, and leave a MonoTODO.
	(GetPhysicalDataFilePath): implement, again naively.  this is
	where the NRE is generated when we access ConnectionString in a
	testcase on .net.
	(ConnectionString): dynamically generate this based on our
	DataFile attribute.
	(DataFile): clear the ConnectionString in the setter so we'll
	regenerate it.
	(ProviderName): use base.ProviderName in the getter, not
	this.ProviderName, so we don't recurse infinitely.
	
	* SqlDataSourceView.cs: start reworking this class.

	* SqlDataSource.cs (GetDbProviderFactory): implement this,
	following the MS docs on the matter (if ProviderName is null/"",
	return SqlClientFactory.Instance.)
	(GetDbProviderFactoryInternal): add an internal method for use by
	SqlDataSourceView.
	(TrackViewState): don't invoke View.TrackViewState unless we have
	one.
	(Selecting): change event handler type to match MS.
	(Filtering): add missing event.
	(View): call CreateDataSourceView, don't just create an
	SqlDataSourceView.


svn path=/trunk/mcs/; revision=57169
2006-02-22 19:14:04 +00:00
Chris Toshok d29fddee2a 2006-02-21 Chris Toshok <[email protected]>
* BoundField.cs: ues the ViewState.Get* pattern with default
	instead of the explicit ViewState lookup + null check, and fix the
	scope of InitializeDataCell.


svn path=/trunk/mcs/; revision=57121
2006-02-22 01:37:14 +00:00
Chris Toshok 99bc4f7b8b 2006-02-21 Chris Toshok <[email protected]>
* ButtonField.cs: ues the ViewState.Get* pattern with default
	instead of the explicit ViewState lookup + null check.

	* CommandField.cs: same.

	* CheckBox.cs: same.

	* AutoGeneratedFieldProperties.cs: same.

	* BaseDataList.cs: same.

	* CircleHotSpot.cs: same.

	* BulletedList.cs: same.

	* DataBoundControl.cs: same.

	* CookieParameter.cs: same.

	* ControlParameter.cs: same.

	* CustomValidator.cs: same.

	* ButtonFieldBase.cs: same.

	* CheckBoxField.cs: same, and fix the scope of InitializeDataCell.

	* AutoGeneratedField.cs: fix scope of InitializeDataCell.

	* BaseValidator.cs: same, and clean up the getter/setter formatting.

	* CompareValidator.cs: same.


svn path=/trunk/mcs/; revision=57120
2006-02-22 01:13:12 +00:00
Vladimir Krasnov 7b1eaada95 * ListControl.cs: fixed DataSource property, to throw
ArgumentException on incorrect value

svn path=/trunk/mcs/; revision=57073
2006-02-20 16:29:28 +00:00
Vladimir Krasnov c6f4350fad Image.cs: fixed missing border="0" attribute, when image has style, but border width is not specified.
svn path=/trunk/mcs/; revision=57072
2006-02-20 16:09:20 +00:00
Vladimir Krasnov 754b9d76b8 * CheckBox.cs: fixed InternalAddAttributesToRender, Render to
correct the "disabled" attribute in CheckBoxList
* CheckBoxList.cs: fixed RenderItem, to correct the "disabled" attribute in CheckBoxList

svn path=/trunk/mcs/; revision=57071
2006-02-20 15:45:42 +00:00
Vladimir Krasnov df67f5c2f0 CheckBox.cs: fixed Render function, removed rendering of empty <span> element if ControlStyleCreated but it's empty.
fixed "disabled" attribute, it should be placed into span element

svn path=/trunk/mcs/; revision=57070
2006-02-20 15:01:46 +00:00
Vladimir Krasnov c8e7cf5188 BoundColumn.cs: fixed InitializeCell function, if DataField is null or empty string, the cell should not be bound.
svn path=/trunk/mcs/; revision=57068
2006-02-20 14:43:58 +00:00
Chris Toshok 56e644889c 2006-02-08 Chris Toshok <[email protected]>
* ListControl.cs (OnDataBinding): in 2.0, only clear our items if
	AppendDataBoundItems != false.  Also, split all the databinding
	logic out to DoDataBinding, which we call from here only if
	!NET_2_0.
	(DoDataBinding): new function. actually perform the binding.
	(PerformDataBinding): implement.
	(PerformSelect): chain up to base class.


svn path=/trunk/mcs/; revision=56683
2006-02-08 20:40:47 +00:00
Chris Toshok 7db12fb2e6 2006-02-07 Chris Toshok <[email protected]>
* ContentPlaceHolder.cs: fix ToolboxDataAttribute.

	* Content.cs: use ContentControlBuilderInternal, and add a bunch
	of unused (for now) EventHandler's here.

	* ContentControlBuilderInternal.cs: rename ContentControlBuilder
	to this.


svn path=/trunk/mcs/; revision=56621
2006-02-07 16:49:30 +00:00
Gonzalo Paniagua Javier fe3850a309 2006-01-24 Gonzalo Paniagua Javier <[email protected]>
* ListControl.cs: bound checking for Items when loading the control
	state, as the number might have been changed on the fly. Patch by
	Elliott Draper.


svn path=/trunk/mcs/; revision=56007
2006-01-24 21:54:40 +00:00
Chris Toshok 89e4fb7548 2006-01-22 Chris Toshok <[email protected]>
* CheckBox.cs: s/GetPostBackClientEvent/GetPostBackEventReference.

	* MultiView.cs (OnBubbleEvent): case the rhs to a string to get
	the intended comparison right and quiet mcs.


svn path=/trunk/mcs/; revision=55915
2006-01-22 20:58:37 +00:00
Konstantin Triger 5a65f8ba6b Add semicolon after client script if does not exist
svn path=/trunk/mcs/; revision=55898
2006-01-22 17:34:15 +00:00
Konstantin Triger 4ab1350f69 preserve user logic when adding client validation
svn path=/trunk/mcs/; revision=55709
2006-01-18 08:46:06 +00:00
Konstantin Triger 5343d82b47 fixing visibility bahavior
svn path=/trunk/mcs/; revision=55598
2006-01-15 13:23:27 +00:00
Gonzalo Paniagua Javier 83ff57d8ff 2006-01-13 Gonzalo Paniagua Javier <[email protected]>
* RangeValidator.cs: allow empty data from the control. Patch from Marek
	Habersack that fixes bug #77239.


svn path=/trunk/mcs/; revision=55510
2006-01-13 14:55:45 +00:00
Gonzalo Paniagua Javier c2af6f8b34 2006-01-10 Gonzalo Paniagua Javier <[email protected]>
* Calendar.cs: Modified file.


svn path=/trunk/mcs/; revision=55303
2006-01-10 16:30:10 +00:00
Konstantin Triger 145662bd35 TARGET_JVM changes to let the compilation pass with csc 1.1
svn path=/trunk/mcs/; revision=55206
2006-01-08 13:21:51 +00:00
Gonzalo Paniagua Javier 7d8b3bf80f 2005-12-08 Gonzalo Paniagua Javier <[email protected]>
* DropDownList.cs: HtmlEncode the item text. Fixes bug #76949.


svn path=/trunk/mcs/; revision=54128
2005-12-08 21:28:02 +00:00
Chris Toshok 2e6afaeadf 2005-12-07 Chris Toshok <[email protected]>
* BaseValidator.cs: in the uplevel rendering case, don't render
	the text if the validator's Display attribute is "None".  Should
	fix bug #76924.


svn path=/trunk/mcs/; revision=54021
2005-12-07 06:31:04 +00:00
Gonzalo Paniagua Javier 4fa0c3c3da 2005-11-30 Gonzalo Paniagua Javier <[email protected]>
* RadioButton.cs: if the 'value' attribute is set explicitly (as
	RadioButtonList does now), use that as the 'name' attribute.
	* RadioButtonList.cs: set the AutoPostBack and Enabled properties of
	the radiobuttons.

	Fixes bug #76706.


svn path=/trunk/mcs/; revision=53741
2005-12-01 02:02:13 +00:00
Gonzalo Paniagua Javier 3b1a44ffc1 2005-11-30 Gonzalo Paniagua Javier <[email protected]>
* CheckBox.cs: add possible 'internal' attributes to the input tag. Fix
	the 'name' attribute when not aligninng to the right.
	* RadioButton.cs: use NameAttribute instead of GroupName when indexing
	the collection. Raise the OnCheckedChanged event. Fixes bug #76710.


svn path=/trunk/mcs/; revision=53739
2005-12-01 01:37:08 +00:00
Gonzalo Paniagua Javier 3046fa752d 2005-11-30 Gonzalo Paniagua Javier <[email protected]>
* DataGrid.cs: clear the control collection on every call to
	CreateControlHierarchy. Fixes bug #76732.


svn path=/trunk/mcs/; revision=53723
2005-11-30 23:35:10 +00:00
Gonzalo Paniagua Javier 6fcdefd63b 2005-11-28 Gonzalo Paniagua Javier <[email protected]>
* ListBox.cs: Rows and SelectionMode are virtual in 1.1


svn path=/trunk/mcs/; revision=53600
2005-11-28 23:03:37 +00:00
Gonzalo Paniagua Javier 6c78824894 2005-11-21 Gonzalo Paniagua Javier <[email protected]>
* CheckBox.cs: use the NameAttribute property for setting 'name'.
	* RadioButton.cs: get a UniqueID based identifier for 'name'.
	Fixes bug #76710.


svn path=/trunk/mcs/; revision=53323
2005-11-21 20:45:14 +00:00
Gonzalo Paniagua Javier 82fa8c8b6f 2005-11-18 Gonzalo Paniagua Javier <[email protected]>
* LinkButton.cs: don't output any javascript when the linkbutton is
	disabled. Fixes bug #76713.


svn path=/trunk/mcs/; revision=53246
2005-11-18 20:37:47 +00:00
Gonzalo Paniagua Javier ffac0a0ef3 2005-11-18 Gonzalo Paniagua Javier <[email protected]>
* DataGrid.cs: use TableHeaderCell instead of TableCell for headers when
	UseAccesibleHeader property is true. Patch by Robert Jordan.


svn path=/trunk/mcs/; revision=53244
2005-11-18 19:59:16 +00:00
Gonzalo Paniagua Javier 676728d2c5 2005-11-18 Gonzalo Paniagua Javier <[email protected]>
* BaseValidator.cs: 'controltovalidate' must be the ClientID of the
	control to validate. Fixes bug #76641.


svn path=/trunk/mcs/; revision=53243
2005-11-18 19:40:45 +00:00
Gonzalo Paniagua Javier 192c30ea03 2005-11-18 Gonzalo Paniagua Javier <[email protected]>
* BoundColumn.cs: when the column is readonly and we're in edit mode,
	keep it as a TextBox. Fixes bug #76714.


svn path=/trunk/mcs/; revision=53242
2005-11-18 19:14:23 +00:00
Gonzalo Paniagua Javier 979abd5fef 2005-11-03 Gonzalo Paniagua Javier <[email protected]>
* ListBox.cs: render the 'onchange' attribute when AutoPostback is
	enabled. Fixes bug #76608.


svn path=/trunk/mcs/; revision=52529
2005-11-03 21:32:14 +00:00
Gonzalo Paniagua Javier 6190b29189 2005-11-03 Gonzalo Paniagua Javier <[email protected]>
* CheckBox.cs: AddAttributesToRender was extra in 1.1, so moved all
	the logic to Render and make it render the ID, which fixes bug #76596.


svn path=/trunk/mcs/; revision=52528
2005-11-03 21:26:49 +00:00
Gonzalo Paniagua Javier 18058a0514 2005-10-25 Gonzalo Paniagua Javier <[email protected]>
* Repeater.cs: someone forgot the curly brackets. Fixes bug 76537.


svn path=/trunk/mcs/; revision=52189
2005-10-25 16:46:37 +00:00
Gonzalo Paniagua Javier 96d9fd876d 2005-10-24 Gonzalo Paniagua Javier <[email protected]>
* Literal.cs: allow LiteralControl as child, but instead of adding it
	to the control collection, it just gets the Text out of it.


svn path=/trunk/mcs/; revision=52149
2005-10-24 20:57:13 +00:00
Gonzalo Paniagua Javier 38336a5d36 2005-10-22 Gonzalo Paniagua Javier <[email protected]>
* PagedDataSource.cs: fix range when we're at the last page.
	* DataGrid.cs: only need to keep the item count in the viewstate.
	Fixes bug #76503.


svn path=/trunk/mcs/; revision=52068
2005-10-22 20:56:53 +00:00
Gonzalo Paniagua Javier 0ffc7318e9 2005-10-20 Gonzalo Paniagua Javier <[email protected]>
* ListControl.cs: made GetSelectedIndices() internal.
	* ListBox.cs: html-encode the item text. Fixed single and multiple
	selection handling. All the tests pass now. Closes bug #76478.


svn path=/trunk/mcs/; revision=51998
2005-10-20 19:11:22 +00:00
Gonzalo Paniagua Javier 1039e0fd21 fix for 76415 + tests
svn path=/trunk/mcs/; revision=51885
2005-10-18 19:47:30 +00:00
Gonzalo Paniagua Javier f9d7d1a7f7 2005-10-17 Gonzalo Paniagua Javier <[email protected]>
* System.Web.UI/Page.cs: don't cache the 'Validate()' results.
	IsValid retests the validators again.

	* System.Web.UI.WebControls/BaseDataList.cs: Type.GetTypeCode
	was fixed and now does not throw a nullref, so we have to do
	it by ourselves here to make the test happy.

	* System.Web.UI.WebControls/BaseValidator.cs: render the text of
	the error message even if we set IsValid programatically. Don't
	use 'valid' directly, as IsValid is virtual.

	Fixes bug #76299.


svn path=/trunk/mcs/; revision=51840
2005-10-17 23:58:16 +00:00