Commit Graph
1341 Commits
Author SHA1 Message Date
Gonzalo Paniagua Javier ffac0a0ef3 2005-11-18 Gonzalo Paniagua Javier <[email protected]>
* DataGrid.cs: use TableHeaderCell instead of TableCell for headers when
	UseAccesibleHeader property is true. Patch by Robert Jordan.


svn path=/trunk/mcs/; revision=53244
2005-11-18 19:59:16 +00:00
Gonzalo Paniagua Javier 676728d2c5 2005-11-18 Gonzalo Paniagua Javier <[email protected]>
* BaseValidator.cs: 'controltovalidate' must be the ClientID of the
	control to validate. Fixes bug #76641.


svn path=/trunk/mcs/; revision=53243
2005-11-18 19:40:45 +00:00
Gonzalo Paniagua Javier 192c30ea03 2005-11-18 Gonzalo Paniagua Javier <[email protected]>
* BoundColumn.cs: when the column is readonly and we're in edit mode,
	keep it as a TextBox. Fixes bug #76714.


svn path=/trunk/mcs/; revision=53242
2005-11-18 19:14:23 +00:00
Gonzalo Paniagua Javier 979abd5fef 2005-11-03 Gonzalo Paniagua Javier <[email protected]>
* ListBox.cs: render the 'onchange' attribute when AutoPostback is
	enabled. Fixes bug #76608.


svn path=/trunk/mcs/; revision=52529
2005-11-03 21:32:14 +00:00
Gonzalo Paniagua Javier 6190b29189 2005-11-03 Gonzalo Paniagua Javier <[email protected]>
* CheckBox.cs: AddAttributesToRender was extra in 1.1, so moved all
	the logic to Render and make it render the ID, which fixes bug #76596.


svn path=/trunk/mcs/; revision=52528
2005-11-03 21:26:49 +00:00
Gonzalo Paniagua Javier 18058a0514 2005-10-25 Gonzalo Paniagua Javier <[email protected]>
* Repeater.cs: someone forgot the curly brackets. Fixes bug 76537.


svn path=/trunk/mcs/; revision=52189
2005-10-25 16:46:37 +00:00
Gonzalo Paniagua Javier 96d9fd876d 2005-10-24 Gonzalo Paniagua Javier <[email protected]>
* Literal.cs: allow LiteralControl as child, but instead of adding it
	to the control collection, it just gets the Text out of it.


svn path=/trunk/mcs/; revision=52149
2005-10-24 20:57:13 +00:00
Gonzalo Paniagua Javier 38336a5d36 2005-10-22 Gonzalo Paniagua Javier <[email protected]>
* PagedDataSource.cs: fix range when we're at the last page.
	* DataGrid.cs: only need to keep the item count in the viewstate.
	Fixes bug #76503.


svn path=/trunk/mcs/; revision=52068
2005-10-22 20:56:53 +00:00
Gonzalo Paniagua Javier c566a8586b fix the 2.0 build after my last commit
svn path=/trunk/mcs/; revision=52002
2005-10-20 19:52:43 +00:00
Gonzalo Paniagua Javier 0ffc7318e9 2005-10-20 Gonzalo Paniagua Javier <[email protected]>
* ListControl.cs: made GetSelectedIndices() internal.
	* ListBox.cs: html-encode the item text. Fixed single and multiple
	selection handling. All the tests pass now. Closes bug #76478.


svn path=/trunk/mcs/; revision=51998
2005-10-20 19:11:22 +00:00
Gonzalo Paniagua Javier 1039e0fd21 fix for 76415 + tests
svn path=/trunk/mcs/; revision=51885
2005-10-18 19:47:30 +00:00
Gonzalo Paniagua Javier f9d7d1a7f7 2005-10-17 Gonzalo Paniagua Javier <[email protected]>
* System.Web.UI/Page.cs: don't cache the 'Validate()' results.
	IsValid retests the validators again.

	* System.Web.UI.WebControls/BaseDataList.cs: Type.GetTypeCode
	was fixed and now does not throw a nullref, so we have to do
	it by ourselves here to make the test happy.

	* System.Web.UI.WebControls/BaseValidator.cs: render the text of
	the error message even if we set IsValid programatically. Don't
	use 'valid' directly, as IsValid is virtual.

	Fixes bug #76299.


svn path=/trunk/mcs/; revision=51840
2005-10-17 23:58:16 +00:00
Gonzalo Paniagua Javier d1e93f922b svn path=/trunk/mcs/; revision=51832 2005-10-17 22:10:53 +00:00
Gonzalo Paniagua Javier 0fc40b5c3b 2005-10-17 Gonzalo Paniagua Javier <[email protected]>
* CustomValidator.cs: an empty ControlToValidate is valid.


svn path=/trunk/mcs/; revision=51829
2005-10-17 21:23:41 +00:00
Sebastien Pouliot 9846dbd980 2005-10-17 Sebastien Pouliot <[email protected]>
* RequiredFieldValidator.cs: Added missing permissions.


svn path=/trunk/mcs/; revision=51801
2005-10-17 14:13:05 +00:00
Gonzalo Paniagua Javier 0f443418aa 2005-10-10 Gonzalo Paniagua Javier <[email protected]>
* DataList.cs: copied and adapted PrepareControlHierarchy from DataGrid.
	Now the items get the attributes from the styles in datalist.  Add the
	separators after each item, not before. GetItemStyle returns the actual
	item style, not the styles in the datalist. Fixes bug #76384 and all
	new tests pass.


svn path=/trunk/mcs/; revision=51506
2005-10-10 09:21:49 +00:00
Gonzalo Paniagua Javier 933e8aa1e6 2005-10-10 Gonzalo Paniagua Javier <[email protected]>
* Style.cs: add a 'border-style: solid' to make IE happy. Fixes bug
	76373.


svn path=/trunk/mcs/; revision=51501
2005-10-10 07:08:36 +00:00
Gonzalo Paniagua Javier f5ffb52231 2005-10-07 Gonzalo Paniagua Javier <[email protected]>
* TemplateColumn.cs: SelectedItem was missing from the select (). Fixes
	bug #76359.


svn path=/trunk/mcs/; revision=51390
2005-10-07 04:29:23 +00:00
Sebastien Pouliot 1b5886a996 2005-10-06 Sebastien Pouliot <[email protected]>
* FontInfo.cs: Gendarme strikes again. Sealed class have no need for 
	inheritance demands.
	* FontUnit.cs: Structs are sealed so there's no need for inheritance 
	demands.
	* Unit.cs: Structs are sealed so there's no need for inheritance 
	demands.


svn path=/trunk/mcs/; revision=51358
2005-10-06 18:49:01 +00:00
Gonzalo Paniagua Javier 8eaf30d66f 2005-10-06 Gonzalo Paniagua Javier <[email protected]>
* PagedDataSource.cs: fix the upper bound for collection and ilist
	enumarators.


svn path=/trunk/mcs/; revision=51354
2005-10-06 18:24:09 +00:00
Gonzalo Paniagua Javier 43707daedd 2005-10-06 Gonzalo Paniagua Javier <[email protected]>
* DataGrid.cs: change the ListItemType for the item selected, set
	SelectedIndex before calling OnSelectedIndexChanged and set the selected
	item type correctly when creating the columns. Fixes bug #76334.

	* ButtonColumn.cs:
	* EditCommandColumn.cs: use a ForeColorLinkbutton, otherwise when
	selecting the row, the button keep the regular link color.

	* DataGridColumn.cs: made the class internal.


svn path=/trunk/mcs/; revision=51320
2005-10-06 07:47:04 +00:00
Gonzalo Paniagua Javier 3ce9565458 2005-10-04 Gonzalo Paniagua Javier <[email protected]>
* DataGrid.cs: fix breakaga of alternating item style in one of my
	last patches.


svn path=/trunk/mcs/; revision=51150
2005-10-04 07:50:06 +00:00
Gonzalo Paniagua Javier 92ff13abd0 2005-10-04 Gonzalo Paniagua Javier <[email protected]>
* Calendar.cs: remove Console.
	* ListBox.cs: the name is the UniqueID, not the ClientID.
	* WebControl.cs: Attributes is case insensitive.


svn path=/trunk/mcs/; revision=51148
2005-10-04 07:36:02 +00:00
Gonzalo Paniagua Javier 5341053263 2005-10-04 Gonzalo Paniagua Javier <[email protected]>
* ImageButton.cs: use UniqueID in LoadPostData and also try just the
	UniqueID without appending a ".x" or ".y". Fixes several issues in
	mojoPortal. Thanks to Joe Audetter for his patience.


svn path=/trunk/mcs/; revision=51145
2005-10-04 07:09:05 +00:00
Gonzalo Paniagua Javier 4896dbb35e fix the 2.0 build
svn path=/trunk/mcs/; revision=51104
2005-10-03 04:44:39 +00:00
Gonzalo Paniagua Javier fc1ea9101e 2005-10-02 Gonzalo Paniagua Javier <[email protected]>
* ButtonColumn.cs: it was lacking databinding, so copied most of it
	from BoundColumn.


svn path=/trunk/mcs/; revision=51098
2005-10-02 23:28:15 +00:00
Gonzalo Paniagua Javier dd2bbcbd2d 2005-10-02 Gonzalo Paniagua Javier <[email protected]>
* FontInfo.cs: removed useless ctor.
	* Style.cs: keep here some commented out debugging code.
	* DataGrid.cs: the Items property does not create a new arraylist if
	the items_list was already initialized. Add case for Separator.
	* DataGridColumn.cs: when sorting is enabled, the linkbutton rendered
	in the header columns has a special ForeColor handling.


svn path=/trunk/mcs/; revision=51095
2005-10-02 22:30:45 +00:00
Gonzalo Paniagua Javier a7efa8fb2c 2005-10-02 Gonzalo Paniagua Javier <[email protected]>
* DataGrid.cs: PageCount must persist in ViewState too and returns the
	number of pages in the paged data source once we set that. Fix checks
	for visibility of the pager: no more 2 pagers when custom paging is
	enabled.


svn path=/trunk/mcs/; revision=51084
2005-10-02 06:35:30 +00:00
Gonzalo Paniagua Javier 09d65c8271 2005-09-30 Gonzalo Paniagua Javier <[email protected]>
* ImageButton.cs: fix a bug reported on the list. We were triggering the
	command event on every POST. And the 'name' attribute was not being
	rendered, so the 'x,y' coordinates didn't have 'uniqueid.' prepended
	and we couldn't find the values.


svn path=/trunk/mcs/; revision=51063
2005-09-30 23:26:09 +00:00
Gonzalo Paniagua Javier 4a9ee87e0c 2005-09-30 Gonzalo Paniagua Javier <[email protected]>
* DataGrid.cs: fix the links for the numeric pager.


svn path=/trunk/mcs/; revision=51061
2005-09-30 22:18:44 +00:00
Gonzalo Paniagua Javier 591e5b3436 2005-09-30 Gonzalo Paniagua Javier <[email protected]>
* DataGrid.cs: when paging is enable, the actual number of items is not
	the number of items rendered before the postback, but that number times
	the number of pages. Now we store the page count in the viewstate. Also,
	as the number might be big, don't allocate an array of objects to fake
	the collection for the PagedDataSource, but use the new NCollection
	class instead, which provides cheap (memory wise) enumerator for an
	arbitrary number of items. Thanks to "Adriano" for the test case.


svn path=/trunk/mcs/; revision=51027
2005-09-30 04:37:22 +00:00
Gonzalo Paniagua Javier af86cbd316 2005-09-29 Gonzalo Paniagua Javier <[email protected]>
* Xml.cs: the show must go on. Removed a few NotImplemented.


svn path=/trunk/mcs/; revision=51023
2005-09-30 02:50:50 +00:00
Gonzalo Paniagua Javier dfdec159d7 2005-09-29 Gonzalo Paniagua Javier <[email protected]>
* System.Web.UI/DesignerDataBoundLiteralControl.cs: changed autoid api.
	* System.Web.UI/DataBoundLiteralControl.cs: changed autoid api.

	* System.Web.UI/Control.cs: fixlet for UniqueID and weird test case.
	Removed PreventAutoID and only use the property to set that value.

	* System.Web.UI/LiteralControl.cs: changed autoid api.

	* System.Web.UI.WebControls/Button.cs: implemented 2.0
	RaisePostBackEvent in terms of the existing code in 1.1 (or viceversa).
	RenderContents() does nothing.

	* System.Web.UI.WebControls/DataGrid.cs: changed autoid api.

	* System.Web.UI.WebControls/EditCommandColumn.cs: only 'Update' causes
	validation.

	* System.Web.UI.WebControls/TableCell.cs: changed autoid api.
	RenderContents checks the number of controls to decide what to do, not
	the value of Text in the viewstate.

	* System.Web.UI.WebControls/TableRow.cs: changed autoid api.

	* System.Web.UI.WebControls/BoundColumn.cs: SelectedItem was missing
	when attaching a DataBind event. When we get an EditItem, we need a
	TextBox to be created and this one will be the one that gets the event.
	Changed ItemDataBinding to deal with a TextBox too.

	All tests pass now in the default profile (2 not run).


svn path=/trunk/mcs/; revision=51019
2005-09-30 02:22:33 +00:00
Gonzalo Paniagua Javier 6ea0412c5b 2005-09-29 Gonzalo Paniagua Javier <[email protected]>
* PagedDataSource.cs: fix IsLastPage. All tests pass.
	* DataGrid.cs: InitializePager always add a cell and it's brand new. No
	need to keep the old one in a field. Now all tests pass here too.


svn path=/trunk/mcs/; revision=50983
2005-09-29 05:23:34 +00:00
Gonzalo Paniagua Javier 3d8f5432c4 2005-09-28 Gonzalo Paniagua Javier <[email protected]>
* PagedDataSource.cs: don't use the properties when they just return a
	field. Fixed Count when paging is enabled. In GetEnumerator, IList goes
	before ICollection (otherwise, an IList will always fall under the
	ICollection case). The enumerator for lists will be empty if 'start'
	is beyond the list size. All existing tests pass, but one in
	DataGridTest that fails because of some problem with the paging.


svn path=/trunk/mcs/; revision=50972
2005-09-28 21:42:00 +00:00
Gonzalo Paniagua Javier bc9bd367eb 2005-09-28 Gonzalo Paniagua Javier <[email protected]>
* Style.cs: fix the 2.0 build.


svn path=/trunk/mcs/; revision=50950
2005-09-28 15:39:02 +00:00
Gonzalo Paniagua Javier 285d824d6a 2005-09-28 Gonzalo Paniagua Javier <[email protected]>
* System.Web_test.dll.sources: add new test.

	* System.Web.UI/AttributeCollection.cs: avoid code duplication and
	don't add "style" to the bag, or it will overwrite the settings made
	by CssStyleCollection.

	* System.Web.UI/CssStyleCollection.cs: make it throw where MS throws.
	Minimize the number of times we create the "style" string and take
	care of updating it for the AttributeCollection. FillStyle and
	BagToString are now private. One should use the 2.0 (internal in <2.0)
	Value property.

	* System.Web.UI.WebControls/Style.cs: avoid unnecesary creation of a
	CssStyleCollection and instead write the style attributes directly to
	the HtmlTextWriter.

	* System.Web.UI.WebControls/CheckBox.cs: adapted to new API.

	* DataGrid.cs: handle null data sources. Fixed the contions that make
	the table to be added to the Controls collection.

	* System.Web.UI.WebControls/Calendar.cs: the table needed an ID and the
	attributes from the parent. Also don't create the ControlStyleCollection
	if it has not already been created.


svn path=/trunk/mcs/; revision=50931
2005-09-28 08:05:58 +00:00
Gonzalo Paniagua Javier 711df0ad3d 2005-09-27 Gonzalo Paniagua Javier <[email protected]>
* Calendar.cs: TrackViewState should be called upon creation, not on
	every get_XXX call. Cleanup.


svn path=/trunk/mcs/; revision=50899
2005-09-27 23:46:56 +00:00
Gonzalo Paniagua Javier a04b30735d 2005-09-27 Gonzalo Paniagua Javier <[email protected]>
* DataGrid.cs: fix another test. The ID of the table generated by the
	datagrid is set to the one on the datagrid if no one set the ID for the
	table.


svn path=/trunk/mcs/; revision=50831
2005-09-27 08:02:27 +00:00
Gonzalo Paniagua Javier a9a0c2f90e 2005-09-27 Gonzalo Paniagua Javier <[email protected]>
* ListControl.cs: this fixes TestValueFieldAndTextFormat from
	DropDownListTest.


svn path=/trunk/mcs/; revision=50829
2005-09-27 07:43:52 +00:00
Gonzalo Paniagua Javier 2542cb7c58 2005-09-27 Gonzalo Paniagua Javier <[email protected]>
* FontUnit.cs: use a table for FontSize names, as the X{1,2}.* ones are
	converted to string as X{1,2}-.*. All FontUnitTests pass now.
	* Unit.cs: throw a format exception when there's not number or minus
	sign in the first non-whitespace character.


svn path=/trunk/mcs/; revision=50821
2005-09-27 06:16:55 +00:00
Gonzalo Paniagua Javier e1f2e36a5b console
svn path=/trunk/mcs/; revision=50815
2005-09-27 05:04:42 +00:00
Gonzalo Paniagua Javier 24fdf865f0 2005-09-27 Gonzalo Paniagua Javier <[email protected]>
* ListControl.cs: SelectedIndex/SelectedValue can be set before
	DataBinding () is called on the control, so we have to keep this values
	around and use them after the data is read. If both properties are
	used, they must refer to the same item.


svn path=/trunk/mcs/; revision=50814
2005-09-27 05:04:25 +00:00
Gonzalo Paniagua Javier e30432766e 2005-09-24 Gonzalo Paniagua Javier <[email protected]>
* DataList.cs: fill in the data keys from BaseDataList so that the
	events can see them. Only assign DataItem when using data binding and
	nullify it after all events are raised. Thanks to Joe Audette for quick
	updates on this.


svn path=/trunk/mcs/; revision=50695
2005-09-24 22:45:41 +00:00
Gonzalo Paniagua Javier 80bbcd29e4 2005-09-24 Gonzalo Paniagua Javier <[email protected]>
* DataList.cs: OnItemCommand() is raised any time OnBubbleEvent is
	called.


svn path=/trunk/mcs/; revision=50680
2005-09-24 18:25:30 +00:00
Sebastien Pouliot adf172ecf9 2005-09-23 Sebastien Pouliot <[email protected]>
* Button.cs: For 2.0 don't add the "name" attribute unless there's an 
	id.
	* DataGrid.cs: Fix TagKey (table) for 2.0.
	* DataList.cs: Revert 2.0 specific stuff that was changed in RC.
	* DropDownList.cs: For 2.0 don't add the "name" attribute unless 
	there's an id.
	* ListBox.cs: For 2.0 don't add the "name" attribute unless there's an
	id.
	* RoleGroupCollection.cs: Fix "extra" exception in Remove method.
	* Style.cs: Fixed (2.0) RegisteredCssClass to returns String.Empty 
	(i.e. not null).
	* TextBox.cs: For 2.0 don't add the "name" attribute unless there's an
	id.
	* TreeView.cs: Added declarative security (Link and Inheritance 
	demands) for Minimal.
	* XmlDataSource.cs: Added declarative security (Link and Inheritance
	demands) for Minimal.


svn path=/trunk/mcs/; revision=50583
2005-09-23 15:46:05 +00:00
Sebastien Pouliot 2493a78c34 2005-09-23 Sebastien Pouliot <[email protected]>
* FontUnit.cs: Added, but only for 1.x, declarative security (Link and
	Inheritance demands) for Minimal.
	* Label.cs: Added declarative security (Link and Inheritance demands) 
	for Minimal.
	* ListItem.cs: Added declarative security (LinkDemands) for Minimal.
	* ListItemCollection.cs: Added declarative security (LinkDemands) for 
	Minimal.
	* MonthChangedEventArgs.cs: Added declarative security (Link and, for 
	2.0, Inheritance demands) for Minimal.
	* PagedDataSource.cs: Added declarative security (LinkDemands) for 
	Minimal.
	* Panel.cs: Added declarative security (Link and Inheritance demands) 
	for Minimal.
	* Repeater.cs: Added declarative security (Link and Inheritance 
	demands) for Minimal.
	* RepeatInfo.cs: Added declarative security (LinkDemands) for Minimal.
	* SelectedDatesCollection.cs: Added declarative security (LinkDemands)
	for Minimal.
	* TargetConverter.cs: Added declarative security (Link and Inheritance
	demands) for Minimal.
	* Unit.cs: Added, but only for 1.x, declarative security (Link and 
	Inheritance demands) for Minimal.
	* ValidatedControlConverter.cs: Added declarative security (Link and 
	Inheritance demands) for Minimal.
	* WebColorConverter.cs: Added declarative security (Link and 
	Inheritance demands) for Minimal.
	* Xml.cs: Added declarative security (Link and Inheritance demands) 
	for Minimal.
	* ValidationSummary.cs: Added declarative security (Link and 
	Inheritance demands) for Minimal.


svn path=/trunk/mcs/; revision=50572
2005-09-23 14:10:35 +00:00
Sebastien Pouliot 41327cef90 2005-09-23 Sebastien Pouliot <[email protected]>
* UnitConverter.cs: Remove conversion from Unit (see unit tests).


svn path=/trunk/mcs/; revision=50571
2005-09-23 13:25:23 +00:00
Gonzalo Paniagua Javier 6465aa1d0d remove conflict line
svn path=/trunk/mcs/; revision=50558
2005-09-23 03:00:57 +00:00
Ben Maurer a9c49a456b oops
svn path=/trunk/mcs/; revision=50552
2005-09-23 01:24:47 +00:00