Commit Graph
448 Commits
Author SHA1 Message Date
Atsushi Eno dcdf2745d6 2004-03-27 Atsushi Enomoto <[email protected]>
* DTDReader.cs : In some places sequential parameter entity was
	  incorrectly skipped (and caused invalid result).

svn path=/trunk/mcs/; revision=24661
2004-03-27 22:00:44 +00:00
Atsushi Eno 5e6c273dd5 2004-03-24 Atsushi Enomoto <[email protected]>
* XmlDocumentNavigator.cs : MoveTo*Namespace() should not iterate
	  namespace nodes which has the same name as already-iterated nodes.
	  Also xmlns='' should not be selected, and once it appeared, default
	  namespace should not be selected anymore.

svn path=/trunk/mcs/; revision=24531
2004-03-24 18:20:14 +00:00
Atsushi Eno ca7962559c 2004-03-24 Atsushi Enomoto <[email protected]>
* XmlCharacterData.cs : ReplaceData() should reject negative integer
	  value for count argument.
	* XmlAttribute.cs, XmlAttributeCollection.cs, XmlNamedNodeMap.cs :
	  On RemoveNamedItem(), default attribute value should be restored.

svn path=/trunk/mcs/; revision=24511
2004-03-24 03:45:22 +00:00
Atsushi Eno 3aee5d6284 2004-03-24 Atsushi Enomoto <[email protected]>
* XmlAttributeCollection.cs : Remove() should throw an exception when
	  target attribute is not included in the collection.
	* XmlDocument.cs : ImportNode() should reject null node.
	* XmlNode.cs : Fixed type of exception for invalid insertion.
	  It should throw an exception not only when the owner document of the
	  reference element is different but its parent element is different.
	  Some error message improvement.

svn path=/trunk/mcs/; revision=24509
2004-03-24 02:21:48 +00:00
Atsushi Eno 0a270288b5 2004-03-21 Atsushi Enomoto <[email protected]>
* XmlReader.cs : ReadInnerXml() incorrectly tried to get output xml.
	  This fixes bug #55856.

svn path=/trunk/mcs/; revision=24384
2004-03-21 06:02:29 +00:00
Atsushi Eno 3e55c81d52 2004-03-20 Atsushi Enomoto <[email protected]>
* XmlTextWriter.cs : Fixed indentation on CDATA. This fixes bug #55828.

svn path=/trunk/mcs/; revision=24361
2004-03-20 00:35:54 +00:00
Atsushi Eno 2e584078f8 2004-03-19 Atsushi Enomoto <[email protected]>
* XmlImplementation.cs : HasFeature() returns true when strVersion
	  is null.

svn path=/trunk/mcs/; revision=24329
2004-03-19 14:31:06 +00:00
Atsushi Eno e681d0520d 2004-03-16 Atsushi Enomoto <[email protected]>
* XmlWhitespace.cs : Fixed WriteTo(). Whitespace nodes should be
	  written regardless of document's PreserveWhitespace.

svn path=/trunk/mcs/; revision=24178
2004-03-16 22:27:08 +00:00
Atsushi Eno 3df559acfa 2004-03-16 Atsushi Enomoto <[email protected]>
* XmlDocumentNavigator.cs : Value should return concatenated string for
	  sequential text nodes. Considered detached nodes, the result of
	  MoveToParent() should be checked.

svn path=/trunk/mcs/; revision=24107
2004-03-16 04:32:32 +00:00
Atsushi Eno 587c901565 2004-03-15 Atsushi Enomoto <[email protected]>
* XmlReader.cs : ReadInnerXml()/ReadOuterXml() should not bork when
	  the reader is on EndElement. Patch by Jean-Marc Andre.

svn path=/trunk/mcs/; revision=24032
2004-03-15 02:48:44 +00:00
Atsushi Eno 1d94aed7e1 2004-03-14 Atsushi Enomoto <[email protected]>
* XmlDocumentNavigator.cs : as for namespace node "xml", MS.NET seems
	  to return attribute node. It affects on IHasXmlNode.GetNode() and
	  SelectNodes()/SelectSingleNode().

svn path=/trunk/mcs/; revision=24020
2004-03-14 19:24:16 +00:00
Atsushi Eno 3210914acc 2004-03-04 Atsushi Enomoto <[email protected]>
* XmlImplementation.cs : fixity fix (I need NUnit runnable ;)

svn path=/trunk/mcs/; revision=23694
2004-03-04 16:52:12 +00:00
Atsushi Eno 4361873dd2 2004-03-04 Atsushi Enomoto <[email protected]>
* XmlImplementation.cs : forgot to commit (renaming internal case)

svn path=/trunk/mcs/; revision=23693
2004-03-04 16:41:57 +00:00
Atsushi Eno e5a9c1000b 2004-03-04 Atsushi Enomoto <[email protected]>
* XmlDocument.cs : Implementation should not return null.

svn path=/trunk/mcs/; revision=23691
2004-03-04 16:28:49 +00:00
Atsushi Eno 40c75c7f96 2004-02-25 Atsushi Enomoto <[email protected]>
* XmlTextWriterOpenElement.cs : Reset() should reset _all_ fields.
	  This fixes indentation bug.

svn path=/trunk/mcs/; revision=23436
2004-02-25 11:07:18 +00:00
Atsushi Eno ad5a737d48 2004-02-19 Atsushi Enomoto <[email protected]>
* XmlTextWriter.cs : Fixed bugzilla #54554 (incorrent end tag output).

svn path=/trunk/mcs/; revision=23246
2004-02-19 04:30:50 +00:00
Atsushi Eno 822f455b93 2004-02-16 Atsushi Enomoto <[email protected]>
* DTDAutomata.cs,
	  DTDObjectModel.cs,
	  DTDReader.cs,
	  DTDValidatingReader.cs : made classes internal.
	* XmlDocument.cs : removed extra FIXMEs.
	* XmlNamedNodeMap.cs,
	  XmlResolver.cs,
	  XmlUrlResolver.cs :
	  Fixed incorrect method signature.

svn path=/trunk/mcs/; revision=23142
2004-02-16 19:04:50 +00:00
Ben Maurer 9f5c60087b 2004-02-15 Ben Maurer <[email protected]>
* DTDValidatingReader.cs: simple optimization. there is only
	one string, skip the string builder and just return the string.

svn path=/trunk/mcs/; revision=23103
2004-02-15 05:49:49 +00:00
Atsushi Eno 27496c3d66 2004-02-13 Atsushi Enomoto <[email protected]>
* DTDObjectModel.cs, DTDReader.cs, DTDValidatingReader.cs :
	  say goodbye to sys.collections.specialized.
	  (replaced the classes in that namespace with ArrayList or Hashtable)

svn path=/trunk/mcs/; revision=23073
2004-02-13 20:08:50 +00:00
Atsushi Eno ee779c6dd8 2004-02-12 Atsushi Enomoto <[email protected]>
* XmlReader.cs : For performance reason, XmlTextReader now uses
	  base ReadInnerXml() and don't store currentTag array unnecessarily.
	* XmlTextReader.cs :
	  - Fixed GetAttribute(int) that might cause index out of range.
	  - Now it consumes the text reader by reading blocks, as MS.NET does.
	    Modified GetRemainder(), PeekChar(), ReadChar() and so on.
	  - Now it doesn't create Value string for linked nodes, unless it
	    is actually required.
	  - some code refactory.

svn path=/trunk/mcs/; revision=23041
2004-02-12 20:33:00 +00:00
Atsushi Eno d43e2ed2ea oops, commited incomplete log.
svn path=/trunk/mcs/; revision=22967
2004-02-11 03:53:40 +00:00
Atsushi Eno c37ea7b26d 2004-02-11 Atsushi Enomoto <[email protected]>
* XmlTextWriter.cs, XmlTextWriterOpenElement.cs.

svn path=/trunk/mcs/; revision=22966
2004-02-11 03:50:03 +00:00
Atsushi Eno 9bd7b7cfc6 2004-02-10 Atsushi Enomoto <[email protected]>
* XmlNode.cs : ChildNodes should not create XmlNodeListChildren
	  every time. This fix heavily improved performance.

svn path=/trunk/mcs/; revision=22937
2004-02-10 08:33:28 +00:00
Atsushi Eno 0e242ba0a0 2004-02-10 Atsushi Enomoto <[email protected]>
* XmlAttributeCollection.cs : set owner element as parent on removal
	  events (though they are not "parent" in infoset or dom context)
	* XmlElement.cs : Don't remove attributes twice (raises extraneous
	  removal events).
	* XmlNamespaceManager.cs, XmlNodeChangedEventArgs :
	  Added NET_1_2 members.

svn path=/trunk/mcs/; revision=22933
2004-02-10 05:41:09 +00:00
Atsushi Eno 8256002451 2004-02-08 Atsushi Enomoto <[email protected]>
* DTDObjectModel.cs : Limit external entity reference from DTD by 256.
	  foreach elimination.  DTDParameterEntityDeclaration should set Root.
	  Compute attribute default value without raising an error.
	  (for non-error reporting reader)
	* DTDReader.cs : Fixes for the above fixes. foreach elimination.
	* DTDValidatingReader.cs, NameTable.cs, XmlAttribute.cs,
	  XmlAttributeCollection.cs, XmlChar.cs, XmlConstruct.cs,
	  XmlDocumentFragment.cs, XmlDocumentNavigator.cs, XmlElement.cs,
	  XmlEntityReference.cs, XmlNamedNodeMap.cs, XmlNode.cs,
	  XmlText.cs : foreach elimination.
	* XmlDocument.cs, XmlSignificantWhitespace.cs, XmlWhitespace.cs :
	  foreach elimination. Removed unnecesary methods.
	* XmlTextReader.cs : code format refactory. Optimized some methods.
	  foreach elimination. Replaced Stack with string array.
	  Replaced StringBuilder with char array. Removed unnecessary methods.

svn path=/trunk/mcs/; revision=22891
2004-02-08 20:27:04 +00:00
Atsushi Eno c90d6dba5b 2004-02-06 Atsushi Enomoto <[email protected]>
* DTDValidatingReader.cs : Fixed MoveToElement() that causes incorrect
	  IsDefault and Depth.
	* XmlAttribute.cs : Fixed .ctor(). Omit more namespace check when
	  checkNamespace = false.
	* XmlNamedNodeMap.cs : Fixed SetNamedItem() to raise events.
	* XmlAttributeCollection.cs : Reimplemented InsertAfter to use
	  InsertBefore() (similar to XmlNode).
	* XmlDocument.cs : Added internal .ctor().  Reimplemented ReadNode()
	  as recursive, to make event order compatible.
	* XmlDocumentType.cs : Use SetNamedItem() (to raise events).
	* XmlElement.cs : Some refactory.  Fixed SetAttributeNode() with
	  string name to block prefixed name.
	* XmlEntity.cs : Don't raise events on setting contents.
	* XmlNode.cs : Some refactory. Added raiseEvent argument to internal
	  InsertBefore().
	* XmlEntityReference.cs : related fix for XmlNode change.
	* XmlTextReader.cs : When the reader is on "attributes" of xmldecl or
	  doctype, Depth 1 lower than usual attribute. Split large function.

svn path=/trunk/mcs/; revision=22799
2004-02-05 16:05:56 +00:00
Atsushi Eno ad968a22b0 2004-02-05 Atsushi Enomoto <[email protected]>
* XmlConvert.cs : ToSingle() and ToDouble() should be culture
	  independent. Patch by Rodolfo Campero.

svn path=/trunk/mcs/; revision=22779
2004-02-05 03:10:05 +00:00
Atsushi Eno fdf21b83be 2004-02-04 Atsushi Enomoto <[email protected]>
* DTDObjectModel.cs : Never expand entity on ScanEntityValue().
	* DTDValidatingReader.cs : XmlDeclaration node requires attributes
	  to be movable.
	* XmlAttribute.cs,
	  XmlDocument.cs,
	  XmlDocumentFragment.cs,
	  XmlElement.cs,
	  XmlEntity.cs,
	  XmlLinkedNode.cs,
	  XmlNode.cs,
	  XmlNotation.cs :
	  Added namespace checking flag (required for such xml readers
	  that holds Namespaces=false). Now only XmlNode holds LastLinkedNode.
	* XmlDocumentType.cs,
	  XmlEntity.cs,
	  XmlEntityReference.cs : The children of Entity and EntityReference
	  became correct. They now holds parsed nodes, but it is only when
	  they are appended to the document.
	* XmlNode.cs : Modified insertBeforeIntern() to InsertBefore() with
	  boolean checkNodeType argument.  This method also tries to create
	  Entity's and EntityReference's child nodes.  Also added internal
	  RemoveChild() with boolean checkNodeType argument.
	* XmlNodeReader.cs : Quick hack for ResolveEntity() that became
	  broken with these changes. use InnerXml as input to entityReader.
	* XmlTextReader.cs : XmlDeclaration's value LocalName should be the
	  same as Name.  The names of DTD's pseudo attributes should be empty.
	  Fixed DTD node's Depth (was regarded as attribute value's depth).

svn path=/trunk/mcs/; revision=22767
2004-02-04 17:48:06 +00:00
Atsushi Eno a540306d7f 2004-02-03 Atsushi Enomoto <[email protected]>
* XmlTextReader.cs, DTDReader.cs : fixity fix ;)

svn path=/trunk/mcs/; revision=22744
2004-02-03 15:28:44 +00:00
Atsushi Eno 80b1ad3644 2004-02-03 Atsushi Enomoto <[email protected]>
* ChangeLog : Fixed incorrect description that should be written for
	  DTDValidatingReader.cs but written for DTDReader.cs.
	* DTDValidatingReader.cs : Fixes described in the last DTDReader fix.

	* XmlChar.cs,
	  XmlConstructs.cs : Made XmlChar and XmlConstructs equivalent and
	  replaced XmlChar with XmlConstruts, renaming "XmlChar" to
	  "XmlCharCompact" and "XmlConstructs" to "XmlChar".
	  (XmlChar will be used for compact framework.)
	* DTDReader.cs, XmlParserInput.cs, XmlTextReader.cs :
	  XmlChar related changes.  Support for surrogate pair.
	  It cannot use TextReader's peek anymore (for surrogate pair).
	  Character range check for PI value, attribute value, text
	* XmlTextWriter.cs : Change openElements from Stack to ArrayList.
	  (It calls ToArray() every time.)

svn path=/trunk/mcs/; revision=22741
2004-02-03 15:04:03 +00:00
Alon Gazit 044ccb28ca now Item(int index) returns null for nodeList.Count
instead of throwing ArgumentOutOfRangeException.

svn path=/trunk/mcs/; revision=22736
2004-02-03 12:46:45 +00:00
Atsushi Eno 949ccf26e7 2004-02-03 Atsushi Enomoto <[email protected]>
* XmlChar.cs : now GetPredefinedEntity() returns int and -1 for not
	  predefined entity names.
	* DTDObjectModel.cs : DTDxxxCollection now derives from
	  - DTDCollectionBase that derives from DictionaryBase.
	  - "Literal value" and "replacement text" are handled differently.
	  - Throw XmlException when external entity could not be resolved.
	  - Return ReplacementText for EntityValue.
	* DTDReader.cs :
	  - Support IXmlLineInfo.
	  - Fixed IGNORE section handling to be more strict.
	  - Compute replacement text on reading entity declarations.
	  - Don't expand char references before getting literal entity value.
	  - Check not allowed parameter entity inside internal subset.
	  - Added ValidateWhitespaceNode() to check whitespace's Validity
	    Constraints on external elementdecl and standalone document.
	  - When invalid data against its datatype was found, don't throw
	    parse error.
	  - Other code refactory.
	* XmlTextReader.cs :
	  - Check for invalid Text pattern "]]>" should not depend on line
	    info since it might not be supported.
	  - Check referenced character's validity (WFC).

svn path=/trunk/mcs/; revision=22730
2004-02-03 08:07:35 +00:00
Atsushi Eno fa84bb251d 2004-01-28 Atsushi Enomoto <[email protected]>
* DTDReader.cs : Added Normalization.  Parameter Entity declaration
	  should block invalid characters. (GEDecl should be fixed as well.)
	* XmlConstruct.cs : Should allow surrogate chars.
	* XmlNotation.cs : When prefix is empty (i.e. almost all cases)
	  Name should not add ':'. Patch by Boris Kirzner.
	* XmlTextReader.cs : Modified private ReadCharacterReference() to
	  return the character (or -1 when should not return anything).
	  Now Text character reference are checked their character range.
	  Set DTDReader.Normalization as well as the reader itself.

svn path=/trunk/mcs/; revision=22580
2004-01-28 16:27:49 +00:00
Atsushi Eno 2ea27f0a02 2004-01-28 Atsushi Enomoto <[email protected]>
* DTDReader.cs : Make sure that parameter entities are not allowed
	  inside internal subset unless it appears as a markupdecl.
	* DTDValidatingReader.cs : ENTITY or ENTITIES type attributes must have
	  a value that indicates *unparsed* entity (i.e. NDATA required).

svn path=/trunk/mcs/; revision=22567
2004-01-28 07:21:05 +00:00
Atsushi Eno acc5410984 2004-01-26 Atsushi Enomoto <[email protected]>
* XmlTextWriter.cs : quick performance fix.
	  Reduced memoty allocation (e.g. 12% when writing XMLSchema.xsd.)

svn path=/trunk/mcs/; revision=22514
2004-01-26 20:03:50 +00:00
Atsushi Eno 5dc2265c13 2004-01-26 Atsushi Enomoto <[email protected]>
* DTDObjectModel.cs :
	  - DTDNode's BaseURI should not always refer to that of DTD's.
	  - Use absolute URI's .ToString() instead of AbsolutePath.
	* DTDReader.cs : Throw XmlException for illegal character references.
	* DTDValidatingReader.cs :
	  - Share XmlResolver when the actual reader is XmlTextReader.
	    (MS's XmlValidatingReader and XmlTextReader do this.)
	  - Added its own EntityHandling property.
	* XmlValidatingReader.cs : Share XmlResolver with XmlTextReader.
	* XmlReader.cs,
	  XmlTextReader.cs : Added new NET_1_2 members.
	* XmlElement.cs : Removed extra lines (caused by XmlTextWriter bugs).
	* XmlEntityReference.cs : Forgot to add, the real fix by Boris.

svn path=/trunk/mcs/; revision=22509
2004-01-26 18:25:39 +00:00
Atsushi Eno 9525b3d1b8 2004-01-23 Atsushi Enomoto <[email protected]>
* XmlWriter.cs, XmlTextWriter.cs :
	  Several namespace related fixes.
	  - Current element's NamespaceURI should be immediately available
	    after the call of WriteStartElement() for LookupPrefix(), so
	    AddMissingElementXmlns() only affects on output. This is
	    now identified by shouldCheckElementXmlns field.
	  - Attribute's overraped xmlns should be ignored for LookupPrefix(),
	    Especially, when the owner element is written with the default
	    namespace. HOWEVER, the attribute should be *written*. This is
	    identified by shouldAddSavedNsToManager field.
	  - In AddMissingElementXmlns(), non-empty prefix namespace was not
	    checked user-written attributes.
	  - XmlWriter.WriteAttributeString() never supplies namespace URI for
	    xmlns attributes for other versions than NET_1_0. Instead, added
	    ns check logic in WriteStartAttribute() only with NET_1_0.
	  - WriteEndAttribute() should reject zero-length namespace for
	    non-default xmlns declarations.
	  - LookupPrefix() should reject argument null and empty.

svn path=/trunk/mcs/; revision=22442
2004-01-23 20:16:10 +00:00
Atsushi Eno 516d8f8acc 2004-01-22 Atsushi Enomoto <[email protected]>
* XmlElement.cs : Reverted previous fix since it broke monodoc web
	  service.

svn path=/trunk/mcs/; revision=22411
2004-01-22 20:17:29 +00:00
Atsushi Eno 48199379da 2004-01-20 Atsushi Enomoto <[email protected]>
* XmlNode.cs : When adding a node to child list, it should reject its
	  ancestors. Patch by Boris Kirzner.
	* XmlNodeReader.cs : Related fix to the fix above. It should not move
	  to children of XmlEntityReference nodes.
	* XmlTextWriter.cs : FixedWriteStartElement() not to write default
	  namespace when ns is null (while ns is "", it writes default ns).
	* XmlElement.cs : Fixed WriteTo() to call WriteStartElement(localName)
	  when NamespaceURI is an empty string.

svn path=/trunk/mcs/; revision=22286
2004-01-20 07:39:06 +00:00
Atsushi Eno 29173cdaf7 2004-01-14 Atsushi Enomoto <[email protected]>
* XmlNode.cs : When adding a node to child list, it should reject its
	  ancestors. Patch by Boris Kirzner.

svn path=/trunk/mcs/; revision=22107
2004-01-15 10:48:23 +00:00
Atsushi Eno 4a3a3b770d 2004-01-14 Atsushi Enomoto <[email protected]>
* XmlAttribute.cs : when set a value, it is no longer default
	  (even if the value is the same as default value).
	* XmlAttributeCollection.cs : Remove() should recover default attribute
	  value to default, not specified value.
	  Patch by Boris Kirzner (modified a bit)
	* XmlDocument.cs : Reference to undeclared entity is not allowed in
	  Load(), while allowed in ReadNode(). Added such distinguishing logic.

svn path=/trunk/mcs/; revision=22052
2004-01-14 07:55:50 +00:00
Atsushi Eno 6ed2623468 2004-01-13 Atsushi Enomoto <[email protected]>
* XmlValidatingReader.cs : Throw exception only in case of errors.
	  Added NET_1_2 Evidences property.

svn path=/trunk/mcs/; revision=22012
2004-01-13 09:07:20 +00:00
Atsushi Eno dc421281b0 2004-01-12 Atsushi Enomoto <[email protected]>
* XmlElement.cs : Fixed .ctor(). Default attribute was not treated as
	  Specified = false. Patch by Boris Kirzner.

svn path=/trunk/mcs/; revision=22004
2004-01-13 03:25:01 +00:00
Eran Domb c1638d2b25 Fix a big in Close () method - close the underlying stream.
svn path=/trunk/mcs/; revision=21942
2004-01-11 14:36:31 +00:00
Atsushi Eno 9bf15946b2 2004-01-11 Atsushi Enomoto <[email protected]>
* XmlException.cs : Fixed incorrect .ctor signature.
	* XmlParserInput.cs : Fixed in sync with the above fix.

svn path=/trunk/mcs/; revision=21936
2004-01-11 10:47:33 +00:00
Atsushi Eno e66ea433af 2004-01-08 Atsushi Enomoto <[email protected]>
* XmlAttribute.cs, XmlElement.cs :
	  Fixed incorrect protected .ctor modification.

svn path=/trunk/mcs/; revision=21836
2004-01-08 02:52:39 +00:00
Nick Drochak 9c0bba9060 2004-01-08 Nick Drochak <[email protected]>
* DTDValidatingReader.cs: Removed unused variable

svn path=/trunk/mcs/; revision=21815
2004-01-07 15:08:37 +00:00
Atsushi Eno 779b2bb2f0 2004-01-07 Atsushi Enomoto <[email protected]>
* XmlNamespaceManager.cs : Implemented .NET 1.2 methods that take
	  atomizedNames argument.
	* XmlTextReader.cs : Use new namespace manager methods.
	  Reduced NameTable.Add().
	* DTDObjectModel.cs : fixed incorrectly commented-out line.

svn path=/trunk/mcs/; revision=21810
2004-01-07 14:46:43 +00:00
Atsushi Eno aa61a23fc0 2004-01-07 Atsushi Enomoto <[email protected]>
* XmlAttribute.cs, XmlDocument.cs, XmlElement.cs :
	  set_Prefix should atomize to name table.
	  Avoided extraneous atomization attempt a bit.

svn path=/trunk/mcs/; revision=21803
2004-01-07 12:26:28 +00:00
Atsushi Eno 65b863c896 2004-01-07 Atsushi Enomoto <[email protected]>
* DTDObjectModel.cs, DTDReader.cs, XmlSecureResolver.cs :
	  avoiding obvious exception.
	* DTDReader.cs, XmlTextReader.cs : Some optimization.
	  Avoided extraneous PeekChar() and reduced name string creation.

svn path=/trunk/mcs/; revision=21797
2004-01-07 09:05:23 +00:00