Commit Graph
10 Commits
Author SHA1 Message Date
Marek Habersack 7aa27e68e9 2009-08-24 Marek Habersack <[email protected]>
* TemplateBuildProvider.cs: ExtractDependencies checks if the
	input has already been parsed/compiled and, if yes, adds
	dependencies from the TemplateParser to the list of the ones
	extracted locally. Fixes bug #377915

	* GenericBuildProvider.cs: added Parsed property.

svn path=/trunk/mcs/; revision=140502
2009-08-24 12:34:56 +00:00
Marek Habersack 8aa3c10397 2009-05-04 Marek Habersack <[email protected]>
* ThemeDirectoryBuildProvider.cs: use new AspGenerator constructor
	which takes AspComponentFoundery as its
	parameter. AspGenerator.RootBuilder isn't initialized until after
	the parser is initialized.

	* TemplateControlCompiler.cs: make sure to call
	ProcessGeneratedCode on each instance of ControlBuilder after it's
	fully generated. Fixes bug #500075

	* TemplateBuildProvider.cs: moved the directive regex to
	AspGenerator

	* BaseCompiler.cs: added two internal properties, BaseType and
	DerivedType, which are used in calls to
	ControlBuilder.ProcessGeneratedCode. Fixes bug #500075

	* AspGenerator.cs: implemented a work around for our parser
	limitation which is unable to extract the page/control's base type
	before parsing the actual file contents. This is necessary to
	support ASP.NET MVC's "generic" Inherits attribute. The reason we
	need to find out what the base type is before parsing the file is
	that we need to look at the type's custom attributes to see if a
	root control builder type is specified (which is what ASP.NET MVC
	does) and, if yes, use it instead of the default type. Fixes bug
	#500075

2009-05-04  Marek Habersack  <[email protected]>

	* TemplateParser.cs: take RootBuilder from the associated
	generator.
	Allow the main page directive to be added twice if the parser
	needs it. Used by AspGenerator when extracting the inherited type
	name before actual parsing. Fixes bug #500075

	* FileLevelControlBuilderAttribute.cs,
	FileLevelPageControlBuilder.cs, FileLevelUserControlBuilder.cs:
	implemented

	* ControlBuilder.cs: added a new internal property,
	DataBindingMethod.
	Implemented ProcessGeneratedCode.

svn path=/trunk/mcs/; revision=133500
2009-05-04 13:29:32 +00:00
Marek Habersack 73f04c137f 2009-03-23 Marek Habersack <[email protected]>
* TemplateBuildProvider.cs: add values of the CodeFile and Src
	page/master/control directives to the list of file dependencies.
	Extract language also for master/page, not only for controls.

	* PageCompiler.cs: CreateConstructors now triggers master page
	build, if the current page is using one. Fixes bug #487857

svn path=/trunk/mcs/; revision=130082
2009-03-23 19:58:36 +00:00
Marek Habersack 39c6840184 2009-03-12 Marek Habersack <[email protected]>
* BuildManager.cs, BuildManagerDirectoryBuilder.cs,
	BuildProvider.cs, TemplateBuildProvider.cs: dependencies are
	returned as an IDictionary <string, bool>. Dependencies must be
	compared case-insensitively.

svn path=/trunk/mcs/; revision=129142
2009-03-12 14:27:12 +00:00
Marek Habersack 709407a75f 2009-03-12 Marek Habersack <[email protected]>
* TemplateBuildProvider.cs: ExtractReferenceDependencies must also
	extract the value of the Page attribute.

svn path=/trunk/mcs/; revision=129141
2009-03-12 14:27:01 +00:00
Marek Habersack 86b4448d43 2009-01-22 Marek Habersack <[email protected]>
* Makefile (net_2_0_dirs): added System.Web - it now depends on
        System.Core, so it needs to be recompiled one more time after
        System.Core is done.

2009-01-22  Marek Habersack  <[email protected]>

        * System.Web.dll.sources: added
        System.Web.Compilation/BuildManagerCacheItem.cs,
        System.Web.Compilation/BuildManagerDirectoryBuilder.cs,
        System.Web.Compilation/BuildProviderGroup.cs

        * Makefile (SYSTEMCORE_DEP): added. Defines SYSTEMCORE_DEP on the
        mcs command line when System.Core is present.
        Added the DEVEL define, which defines DEVEL on the mcs command
        line. This is used to conditionally compile development helper code in
        System.Web.Util.FileUtils (and possibly other stuff later on)

2009-01-22  Marek Habersack  <[email protected]>

        * XsdBuildProvider.cs: added missing BuildProviderAppliesTo
        attribute.

        * BuildProvider.cs: added new internal virtual method,
        ExtractDependencies() whose purpose is to extract virtual path
        dependencies without compiling the code, if possible.
        
        * TemplateBuildProvider.cs: implemented the new
        ExtractDependencies () method which uses regular expressions to
        extract file dependencies from the source without having to
        compile the file.

        * CompilationException.cs: added a new public property, Results,
        which returns the compilation results.

        * BuildProviderGroup.cs: added. A simple class descending from
        List <BuildProvider> which is used to hold a compilation batch -
        that is a collection of BuildProvider instances.

        * BuildManagerDirectoryBuilder.cs: new class which takes care of
        generating compilation batches for the requested virtual path. A
        set of batches is generated from files found in the same virtual
        directory as the requested virtual path and all of the
        dependencies of those files. All files are grouped in batches
        within which no file depends upon its siblings. An attempt is made
        to sort the batches from the "least dependent" to the "most
        dependent" batches - i.e. the batches which do not depend on other
        batches go to the top.
        Code generating the batches now correctly detects dependency loops
        and throws an exception when one is encountered.
        Batches are represented as instances of a new class -
        BuildProviderGroup.

        * BuildManagerCacheItem.cs: added. Contains all the compilation
        result information needed by BuildManager. See below.

        * BuildManager.cs: complete batch building rewrite:
         - only one build lock is held instead of a set of compilation
           tickets. Only one thread can compile anything at one given
           time.
         - retrieving types from the build cache now uses a slim rw lock,
           so that readers aren't blocked while compilation is in
           progress. Writer lock is acquired only when adding a newly
           compiled type to the build cache and when removing it after its
           dependencies made it invalid.
         - assembly references for each compilation are now collected
           dynamically as the source is being compiled, this removed a lot
           of complexity in dealing with assembles containing conflicting
           types. As a consequence right now there may exist several
           loaded assemblies containing the same type, but only the latest
           of them will be used in new compiles.
         - the thread compiling code can recurse into the Build method
           which causes the recursively referenced code to be compiled
           into a separate, uniquely named, assembly. This deals with all
           recursion loops and dependency problems.
         - automatic app domain restart after a certain number of compiles
           is enabled now.
         - improved compilation error handling. If a compilation error
           occurs, the code attempts to recompile the assembly up to 3
           times, each time removing from the batch the files/virtual
           paths which failed parsing/compilation. If the attempts failed,
           another one is made to compile only the virtual path requested
           by the calling code. Only should that fail a compilation
           exception is thrown. All the compilation errors are written to
           stdout if the application is in the debug mode.
         - changed assembly naming. It now generates assembly names based
           on whether the compilation is recursive and whether the batch
           being compiled contains more than one code unit or
           not.
         - compilation results are now stored in the cache as instances of
           the new BuildManagerCacheItem class, which contains all the
           information required by BuildManager to return types,
           assemblies, dependencies etc.
         - GetReferencedAssemblies now correctly returns only the
           assemblies defined in the .config files.
         - GetVirtualPathDependencies does not need to compile code
           anymore in order to extract virtual path dependencies. New code
           in BuildProvider.ExtractDependencies () takes care of that.
         - a BuildManagerDirectoryBuilder class instance is used to
           generate compilation batches.

        * AssemblyBuilder.cs: added support for keeping track of which
        code unit was generated by which BuildProvider andr which
        BuildProvider produced a given source file. Both changes serve the
        purpose of dealing with compilation errors in BuildManager.

        * ApplicationFileBuildProvider.cs: added missing
        BuildProviderAppliesTo attribute

2009-01-22  Marek Habersack  <[email protected]>

        * FileUtils.cs: added two conditionally compiled methods (they
        require DEVEL to be defined) which output lines to a log file.

2009-01-22  Marek Habersack  <[email protected]>

        * WebTest.cs: Run () sets the internal field
        BuildManager.suppressDebugModeMessages to true.

2009-01-22  Marek Habersack  <[email protected]>

        * Web.mono.config: added numRecompilesBeforeAppRestart attribute
        to the compilation element, set to 100000, to avoid appdomain
        restarts during tests.



svn path=/trunk/mcs/; revision=124179
2009-01-22 11:40:22 +00:00
Marek Habersack 4944213e17 2008-06-30 Marek Habersack <[email protected]>
* AspGenerator.cs: hush the warnings and fix invalid type
	comparison.

	* AssemblyBuilder.cs: hush the warnings and add some debugging
	CWLs.

	* AspParser.cs, AppResourcesCompiler.cs, TemplateBuildProvider.cs,
	CachingCompiler.cs, BaseCompiler.cs, TemplateControlCompiler.cs,
	SimpleBuildProvider.cs, BuildManager.cs: hush the warnings

2008-06-30  Marek Habersack  <[email protected]>

	* HtmlForm.cs: hush the warnings

2008-06-30  Marek Habersack  <[email protected]>

	* ObjectDataSourceView.cs, Menu.cs, DataList.cs,
	CustomValidator.cs: hush the warnings

2008-06-30  Marek Habersack  <[email protected]>

	* MachineKeyRegistryStorage.cs: hush the warnings

2008-06-30  Marek Habersack  <[email protected]>

	* SqliteMembershipProvider.cs, SqliteRoleProvider.cs: remove
	unused method

	* SqlRoleProvider.cs, AspNetDBSchemaChecker.cs: hush the warnings

2008-06-30  Marek Habersack  <[email protected]>

	* UserControlParser.cs: hush the warnings and remove unnecessary
	code.

	* ControlCachePolicy.cs, PageParser.cs, ControlBuilder.cs,
	TemplateParser.cs, SimpleWebHandlerParser.cs, TemplateControl.cs,
	ApplicationFileParser.cs: hush the warnings

	* Page.cs: Context is protected internal in .NET 3.5
	Initialize encryption IVs before returning the transform.

	* Control.cs: Hush the warnings.

2008-06-30  Marek Habersack  <[email protected]>

	* HttpRuntime.cs, HttpApplication.cs: hush the warnings

	* HttpContext.cs: Hush the warnings.

2008-06-30  Marek Habersack  <[email protected]>

	* SqliteProfileProvider.cs: remove unused method

2008-06-30  Marek Habersack  <[email protected]>

	* CompilationSection.cs: hush the warnings



svn path=/trunk/mcs/; revision=106886
2008-06-30 13:20:58 +00:00
Marek Habersack 1e9e697cc9 2008-04-07 Marek Habersack <[email protected]>
* VirtualPath.cs: added

2008-04-08  Marek Habersack  <[email protected]>

	* System.Web.dll.sources: added System.Web/VirtualPath.cs

2008-04-08  Marek Habersack  <[email protected]>

	* DefaultVirtualDirectory.cs: fixed the constructor - derive
	virtual directory from the original path.
	AddDirectories and AddFiles combine the virtual paths properly
	now.

2008-04-08  Marek Habersack  <[email protected]>

	* TemplateParser.cs: CodeFile/Src handling uses
	HostingEnvironment.VirtualPathProvider to check for file
	existence.

2008-04-08  Marek Habersack  <[email protected]>

	* TemplateParser.cs: CodeFile/Src handling uses
	HostingEnvironment.VirtualPathProvider to check for file
	existence.

2008-04-08  Marek Habersack  <[email protected]>

	* AppCodeCompiler.cs: VirtualPath used in PhysicalToVirtual.

	* BuildManager.cs: switched to VirtualPath instead of a string
	path in several methods.
	Batch compilation is turned off if we have a custom
	VirtualPathProvider which implements only the VirtualFile and
	falls back to DefaultVirtualDirectory implementation for directory
	access.

	* GenericBuildProvider.cs: AddCodeFile accepts a virtual path.

	* BuildProvider.cs: SetVirtualPath accepts a VirtualPath now.

	* AssemblyBuilder.cs: constructors use the new VirtualPath class
	now.
	AddCodeFile can use the VirtualPathProvider if necessary now.
	BuildAssembly overloads accept VirtualPath parameter instead of a
	string path now.

	* TemplateBuildProvider.cs: GetCodeBehindSource returns the
	virtual path now.

svn path=/trunk/mcs/; revision=100063
2008-04-07 23:00:16 +00:00
Marek Habersack 8fae71a7b0 2008-02-05 Marek Habersack <[email protected]>
* GenericBuildProvider.cs: introduced a new abstract method,
	GetReferencedAssemblies, which is called on descendant builders to
	get a list of assemblies referenced by the parsed file. Fixes bug
	#357499.

	* AssemblyBuilder.cs: added a new overload of the
	AddAssemblyReference method, to be used by build providers to
	register assemblies collected by the corresponding parser.

	* TemplateBuildProvider.cs, SimpleBuildProvider.cs: implemented
	overload of the new abstract method GetReferencedAssemblies.

svn path=/trunk/mcs/; revision=94873
2008-02-05 12:13:31 +00:00
Marek Habersack e71f514f40 2008-01-24 Marek Habersack <[email protected]>
* WebHandlerBuildProvider.cs: derive from the new
	SimpleBuildProvider class.

	* BuildManager.cs: full implementation of the batch compilation
	for the 2.0 profile. The implementation is most probably different
	to MS.NET's but the effects are the same (or nearly the same -
	there are some minor differences). There are missing bits and
	pieces, but minor ones - to be added later.

	* SimpleBuildProvider.cs: new build provider abstract class
	deriving from the GenericBuildProvider that implements common code
	for building web handlers and web services.

	* GenericBuildProvider.cs: new generic abstract class used to
	implement base builder code for all the build provider types and
	maximize code reuse.

	* PageBuildProvider.cs: derive from the new TemplateBuildProvider
	class and implement all the necessary abstract members. 
	Handle "fake" virtual paths, to properly support generating of the
	WSDL helper code.

	* BuildProvider.cs: SetVirtualPath now converts the passed path to
	absolute URL.
	Added internal virtual method GenerateCode, used by derived
	classes.
	SetCommonParameters no longer sets the referenced assemblies, this
	is done in BuildManager now.
	Added an internal virtual property CodeUnit which returns the
	build provider's compilation unit.

	* PageCompiler.cs: fix assignment of base types for asynchronous
	pages, to match MS.NET.
	For asynchronous pages, add the necessary methods generation.

	* BaseCompiler.cs: default namespace is now set using a constant.
	Renamed the Init method into ConstructType, to better reflect its
	purpose and made the method internal - it is used by the build
	providers.
	Added several CreateProvider overloads for easier and more unified
	compilation provider creation.
	Added an internal MainClassType property to enable class type name
	retrieval from other parts of the class hierarchy.

	* ApplicationFileBuildProvider.cs: new build provider deriving
	from the TemplateBuildProvider class to compile the global.asax
	file.

	* AspGenerator.cs: properly handle parsers which have no input
	file path given, but use TextReader instead.
	Dependencies are virtual paths now, convert them to physical ones
	before creating cache dependency.

	* CachingCompiler.cs: parser dependencies are virtual paths now,
	convert them to physical ones before creating cache dependency.

	* AssemblyBuilder.cs: full implementation of the documented
	functionality as well as a lot of internal build code
	added. Produces assemblies using the same style what MS.NET for
	temporary and target file naming. Handles partial type squashing
	if the same partial type is used by several code compile units
	added to the same builder instance.

	* MasterPageBuildProvider.cs: use the new TemplateBuildProvider
	base class and add implementation of all the abstract methods
	required by it.

	* ThemeDirectoryBuildProvider.cs: new build provider to compile
	theme directories. Replaces the old ThemeDirectoryCompiler class.

	* UserControlBuildProvider.cs: use the new TemplateBuildProvider
	base class and add implementation of all the abstract methods
	required by it.

	* TemplateBuildProvider.cs: new internal abstract class which
	implements the common tasks for all the template control build
	providers.

	* WebServiceBuildProvider.cs: use the new SimpleBuildProvider base
	type to implement building.

2008-01-24  Marek Habersack  <[email protected]>

	* PageThemeFileParser.cs: the DefaultBaseType property removed.

	* ApplicationFileParser.cs: added constructor which takes a
	TextReader.
	Removed the DefaultBaseType property.
	Added the Reader property.

	* MasterPage.cs: use BuildManager to create page instance.

	* WebHandlerParser.cs: added a compatibility constructor.

	* TemplateControl.cs: GetTypeFromControlPath uses
	BuildManager.GetCompiledType for the 2.0+ profile.

	* WebServiceParser.cs: added a compatibility internal
	constructor.

	* SimpleWebHandlerParser.cs: properly treat context and
	physicalPath parameters to the constructor, especially for the
	2.0+ profile where they are obsolete.
	Dependencies are added using virtual paths.

	* PageThemeParser.cs: DefaultBaseType property removed.

	* Page.cs: Style sheets and themes are compiled using
	BuildManager.
	Previous page instance is compiled using BuildManager for the 2.0+
	profile.

	* MasterPageParser.cs: Use BuildManager to create instance and
	compile types.
	Dependencies are added using virtual paths.

	* SimpleHandlerFactory.cs: Use
	BuildManager.CreateInstanceFromVirtualPath for the 2.0+ profile.

	* UserControlParser.cs: if the parser is created using a
	TextReader, take the input file path from the virtual path.
	Added a new internal constructor which takes both a TextReader and
	an inputFile parameters.
	Set base type to the default in the constructors.
	Use virtual path when setting master page dependency.
	DefaultBaseTypename doesn't use a literal string in the 2.0+
	profile, it gets the base type from the application
	configuration.

	* TemplateControlParser.cs: Dependency on a control/page mentioned
	in the Reference directive is registered using the virtual path.
	TextReader property is an override now.

	* TemplateParser.cs: RegisterCustomControl adds a dependency on
	the virtual path, not the physical path. The custom control is
	compiled using BuildManager.GetCompiledType for the 2.0+ profile.
	RegisterNamespace does not add a dependency on the assembly.
	LoadType does not add a dependency on the assembly.
	Legacy Src attribute is handled properly now.
	Dependency on code-behind (Src and CodeFile directive attributes)
	is added using the code-behind file's virtual path.
	GetAssemblyFromSource adds a dependency using the virtual path.
	DefaultBaseType implemented here, using DefaultBaseTypeName which
	is implemented in the descendant classes.
	Added internal CodeBehindSource property, used by build
	providers.
	ClassName property works correctly if inputFile is missing
	(e.g. when the parser has been created using a TextReader)
	Added a virtual internal property TextReader to return the readed
	which has been used to create the parser instance.

	* PageHandlerFactory.cs: GetHandler uses
	BuildManager.CreateInstanceFromVirtualPath for the 2.0+ profile.

	* PageParser.cs: set the default base type in the constructors.
	If the input file is not passed to a constructor, take the input
	file path from the virtual path.
	GetCompiledPageInstance uses BuildManager.CreateInstanceFromVirtualPath
	for the 2.0+ profile.
	MasterPage dependency is set using the virtual path of the master
	page.
	MasterPage is compiled into a type using BuildManager.GetCompiledType.
	GetCompiledPageType uses BuildManager.GetCompiledType for the 2.0
	profile.
	DefaultBaseType override removed, it is implemented in the
	TemplateParser class.
	DefaultBaseTypename doesn't use a literal string in the 2.0+
	profile, it gets the base type from the application
	configuration.

2008-01-24  Marek Habersack  <[email protected]>

	* HttpApplicationFactory.cs: use BuildManager.GetCompiledType to
	build the application (global.asax) file.

svn path=/trunk/mcs/; revision=93848
2008-01-24 21:55:44 +00:00