Commit Graph
257 Commits
Author SHA1 Message Date
Gert Driesen fe34437ee6 * DbCommandBuilder.cs: Fixed default value for ConflicOption.
* OdbcCommandBuilder.cs: Added test for ConflictOption default value.

svn path=/trunk/mcs/; revision=122227
2008-12-30 05:11:15 +00:00
Gert Driesen b8ff346173 * DbCommandBuilder.cs: Return a zero-length string when QuotePrefix or
QuoteSuffix are not set (or are set to null). Changing QuotePrefix or
QuoteSuffix after a command has been generated should result in an
InvalidOperationException.
* DbConnectionStringBuilder.cs: Added support for ODBC rules. Major
rewrite fixing many compatibility issues, and improving support for
connectionstring formats/characters.
* System.Data_test.dll.sources: Added OdbcCommandBuilderTest.cs,
OdbcConnectionStringBuilderTest.cs and DbCommandBuilderTest.cs.
* libodbc.cs: Add IdentifierQuoteChar to OdbcInfo.
* OdbcCommandBuilder.cs: Return a zero-length string when QuotePrefix
or QuoteSuffix are not set (or are set to null). Changing QuotePrefix
or QuoteSuffix after a command has been generated should result in an
InvalidOperationException. Implemented support for obtaining
character(s) for quoting identifiers from specified connection.
Modified generated SQL to match MS.
* OdbcConnectionStringBuilder.cs: Improved special casing of Driver
and Dsn keywords. Re-use implemenation of DbConnectionStringBuilder.
Improved argument checks to match MS.
* DbCommandBuilderTest.cs: Added tests for QuotePrefix and
QuoteSuffix.
* DbConnectionStringBuilderTest.cs: Added tests for both odbc and
non-odbc rules.
* OdbcCommandBuilderTest.cs: Added tests for QuotePrefix and
QuoteSuffix. Added tests for QuoteIdentifier (some still marked
NotWorking).
* OdbcConnectionStringBuilderTest.cs: Moved from ProviderTests.
Added and improved tests.

svn path=/trunk/mcs/; revision=122225
2008-12-30 03:41:45 +00:00
Gonzalo Paniagua Javier 79db1be679 Use IndexOf (char)
svn path=/trunk/mcs/; revision=122122
2008-12-25 07:47:35 +00:00
Atsushi Eno 622852656f 2008-11-25 Atsushi Enomoto <[email protected]>
* DbDataRecord.cs : it is abstract, so create different impl. class.
	* DbEnumerator.cs : use above.


svn path=/trunk/mcs/; revision=119940
2008-11-25 10:32:45 +00:00
Raja R Harinath 9d0c64bbfd Avoid allocating empty arrays.
* Index.cs (empty): New empty array constant.
(Reset): Initialize '_array' to 'empty'.
(RebuildIndex): Don't allocate array if it will be empty.
(FindAllIndexes): Use 'empty' instead of 'new int [0]'.

svn path=/trunk/mcs/; revision=119008
2008-11-17 12:30:45 +00:00
Raja R Harinath 7b06496296 Simplify using some invariants
* Index.cs: Remove use of Array and Size properties by taking
advantage of the invariant that _array is never null.
(EnsureArray): Remove.
(Array): Remove.

svn path=/trunk/mcs/; revision=119007
2008-11-17 12:30:27 +00:00
Raja R Harinath 9ab60f6e52 * RecordCache.cs: Reduce some extraneous nesting.
svn path=/trunk/mcs/; revision=119006
2008-11-17 12:30:09 +00:00
Raja R Harinath 34779ceef2 formatting fixes
svn path=/trunk/mcs/; revision=119005
2008-11-17 12:29:51 +00:00
Daniel Morgan cf3b4b10d7 2008-10-07 Daniel Morgan <[email protected]>
* DbConnectionStringBuilder.cs: fix setting and getting
	the ConnectionString property

svn path=/trunk/mcs/; revision=115173
2008-10-08 06:35:01 +00:00
Marek Safar f552aca039 Fixes the build
svn path=/trunk/mcs/; revision=113976
2008-09-24 16:32:55 +00:00
Veerapuram Varadhan fb07f03a37 **Fixes bug#421336 - sanely handle various scenarios that lead to
exceptions while creating insert/delete and update commands.


svn path=/trunk/mcs/; revision=113180
2008-09-16 16:13:22 +00:00
Raja R Harinath 5e7095f954 style nits
svn path=/trunk/mcs/; revision=113147
2008-09-16 12:52:47 +00:00
Raja R Harinath b24f84250b Some more style nits
* DataContainer.cs (*.ZeroOut): Rename from the somewhat unclear
'SetDefaultValue'.
(IsNull): Use a more idiomatic form of the short-circuit.
(*.SetValue): Convert to one-liners.

svn path=/trunk/mcs/; revision=112367
2008-09-05 09:19:39 +00:00
Marek Safar 02e9af391d Warnings cleanup
svn path=/trunk/mcs/; revision=111855
2008-08-28 19:08:55 +00:00
Daniel Morgan b2bfffeaec 2008-08-27 Daniel Morgan <[email protected]>
* System.Data.Common/DbConnectionStringBuilder.cs: Keys and Values
	get properties should return a ReadOnlyCollection

svn path=/trunk/mcs/; revision=111751
2008-08-27 23:19:23 +00:00
Raja R Harinath 6540940241 Reduce massive code duplication
* System.Data.Common/DataContainer.cs (DataContainer): Rename from
AbstractDataContainer.
Introduce new 'protected abstract' members to encapsulate
type-specific handling, and move all common code here.
(DataContainer.Create): Rename from CreateInstance.
* System.Data/DataColumn.cs: Update to changes in DataCollection.

(Since a majority of the lines are changed, I decided to dos2unix the file
too)

svn path=/trunk/mcs/; revision=110002
2008-08-08 17:47:58 +00:00
Sebastien Pouliot 740631d6f3 2008-07-06 Sebastien Pouliot <[email protected]>
* DbDataReader.cs: Replace a few Type.GetType by typeof
	[Found using Gendarme AvoidTypeGetTypeForConstantStringsRule]


svn path=/trunk/mcs/; revision=107358
2008-07-07 00:19:15 +00:00
Veerapuram Varadhan 5d67ea84a4 check for null before fetching column mapping
svn path=/trunk/mcs/; revision=107144
2008-07-03 13:37:14 +00:00
Rodrigo Kumpera c2b894982a In System.Data:
2008-07-01  Rodrigo Kumpera  <[email protected]>

	* DataTable.cs: Kill some foreach loops.
	
	* DataRow.cs: Same.

In System.Data.Common:
2008-07-01  Rodrigo Kumpera  <[email protected]>

	* RecordCache.cs: Kill some foreach loops.


svn path=/trunk/mcs/; revision=107031
2008-07-02 04:02:55 +00:00
Gert Driesen 5be9b22ef3 * DataColumnMappingCollection.cs: Modified argument names to match
MS. Code formatting.
* DataTableMappingCollection.cs: Modified argument names to match MS.
Code formatting.

svn path=/trunk/mcs/; revision=101350
2008-04-21 17:43:13 +00:00
Gert Driesen 04897e44fc * DbDataAdapter.cs: Corcompare fixes and code formatting.
* DbDataRecord.cs: Corcompare fixes and code formatting.
* DataColumnMappingCollection.cs: Corcompare fixes and code formatting.
* RowUpdatedEventArgs.cs: Corcompare fixes and code formatting.
* DbParameterCollection.cs: Corcompare fixes and code formatting.

svn path=/trunk/mcs/; revision=98815
2008-03-23 09:15:34 +00:00
Atsushi Eno 18737776de 2007-11-15 Atsushi Enomoto <[email protected]>
* DbProviderFactoriesConfigurationHandler.cs : Create() now takes
	  parent DataSet into consideration i.e. it now merges items in
	  different configurations. Fixed bug #323708.


svn path=/trunk/mcs/; revision=89701
2007-11-15 20:13:44 +00:00
Gert Driesen c231373769 * DataColumn.cs: Fixed ParamName of ArgumentNullException. Modified
exception message for invalid DateTimeMode value to match MS. Code
formatting.
* DbDataPermissionAttribute.cs: In KeyRestrictionBehavior, reuse
ExceptionHelper.CheckEnumValue.   
* ExceptionHelper.cs: Use same exception message for both 1.0 and 2.0.
* Index.cs: Fixed compiler warnings. Code formatting.
* SqlCommand.cs: Use ExceptionHelper.CheckEnumValue for enum checks.
* OleDbCommand.cs: Use ExceptionHelper.CheckEnumValue for enum checks.
* DBDataPermissionAttributeTest.cs: Improved test for invalid
KeyRestrictionBehavior. Fixed line endings.
* DataColumnTest.cs: No longer derive from deprecated Assertion class.
Code formatting. Added test for DateTimeMode.

svn path=/trunk/mcs/; revision=87866
2007-10-21 13:26:43 +00:00
Gert Driesen 3930b4b9cf * System.Data_test.dll.sources: Added DbDataAdapterTest.cs,
OdbcCommandTest.cs, OdbcConnectionTest.cs, OdbcDataAdapterTest.cs, 
OleDbCommandTest.cs, OleDbConnectionTest.cs, OleDbDataAdapterTest.cs, 
SqlDataAdapterTest.cs.
* DbDataAdapter.cs: Implemented UpdateBatchSize setter.
* DataAdapter.cs: In FillLoadOption setter, ensure value is valid.
Modified MissingMappingAction and MissingSchemaAction setters to use
ExceptionHelper.CheckEnumValue to validate value. Spaces to tabs and
code formatting.
* ExceptionHelper.cs: Added CheckEnumValue method and modified
InvalidEnumValueException method to return AORE on 2.0 profile. Added
ConnectionClosed method that returns an InvalidOperationException.
* OleDbDataAdapter.cs: In default ctor, set SelectCommand to null.
Only initialize SelectCommand in ctors. Use direct assignment in
IDbDataAdapter implementation.
* OleDbCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Added implementation for UpdatedRowSource.
* OleDbConnection.cs: Moved initialization of gda to Open ().
Avoid unnecessary initialization. Return zero-length string if
ConnectionString is null. If getters to Database, DataSource and
Provider return zero-length string if the connection is closed.
In ServerVersion, BeginTransaction and GetSchema, throw an
InvalidOperationException if connection is closed.
* OdbcCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Spaces to tabs and code formatting.
* OdbcError.cs: Fixed typo in exception message.
* OdbcConnection.cs: Return zero-length string if ConnectionString is
null. In getters for Database, DataSource and Driver return a
zero-length string if connection is closed. In BeginTransaction and
GetSchema throw InvalidOperationException if connection is closed.
Added override for GetSchema (string, string []). Use string.Empty
instead of "".
* OdbcDataAdapter.cs: Avoid unnecessary initializations. Use direct
assignment in IDbDataAdapter implementation. In default ctor, set
SelectCommand to null.
* SqlCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Use ExceptionHelper.InvalidEnumValueException
to avoid code duplication. Spaces to tabs and code formatting.
* SqlConnection.cs: Use different default package size on 2.0 profile.
Added constants for default values, instead of using magic numbers.
Avoid unnecessary initialization. In PacketSize, return default or
configured packet size when connection is not open. Use 
ExceptionHelper.ConnectionClosed instead of local method. Removed   
use of some hardcoded values in SetDefaultConnectionParameters, and
use Environment.MachineName as default WorkstationId instead of 
DNS host name. Code formatting.
* SqlDataAdapter.cs: In default ctor, set SelectCommand to null.
Avoid unnecessary initializations. Use direct assignment in   
IDbDataAdapter implementation. Fixed exception message for negative
UpdateBatchSize. In Dispose override, make sure to invoke base
method.
* DbDataAdapterTest.cs: Added test for UpdateBatchSize.
* DataAdapterTest.cs: Added tests for AcceptChangesDuringFile,   
AcceptChangesDuringUpdate, ContinueUpdateOnError, FillLoadOption,
MissingMappingAction, MissingSchemaAction and                      
ReturnProviderSpecificTypes.
* OdbcDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OdbcDataReaderTest.cs: fixed line endings.
* OdbcCommandTest.cs: Added tests for ctors and CommantText.
* OdbcConnectionTest.cs: Removed original test that relied on MySQL.
Added ctor tests. Added tests for BeginTransaction, GetSchema and 
ServerVersion with connection that is closed.
* OleDbDataAdapterTest.cs: Added tests for ctors, DeleteCommand, 
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OleDbCommandTest.cs: Added tests for ctors and CommandText.
* OleDbConnectionTest.cs: Added tests for ctors and ConnectionString. 
Added tests for BeginTransaction, GetSchema and ServerVersion with connection that is closed.
* SqlCommandTest.cs: Added tests for ctors and CommantText. 
* SqlConnectionTest.cs: Added tests for ctors, ConnectionString and 
ServerVersion.
* SqlDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand, UpdateBatchSize and 
Dispose.

svn path=/trunk/mcs/; revision=87859
2007-10-20 23:16:52 +00:00
Gert Driesen e2681602c2 * DbTransaction.cs: Do not perform a rollback in Dispose (bool).
Leaves it up to deriving classes to override Dispose (bool) and
perform a rollback if necessary. Fixes bug #325397. Code formatting.
* ExceptionHelper.cs: Added TransactionNotUsable method that constructs
an InvalidOperationException to be thrown by IDbTransaction
implementations when the transaction is no longer open.
* OdbcTransaction.cs: Keep state of the transaction, and update it
when performing commit or rollback. In Dispose (bool), only perform
a rollback if transaction was not committed or rollback before.
In Commit and Rollback, throw an InvalidOperationException if
transaction is no longer open.
* SqlTransaction.cs: Avoid unnecessary initialization. Remove
isRolledBack since its essentially the same as isOpen. Use
ExceptionHelper.TransactionNotUsable instead of duplicating code.
On 2.0 profile, ignore call to Rollback when transaction was already
disposed.
* OleDbTransaction.cs: Keep track of whether transaction is open and
whether it's disposed. In Commit an Rollback, throw an IOE if the
transaction is no longer open. In Dispose (bool), perform a rollback
if the transaction is still open.

svn path=/trunk/mcs/; revision=87835
2007-10-19 16:04:39 +00:00
Nagappan Alagappan d6b5b3c2df * DbDataAdapter.cs: Added MonoTODO in appropriate place.
* DbCommandBuilder.cs (initializeCommand): Implemented missing API.

svn path=/trunk/mcs/; revision=86517
2007-09-27 17:28:40 +00:00
Nagappan Alagappan ed44256006 2007-09-25 Nagappan A <[email protected]>
* DbConnection.cs: 2.0 attribute fixes.

	* DataColumnMapping.cs: 2.0 attribute fixes.

	* DbParameterCollection.cs: Code alignment.

	* DataAdapter.cs: 2.0 attribute fixes.

	* DataTableMapping.cs: 2.0 attribute fixes.

	* RowUpdatingEventArgs.cs (BaseCommand): Code alignment.


svn path=/trunk/mcs/; revision=86296
2007-09-25 05:23:45 +00:00
Konstantin Triger 283716cb20 DbEnumerator.cs, DbDataRecord.cs: refactoring; DbDataRecord.cs: GetValue() should return null instead of DBNull
svn path=/trunk/mcs/; revision=86257
2007-09-24 14:44:35 +00:00
Nagappan Alagappan ca43995a30 2007-08-10 Nagappan A <[email protected]>
* DbDataAdapter.cs (Fill): Fixed method signature.


svn path=/trunk/mcs/; revision=83797
2007-08-10 05:17:19 +00:00
Nagappan Alagappan 724a84ebf5 2007-07-26 Nagappan A <[email protected]>
* DbConnection.cs: Removed bogus TODO.


svn path=/trunk/mcs/; revision=82768
2007-07-26 13:06:23 +00:00
Nagappan Alagappan 5c266b32df 2007-07-22 Nagappan A <[email protected]>
* DbConnection.cs: 2.0 missing features.

	* DbDataAdapter.cs: 2.0 missing features.


svn path=/trunk/mcs/; revision=82422
2007-07-22 06:42:40 +00:00
Gert Driesen 53332a431f * DbDataAdapter.cs: Marked ICloneable.Clone obsolete to match MS.
svn path=/trunk/mcs/; revision=81108
2007-06-30 13:58:00 +00:00
Nagappan Alagappan af7c96b67e 2007-06-21 Nagappan A <[email protected]>
* DbConnectionStringBuilder.cs (Add): Fixed exception error message.


svn path=/trunk/mcs/; revision=80470
2007-06-21 13:15:51 +00:00
Nagappan Alagappan 354842e304 2007-06-21 Nagappan A <[email protected]>
* DbConnectionStringBuilder.cs (Init): Modified the dictionary to
	use StringComparer.InvariantCultureIgnoreCase.
	(Add, ContainsKey): Checks whether argument is null or empty string.


svn path=/trunk/mcs/; revision=80465
2007-06-21 13:09:49 +00:00
Konstantin Triger cde03727d8 provide docs for unsupported functionality
svn path=/trunk/mcs/; revision=78212
2007-05-30 14:10:21 +00:00
Konstantin Triger 4db1a31f35 improve exception message
svn path=/trunk/mcs/; revision=78211
2007-05-30 14:09:15 +00:00
Konstantin Triger 6c1d4bcd52 TARGET_JVM: the attribute is not needed anymore
svn path=/trunk/mcs/; revision=78177
2007-05-30 09:28:02 +00:00
Adar Wesley b9fcdffeb5 2007-05-08 Adar Wesley <[email protected]>
* DbProviderFactory.cs: minor refactoring for throwing exceptions

        * OleDbCommandBuilder.cs: added missing methods QuoteIdentifier,
        UnquoteIdentifier.

        * OleDbConnection.cs: added missing method ResetState.

        * OleDbDataReader.cs: added missing method GetData.

        * OleDbError.cs: added missing method ToString.

        * OleDbErrorCollection.cs: added missing method strongly typed
        CopyTo.

        * OleDbFactory.cs: added missing method CreatePermission.

        * OleDbParameter.cs: added missing methods ResetOleDbType,
        ResetDbType.

        * OleDbParameterCollection.cs: added missing methods strongly
        typed AddRange, IndexOf.



svn path=/trunk/mcs/; revision=76940
2007-05-08 15:14:49 +00:00
Konstantin Triger 954d065539 TARGET_JVM: SkipJavaOutputValidation for DataAdapter.Fill
svn path=/trunk/mcs/; revision=76491
2007-04-30 13:40:52 +00:00
Marek Habersack d105ea0838 2007-04-30 Marek Habersack <[email protected]>
* ConnectionStringsExpressionBuilder.cs: support expressions with
	suffixes .ProviderName and .ConnectionString (case-insensitie) and
	generate a call to GetConnectionStringProviderName in the former
	case. Fixes bug #81490

2007-04-30  Marek Habersack  <[email protected]>

	* SqlDataSource.cs: do not catch the exception if ProviderName is
	not null or empty (as per docs and what MS.NET does).

2007-04-30  Marek Habersack  <[email protected]>

	* DbProviderFactories.cs: throw the same exception MS.NET does.

svn path=/trunk/mcs/; revision=76486
2007-04-30 11:02:24 +00:00
Konstantin Triger e1123c3b45 use Invariant culture for string manipulations
svn path=/trunk/mcs/; revision=75441
2007-04-05 13:53:23 +00:00
Gert Driesen e86ef7ce8d * app_test_2.0.config: Modified DbProviderFactories to allow testing
of clear and remove nodes.
* DbProviderFactoriesConfigurationHandler.cs: Added support for
clear node.
* DbProviderFactoriesConfigurationHandlerTest.cs: Changed test to also
verify behavior for clear and remove nodes.

svn path=/trunk/mcs/; revision=73663
2007-03-03 20:15:49 +00:00
Gert Driesen a789895532 * DbProviderFactoriesConfigurationHandlerTest.cs: Fixed tests to
pass on MS. Added NotWorking test to check whether DbProviderFactories
that are defined on machine config are available.
* ConnectionStringsSectionHandler.cs: Removed since the 2.0 config
API is in place.
* DbProviderFactoriesConfigurationHandler.cs: Fixed name of DataSet
to match MS. Removed SupportedClasses column since this is no longer
part of 2.0 profile (removed during beta). Throw
ConfigurationErrorsException for unrecognized elements. Mark methods
private, and refactor them. Added FIXMEs for missing checks for
unrecognized attributes.
* DbProviderFactories.cs: Marked constants internal. Replaced spaces
with tabs. Use ConfigurationManager.GetSection instead of deprecated
ConfigurationSettings.GetConfig.
* app_test_2.0.config: Fixed assembly qualified names of config
handler. Removed usage of ConnectionStringsSectionHandler, since
this is now handled by 2.0 config system. Spaces to tabs.
* System.Data.dll.sources: Removed ConnectionStringsSectionHandler.

svn path=/trunk/mcs/; revision=73659
2007-03-03 15:09:07 +00:00
Atsushi Eno b3b740544f 2007-02-26 Atsushi Enomoto <[email protected]>
* DbProviderFactoriesConfigurationHandler.cs : there was a config
	  test that used to be broken.


svn path=/trunk/mcs/; revision=73432
2007-02-26 15:06:22 +00:00
Atsushi Eno 049e7be6cd 2007-02-26 Atsushi Enomoto <[email protected]>
* DbProviderFactoriesConfigurationHandler.cs : remove "support"
	  attribute check, as it does not really do anything.


svn path=/trunk/mcs/; revision=73417
2007-02-26 09:43:16 +00:00
Atsushi Eno a57b6ac702 2007-02-19 Atsushi Enomoto <[email protected]>
* DbProviderFactoriesConfigurationHandler.cs : "support" attribute is
	  optional. Fixed bug #80894.

	* DbProviderFactoriesConfigurationHandlerTest.cs : test for #80894.


svn path=/trunk/mcs/; revision=73093
2007-02-19 07:32:05 +00:00
Marek Habersack a9cc4931de really revert teh changes
svn path=/trunk/mcs/; revision=72881
2007-02-15 00:59:18 +00:00
Marek Habersack 20b450f9b8 Revert this one too
svn path=/trunk/mcs/; revision=72880
2007-02-15 00:54:29 +00:00
Marek Habersack f877231cae The SupportedClasses column is no longer valid
svn path=/trunk/mcs/; revision=72878
2007-02-15 00:08:16 +00:00
Nagappan Alagappan 92a3f2f5aa 2007-02-09 Nagappan A <[email protected]>
* DbProviderFactory.cs: Derived class has to implement all the
	methods of this class.

	* DbProviderFactoriesConfigurationHandler.cs (Create): Removed
	bogus MonoTODO


svn path=/trunk/mcs/; revision=72538
2007-02-09 13:51:10 +00:00