* OdbcColumn.cs: Treat OdbcType.Numeric as decimal.
* OdbcConnection.cs: Keep (weak) list of commands to allow us to
dispose them (and free their corresponding statement handles) when
the connection is closed. Fixed bug #341743.
* OdbcCommand.cs: Add internal Unlink method that is invoked when the
OdbcConnection is disposed, and which frees the statement handle.
Modified ExecuteNonQuery helper to take CommandBehavior and rename
freeHandle argument to createReader. Added CommandBehavior argument
to ExecSQL. Added FreeStatement overload that takes an option to not
perform an unlink. Fixes bug #3417434.
svn path=/trunk/mcs/; revision=122226
QuoteSuffix are not set (or are set to null). Changing QuotePrefix or
QuoteSuffix after a command has been generated should result in an
InvalidOperationException.
* DbConnectionStringBuilder.cs: Added support for ODBC rules. Major
rewrite fixing many compatibility issues, and improving support for
connectionstring formats/characters.
* System.Data_test.dll.sources: Added OdbcCommandBuilderTest.cs,
OdbcConnectionStringBuilderTest.cs and DbCommandBuilderTest.cs.
* libodbc.cs: Add IdentifierQuoteChar to OdbcInfo.
* OdbcCommandBuilder.cs: Return a zero-length string when QuotePrefix
or QuoteSuffix are not set (or are set to null). Changing QuotePrefix
or QuoteSuffix after a command has been generated should result in an
InvalidOperationException. Implemented support for obtaining
character(s) for quoting identifiers from specified connection.
Modified generated SQL to match MS.
* OdbcConnectionStringBuilder.cs: Improved special casing of Driver
and Dsn keywords. Re-use implemenation of DbConnectionStringBuilder.
Improved argument checks to match MS.
* DbCommandBuilderTest.cs: Added tests for QuotePrefix and
QuoteSuffix.
* DbConnectionStringBuilderTest.cs: Added tests for both odbc and
non-odbc rules.
* OdbcCommandBuilderTest.cs: Added tests for QuotePrefix and
QuoteSuffix. Added tests for QuoteIdentifier (some still marked
NotWorking).
* OdbcConnectionStringBuilderTest.cs: Moved from ProviderTests.
Added and improved tests.
svn path=/trunk/mcs/; revision=122225
* OdbcDataReader.cs: apply patch from Steve ? that fixes bug #433741.
GetBytes() was returning only the last byte.
svn path=/trunk/mcs/; revision=115305
* OdbcDataReader.cs: Fix unneeded self-assignment for 'length'. Also
fix a bad setter where "value = behavior" instead of "behavior = value"
[Found using Gendarme ReviewSelfAssignmentRule]
svn path=/trunk/mcs/; revision=107331
OdbcConnection to create OdbcException.
* OdbcException.cs: Added support for multiple OdbcError instances
and fixed Message property on 2.0 profile.
* OdbcCommand.cs: Use internal CreateOdbcException method on
OdbcConnection to create OdbcException. Code formatting.
* OdbcError.cs: Moved code to obtain ODBC error info to newly
introduced CreateOdbcException on OdbcConnection. Code formatting.
* OdbcDataReader.cs: Use internal CreateOdbcException method on
OdbcTransaction to create OdbcException.
* OdbcParameterCollection.cs: Removed obsolete Bind method.
* OdbcConnection.cs: Added SafeDriver property that returns
name of driver if available and a zero-length string otherwise.
Use CreateOdbcException method to create OdbcException from ODBC
error info. Added CreateOdbcException method to construct
OdbcException from all available ODBC error info.
* OdbcParameter.cs: Use internal CreateOdbcException method on
OdbcConnection to create OdbcException.
svn path=/trunk/mcs/; revision=98891
of bug #372823.
* OdbcTypeMap.cs: Fixed mapping for NChar, NText and NVarChar.
* OdbcDataReader.cs (GetColumn): Use Unicode encoding to decode
column name buffer.
(GetDataTypeName): Use SQLColAttribute to determine type name of
column.
(GetValue): Fixed retrieving value of nchar column. When retrieving
variable length unicode value, use Unicode encoding to decode buffer
and remove trailing null characters. Fixes bug #364430.
svn path=/trunk/mcs/; revision=98771
* System.Data.dll.sources: Add new OleDbMetaDataCollectionNames.cs
* System.Data_test.dll.sources: Add the new OdbcMetaDataColumnNamesTest,
OleDbMetaDataCollectionNamesTest and SqlClientMetaDataCollectionNamesTest.
In class/System.Data/System.Data.Odbc:
* OdbcMetaDataCollectionNames.cs: Set the field values.
In class/System.Data/System.Data.OleDb:
* OleDbMetaDataCollectionNames.cs: New.
In class/System.Data/System.Data.SqlClient:
* SqlClientMetaDataCollectionNames.cs: Set the field values.
In class/System.Data/Test/System.Data.Odbc:
* OdbcMetaDataCollectionNamesTest.cs: New.
In class/System.Data/Test/System.Data.OleDb:
* OleDbMetaDataCollectionNamesTest.cs: New.
In class/System.Data/Test/System.Data.SqlClient:
* SqlClientMetaDataCollectionNamesTest.cs: New.
svn path=/trunk/mcs/; revision=97175
OdbcCommandTest.cs, OdbcConnectionTest.cs, OdbcDataAdapterTest.cs,
OleDbCommandTest.cs, OleDbConnectionTest.cs, OleDbDataAdapterTest.cs,
SqlDataAdapterTest.cs.
* DbDataAdapter.cs: Implemented UpdateBatchSize setter.
* DataAdapter.cs: In FillLoadOption setter, ensure value is valid.
Modified MissingMappingAction and MissingSchemaAction setters to use
ExceptionHelper.CheckEnumValue to validate value. Spaces to tabs and
code formatting.
* ExceptionHelper.cs: Added CheckEnumValue method and modified
InvalidEnumValueException method to return AORE on 2.0 profile. Added
ConnectionClosed method that returns an InvalidOperationException.
* OleDbDataAdapter.cs: In default ctor, set SelectCommand to null.
Only initialize SelectCommand in ctors. Use direct assignment in
IDbDataAdapter implementation.
* OleDbCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Added implementation for UpdatedRowSource.
* OleDbConnection.cs: Moved initialization of gda to Open ().
Avoid unnecessary initialization. Return zero-length string if
ConnectionString is null. If getters to Database, DataSource and
Provider return zero-length string if the connection is closed.
In ServerVersion, BeginTransaction and GetSchema, throw an
InvalidOperationException if connection is closed.
* OdbcCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Spaces to tabs and code formatting.
* OdbcError.cs: Fixed typo in exception message.
* OdbcConnection.cs: Return zero-length string if ConnectionString is
null. In getters for Database, DataSource and Driver return a
zero-length string if connection is closed. In BeginTransaction and
GetSchema throw InvalidOperationException if connection is closed.
Added override for GetSchema (string, string []). Use string.Empty
instead of "".
* OdbcDataAdapter.cs: Avoid unnecessary initializations. Use direct
assignment in IDbDataAdapter implementation. In default ctor, set
SelectCommand to null.
* SqlCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Use ExceptionHelper.InvalidEnumValueException
to avoid code duplication. Spaces to tabs and code formatting.
* SqlConnection.cs: Use different default package size on 2.0 profile.
Added constants for default values, instead of using magic numbers.
Avoid unnecessary initialization. In PacketSize, return default or
configured packet size when connection is not open. Use
ExceptionHelper.ConnectionClosed instead of local method. Removed
use of some hardcoded values in SetDefaultConnectionParameters, and
use Environment.MachineName as default WorkstationId instead of
DNS host name. Code formatting.
* SqlDataAdapter.cs: In default ctor, set SelectCommand to null.
Avoid unnecessary initializations. Use direct assignment in
IDbDataAdapter implementation. Fixed exception message for negative
UpdateBatchSize. In Dispose override, make sure to invoke base
method.
* DbDataAdapterTest.cs: Added test for UpdateBatchSize.
* DataAdapterTest.cs: Added tests for AcceptChangesDuringFile,
AcceptChangesDuringUpdate, ContinueUpdateOnError, FillLoadOption,
MissingMappingAction, MissingSchemaAction and
ReturnProviderSpecificTypes.
* OdbcDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OdbcDataReaderTest.cs: fixed line endings.
* OdbcCommandTest.cs: Added tests for ctors and CommantText.
* OdbcConnectionTest.cs: Removed original test that relied on MySQL.
Added ctor tests. Added tests for BeginTransaction, GetSchema and
ServerVersion with connection that is closed.
* OleDbDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OleDbCommandTest.cs: Added tests for ctors and CommandText.
* OleDbConnectionTest.cs: Added tests for ctors and ConnectionString.
Added tests for BeginTransaction, GetSchema and ServerVersion with connection that is closed.
* SqlCommandTest.cs: Added tests for ctors and CommantText.
* SqlConnectionTest.cs: Added tests for ctors, ConnectionString and
ServerVersion.
* SqlDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand, UpdateBatchSize and
Dispose.
svn path=/trunk/mcs/; revision=87859
In IsolationLevel, throw IOE if transaction is no longer open.
* SqlTransaction.cs: Clear connection in commit. In IsolationLevel,
throw IOE if transaction is no longer open.
* OleDbTransaction.cs: Clear connection in Commit and Rollback. In
IsolationLevel and Begin overloads, throw IOE if transaction is no
longer open.
svn path=/trunk/mcs/; revision=87836
Leaves it up to deriving classes to override Dispose (bool) and
perform a rollback if necessary. Fixes bug #325397. Code formatting.
* ExceptionHelper.cs: Added TransactionNotUsable method that constructs
an InvalidOperationException to be thrown by IDbTransaction
implementations when the transaction is no longer open.
* OdbcTransaction.cs: Keep state of the transaction, and update it
when performing commit or rollback. In Dispose (bool), only perform
a rollback if transaction was not committed or rollback before.
In Commit and Rollback, throw an InvalidOperationException if
transaction is no longer open.
* SqlTransaction.cs: Avoid unnecessary initialization. Remove
isRolledBack since its essentially the same as isOpen. Use
ExceptionHelper.TransactionNotUsable instead of duplicating code.
On 2.0 profile, ignore call to Rollback when transaction was already
disposed.
* OleDbTransaction.cs: Keep track of whether transaction is open and
whether it's disposed. In Commit an Rollback, throw an IOE if the
transaction is no longer open. In Dispose (bool), perform a rollback
if the transaction is still open.
svn path=/trunk/mcs/; revision=87835
magic numbers. For Snapshot isolation level, the attribute
SQL_COPT_SS_TXN_ISOLATION must be used instead. When isolation level
is Unspecified, then do not modify the isolation level at all and
lazy initlization the IsolationLevel property. Modified exceptions
for invalid / not supported isolation levels to match MS.
* libodbc.cs: Added attribute for changing SQL Server specific
connection option. Added enum for ODBC isolation level options.
Added SQLGetConnectAttr method.
svn path=/trunk/mcs/; revision=87827
stub for ICloneable.Clone.
* OdbcTransaction.cs: Dispose should be explicit interface impl., not
public. Connection is also public on 2.0 profile.
svn path=/trunk/mcs/; revision=81109
* OdbcDataReader.cs (GetValue): Sybase returns the fraction values
in nano seconds, but DateTime expects the value in milliseconds,
so the conversion.
svn path=/trunk/mcs/; revision=77937
* OdbcInfoMessageEventArgs.cs (ToString): Implemented new method.
* OdbcParameterCollection.cs (AddRange, Insert, AddWithValue)
(Remove, Contains, CopyTo): Implemented missing .NET 2.0 methods.
* OdbcMetaDataCollectionNames.cs: Added new class for .NET 2.0
profile.
* OdbcMetaDataCollectionNames.cs (Equals): Implemented overloads
methods.
2007-02-02 Nidhi Rawal <[email protected]>
* libodbc.cs: Imported a dll file for char datatype.
* OdbcDataReader.cs (GetChar): Implemented the method and wrote
a switch case for char data type in GetValue method..
(GetDecimal): Implemented the method.
* OdbcConnectionStringBuilder.cs: Written the new class.
* OdbcMetaDataColumnNames.cs: Written the new class.
* OdbcFactory.cs (CreateConnectionStringBuilder): Implemented the method.
* OdbcParameterCollection.cs (IndexOf): Implemented the method.
svn path=/trunk/mcs/; revision=73235