overload that can be used to retrieve an existing connection pool.
Modified ResetConnectionPool () to skip free slots in the pool and to
close pooled connections that are not in use. Pooled connections that
are in use are now marked as non-pooled so that they are no longer
returned to the pool when they are closed. Fixes bug #443131.
* SqlConnection.cs: In Close, also remove reference to pool. In Open,
set TdsConnection.Pooling to false for a non-pooled connection.
Fixed ClearAllPools to no longer create a new connection for each
pool. In ClearPool, perform a lookup of the pool to clear using
the connectionstring as the pool field may refer to another pool
(as the connectionstring may have changed).
* SqlConnectionTest.cs: Added tests for ClearPool and ClearAllPools.
svn path=/trunk/mcs/; revision=118308
zero-length string, then fallback to default value for boolean and
integer backed properties. Throw ArgumentException when min pool size
exceeds max pool size. Check whether value for 'MARS' is a bool.
The 'user instance' property is 2.0 only.
* SqlConnectionTest.cs: Enabled connection string related tests that
previously failed. Added/improved connection string tests.
svn path=/trunk/mcs/; revision=110471
field. Remove Init method, as initialization is done in
SetDefaultConnectionParameters. Initialize parms in
SetDefaultConnectionParameters to avoid calling Reset on newly
initialized collection. In Dispose (bool), also invoke base.Dispose if
SqlConnection was already disposed. Fixes bug #412571.
* SqlConnectionTest.cs: Enabled and improved test for bug #412571.
svn path=/trunk/mcs/; revision=109013
equals original state. Fixes bug #412574. Removed extra whitespace.
* SqlConnectionTest.cs: Enabled test for bug #412574.
svn path=/trunk/mcs/; revision=109009
match MS. Code formatting.
* SqlCommand.cs: Changed argument names to match MS. Code formatting.
Do not include explicit IDbCommand implementation on 2.0 profile.
* SqlCommandBuilder.cs: Changed argument names to match MS. Code
formatting.
* SqlDataReader.cs: Changed argument names to match MS. Code
formatting.
* SqlParameterCollection.cs: Do not include IList, ICollection and
IDataParameterCollection explicit interface implementation on 2.0
profile. Code formatting.
* SqlConnection.cs: Changed argument names to match MS.
* SqlDataAdapter.cs: Changed argument names to match MS.
* SqlTransaction.cs: Do not include explicit interface implementation
of IDbTransaction.Connection on 2.0 profile. Code formatting.
svn path=/trunk/mcs/; revision=101355
* SqlConnection.cs: TCP port discovery via UDP port 1434 should
honor the timeout specified in the connection string (or the
default one). In some environments 100 microseconds might not be
enough to discover the port.
svn path=/trunk/mcs/; revision=100077
OdbcCommandTest.cs, OdbcConnectionTest.cs, OdbcDataAdapterTest.cs,
OleDbCommandTest.cs, OleDbConnectionTest.cs, OleDbDataAdapterTest.cs,
SqlDataAdapterTest.cs.
* DbDataAdapter.cs: Implemented UpdateBatchSize setter.
* DataAdapter.cs: In FillLoadOption setter, ensure value is valid.
Modified MissingMappingAction and MissingSchemaAction setters to use
ExceptionHelper.CheckEnumValue to validate value. Spaces to tabs and
code formatting.
* ExceptionHelper.cs: Added CheckEnumValue method and modified
InvalidEnumValueException method to return AORE on 2.0 profile. Added
ConnectionClosed method that returns an InvalidOperationException.
* OleDbDataAdapter.cs: In default ctor, set SelectCommand to null.
Only initialize SelectCommand in ctors. Use direct assignment in
IDbDataAdapter implementation.
* OleDbCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Added implementation for UpdatedRowSource.
* OleDbConnection.cs: Moved initialization of gda to Open ().
Avoid unnecessary initialization. Return zero-length string if
ConnectionString is null. If getters to Database, DataSource and
Provider return zero-length string if the connection is closed.
In ServerVersion, BeginTransaction and GetSchema, throw an
InvalidOperationException if connection is closed.
* OdbcCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Spaces to tabs and code formatting.
* OdbcError.cs: Fixed typo in exception message.
* OdbcConnection.cs: Return zero-length string if ConnectionString is
null. In getters for Database, DataSource and Driver return a
zero-length string if connection is closed. In BeginTransaction and
GetSchema throw InvalidOperationException if connection is closed.
Added override for GetSchema (string, string []). Use string.Empty
instead of "".
* OdbcDataAdapter.cs: Avoid unnecessary initializations. Use direct
assignment in IDbDataAdapter implementation. In default ctor, set
SelectCommand to null.
* SqlCommand.cs: Added constant for default CommandTimeout, instead
of using a magic number. Avoid unnecessary initialization. Fixed
default value for DesignTimeVisible. Return zero-length string if
CommandText is null. Use ExceptionHelper.InvalidEnumValueException
to avoid code duplication. Spaces to tabs and code formatting.
* SqlConnection.cs: Use different default package size on 2.0 profile.
Added constants for default values, instead of using magic numbers.
Avoid unnecessary initialization. In PacketSize, return default or
configured packet size when connection is not open. Use
ExceptionHelper.ConnectionClosed instead of local method. Removed
use of some hardcoded values in SetDefaultConnectionParameters, and
use Environment.MachineName as default WorkstationId instead of
DNS host name. Code formatting.
* SqlDataAdapter.cs: In default ctor, set SelectCommand to null.
Avoid unnecessary initializations. Use direct assignment in
IDbDataAdapter implementation. Fixed exception message for negative
UpdateBatchSize. In Dispose override, make sure to invoke base
method.
* DbDataAdapterTest.cs: Added test for UpdateBatchSize.
* DataAdapterTest.cs: Added tests for AcceptChangesDuringFile,
AcceptChangesDuringUpdate, ContinueUpdateOnError, FillLoadOption,
MissingMappingAction, MissingSchemaAction and
ReturnProviderSpecificTypes.
* OdbcDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OdbcDataReaderTest.cs: fixed line endings.
* OdbcCommandTest.cs: Added tests for ctors and CommantText.
* OdbcConnectionTest.cs: Removed original test that relied on MySQL.
Added ctor tests. Added tests for BeginTransaction, GetSchema and
ServerVersion with connection that is closed.
* OleDbDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand and Dispose.
* OleDbCommandTest.cs: Added tests for ctors and CommandText.
* OleDbConnectionTest.cs: Added tests for ctors and ConnectionString.
Added tests for BeginTransaction, GetSchema and ServerVersion with connection that is closed.
* SqlCommandTest.cs: Added tests for ctors and CommantText.
* SqlConnectionTest.cs: Added tests for ctors, ConnectionString and
ServerVersion.
* SqlDataAdapterTest.cs: Added tests for ctors, DeleteCommand,
InsertCommand, SelectCommand, UpdateCommand, UpdateBatchSize and
Dispose.
svn path=/trunk/mcs/; revision=87859
for assigning zero-length string, and use String.Length to check for
zero-length string. Added support for IsolationLevel.Snapshot.
Added StructuredTypeMembers schema collection and restrictions. Fixed
table name for MetaDataCollections collection. Implemented
DataSourceInformation collection. Added missing data types (probably
introduced in 2.0 SP1). In GetSchema, throw InvalidOperationException
if connection is closed and throw NotImplementedException for
StructuredTypeMembers collection.
svn path=/trunk/mcs/; revision=87751
not valid. On 2.0 profile, when IsolationLevel.Unspecified is passed
make sure to also set SqlTransaction.IsolationLevel to
ReadCommitted. Modified exceptions to match MS.
svn path=/trunk/mcs/; revision=87735
IsolationLevel.Unspecified, so the default is set as ReadCommited.
Thanks to Jerome Haltom <[email protected]> for this patch.
Fixes bug # 333082.
* SqlTransaction.cs: If transaction count is greater then 0 then roll
back. Thanks to Jerome Haltom <[email protected]> for this
patch. Fixes bug # 331953.
svn path=/trunk/mcs/; revision=87659
* SqlCommand.cs, SqlDataReader.cs, SqlConnection.cs: When the
server resets the connection, now the client code also disconnects
the session and remove the instance from pool. Fixes bug # 81933.
svn path=/trunk/mcs/; revision=83522
* SqlClientFactory.cs: Use SqlDataSourceEnumerator from S.D.Sql and
marked method todo. Avoid unnessary casts. Code formatting.
* SqlCommand.cs: Explicit interface implementation of IDbCommand not
necessary on 2.0 profile. Fixes API mismatches. Avoid unnecessary
casts. Code formatting.
* SqlConnection.cs: Also use RecommendAsConfigurable instead of
SettingBindableAttribute on 2.0. Use StateChange event from base class
on 2.0. Only explicitly implement IDbConnection methods on 1.0, since
these are implemented by base class on 2.0 profile. Removed extra
explicit implementation of IDisposable since the base class implements
this. Code formatting.
* SqlDataAdapter.cs: Dispose (bool) override not necessary on 2.0
profile. Stubbed ICloneable.Clone. Fixes API mismatches.
* SqlDataReader.cs: On 2.0, IDisposable.Dispose is implemented by
DbDataReader. Only 1.0 profile, explicitly implemented IEnumerable
GetEnumerator. Code formatting.
* SqlDataSourceEnumerator.cs: Removed.
* SQLDebugging.cs: Marked sealed on 2.0. Code formatting.
* SqlNotificationAuthType.cs: Removed.
* SqlNotificationInfo.cs: Added missing fields. Code formatting.
* SqlNotificationSource.cs: Added missing fields. Code formatting.
* SqlNotificationTransports.cs: Removed.
* SqlNotificationType.cs: Added missing Unknown field. Code formatting.
* SqlParameter.cs: Removed Browsable and EditorBrowsable attributes
from Precision and Scale. Fixes API mismatches. Code formatting fixes.
* SqlTransaction.cs: On 2.0 profile, Dispose method is exposed by
base class. Fixes API mismatches. Code formatting fixes.
* System.Data.dll.sources: Removed ISqlNotificationReceiver.cs,
SqlDataSourceEnumerator.cs, SqlNotificationAuthType.cs,
SqlNotificationTransports.cs.
svn path=/trunk/mcs/; revision=81134
* SqlCommand.cs, SqlConnectionStringBuilder.cs, SqlConnection.cs:
Fixed 1.0 and 2.0 extras, errors as stated in class status page.
* SqlDataAdapter.cs, SqlParameter.cs:Fixed 1.0 and 2.0 extras,
errors as stated in class status page.
* SqlBulkCopyColumnMappingCollection.cs: Fixed 1.0 and 2.0 extras,
errors as stated in class status page.
svn path=/trunk/mcs/; revision=78717
* SqlParameter.cs (SqlParameter): Updated constructor to use the
new TDS RPC implementation.
Fixed missing attributes.
(SetDbType): Added new case for sql_variant type.
(ConvertToFrameworkType): Implemented new private method to
convert the data type to framework type.
* SqlParameterCollection.cs: Fixed missing attributes and
implemented missing methods.
* SqlConnection.cs: Fixed missing attributes.
* SqlConnectionStringBuilder.cs: Certain attributes are missing or
its value or they are not appropriate. Fixed them.
* SqlDataReader.cs (GetData): Method is available only under 1.0
profile.
* SqlCommandBuilder.cs: Certain attributes are available only
under 2.0 profile, so moved them inside ifdef.
* SqlCommand.cs: Certain attributes are available only under 2.0
profile, so moved them inside ifdef.
svn path=/trunk/mcs/; revision=78186
* SqlClientFactory.cs: Added two using directives.
(CreateConnectionStringBuilder): Implemented the method.
(CreatePermission): Implemented the property.
* SqlCommand.cs: Added one using directive.
(Clone): Implemented the method.
(Dispose): Implemented the method.
(BeginExecuteXmlReader): Implemented the method.
* SqlCommandBuilder.cs (QuoteIdentifier): Implemented the method.
(UnquoteIdentifier): Implemented the method.
* SqlConnection.cs (ChangePassword): Implemented the method.
2007-03-19 Nidhi Rawal <[email protected]>
* SqlClientFactory.cs (CanCreateDataSourceEnumerator): Implemented
the property.
* SqlCommand.cs (Notification): Implemented the property.
(NotificationAutoEnlist): Implemented the property.
* SqlDataReader.cs (VisibleFieldCount): Implemented the property.
* SqlConnectionStringBuilder.cs (TrustServerCertificate): Implemented
the property.
(TypeSystemVersion): Implemented the property.
(UserInstance): Implemented the property.
(ContextConnection): Implemented the property.
* SqlConnection.cs (FireInfoMessageEventOnUserErrors): Implemented
the property.
(StatisticsEnabled): Implemented the property.
* SqlDataAdapter.cs (UpdateBatchSize): Implemented the property.
* SqlParameter.cs: Implemented one attribute.
svn path=/trunk/mcs/; revision=75189
* SqlParameter.cs (CompareInfo): Implemented the property
CompareInfo.
2007-02-15 Nidhi Rawal <[email protected]>
* SqlCommand.cs: Added some attributes which were not implemented
for .NET 2.0 and removed extra attribute which are not there in
.NET 2.0.
* SqlCommandBuilder.cs: Added some attributes that were not
implemented for .NET 2.0.
* SqlParameterCollection.cs: Added some attributes that were
not implemented for .NET 2.0.
* SqlConnectionStringBuilder.cs: Added some attributes that
were not implemented for .NET 2.0.
* SqlConnection.cs: Added attribute that was not implemented
for .NET 2.0.
* SqlParameter.cs: Added some attributes which were not
implemented for .NET 2.0 and removed some extra attributes which
are not there in .NET 2.0
svn path=/trunk/mcs/; revision=73144
* SqlTransaction.cs (Dispose): Fixed compliation warning.
* SqlDataReader.cs (GetValues): Length of elements to be copied was
decided based on the argument array passed, which caused a bug, if
the length of given array is more than actual column values.
* SqlCommandBuilder.cs (CatalogSeparator, SchemaSeparator)
(CatalogLocation): Implemented missing properties.
(CreateDeleteCommand, CreateInsertCommand, CreateUpdateCommand):
Modified private methods to take bool flag. If true, add actual
parameter name instead of p1, p2 etc.
(CreateParameter): Added overloaded private method to create
parameter with the actual column name.
(GetUpdateCommand, GetDeleteCommand, GetInsertCommand):
Implemented missing overloaded methods.
(SetRowUpdatingHandler): Implemented missing protected method.
* SqlCommand.cs: Fixed compilation warning. Removed bogus
MonoTODO's.
svn path=/trunk/mcs/; revision=70619
System.ComponentModel.Component already calls Dispose.
* SqlParameter.cs: Removed explicit interface implementation of
IDataParameter.ParameterName.
* OdbcErrorCollection.cs: Removed explicit interface implementation
of IEnumerable.GetEnumerator ().
* OdbcCommand.cs: Removed destructor as the destructor in
System.ComponentModel.Component already calls the Dispose method.
Removed explicit interface implemenation of members that are
implement by public members.
* OdbcDataReader.cs: Removed explicit interface implemenation of
IDataRecord.GetData.
* OleDbErrorCollection.cs: Removed explicit interface implementation
of IEnumerable.GetEnumerator ().
* OleDbParameterCollection.cs: Removed explicit interface
implementation members that are already implementation by public
members.
* DataTable.cs: Renamed initInProgress to fInitInProgress. BeginInit
and EndInit must only be virtual in 2.0 profile. Set eol-style to CRLF.
svn path=/trunk/mcs/; revision=61328
* Test/ProviderTests/System.Data.SqlClient/SqlConnectionTest.cs :
- OpenTest_1 : test InvalidOperationException is raised if
ConnectionString is empty
- DisposeTest : test nullreference exception is not raised
* System.Data.SqlClient/SqlConnection.cs :
- SetConnectionString : set the pareameter to default values
if connection string is empty or null
- Open : Raise InvalidOperationException if Connection String
is empty or null
- Dispose : Test exception not raised if dispose called on a
connection with empty connection string
slight modification of the patch by Jonel Rienton
svn path=/trunk/mcs/; revision=59582
* Mono.Data.Tds/Mono.Data.Tds.Protocol/Tds.cs
* Mono.Data.Tds/Mono.Data.Tds.Protocol/Tds70.cs :
- Modifications to set the desired packetsize info when connecting
to database
* System.Data/System.Data.SqlClient/SqlConnection.cs
- Modifications to get the correct Packet Size
svn path=/trunk/mcs/; revision=53443
* Mono.Data.Tds/Mono.Data.Tds.Protocol/TdsConnectionParameter.cs :
- Added a class variable 'AttachDBFileName' to store the location
of the DB file.
* Mono.Data.Tds/Mono.Data.Tds.Protocol/Tds70.cs (Connect) :
- Modified to append the bytes corresponding to AttachDBFileName
into the Tds Packets.
* System.Data/System.Data.SqlClient/SqlConnection.cs (SetProperties) :
- Added support for AttachDBFileName
svn path=/trunk/mcs/; revision=51909
* Mono.Data.Tds.Protocol/Tds.cs:
- Modified the way Server Version number is calculated
- Added a new varaible to remember the original database
connected to and to reset the Database property when the
connection to database is closed.
* Mono.Data.Tds.Protocol/Tds70.cs:
modified Reset() to Call the Reset() of base class which
in turn resets the database name.
In System.Data/Test/ProviderTests/System.Data.SqlClient:
* SqlConnectionTest.cs: removed some hardcoded database names
in DatabasePropertyTest ().
In System.Data/System.Data.SqlClient:
* SqlConnection.cs :
- Set the correct Default Values for Parameters.
- Added Argument Checks (where missing) for the Properties and
throw the correct exception on error.
- Modified SetDefaultParameters() to make sure that the parameters
are all reset to default values everytime it is called.
- Modified SetProperties() to take into account the order of the
keywords in the ConnectionString.
svn path=/trunk/mcs/; revision=50377
2005-08-26 Sureshkumar T <[email protected]>
* SqlConnection.cs (Open): enable sp_reset_connection.
In Mono.Data.Tds/Mono.Data.Tds.Protocol:
2005-08-26 Sureshkumar T <[email protected]>
* Tds70.cs (ExecProc): if no parameters, execute via RPC. parameter
support has to be added.
* Tds.cs (ExecRPC): added virtual method to execute via RPC.
This fixes bug #68978 by enabling execution of sp_reset_connection.
svn path=/trunk/mcs/; revision=48881
2005-07-22 Sureshkumar T <[email protected]>
* DataColumnMappingCollection.cs: updated attributes & attribute
descriptions to match with masterinfos.
In System.Data.SqlClient:
2005-07-22 Sureshkumar T <[email protected]>
* SqlCommandBuilder.cs, SqlParameterCollection.cs,
SqlConnection.cs, SqlParameter.cs:
- updated attributes & attribute descriptions to match with
masterinfos.
In System.Data:
* DataViewSettingCollection.cs, DataTableCollection.cs,
DataSet.cs, DataView.cs, DataColumn.cs, ForeignKeyConstraint.cs,
DataRelationCollection.cs, UniqueConstraint.cs, DataTable.cs,
DataColumnCollection.cs, DataRelation.cs, DataSet.cs:
- updated attributes & attribute descriptions to match with
masterinfos.
In System.Data.Odbc:
* OdbcParameter.cs: updated attributes & attribute descriptions to
match with masterinfos.
svn path=/trunk/mcs/; revision=47554
* Mono.Data.Tds/Mono.Data.Tds.Protocol/TdsInternalException.cs: Add ctor for InnerException.
* Mono.Data.Tds/Mono.Data.Tds.Protocol/TdsComm.cs: Throw TdsInternalException rather than
SocketException.
* System.Data/System.Data.SqlClient/SqlConnection.cs: Open (): catch TdsInternalException and throw
SqlException.
* System.Data/System.Data.SqlClient/SqlException.cs: code re-organised to pass message as well with
the exception.
svn path=/trunk/mcs/; revision=46722