mirror of
https://github.com/BepInEx/mono.git
synced 2026-11-17 01:41:17 -10:00
It's an optional element according to [1] and we were simply throwing a NotImplementedException when encountering it. Fixed by reading the element value instead. I noticed that we had a 'details' variable that was never assigned, so the check for `details == null` was always true and can be removed. This makes inlining the body of the CreateFault() call easier since we no longer need to choose different overloads and makes the code consistent with the CreateFault12 method. Also added a better exception in case of an unrecognized element. The CreateFault12 method (handles SOAP 1.2) does not need a similar fix since actor is not an element in that version [2]. Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=42226 [1] https://www.w3.org/TR/soap11/#_Toc478383507 [2] https://www.w3.org/TR/soap12/#soapfault