Commit Graph
317 Commits
Author SHA1 Message Date
Joseph Barcia 7727d1d08c Fix pmapper-data-basepath ignored in all-checks and race condition in instances module
The pmapperCommand in runAllChecksCommand was missing the
PmapperDataBasePath parameter, causing --pmapper-data-basepath to be
ignored for the pmapper module when running all-checks. (Fixes #105)

The instances module had a race condition where role analysis ran before
the receiver goroutine finished collecting all MappedInstances. This
caused IsAdminRole and CanPrivEscToAdmin columns to appear empty in
all-checks despite pmapper data being available. Fixed by signaling
the receiver to stop and waiting for it to drain before running role
analysis.

Version bumped to 2.0.4.
2026-04-21 13:06:11 +00:00
Seth Art 11652a9a6e Fix service slug mismatches for awsservicemap v1.1.0 across all commands
awsservicemap v1.1.0 switched to URL-based service slugs, breaking all
commands that used the old identifiers. Affected slugs and their fixes:

  secretsmanager  -> secrets-manager   (resource-trusts, inventory)
  ssm             -> systems-manager   (inventory)
  elb             -> elasticloadbalancing (endpoints, inventory, network-ports)
  es              -> opensearch-service   (endpoints, inventory, resource-trusts)
  mq              -> amazon-mq            (endpoints, inventory)
  stepfunctions   -> step-functions       (inventory)
  sagemaker       -> sagemaker-ai         (env-vars)
  clouddirectory  -> directoryservice     (directory-services)
  kinesis         -> streams              (inventory)
  lightsail       -> amazonlightsail.com  (endpoints, env-vars, network-ports)

Each mismatch caused IsServiceInRegion to return false for all regions,
silently skipping enumeration of that service entirely.
2026-04-11 11:40:48 -04:00
Seth Art 6ac7a0bf6b Fix secrets command skipping all regions due to stale service slug names
awsservicemap v1.1.0 changed to a URL-based service identification format.
The secrets module was passing old-style slugs ("secretsmanager", "ssm") to
IsServiceInRegion, which never matched the new URL-derived slugs
("secrets-manager", "systems-manager"). This caused 0 tasks to be queued
and no secrets to be returned despite secrets existing in the account.
2026-04-11 11:40:48 -04:00
Dominik Prodinger 6f45cbe900 Fix false positive where GitHub Actions subject was not recognized 2026-02-09 12:19:05 +01:00
Seth Art 1bb8576a27 Added logging for all successfull API calls to cloudfox-info.log 2025-12-15 13:33:55 -05:00
Seth Art 16b3c66624 Unified logging around logrus. removed standard logging lines. 2025-12-15 13:33:54 -05:00
Seth Art b3a03ec7bd Fixed small bug with inventory where it was counting total resources incorrectly 2025-12-15 13:33:54 -05:00
Seth Art 521cf7e4f4 Reduced the number of times awsservicemap calls out to get the AWS json 2025-12-15 13:33:54 -05:00
Seth Art 0e7b006cde Merge branch 'main' into main 2025-04-21 11:49:06 -04:00
Seth Art 00b49aa33c Merge branch 'main' into feature/add-opensearch-to-resource-trusts-command 2025-04-16 19:15:07 -04:00
Seth Art 4584774ec1 updated arn column to print full arn 2025-04-16 17:10:59 -06:00
Seth Art d558e1cf55 Update supported services banner 2025-04-16 16:56:11 -06:00
Seth Art 19b825cfa6 Merge remote-tracking branch 'origin' into feature/add-vpcendpoint-to-resource-trusts-command 2025-04-16 16:48:21 -06:00
edops973 dfed0491f2 Ignore public apigateway in resource trusts command 2025-03-27 20:43:43 +07:00
edops973 7671e7e717 Add opensearch unittest 2025-03-15 22:53:01 +07:00
edops973 0c858e6cd4 Add missing method in codebuild_mocks.go 2025-03-15 22:47:53 +07:00
edops973 0deb568e41 Get open search policies 2025-03-15 22:47:43 +07:00
edops973 2806f7ea08 Merge conflict 2025-03-15 22:45:10 +07:00
edops973 56e64d8e62 Merge conflict 2025-03-15 22:41:45 +07:00
edops973 43fe99e832 Merge conflict 2025-03-15 22:35:23 +07:00
edops973 5d2f2616af Merge conflict 2025-03-15 22:33:21 +07:00
edops973 d8e4157e93 Fix resource-trusts unittest 2025-03-15 22:15:04 +07:00
edops973 296710c474 Merge conflict 2025-03-15 21:56:19 +07:00
Seth Art 6b45f54699 Removed block that ran kms even without feature flag. Also edited supported serviecs line to account for feature flag use 2025-03-15 10:38:38 -04:00
Seth Art 2391bb7802 merge updates 2025-03-15 10:31:23 -04:00
edops973 caaf399e9d Add feature flag for KMS service in resource-trusts command 2025-03-14 18:02:13 +07:00
edops973 7e6439924a Remove task definition column in env-vars command 2025-03-14 18:02:11 +07:00
edops973 d3c042c1e3 Add task definition column to env-vars command 2025-03-14 18:02:07 +07:00
edops973 cda06fff7a Add container name column to ecs-tasks command 2025-03-14 18:02:05 +07:00
edops973 e49402991a Fix the order of input parameters when fetching KMS policy 2025-03-14 18:01:59 +07:00
edops973 cae31fbf21 fix kms client nil when running all-checks command 2025-03-14 18:01:52 +07:00
edops973 4e75b1151b Add resource-trusts KMS unit test 2025-03-14 18:01:43 +07:00
edops973 831198c42d Support kms service for command resource-trusts 2025-03-14 18:01:35 +07:00
edops973 89b3492399 Fix the order of input parameters when fetching KMS policy 2025-03-13 00:00:16 +07:00
edops973 67b84f0c74 fix kms client nil when running all-checks command 2025-03-10 23:09:21 +07:00
edops973 5e0eb15f7d Add resource-trusts KMS unit test 2025-03-07 18:18:05 +07:00
edops973 ec497faba4 Support kms service for command resource-trusts 2025-03-07 15:25:53 +07:00
Dominic Breuker ab4866fcbf fix bug with route53 alias record processing 2024-11-13 21:24:17 +01:00
Dominic Breuker 00fe4fdce3 add support for Route53 Alias records in route53 command 2024-10-30 21:22:22 +01:00
Seth Art b3c25bb5d0 spelling fix 2024-10-15 16:28:04 -04:00
Seth Art 878d7ec0c4 Fixed bug in cape where files did not exist crash. Fixed bug that duplicated edges because of magenta. 2024-10-15 16:16:31 -04:00
Seth Art ebf9985d40 Fix for #92 2024-10-10 19:14:09 -04:00
Seth Art 8e1e8d0c0a Fix for cape that also makes edges for cross-account explicit trusts. Also added a new flag to ignore certain edges entirely. 2024-10-10 18:23:54 -04:00
Seth Art a88e98aedd Removed AWSSSO-ACCOUNTID entries from cape table as they are redundant 2024-09-30 16:05:49 -04:00
Seth Art 6b0970ebd7 Fix for cape in regards to permission expansion 2024-09-24 16:15:49 -04:00
Seth Art e0dc71b414 updated the adminActionNames check actions to remove ssm get documents and replace with ssm get parameters 2024-09-23 13:48:28 -04:00
Seth Art b31f36746b added the the --admin-check-only flag to iam-simulator command 2024-09-23 13:47:07 -04:00
Seth Art 0a95240b7f added admin/pmapper logic to principals command 2024-09-23 13:45:59 -04:00
Seth Art 0b88bcac56 Updated tests to make sure that RDS instances without clusters are checked for 2024-05-29 11:30:49 -04:00
Seth Art 91f5f14f0e Added RDS database instances back into output. I think it's ok to have both clusters and instances in the output 2024-05-29 10:07:02 -04:00