Drop-OSS/drop-app
1
0
Fork 0
mirror of https://github.com/Drop-OSS/drop-app.git synced 2026-07-21 08:56:07 -04:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #1] [CLOSED] [UNTESTED] Static linking on binaries #102

New Issue
Closed
opened 2026-02-17 17:12:06 -05:00 by yindo · 0 comments
yindo commented 2026-02-17 17:12:06 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop-app/pull/1
Author: @alessiodam
Created: 10/8/2024
Status: ❌ Closed

Base: main ← Head: alessiodam-patches/ci-dynamic-linking

📝 Commits (2)

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 .gitlab-ci.yml (+2 -0)
📝 src-tauri/Cargo.toml (+5 -0)

📄 Description

PR Description:

Prevent Missing OpenSSL Libraries on Windows/Linux (Non-dev Instances)

This PR modifies the build process to generate statically linked binaries for Windows and Linux. By including OpenSSL in the build and disabling dynamic linking, this ensures that the application can run smoothly on non-dev machines without requiring additional OpenSSL libraries or dependencies.

Note: This change is currently untested as I do not have access to the CI environment.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop-app/pull/1 **Author:** [@alessiodam](https://github.com/alessiodam) **Created:** 10/8/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `alessiodam-patches/ci-dynamic-linking` --- ### 📝 Commits (2) - [`f8d3a5a`](https://github.com/Drop-OSS/drop-app/commit/f8d3a5ad973bb9d4deef1d720f56c679b83562f2) Update .gitlab-ci.yml - [`dc7a822`](https://github.com/Drop-OSS/drop-app/commit/dc7a82247aca9f8297dd6d5ae633d7eb44637ced) Update Cargo.toml ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.gitlab-ci.yml` (+2 -0) 📝 `src-tauri/Cargo.toml` (+5 -0) </details> ### 📄 Description ### PR Description: **Prevent Missing OpenSSL Libraries on Windows/Linux (Non-dev Instances)** This PR modifies the build process to generate statically linked binaries for Windows and Linux. By including OpenSSL in the build and disabling dynamic linking, this ensures that the application can run smoothly on non-dev machines without requiring additional OpenSSL libraries or dependencies. **Note**: This change is currently untested as I do not have access to the CI environment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:12:06 -05:00
yindo closed this issue 2026-02-17 17:12:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
feature
needs-triage
pull-request
Mirrored from GitHub Pull Request
 support
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop-app#102
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?