Drop-OSS/drop-app
1
0
Fork 0
mirror of https://github.com/Drop-OSS/drop-app.git synced 2026-07-19 13:35:57 -04:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #24] [MERGED] fix(settings): Fixed save button to include user feedback & only allow numeric characters #112

New Issue
Closed
opened 2026-02-17 17:12:08 -05:00 by yindo · 0 comments
yindo commented 2026-02-17 17:12:08 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop-app/pull/24
Author: @AdenMGB
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @quexeky

Base: develop ← Head: develop

📝 Commits (1)

  • 5a6bcb8 Update downloads.vue to incoperate button save state & restricting input

📊 Changes

1 file changed (+51 additions, -6 deletions)

View changed files

📝 pages/settings/downloads.vue (+51 -6)

📄 Description

Simple & easy fix Referencing 🔗: https://discord.com/channels/1291622805124812871/1331870758183637072

  • Added saveState for the threads configuration button in the settings page
  • Prevented Non-Numeric characters being entered as a value for downloadThreads originally resulting in a panic

Little demo 🎥

https://github.com/user-attachments/assets/1263105b-8530-4a5e-8af0-aa5ff39c17cd

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop-app/pull/24 **Author:** [@AdenMGB](https://github.com/AdenMGB) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@quexeky](https://github.com/quexeky) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (1) - [`5a6bcb8`](https://github.com/Drop-OSS/drop-app/commit/5a6bcb8be3f62ad15657890ae5e04147a6d8bb68) Update downloads.vue to incoperate button save state & restricting input ### 📊 Changes **1 file changed** (+51 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pages/settings/downloads.vue` (+51 -6) </details> ### 📄 Description Simple & easy fix Referencing 🔗: [https://discord.com/channels/1291622805124812871/1331870758183637072](https://discord.com/channels/1291622805124812871/1331870758183637072) - Added `saveState` for the threads configuration button in the settings page - Prevented **_Non-Numeric_** characters being entered as a value for `downloadThreads` originally resulting in a panic Little demo 🎥 https://github.com/user-attachments/assets/1263105b-8530-4a5e-8af0-aa5ff39c17cd --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:12:08 -05:00
yindo closed this issue 2026-02-17 17:12:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
feature
needs-triage
pull-request
Mirrored from GitHub Pull Request
 support
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop-app#112
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?