[PR #23] [MERGED] Implement better error system and segregate errors and commands #113

New Issue

2026-02-17T17:12:08-05:00

yindo commented

2026-02-17 17:12:08 -05:00

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop-app/pull/23
Author: @quexeky
Created: 1/12/2025
Status: ✅ Merged
Merged: 1/13/2025
Merged by: @quexeky

Base: develop ← Head: better-errors

📝 Commits (10+)

97850a3 chore: Progress on amend_settings command
61f72b0 chore(errors): Progress on better error handling with segragation of files
aaa8171 chore: Progress on amend_settings command
81eb79d Merge branch 'develop' into better-errors
c8dc9a9 chore(commands): Separated commands under each subdirectory into respective commands.rs files
f746af1 chore(errors): Almost all errors and commands have been segregated
b454f13 chore(errors): Added drop server error
380a5ec feat(core): Update to using nightly compiler
5af5bc7 chore(errors): More progress on error handling
a03e935 chore(errors): Implementing Try and FromResidual for UserValue

📊 Changes

45 files changed (+823 additions, -601 deletions)

View changed files

📝 pages/settings/downloads.vue (+1 -0)
📝 src-tauri/Cargo.lock (+23 -0)
📝 src-tauri/Cargo.toml (+2 -0)
➕ src-tauri/rust-toolchain.toml (+2 -0)
📝 src-tauri/src/autostart.rs (+15 -8)
➕ src-tauri/src/commands.rs (+16 -0)
➕ src-tauri/src/database/commands.rs (+83 -0)
📝 src-tauri/src/database/db.rs (+2 -58)
➕ src-tauri/src/database/debug.rs (+22 -0)
➕ src-tauri/src/database/mod.rs (+4 -0)
➕ src-tauri/src/database/settings.rs (+24 -0)
➖ src-tauri/src/debug.rs (+0 -26)
➕ src-tauri/src/download_manager/commands.rs (+31 -0)
📝 src-tauri/src/download_manager/download_manager.rs (+2 -1)
📝 src-tauri/src/download_manager/download_manager_builder.rs (+8 -4)
📝 src-tauri/src/download_manager/downloadable.rs (+3 -2)
📝 src-tauri/src/download_manager/mod.rs (+1 -1)
📝 src-tauri/src/download_manager/progress_object.rs (+13 -10)
📝 src-tauri/src/error/application_download_error.rs (+1 -14)
➕ src-tauri/src/error/drop_server_error.rs (+10 -0)

...and 25 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop-app/pull/23 **Author:** [@quexeky](https://github.com/quexeky) **Created:** 1/12/2025 **Status:** ✅ Merged **Merged:** 1/13/2025 **Merged by:** [@quexeky](https://github.com/quexeky) **Base:** `develop` ← **Head:** `better-errors` --- ### 📝 Commits (10+) - [`97850a3`](https://github.com/Drop-OSS/drop-app/commit/97850a38f1f14fca1fbdb387cb26f29886e8030a) chore: Progress on amend_settings command - [`61f72b0`](https://github.com/Drop-OSS/drop-app/commit/61f72b0013dc769630712239031bfbb22cae0ecc) chore(errors): Progress on better error handling with segragation of files - [`aaa8171`](https://github.com/Drop-OSS/drop-app/commit/aaa817118ce6ec7678f875c9e85104e911af19e6) chore: Progress on amend_settings command - [`81eb79d`](https://github.com/Drop-OSS/drop-app/commit/81eb79d38f9e0c57461d7dcce491a94365a707b5) Merge branch 'develop' into better-errors - [`c8dc9a9`](https://github.com/Drop-OSS/drop-app/commit/c8dc9a93264104aa1808b66e08f87896143821dd) chore(commands): Separated commands under each subdirectory into respective commands.rs files - [`f746af1`](https://github.com/Drop-OSS/drop-app/commit/f746af1250bd348ec42115f2eae6de722f5204d8) chore(errors): Almost all errors and commands have been segregated - [`b454f13`](https://github.com/Drop-OSS/drop-app/commit/b454f13f6d305535efbb9fd68636c2db0d28c48f) chore(errors): Added drop server error - [`380a5ec`](https://github.com/Drop-OSS/drop-app/commit/380a5ec5d52665bc10a3d4f117ca60a1604c2ab5) feat(core): Update to using nightly compiler - [`5af5bc7`](https://github.com/Drop-OSS/drop-app/commit/5af5bc7be4d1a712f4bcd41d21e1f31888e32dd4) chore(errors): More progress on error handling - [`a03e935`](https://github.com/Drop-OSS/drop-app/commit/a03e935b59b96102fcfa35aadc3aa863ac00c03c) chore(errors): Implementing Try and FromResidual for UserValue ### 📊 Changes **45 files changed** (+823 additions, -601 deletions) <details> <summary>View changed files</summary> 📝 `pages/settings/downloads.vue` (+1 -0) 📝 `src-tauri/Cargo.lock` (+23 -0) 📝 `src-tauri/Cargo.toml` (+2 -0) ➕ `src-tauri/rust-toolchain.toml` (+2 -0) 📝 `src-tauri/src/autostart.rs` (+15 -8) ➕ `src-tauri/src/commands.rs` (+16 -0) ➕ `src-tauri/src/database/commands.rs` (+83 -0) 📝 `src-tauri/src/database/db.rs` (+2 -58) ➕ `src-tauri/src/database/debug.rs` (+22 -0) ➕ `src-tauri/src/database/mod.rs` (+4 -0) ➕ `src-tauri/src/database/settings.rs` (+24 -0) ➖ `src-tauri/src/debug.rs` (+0 -26) ➕ `src-tauri/src/download_manager/commands.rs` (+31 -0) 📝 `src-tauri/src/download_manager/download_manager.rs` (+2 -1) 📝 `src-tauri/src/download_manager/download_manager_builder.rs` (+8 -4) 📝 `src-tauri/src/download_manager/downloadable.rs` (+3 -2) 📝 `src-tauri/src/download_manager/mod.rs` (+1 -1) 📝 `src-tauri/src/download_manager/progress_object.rs` (+13 -10) 📝 `src-tauri/src/error/application_download_error.rs` (+1 -14) ➕ `src-tauri/src/error/drop_server_error.rs` (+10 -0) _...and 25 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-17 17:12:08 -05:00

yindo closed this issue

2026-02-17 17:12:08 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Drop-OSS/drop-app#113