[PR #76] [MERGED] Cache-first object fetching #134

New Issue

2026-02-17T17:12:10-05:00

yindo commented

2026-02-17 17:12:10 -05:00

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop-app/pull/76
Author: @DecDuck
Created: 7/26/2025
Status: ✅ Merged
Merged: 7/26/2025
Merged by: @DecDuck

Base: develop ← Head: cache-fixes

📝 Commits (3)

b8e2bce fix: submillisecond cache hits
87ddaf4 fix: async object loading to hand control back to renderer
75a1ebd fix: clippy

📊 Changes

12 files changed (+110 additions, -101 deletions)

View changed files

📝 app.vue (+1 -0)
📝 components/HeaderUserWidget.vue (+2 -2)
➕ components/LoadingIndicator.vue (+7 -0)
📝 pages/library/[id]/index.vue (+19 -20)
📝 src-tauri/src/error/remote_access_error.rs (+1 -1)
📝 src-tauri/src/games/library.rs (+4 -4)
📝 src-tauri/src/lib.rs (+10 -15)
📝 src-tauri/src/remote/auth.rs (+1 -1)
📝 src-tauri/src/remote/cache.rs (+52 -35)
📝 src-tauri/src/remote/commands.rs (+1 -1)
📝 src-tauri/src/remote/fetch_object.rs (+11 -21)
📝 src-tauri/tauri.conf.json (+1 -1)

📄 Description

Currently cache hits are sub-millisecond on an SSD, which is good.

I think WebView loads images synchronously or something, because cache misses make the webview freeze up, so we can't show any loading state. Will need to figure out a workaround.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop-app/pull/76 **Author:** [@DecDuck](https://github.com/DecDuck) **Created:** 7/26/2025 **Status:** ✅ Merged **Merged:** 7/26/2025 **Merged by:** [@DecDuck](https://github.com/DecDuck) **Base:** `develop` ← **Head:** `cache-fixes` --- ### 📝 Commits (3) - [`b8e2bce`](https://github.com/Drop-OSS/drop-app/commit/b8e2bce0ebfc805505adf8ed7b7a4fe3d8fd69e7) fix: submillisecond cache hits - [`87ddaf4`](https://github.com/Drop-OSS/drop-app/commit/87ddaf45be96828d396b57e1ad8d6f08733aa772) fix: async object loading to hand control back to renderer - [`75a1ebd`](https://github.com/Drop-OSS/drop-app/commit/75a1ebded7ae85bd5af31afbab9901d9c0c54b1a) fix: clippy ### 📊 Changes **12 files changed** (+110 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `app.vue` (+1 -0) 📝 `components/HeaderUserWidget.vue` (+2 -2) ➕ `components/LoadingIndicator.vue` (+7 -0) 📝 `pages/library/[id]/index.vue` (+19 -20) 📝 `src-tauri/src/error/remote_access_error.rs` (+1 -1) 📝 `src-tauri/src/games/library.rs` (+4 -4) 📝 `src-tauri/src/lib.rs` (+10 -15) 📝 `src-tauri/src/remote/auth.rs` (+1 -1) 📝 `src-tauri/src/remote/cache.rs` (+52 -35) 📝 `src-tauri/src/remote/commands.rs` (+1 -1) 📝 `src-tauri/src/remote/fetch_object.rs` (+11 -21) 📝 `src-tauri/tauri.conf.json` (+1 -1) </details> ### 📄 Description Currently cache hits are sub-millisecond on an SSD, which is good. I think WebView loads images synchronously or something, because cache misses make the webview freeze up, so we can't show any loading state. Will need to figure out a workaround. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-17 17:12:10 -05:00

yindo closed this issue

2026-02-17 17:12:10 -05:00

yindo referenced this issue

2026-06-05 14:24:37 -04:00

[GH-ISSUE #134] [BUG] Setup-only Game still shows Play #67

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Drop-OSS/drop-app#134