Drop-OSS/drop-app
1
0
Fork 0
mirror of https://github.com/Drop-OSS/drop-app.git synced 2026-07-21 08:56:07 -04:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #125] [MERGED] Fix for multi-version downloads #155

New Issue
Closed
opened 2026-02-17 17:12:13 -05:00 by yindo · 0 comments
yindo commented 2026-02-17 17:12:13 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop-app/pull/125
Author: @DecDuck
Created: 8/28/2025
Status: ✅ Merged
Merged: 8/28/2025
Merged by: @DecDuck

Base: develop ← Head: multi-version-download-fix

📝 Commits (3)

📊 Changes

3 files changed (+74 additions, -34 deletions)

View changed files

📝 src-tauri/src/error/remote_access_error.rs (+5 -0)
📝 src-tauri/src/games/downloads/download_agent.rs (+67 -32)
📝 src-tauri/src/games/downloads/manifest.rs (+2 -2)

📄 Description

Manifests from the server assign a version to each chunk, due to how delta versions are laid on top of each other. This fix is a client-side only fix, slated for v0.3.3 client.

It organises buckets by version, rather than assigning a version to each chunk, to keep the download_logic.rs simple. It pre-requests all download contexts before starting the download, so contexts may expire if downloads take long enough and the different versions aren't spaced equally throughout the manifest.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop-app/pull/125 **Author:** [@DecDuck](https://github.com/DecDuck) **Created:** 8/28/2025 **Status:** ✅ Merged **Merged:** 8/28/2025 **Merged by:** [@DecDuck](https://github.com/DecDuck) **Base:** `develop` ← **Head:** `multi-version-download-fix` --- ### 📝 Commits (3) - [`355df48`](https://github.com/Drop-OSS/drop-app/commit/355df48818c40448eed4818c7c36b35db8776846) fix: multi version downloads - [`d52547e`](https://github.com/Drop-OSS/drop-app/commit/d52547ecbb09a0f4ad7deaea7f03ff8185443c3b) fix: remove debug utils - [`5efa88d`](https://github.com/Drop-OSS/drop-app/commit/5efa88dc99d1c42db0b8bca4e189f357ff6d5644) fix: clippy ### 📊 Changes **3 files changed** (+74 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/src/error/remote_access_error.rs` (+5 -0) 📝 `src-tauri/src/games/downloads/download_agent.rs` (+67 -32) 📝 `src-tauri/src/games/downloads/manifest.rs` (+2 -2) </details> ### 📄 Description Manifests from the server assign a version to each chunk, due to how delta versions are laid on top of each other. This fix is a client-side only fix, slated for v0.3.3 client. It organises buckets by version, rather than assigning a version to each chunk, to keep the download_logic.rs simple. It pre-requests all download contexts before starting the download, so contexts may expire if downloads take long enough and the different versions aren't spaced equally throughout the manifest. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:12:13 -05:00
yindo closed this issue 2026-02-17 17:12:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
feature
needs-triage
pull-request
Mirrored from GitHub Pull Request
 support
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop-app#155
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?