[PR #154] [MERGED] 139 add and resolve clippy lints to prevent unwrap and expect functions #163

New Issue

2026-02-17T17:12:14-05:00

yindo commented

2026-02-17 17:12:14 -05:00

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop-app/pull/154
Author: @quexeky
Created: 9/24/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @quexeky

Base: develop ← Head: 139-add-and-resolve-clippy-lints-to-prevent-unwrap-and-expect-functions

📝 Commits (10+)

be4fc2d fix: Add lint and remove all unwraps from lib.rs
ea6fa55 chore: Remove all unwraps from util.rs and add state_lock macro
be5500d chore: Add CacheError and remove unwraps from fetch_object
ddde547 chore: Remove unwraps from fetch_object and server_proto
83dc773 chore: Remove unwraps from auth.rs
463c5e6 chore: Remove unwraps from process_handlers
dcb7455 chore: Clippy unwrap linting
d6a9994 Merge branch 'develop' into 139-add-and-resolve-clippy-lints-to-prevent-unwrap-and-expect-functions
0d78375 chore: Remove lint
f733fbb chore: Make the rest of clippy happy

📊 Changes

40 files changed (+6001 additions, -622 deletions)

View changed files

📝 package.json (+2 -1)
📝 src-tauri/Cargo.lock (+6 -6)
📝 src-tauri/src/client/cleanup.rs (+2 -2)
📝 src-tauri/src/client/commands.rs (+2 -2)
📝 src-tauri/src/database/commands.rs (+21 -5)
📝 src-tauri/src/database/db.rs (+65 -23)
📝 src-tauri/src/database/scan.rs (+2 -2)
📝 src-tauri/src/download_manager/commands.rs (+5 -7)
📝 src-tauri/src/download_manager/download_manager_builder.rs (+15 -22)
📝 src-tauri/src/download_manager/download_manager_frontend.rs (+16 -28)
📝 src-tauri/src/download_manager/util/progress_object.rs (+13 -23)
📝 src-tauri/src/download_manager/util/queue.rs (+3 -3)
📝 src-tauri/src/error/application_download_error.rs (+9 -3)
➕ src-tauri/src/error/cache_error.rs (+26 -0)
📝 src-tauri/src/error/library_error.rs (+10 -7)
📝 src-tauri/src/error/mod.rs (+1 -0)
📝 src-tauri/src/error/process_error.rs (+5 -3)
📝 src-tauri/src/error/remote_access_error.rs (+3 -5)
📝 src-tauri/src/games/downloads/commands.rs (+6 -13)
📝 src-tauri/src/games/downloads/download_agent.rs (+55 -40)

...and 20 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop-app/pull/154 **Author:** [@quexeky](https://github.com/quexeky) **Created:** 9/24/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@quexeky](https://github.com/quexeky) **Base:** `develop` ← **Head:** `139-add-and-resolve-clippy-lints-to-prevent-unwrap-and-expect-functions` --- ### 📝 Commits (10+) - [`be4fc2d`](https://github.com/Drop-OSS/drop-app/commit/be4fc2d37aebb3ac9317748523118fe914076bfc) fix: Add lint and remove all unwraps from lib.rs - [`ea6fa55`](https://github.com/Drop-OSS/drop-app/commit/ea6fa551a2ad2a99e5e7d5a04e14046e4bb24c60) chore: Remove all unwraps from util.rs and add state_lock macro - [`be5500d`](https://github.com/Drop-OSS/drop-app/commit/be5500d29f584ad183506b912292e1d7b0fd521e) chore: Add CacheError and remove unwraps from fetch_object - [`ddde547`](https://github.com/Drop-OSS/drop-app/commit/ddde547c081741f7d70c66789eeac79f66412d41) chore: Remove unwraps from fetch_object and server_proto - [`83dc773`](https://github.com/Drop-OSS/drop-app/commit/83dc773b1058034e6a18386af0acba741b254d69) chore: Remove unwraps from auth.rs - [`463c5e6`](https://github.com/Drop-OSS/drop-app/commit/463c5e6f3b466484fa4683e43ee9acaa22e6a9b6) chore: Remove unwraps from process_handlers - [`dcb7455`](https://github.com/Drop-OSS/drop-app/commit/dcb7455954a185568e254060fda1aed52cfac620) chore: Clippy unwrap linting - [`d6a9994`](https://github.com/Drop-OSS/drop-app/commit/d6a9994f8b73fc9f36ee87bfc2136e3084e7df15) Merge branch 'develop' into 139-add-and-resolve-clippy-lints-to-prevent-unwrap-and-expect-functions - [`0d78375`](https://github.com/Drop-OSS/drop-app/commit/0d78375f5414ad10114350547c621efe172a28e3) chore: Remove lint - [`f733fbb`](https://github.com/Drop-OSS/drop-app/commit/f733fbba65964e57303525f3dcf5e86181c27f94) chore: Make the rest of clippy happy ### 📊 Changes **40 files changed** (+6001 additions, -622 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+2 -1) 📝 `src-tauri/Cargo.lock` (+6 -6) 📝 `src-tauri/src/client/cleanup.rs` (+2 -2) 📝 `src-tauri/src/client/commands.rs` (+2 -2) 📝 `src-tauri/src/database/commands.rs` (+21 -5) 📝 `src-tauri/src/database/db.rs` (+65 -23) 📝 `src-tauri/src/database/scan.rs` (+2 -2) 📝 `src-tauri/src/download_manager/commands.rs` (+5 -7) 📝 `src-tauri/src/download_manager/download_manager_builder.rs` (+15 -22) 📝 `src-tauri/src/download_manager/download_manager_frontend.rs` (+16 -28) 📝 `src-tauri/src/download_manager/util/progress_object.rs` (+13 -23) 📝 `src-tauri/src/download_manager/util/queue.rs` (+3 -3) 📝 `src-tauri/src/error/application_download_error.rs` (+9 -3) ➕ `src-tauri/src/error/cache_error.rs` (+26 -0) 📝 `src-tauri/src/error/library_error.rs` (+10 -7) 📝 `src-tauri/src/error/mod.rs` (+1 -0) 📝 `src-tauri/src/error/process_error.rs` (+5 -3) 📝 `src-tauri/src/error/remote_access_error.rs` (+3 -5) 📝 `src-tauri/src/games/downloads/commands.rs` (+6 -13) 📝 `src-tauri/src/games/downloads/download_agent.rs` (+55 -40) _...and 20 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-17 17:12:14 -05:00

yindo closed this issue

2026-02-17 17:12:14 -05:00

yindo referenced this issue

2026-06-05 14:24:42 -04:00

[GH-ISSUE #163] [BUG] Pressing "Refresh" does not re-establish connection to server #87

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Drop-OSS/drop-app#163