Drop-OSS/drop-app
1
0
Fork 0
mirror of https://github.com/Drop-OSS/drop-app.git synced 2026-08-27 19:19:55 -04:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[PR #158] [CLOSED] limit chunks length on downloads #171

New Issue
Closed
opened 2026-02-17 17:12:14 -05:00 by yindo · 0 comments
yindo commented 2026-02-17 17:12:14 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop-app/pull/158
Author: @laylafogiel-hash
Created: 10/12/2025
Status: ❌ Closed

Base: develop ← Head: limit-chunk-length

📝 Commits (1)

  • 38f7483 limit chunks length on downloads

📊 Changes

1 file changed (+106 additions, -94 deletions)

View changed files

📝 src-tauri/src/games/downloads/download_logic.rs (+106 -94)

📄 Description

The drop server limits the length of requested chunks to 256 (see file server/api/v2/client/chunk.post.ts), but the client may request bigger chunks than that, which cuase an error. This especially can happen with .zip files which may have large chunks.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop-app/pull/158 **Author:** [@laylafogiel-hash](https://github.com/laylafogiel-hash) **Created:** 10/12/2025 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `limit-chunk-length` --- ### 📝 Commits (1) - [`38f7483`](https://github.com/Drop-OSS/drop-app/commit/38f7483d13efc4fc0ad1a5d3d48b58ff15481e61) limit chunks length on downloads ### 📊 Changes **1 file changed** (+106 additions, -94 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/src/games/downloads/download_logic.rs` (+106 -94) </details> ### 📄 Description The drop server limits the length of requested chunks to 256 (see file server/api/v2/client/chunk.post.ts), but the client may request bigger chunks than that, which cuase an error. This especially can happen with .zip files which may have large chunks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:12:14 -05:00
yindo closed this issue 2026-02-17 17:12:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
feature
needs-triage
pull-request
Mirrored from GitHub Pull Request
 support
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop-app#171
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?