Drop-OSS/drop-app
1
0
Fork 0
mirror of https://github.com/Drop-OSS/drop-app.git synced 2026-07-21 08:56:07 -04:00
Code Issues 41 Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #7] [Feature Request] Download speed & Time remain indicator within the downloads page #5

New Issue
Closed
opened 2026-02-17 17:11:48 -05:00 by yindo · 6 comments
yindo commented 2026-02-17 17:11:48 -05:00
Owner
Copy Link
Copy Source

Originally created by @AdenMGB on GitHub (Dec 26, 2024).
Original GitHub issue: https://github.com/Drop-OSS/drop-app/issues/7

Originally assigned to: @quexeky on GitHub.

Hello, I think a nice little to have QoL feature would be Download speed & Time remain indicator when downloading apps from the target server via the drop client app

I'd imagine this is quite and easy little feature to add, so much so I have already wrote the code for it and planning on becoming a contributor, but I cannot test it because for some reason when I run yarn tauri dev I get this weird ERROR [unhandledRejection] require is not defined but oh well that's for another day.

Thanks for maintaining this awesome little project!

Sincerely, Aden

Just in case you wanted it here's my implementation which is yet to be confirmed working with the files:
new code.zip

pages\settings\downloads.vue

image
image
image

utils\format.ts (new file)

image

src-tauri\src\downloads\progress_object.rs

image

Originally created by @AdenMGB on GitHub (Dec 26, 2024). Original GitHub issue: https://github.com/Drop-OSS/drop-app/issues/7 Originally assigned to: @quexeky on GitHub. ### **Hello**, I think a nice little to have QoL feature would be Download speed & Time remain indicator when downloading apps from the target server via the drop client app I'd imagine this is quite and easy little feature to add, so much so I have already wrote the code for it and planning on becoming a contributor, but I cannot test it because for some reason when I run `yarn tauri dev` I get this weird `ERROR [unhandledRejection] require is not defined` but oh well that's for another day. Thanks for maintaining this awesome little project! _Sincerely, Aden_ Just in case you wanted it here's my implementation which is yet to be confirmed working with the files: [new code.zip](https://github.com/user-attachments/files/18256024/new.code.zip) ### pages\settings\downloads.vue ![image](https://github.com/user-attachments/assets/9b07fdd8-adce-4b91-bc3c-f47aa8ecc8a2) ![image](https://github.com/user-attachments/assets/793c5593-7885-4879-b734-f28ced9a290d) ![image](https://github.com/user-attachments/assets/f1e9e48c-a917-40da-a2b8-e6525c89ceeb) ### utils\format.ts (new file) ![image](https://github.com/user-attachments/assets/601f4ee7-5d13-48c1-a1c7-d5e5fe596c61) ### src-tauri\src\downloads\progress_object.rs ![image](https://github.com/user-attachments/assets/60fe8e65-9482-4ea6-8d63-2de2dc51ee53)
yindo closed this issue 2026-02-17 17:11:48 -05:00
yindo commented 2026-02-17 17:11:48 -05:00
Author
Owner
Copy Link
Copy Source

@DecDuck commented on GitHub (Dec 26, 2024):

Oh shit I thought would've been a pain in the ass to implement, I completely forgot our progress track just counted bytes. This feature was definitely planned, but I had been putting it off. Good to know it'll be since and easy!

We had initially planned to push events from the Rust side to update download statistics on the frontend, but this might be a better solution. @quexeky ?

@DecDuck commented on GitHub (Dec 26, 2024): Oh shit I thought would've been a pain in the ass to implement, I completely forgot our progress track just counted bytes. This feature was definitely planned, but I had been putting it off. Good to know it'll be since and easy! We had initially planned to push events from the Rust side to update download statistics on the frontend, but this might be a better solution. @quexeky ?
yindo commented 2026-02-17 17:11:48 -05:00
Author
Owner
Copy Link
Copy Source

@quexeky commented on GitHub (Dec 26, 2024):

@DecDuck I see you've added it already?

@quexeky commented on GitHub (Dec 26, 2024): @DecDuck I see you've added it already?
yindo commented 2026-02-17 17:11:48 -05:00
Author
Owner
Copy Link
Copy Source

@DecDuck commented on GitHub (Dec 26, 2024):

Not pushed yet. Still adding the final touches.

@DecDuck commented on GitHub (Dec 26, 2024): Not pushed yet. Still adding the final touches.
yindo commented 2026-02-17 17:11:48 -05:00
Author
Owner
Copy Link
Copy Source

@quexeky commented on GitHub (Dec 26, 2024):

Aight that works. Is it event-based or poll-based? The initial implementation was poll-based

@quexeky commented on GitHub (Dec 26, 2024): Aight that works. Is it event-based or poll-based? The initial implementation was poll-based
yindo commented 2026-02-17 17:11:48 -05:00
Author
Owner
Copy Link
Copy Source

@DecDuck commented on GitHub (Dec 26, 2024):

Event based.

@DecDuck commented on GitHub (Dec 26, 2024): Event based.
yindo commented 2026-02-17 17:11:48 -05:00
Author
Owner
Copy Link
Copy Source

@quexeky commented on GitHub (Dec 26, 2024):

Shall I revert my local version?

@quexeky commented on GitHub (Dec 26, 2024): Shall I revert my local version?
yindo changed title from [Feature Request] Download speed & Time remain indicator within the downloads page to [GH-ISSUE #7] [Feature Request] Download speed & Time remain indicator within the downloads page 2026-06-05 14:24:17 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
feature
needs-triage
pull-request
Mirrored from GitHub Pull Request
 support
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop-app#5
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?