Drop-OSS/drop
1
0
Fork 0
mirror of https://github.com/Drop-OSS/drop.git synced 2026-08-26 15:07:58 -04:00
Code Issues 77 Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #12] Account Creation Form Issues #10

New Issue
Closed
opened 2026-02-17 17:05:54 -05:00 by yindo · 3 comments
yindo commented 2026-02-17 17:05:54 -05:00
Owner
Copy Link
Copy Source

Originally created by @Shadowfita on GitHub (Dec 26, 2024).
Original GitHub issue: https://github.com/Drop-OSS/drop/issues/12

Hi,

Great project(s). Thank you very much for undertaking such a task.

I have just spun up my own instance and upon creating the admin account, am unable to use a non-typical domain suffix. It seems that every other letter makes it invalid. E.g., .tech domains.

Additionally, the username character requirement seems to be checking if it is greater than 5 characters, rather than equal to or greater than, as one would expect based on the input description.

Thanks again!

Originally created by @Shadowfita on GitHub (Dec 26, 2024). Original GitHub issue: https://github.com/Drop-OSS/drop/issues/12 Hi, Great project(s). Thank you very much for undertaking such a task. I have just spun up my own instance and upon creating the admin account, am unable to use a non-typical domain suffix. It seems that every other letter makes it invalid. E.g., .tech domains. Additionally, the username character requirement seems to be checking if it is greater than 5 characters, rather than equal to or greater than, as one would expect based on the input description. Thanks again!
yindo closed this issue 2026-02-17 17:05:54 -05:00
yindo commented 2026-02-17 17:05:55 -05:00
Author
Owner
Copy Link
Copy Source

@DecDuck commented on GitHub (Dec 26, 2024):

Thanks for the bug report!

We've patched the username issue just now on our develop branch (was just missing the = sign)

About the email issue - what emails were you trying? The validation regex doesn't specify any specific TLDs, it's just looking for:

[text]@[text].[text]

Did you perhaps have a space at the beginning or end?

@DecDuck commented on GitHub (Dec 26, 2024): Thanks for the bug report! We've patched the username issue just now on our `develop` branch (was just missing the = sign) About the email issue - what emails were you trying? The validation regex doesn't specify any specific TLDs, it's just looking for: [text]@[text].[text] Did you perhaps have a space at the beginning or end?
yindo commented 2026-02-17 17:05:55 -05:00
Author
Owner
Copy Link
Copy Source

@Shadowfita commented on GitHub (Dec 26, 2024):

Thanks for the bug report!

We've patched the username issue just now on our develop branch (was just missing the = sign)

About the email issue - what emails were you trying? The validation regex doesn't specify any specific TLDs, it's just looking for:

[text]@[text].[text]

Did you perhaps have a space at the beginning or end?

No spaces. For example: .com is valid, .au is not, and .tech is not.

Appreciate your prompt action!!

@Shadowfita commented on GitHub (Dec 26, 2024): > Thanks for the bug report! > > We've patched the username issue just now on our `develop` branch (was just missing the = sign) > > About the email issue - what emails were you trying? The validation regex doesn't specify any specific TLDs, it's just looking for: > > [text]@[text].[text] > > Did you perhaps have a space at the beginning or end? No spaces. For example: .com is valid, .au is not, and .tech is not. Appreciate your prompt action!!
yindo commented 2026-02-17 17:05:55 -05:00
Author
Owner
Copy Link
Copy Source

@DecDuck commented on GitHub (Dec 26, 2024):

Hey! I figured out the issue. I had misunderstood what the g flag does to a RegEx in Javascript.

It's been fixed in the develop branch, and I can backport the fix to the main branch if you need.

@DecDuck commented on GitHub (Dec 26, 2024): Hey! I figured out the issue. I had misunderstood what the `g` flag does to a RegEx in Javascript. It's been fixed in the `develop` branch, and I can backport the fix to the `main` branch if you need.
yindo changed title from Account Creation Form Issues to [GH-ISSUE #12] Account Creation Form Issues 2026-06-05 14:20:56 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
feature
feature
good first issue
needs-triage
pull-request
Mirrored from GitHub Pull Request
 qol
support
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop#10
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?