mirror of
https://github.com/Drop-OSS/drop.git
synced 2026-07-24 20:05:39 -04:00
[GH-ISSUE #220] [BUG] Downloading a game .zip archive crashes the Drop server #109
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MonkaKokosowa on GitHub (Aug 28, 2025).
Original GitHub issue: https://github.com/Drop-OSS/drop/issues/220
Originally assigned to: @DecDuck on GitHub.
Clean install of drop (for testing it out as alternative), I have set up a FlatFilesystem library and after importing a game and a default version of it I tried to install it with the desktop client, the download first runs, validates, and it happens in a continuous loop a few times until I get a client "IO" error and the server crashes. That happens with any game (.zip archive) I imported (none of them have password protection)
I'm also adding redacted docker-compose env vars in case that could affect this.
docker-compose.yml:Server log:
@seamon67 commented on GitHub (Aug 28, 2025):
I am facing the same issue. I just stopped using zips altogether
@DecDuck commented on GitHub (Aug 28, 2025):
Does the client CTD or just fail to download?
Edit: nvm, read the issue properly, sorry.
Will try to reproduce.
@seamon67 commented on GitHub (Aug 29, 2025):
It happens in very specific games. This issue of zips not downloading happens for me in Wartales.
Basically, Wartales raw folder is around 47GB but using WinZip on Normal Compression settings, it goes down to a 16GB zip file.
Now, whenever I try to download Wartales using the Drop Client, it throws error periodically and the download never finishes. I can see the CPU usage spike up as it tries to unzip. I am thinking it breaks somewhere in between decompression and transferring the files to the Client PC.
If I give Drop the raw Wartales Folder that is 47GB, it downloads perfectly fine.
@DecDuck commented on GitHub (Aug 29, 2025):
Can you upload the zip somewhere? Zip, as a format, is very very annoying and Drop doesn't support the couple dozen or so decompression methods that are available as part of the Zip format. 47GB->16GB sounds like it's not using the standard DEFLATE decompression method, which is the only one we support yet.
If the zip is using other compression methods, this'll become an issue for https://github.com/Drop-OSS/droplet.
@seamon67 commented on GitHub (Aug 29, 2025):
I think that's likely the issue. I have moved to putting Games directly as folders but maybe using Store Compression Settings in WinZip which just stores the files as a zip file without any compression is the way to go.
@MonkaKokosowa commented on GitHub (Aug 29, 2025):
I will try to prepare a zip I can share publicly and upload it today
I don't know how it was with others, but all my zips were compressed with standard
zip -r game.zip ./game/.command. When I can I'm gonna check what method they use.@MonkaKokosowa commented on GitHub (Aug 29, 2025):
I checked the method, it's
Deflate: Normal, also I reproduced the error with a zip I can share. I imported SuperTuxKart archived with my previous method to the server.Here's the link: https://filebin.net/38fc287459frhj7w
Here's the server core dump for this file
@DecDuck commented on GitHub (Aug 29, 2025):
Frustratingly, the issue seems to be intermittent because it's a timeout error:
I can't replicate the server crash though
@MonkaKokosowa commented on GitHub (Aug 30, 2025):
Is there a way to increase the timeout then?
It might really be the issue here, as my server is very much bottlenecked with storage by having remote NFS HDDs mounted on a VPS, so I get around 3mb/s download speeds on the client at best.
Also I'm gonna try later replicating my setup on local SSD to see if the issue persists.
@DecDuck commented on GitHub (Aug 30, 2025):
What kinds of speeds do you get through that off-site NFS share outside of Drop? Drop downloads are probably very random IO heavy, which is why the speeds are so poor. Could probably be worked on.
@seamon67 commented on GitHub (Aug 30, 2025):
I have also never had the Server crash because of this issue.
Also, I have the Drop Server on a fairly high end SSD based ZFS setup and it's pretty much maxing out the network bandwidth.
@DecDuck commented on GitHub (Aug 30, 2025):
So it seems it breaks with high IO latency?
@DecDuck commented on GitHub (Sep 7, 2025):
Those who are experiencing this bug, are you using an NGINX proxy?
@utlilb commented on GitHub (Sep 7, 2025):
Yes I am behind NGINX. If you are thinking timeout settings be aware I've got global timeout settings quite a bit higher than normal because I'm also using Nextcloud behind it.
@DecDuck commented on GitHub (Sep 7, 2025):
We've discovered that this issue is some interaction with NGINX (and maybe other HTTP proxies), which is why it wasn't showing up in development.
From the Discord, here's what works:
But NGINX on another host doing HTTP proxying doesn't.
@MonkaKokosowa commented on GitHub (Sep 8, 2025):
Also, that seems to be unrelated to my error, as I tried to connect over HTTP (using a Tailscale tunnel that's bound to IP in compose) directly to Drop server and I unfortunately get the same error.
On another note sorry for being unresponsive for a while, had a few issues. Though I'm gonna do all the tests today and get back to you.
@MonkaKokosowa commented on GitHub (Sep 8, 2025):
Okay, so I did some testing. First of all, that thing with Drop being slower is not at all the case, the speed is so close the difference is within margins (though it might be the case just because of how slow my env is).
Second, that isn't an issue with .zip archives specifically, but (at least for me) with FlatFilesystem library type as a whole. I unpacked the archives and tried adding them to FlatFilesystem library (the same one as before) and I got the same error as before, but when I did a
mkdir v1 && mv ./* v1/and changed the library to Drop-style it suddenly just worked with no issues.@DecDuck commented on GitHub (Oct 12, 2025):
Sorry, I missed the new messages.
That's really really strange. It should be identical. I'll have to do more testing.
[BUG] Downloading a game .zip archive crashes the Drop serverto [GH-ISSUE #220] [BUG] Downloading a game .zip archive crashes the Drop server