Drop-OSS/drop
1
0
Fork 0
mirror of https://github.com/Drop-OSS/drop.git synced 2026-07-25 04:15:36 -04:00
Code Issues 77 Packages Projects Releases 10 Wiki Activity

[PR #193] [MERGED] Fix broken admin library view if game library contains paths/titles with non-unicode characters #257

New Issue
Closed
opened 2026-02-17 17:06:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-17 17:06:31 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop/pull/193
Author: @FurbyOnSteroids
Created: 8/16/2025
Status: ✅ Merged
Merged: 8/16/2025
Merged by: @DecDuck

Base: develop ← Head: fix-non-unicode-titles-in-tasks

📝 Commits (9)

  • e21688f replace btoa with a Buffer implementation, as btoa does not support non-unicode characters.
  • 3b44bbb replace btoa with a Buffer implementation, as btoa does not support non-unicode characters.
  • ca4c01b Merge remote-tracking branch 'origin/fix-non-unicode-titles-in-tasks' into fix-non-unicode-titles-in-tasks
  • e4653b7 fix linting
  • 9cafaf5 fix linting
  • f98b811 replace buffer implementation with a md5 hash. This also adds the ts-md5 library.
  • f94f7e3 Revert "replace buffer implementation with a md5 hash. This also adds the ts-md5 library."
  • 474128e replace buffer implementation with md5 hash from node:crypto
  • 28c745a fix linting.. again

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 server/internal/library/index.ts (+7 -2)

📄 Description

Fixes #192

Btoa does not support non-unicode characters (https://developer.mozilla.org/en-US/docs/Web/API/Window/btoa#unicode_strings).
This replaces btoa with Buffers to convert utf8 to base64.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop/pull/193 **Author:** [@FurbyOnSteroids](https://github.com/FurbyOnSteroids) **Created:** 8/16/2025 **Status:** ✅ Merged **Merged:** 8/16/2025 **Merged by:** [@DecDuck](https://github.com/DecDuck) **Base:** `develop` ← **Head:** `fix-non-unicode-titles-in-tasks` --- ### 📝 Commits (9) - [`e21688f`](https://github.com/Drop-OSS/drop/commit/e21688f14c61f347cd4c8f10f1fbdbd6dd84e59c) replace btoa with a Buffer implementation, as btoa does not support non-unicode characters. - [`3b44bbb`](https://github.com/Drop-OSS/drop/commit/3b44bbb9b77a10fd8d3590f71ff4a2ab9585c19a) replace btoa with a Buffer implementation, as btoa does not support non-unicode characters. - [`ca4c01b`](https://github.com/Drop-OSS/drop/commit/ca4c01b155088a421d0fa83facd9a4b8b7fa27e1) Merge remote-tracking branch 'origin/fix-non-unicode-titles-in-tasks' into fix-non-unicode-titles-in-tasks - [`e4653b7`](https://github.com/Drop-OSS/drop/commit/e4653b776ca14635748dfe8d6ef63d535a95fe91) fix linting - [`9cafaf5`](https://github.com/Drop-OSS/drop/commit/9cafaf5aadf0086ca8cd0666e7013da3fe0b9527) fix linting - [`f98b811`](https://github.com/Drop-OSS/drop/commit/f98b811ab99b9198a3c44fa216b8ee09edc9fab3) replace buffer implementation with a md5 hash. This also adds the ts-md5 library. - [`f94f7e3`](https://github.com/Drop-OSS/drop/commit/f94f7e395016f550b98cec36bcec1de51ef15bfd) Revert "replace buffer implementation with a md5 hash. This also adds the ts-md5 library." - [`474128e`](https://github.com/Drop-OSS/drop/commit/474128e01ecc70c190d41181a71011c64deefa10) replace buffer implementation with md5 hash from node:crypto - [`28c745a`](https://github.com/Drop-OSS/drop/commit/28c745a334895145686e4ad8dd5efac385a526e8) fix linting.. again ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/internal/library/index.ts` (+7 -2) </details> ### 📄 Description Fixes #192 Btoa does not support non-unicode characters (https://developer.mozilla.org/en-US/docs/Web/API/Window/btoa#unicode_strings). This replaces btoa with Buffers to convert utf8 to base64. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:06:31 -05:00
yindo closed this issue 2026-02-17 17:06:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
feature
feature
good first issue
needs-triage
pull-request
Mirrored from GitHub Pull Request
 qol
support
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop#257
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?