[PR #259] [MERGED] Admin home page 128 #278

Closed
opened 2026-02-17 17:06:34 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop/pull/259
Author: @Pacodastre
Created: 10/8/2025
Status: Merged
Merged: 11/7/2025
Merged by: @DecDuck

Base: developHead: admin-home-page-128


📝 Commits (10+)

  • 899d77b First iteration on the new PieChart component
  • ff15287 #128 Adds new admin home page
  • 448110c Fixes code after merging conflicts
  • 9b765cb Removes empty file
  • f00a18e Uses real data for admin home page, and improves style
  • 7ae14ab Reverts debugging code
  • 32172de Defines missing variable
  • 87d1a97 Caches user stats data for admin home page
  • bfe494c Typo
  • a22910e Styles improvements

📊 Changes

40 files changed (+1352 additions, -150 deletions)

View changed files

📝 components/GameEditor/Metadata.vue (+0 -1)
📝 components/GameEditor/Version.vue (+14 -4)
components/Icons/GamepadIcon.vue (+19 -0)
components/PieChart/PieChart.vue (+45 -0)
components/PieChart/PieSlice.vue (+35 -0)
components/PieChart/types.d.ts (+19 -0)
components/PieChart/utils.ts (+50 -0)
components/ProgressBar.vue (+31 -0)
components/RankingList.vue (+43 -0)
components/SourceTable.vue (+193 -0)
components/TileWithLink.vue (+52 -0)
📝 i18n/locales/en_us.json (+29 -3)
📝 layouts/admin.vue (+7 -2)
📝 pages/admin/index.vue (+167 -1)
📝 pages/admin/library/sources/index.vue (+7 -94)
📝 pages/admin/task/[id]/index.vue (+1 -12)
📝 pages/store/[id]/index.vue (+23 -1)
📝 server/api/v1/admin/game/[id]/index.delete.ts (+2 -6)
📝 server/api/v1/admin/game/[id]/index.get.ts (+14 -1)
📝 server/api/v1/admin/game/version/index.delete.ts (+2 -10)

...and 20 more files

📄 Description

This is what the new page looks like (style could be greatly improved here).

Screenshot 2025-10-08 at 17-16-39 Home - Admin - Drop

Some notes about this PR:

  • I refactored the sources table into its own component and modified it to add it to this page. Note that the table on the admin home page doesn't have edit/delete actions.
  • I added a new function on the file system providers fsStats which returns file system info for the base directory in the configuration of that provider.
  • The tooltip on the pie chart doesn't work properly. This is due to the fact that the component uses absolute/relative positioning for the link in the bottom right of the tile. I tried playing with the values a bit, but couldn't get it working properly. So either the tooltip will need to work differently, or the absolute/relative positioning needs to be removed from the tile component.
  • the pie chart svg uses absolute coordinates (rather than relative coordinates). I don't think it matters, but just wanted to point it out.
  • I still need to do a little bit of refactoring.

Here's what the sources page looks like now:

Screenshot 2025-10-08 at 17-17-00 Library Sources - Admin - Drop

Let me know what you want me to improve.

Fixes #128


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop/pull/259 **Author:** [@Pacodastre](https://github.com/Pacodastre) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@DecDuck](https://github.com/DecDuck) **Base:** `develop` ← **Head:** `admin-home-page-128` --- ### 📝 Commits (10+) - [`899d77b`](https://github.com/Drop-OSS/drop/commit/899d77b78874afec8273dc50762a9a51550a0957) First iteration on the new PieChart component - [`ff15287`](https://github.com/Drop-OSS/drop/commit/ff152876f905128f8712bf5482f53c3ddfc7ffea) #128 Adds new admin home page - [`448110c`](https://github.com/Drop-OSS/drop/commit/448110c3bab7e73976cd78f9a29f2edf43be2f11) Fixes code after merging conflicts - [`9b765cb`](https://github.com/Drop-OSS/drop/commit/9b765cbcb672497c734ab51dd94de8464e131df3) Removes empty file - [`f00a18e`](https://github.com/Drop-OSS/drop/commit/f00a18eb40406bba70bcb6292daf0daf2b011f10) Uses real data for admin home page, and improves style - [`7ae14ab`](https://github.com/Drop-OSS/drop/commit/7ae14ab094c1c577cdc2d992decbf4090a119e22) Reverts debugging code - [`32172de`](https://github.com/Drop-OSS/drop/commit/32172dee6cba2a6501aa8a9d6829d58202d86989) Defines missing variable - [`87d1a97`](https://github.com/Drop-OSS/drop/commit/87d1a972bc12b1e2183b6c9efd5d448db5b7e7ed) Caches user stats data for admin home page - [`bfe494c`](https://github.com/Drop-OSS/drop/commit/bfe494cd3e4a83fa11192e584fbb5a7ff48ea36e) Typo - [`a22910e`](https://github.com/Drop-OSS/drop/commit/a22910ee877bb32030783fe1ac396a37d6ee7251) Styles improvements ### 📊 Changes **40 files changed** (+1352 additions, -150 deletions) <details> <summary>View changed files</summary> 📝 `components/GameEditor/Metadata.vue` (+0 -1) 📝 `components/GameEditor/Version.vue` (+14 -4) ➕ `components/Icons/GamepadIcon.vue` (+19 -0) ➕ `components/PieChart/PieChart.vue` (+45 -0) ➕ `components/PieChart/PieSlice.vue` (+35 -0) ➕ `components/PieChart/types.d.ts` (+19 -0) ➕ `components/PieChart/utils.ts` (+50 -0) ➕ `components/ProgressBar.vue` (+31 -0) ➕ `components/RankingList.vue` (+43 -0) ➕ `components/SourceTable.vue` (+193 -0) ➕ `components/TileWithLink.vue` (+52 -0) 📝 `i18n/locales/en_us.json` (+29 -3) 📝 `layouts/admin.vue` (+7 -2) 📝 `pages/admin/index.vue` (+167 -1) 📝 `pages/admin/library/sources/index.vue` (+7 -94) 📝 `pages/admin/task/[id]/index.vue` (+1 -12) 📝 `pages/store/[id]/index.vue` (+23 -1) 📝 `server/api/v1/admin/game/[id]/index.delete.ts` (+2 -6) 📝 `server/api/v1/admin/game/[id]/index.get.ts` (+14 -1) 📝 `server/api/v1/admin/game/version/index.delete.ts` (+2 -10) _...and 20 more files_ </details> ### 📄 Description This is what the new page looks like (style could be greatly improved here). <img width="1624" height="1064" alt="Screenshot 2025-10-08 at 17-16-39 Home - Admin - Drop" src="https://github.com/user-attachments/assets/1c1457f0-93aa-4030-9b4a-4eec264cb060" /> Some notes about this PR: - I refactored the sources table into its own component and modified it to add it to this page. Note that the table on the admin home page doesn't have edit/delete actions. - I added a new function on the file system providers `fsStats` which returns file system info for the base directory in the configuration of that provider. - The tooltip on the pie chart doesn't work properly. This is due to the fact that the <TileWithLink /> component uses absolute/relative positioning for the link in the bottom right of the tile. I tried playing with the values a bit, but couldn't get it working properly. So either the tooltip will need to work differently, or the absolute/relative positioning needs to be removed from the tile component. - the pie chart svg uses absolute coordinates (rather than relative coordinates). I don't think it matters, but just wanted to point it out. - I still need to do a little bit of refactoring. Here's what the sources page looks like now: <img width="1624" height="1064" alt="Screenshot 2025-10-08 at 17-17-00 Library Sources - Admin - Drop" src="https://github.com/user-attachments/assets/3e8ff8d6-5e83-4a3f-9596-8297e35d73e7" /> Let me know what you want me to improve. Fixes #128 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:06:34 -05:00
yindo closed this issue 2026-02-17 17:06:34 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop#278