[PR #289] [MERGED] Internal server error fixes, 7z fixes, etc #286

Closed
opened 2026-02-17 17:06:35 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop/pull/289
Author: @DecDuck
Created: 11/21/2025
Status: Merged
Merged: 11/30/2025
Merged by: @DecDuck

Base: developHead: small-fixes


📝 Commits (9)

📊 Changes

29 files changed (+238 additions, -140 deletions)

View changed files

📝 components/NotificationItem.vue (+4 -1)
📝 components/UserHeader/NotificationWidgetPanel.vue (+4 -1)
📝 composables/notifications.ts (+6 -2)
📝 eslint.config.mjs (+5 -0)
📝 i18n/locales/en_us.json (+1 -0)
📝 package.json (+1 -1)
📝 pages/account/notifications.vue (+42 -29)
📝 pages/admin/settings.vue (+5 -5)
📝 pnpm-lock.yaml (+45 -45)
rules/no-prisma-delete.mts (+34 -0)
📝 server/api/v1/admin/auth/invitation/index.delete.ts (+5 -1)
📝 server/api/v1/admin/game/[id]/index.delete.ts (+1 -1)
📝 server/api/v1/admin/library/sources/index.delete.ts (+3 -1)
📝 server/api/v1/admin/token/[id]/index.delete.ts (+2 -2)
📝 server/api/v1/admin/users/[id]/index.delete.ts (+1 -0)
📝 server/api/v1/auth/signup/simple.post.ts (+1 -1)
📝 server/api/v1/client/saves/[gameid]/[slotindex]/index.delete.ts (+5 -7)
📝 server/api/v1/notifications/[id]/index.delete.ts (+2 -2)
server/api/v1/notifications/clear.post.ts (+25 -0)
📝 server/api/v1/user/token/[id]/index.delete.ts (+2 -2)

...and 9 more files

📄 Description

  • Adds drop/no-prisma-delete lint to prevent using the .delete() function, which is error prone (it throws if the record doesn't exist)
  • Updates droplet to fix the performance issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop/pull/289 **Author:** [@DecDuck](https://github.com/DecDuck) **Created:** 11/21/2025 **Status:** ✅ Merged **Merged:** 11/30/2025 **Merged by:** [@DecDuck](https://github.com/DecDuck) **Base:** `develop` ← **Head:** `small-fixes` --- ### 📝 Commits (9) - [`650a3ca`](https://github.com/Drop-OSS/drop/commit/650a3ca98d306dfd79a84ce1f4db4d5f928f0c09) fix: add no-prisma-delete lint - [`2d165bf`](https://github.com/Drop-OSS/drop/commit/2d165bf99794860d8d1867beae55395c2eaf5830) fix: typescript for lint - [`b0bf1a2`](https://github.com/Drop-OSS/drop/commit/b0bf1a27955f18bda8360626ce159a864da0b0e7) fix: bump droplet - [`b842d78`](https://github.com/Drop-OSS/drop/commit/b842d78b947add541ab630bb9d761e1b9343de9c) fix: oidc scopes override - [`bcb88f8`](https://github.com/Drop-OSS/drop/commit/bcb88f8069426de191535ccdd2eb856086efec75) fix: type errors - [`973c3ef`](https://github.com/Drop-OSS/drop/commit/973c3efa18585ec19f9cd633fd9e2e59761e3f02) Merge branch 'develop' into small-fixes - [`e230f79`](https://github.com/Drop-OSS/drop/commit/e230f79b549b6324016f684f849f7793897befcb) feat: delete all notifications - [`1e7ed34`](https://github.com/Drop-OSS/drop/commit/1e7ed34a60ec36fed2a2b9d134c89ccf69929ff3) fix: lint - [`c0b6904`](https://github.com/Drop-OSS/drop/commit/c0b69048cf37066ca07543d0e4ee2a35125db3a0) fix: light mode style fixes ### 📊 Changes **29 files changed** (+238 additions, -140 deletions) <details> <summary>View changed files</summary> 📝 `components/NotificationItem.vue` (+4 -1) 📝 `components/UserHeader/NotificationWidgetPanel.vue` (+4 -1) 📝 `composables/notifications.ts` (+6 -2) 📝 `eslint.config.mjs` (+5 -0) 📝 `i18n/locales/en_us.json` (+1 -0) 📝 `package.json` (+1 -1) 📝 `pages/account/notifications.vue` (+42 -29) 📝 `pages/admin/settings.vue` (+5 -5) 📝 `pnpm-lock.yaml` (+45 -45) ➕ `rules/no-prisma-delete.mts` (+34 -0) 📝 `server/api/v1/admin/auth/invitation/index.delete.ts` (+5 -1) 📝 `server/api/v1/admin/game/[id]/index.delete.ts` (+1 -1) 📝 `server/api/v1/admin/library/sources/index.delete.ts` (+3 -1) 📝 `server/api/v1/admin/token/[id]/index.delete.ts` (+2 -2) 📝 `server/api/v1/admin/users/[id]/index.delete.ts` (+1 -0) 📝 `server/api/v1/auth/signup/simple.post.ts` (+1 -1) 📝 `server/api/v1/client/saves/[gameid]/[slotindex]/index.delete.ts` (+5 -7) 📝 `server/api/v1/notifications/[id]/index.delete.ts` (+2 -2) ➕ `server/api/v1/notifications/clear.post.ts` (+25 -0) 📝 `server/api/v1/user/token/[id]/index.delete.ts` (+2 -2) _...and 9 more files_ </details> ### 📄 Description - Adds `drop/no-prisma-delete` lint to prevent using the .delete() function, which is error prone (it throws if the record doesn't exist) - Updates droplet to fix the performance issues --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:06:35 -05:00
yindo closed this issue 2026-02-17 17:06:35 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop#286