Drop-OSS/drop
1
0
Fork 0
mirror of https://github.com/Drop-OSS/drop.git synced 2026-07-25 12:25:31 -04:00
Code Issues 77 Packages Projects Releases 10 Wiki Activity

[PR #301] [MERGED] Adds new tile on the admin home page with system data. #296

New Issue
Closed
opened 2026-02-17 17:06:36 -05:00 by yindo · 0 comments
yindo commented 2026-02-17 17:06:36 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop/pull/301
Author: @Pacodastre
Created: 12/4/2025
Status: ✅ Merged
Merged: 1/21/2026
Merged by: @DecDuck

Base: develop ← Head: system-data-tile-on-admin-home-page

📝 Commits (8)

  • dfb7296 Adds new tile on the admin home page with system data. Also fixes the active users bug in the pie chart
  • 2e2249c Fixes missing parentheses
  • a13ed5a Updates user stats cache when signing in
  • c7c7664 Reads active number of users from session provider
  • c0a7805 Removes unused variable
  • bb2b149 Small improvements
  • a690099 Removes acl properties from system data websocket and performs initial push of data
  • 7ff05e5 fix: remove acl fetch

📊 Changes

18 files changed (+243 additions, -23 deletions)

View changed files

📝 components/PieChart/PieChart.vue (+1 -1)
📝 components/SourceTable.vue (+3 -5)
➕ composables/admin-home.ts (+21 -0)
📝 i18n/locales/en_us.json (+4 -0)
📝 pages/admin/index.vue (+59 -0)
➕ server/api/v1/admin/system-data/ws.get.ts (+36 -0)
📝 server/api/v1/auth/odic/callback.get.ts (+2 -0)
📝 server/internal/acls/descriptions.ts (+5 -0)
📝 server/internal/acls/index.ts (+4 -0)
📝 server/internal/notifications/index.ts (+2 -2)
📝 server/internal/session/cache.ts (+5 -0)
📝 server/internal/session/db.ts (+16 -0)
📝 server/internal/session/index.ts (+8 -2)
📝 server/internal/session/memory.ts (+9 -0)
📝 server/internal/session/types.d.ts (+1 -0)
➕ server/internal/system-data/index.ts (+58 -0)
📝 server/internal/userstats/index.ts (+2 -13)
➕ utils/utils.ts (+7 -0)

📄 Description

Also fixes the active users bug in the pie chart.

Two things to note here:

  • at least when running pnpm dev, the progress bars for cpu and ram usage don't load properly at first, but work fine after a few seconds.
  • some error appears in the terminal intermittently. It might be related the websocket being disconnected/reconnected, i'm not 100% sure.
ERROR  [unhandledRejection] Failed to catch-up listener: callback does not exist
    at Object.catchupListener (.nuxt/dev/index.mjs:1:381909)
    at Timeout._onTimeout (.nuxt/dev/index.mjs:1:382028)
    at listOnTimeout (node:internal/timers:608:17)
    at process.processTimers (node:internal/timers:543:7)
userId:  8e03afaf-15d5-4eab-9be8-ae59eaa3a352
id:  3395e664-da84-4709-a1d9-0792789862d0
listers:  Map(1) {
  '8e03afaf-15d5-4eab-9be8-ae59eaa3a352' => Map(1) {
    '3340736d-f8f2-4b62-b70a-a56a8970c992' => { callback: [Function (anonymous)], acls: [Array] } } }

Here's a screenshot the update:

Screenshot From 2025-12-05 00-08-55

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop/pull/301 **Author:** [@Pacodastre](https://github.com/Pacodastre) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 1/21/2026 **Merged by:** [@DecDuck](https://github.com/DecDuck) **Base:** `develop` ← **Head:** `system-data-tile-on-admin-home-page` --- ### 📝 Commits (8) - [`dfb7296`](https://github.com/Drop-OSS/drop/commit/dfb729600fcd2f9caecc3b94757b15762f328d03) Adds new tile on the admin home page with system data. Also fixes the active users bug in the pie chart - [`2e2249c`](https://github.com/Drop-OSS/drop/commit/2e2249cc76da420020023a18f54346ab6da88e26) Fixes missing parentheses - [`a13ed5a`](https://github.com/Drop-OSS/drop/commit/a13ed5a2a00fef8314eb566c0e233ca58b58fb1d) Updates user stats cache when signing in - [`c7c7664`](https://github.com/Drop-OSS/drop/commit/c7c766488b284d059a8a6fb247c2dc4092cf5362) Reads active number of users from session provider - [`c0a7805`](https://github.com/Drop-OSS/drop/commit/c0a78052941352838972c9873e90b087f8e8ae27) Removes unused variable - [`bb2b149`](https://github.com/Drop-OSS/drop/commit/bb2b149b10a2a231c4f3be9dc47d821f9f6fb5d7) Small improvements - [`a690099`](https://github.com/Drop-OSS/drop/commit/a6900995d8a698ac342bdf3d6765814e9b98d10a) Removes acl properties from system data websocket and performs initial push of data - [`7ff05e5`](https://github.com/Drop-OSS/drop/commit/7ff05e571ef8f0cba47f409cb2d91068d8ef8894) fix: remove acl fetch ### 📊 Changes **18 files changed** (+243 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `components/PieChart/PieChart.vue` (+1 -1) 📝 `components/SourceTable.vue` (+3 -5) ➕ `composables/admin-home.ts` (+21 -0) 📝 `i18n/locales/en_us.json` (+4 -0) 📝 `pages/admin/index.vue` (+59 -0) ➕ `server/api/v1/admin/system-data/ws.get.ts` (+36 -0) 📝 `server/api/v1/auth/odic/callback.get.ts` (+2 -0) 📝 `server/internal/acls/descriptions.ts` (+5 -0) 📝 `server/internal/acls/index.ts` (+4 -0) 📝 `server/internal/notifications/index.ts` (+2 -2) 📝 `server/internal/session/cache.ts` (+5 -0) 📝 `server/internal/session/db.ts` (+16 -0) 📝 `server/internal/session/index.ts` (+8 -2) 📝 `server/internal/session/memory.ts` (+9 -0) 📝 `server/internal/session/types.d.ts` (+1 -0) ➕ `server/internal/system-data/index.ts` (+58 -0) 📝 `server/internal/userstats/index.ts` (+2 -13) ➕ `utils/utils.ts` (+7 -0) </details> ### 📄 Description Also fixes the active users bug in the pie chart. Two things to note here: - at least when running `pnpm dev`, the progress bars for cpu and ram usage don't load properly at first, but work fine after a few seconds. - some error appears in the terminal intermittently. It might be related the websocket being disconnected/reconnected, i'm not 100% sure. ``` ERROR [unhandledRejection] Failed to catch-up listener: callback does not exist at Object.catchupListener (.nuxt/dev/index.mjs:1:381909) at Timeout._onTimeout (.nuxt/dev/index.mjs:1:382028) at listOnTimeout (node:internal/timers:608:17) at process.processTimers (node:internal/timers:543:7) userId: 8e03afaf-15d5-4eab-9be8-ae59eaa3a352 id: 3395e664-da84-4709-a1d9-0792789862d0 listers: Map(1) { '8e03afaf-15d5-4eab-9be8-ae59eaa3a352' => Map(1) { '3340736d-f8f2-4b62-b70a-a56a8970c992' => { callback: [Function (anonymous)], acls: [Array] } } } ``` Here's a screenshot the update: <img width="2630" height="1564" alt="Screenshot From 2025-12-05 00-08-55" src="https://github.com/user-attachments/assets/4a683a90-de7c-49b4-8a39-68828961e5de" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:06:36 -05:00
yindo closed this issue 2026-02-17 17:06:36 -05:00
yindo changed title from [PR #301] [MERGED] Adds new tile on the admin home page with system data. to [PR #301] [MERGED] Adds new tile on the admin home page with system data. 2026-06-05 14:22:24 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
feature
feature
good first issue
needs-triage
pull-request
Mirrored from GitHub Pull Request
 qol
support
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop#296
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?