[PR #304] [MERGED] Add ODIC Back-Channel Logout #299

Closed
opened 2026-02-17 17:06:36 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop/pull/304
Author: @Huskydog9988
Created: 1/3/2026
Status: Merged
Merged: 1/19/2026
Merged by: @DecDuck

Base: developHead: oidc-logout


📝 Commits (10+)

  • b7887ec prevent returning expired sessions
  • ba959a7 add issuer to ODIC creds
  • 1b4c362 get id token in ODIC
  • 54cdf28 make session signin return session
  • 9e69ac8 working backchannel logout?
  • 97e0d12 require https for ODIC provider
  • d7abc99 handle wellknown not being https
  • 026dfe6 find session api progress
  • 5573a12 fix windows build
  • a165088 return session token on session

📊 Changes

18 files changed (+709 additions, -114 deletions)

View changed files

📝 .prettierignore (+2 -0)
📝 eslint.config.mjs (+3 -0)
📝 nuxt.config.ts (+8 -7)
📝 package.json (+2 -1)
📝 pnpm-lock.yaml (+8 -3)
📝 pnpm-workspace.yaml (+2 -2)
📝 server/api/v1/auth/odic/callback.get.ts (+17 -4)
server/api/v1/auth/odic/logout.post.ts (+46 -0)
📝 server/api/v1/auth/passkey/finish.post.ts (+3 -1)
📝 server/api/v1/auth/signin/simple.post.ts (+8 -11)
📝 server/internal/auth/index.ts (+1 -1)
📝 server/internal/auth/oidc/index.ts (+283 -48)
📝 server/internal/config/sys-conf.ts (+19 -2)
📝 server/internal/session/cache.ts (+52 -6)
📝 server/internal/session/db.ts (+109 -8)
📝 server/internal/session/index.ts (+68 -12)
📝 server/internal/session/memory.ts (+47 -6)
📝 server/internal/session/types.d.ts (+31 -2)

📄 Description

Let an ODIC provider sign out users. Also attempted to make the server more spec compliant by verifying responses and enforcing HTTPS for providers by default.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop/pull/304 **Author:** [@Huskydog9988](https://github.com/Huskydog9988) **Created:** 1/3/2026 **Status:** ✅ Merged **Merged:** 1/19/2026 **Merged by:** [@DecDuck](https://github.com/DecDuck) **Base:** `develop` ← **Head:** `oidc-logout` --- ### 📝 Commits (10+) - [`b7887ec`](https://github.com/Drop-OSS/drop/commit/b7887ecd89eab96ef23ad71d0cc9d15902e8ba1f) prevent returning expired sessions - [`ba959a7`](https://github.com/Drop-OSS/drop/commit/ba959a7323641b4db80f1f831eb970bf8d6e4aec) add issuer to ODIC creds - [`1b4c362`](https://github.com/Drop-OSS/drop/commit/1b4c362de6cfbe09c2974f3dc810d5c44448c64d) get id token in ODIC - [`54cdf28`](https://github.com/Drop-OSS/drop/commit/54cdf28d08d6a2b7bb8eee5b26eec90b71d96474) make session signin return session - [`9e69ac8`](https://github.com/Drop-OSS/drop/commit/9e69ac80092bb5a9fb186f3002169ff9ea37c332) working backchannel logout? - [`97e0d12`](https://github.com/Drop-OSS/drop/commit/97e0d12132e40fc1ffe24c4ef46c21155c6e56f4) require https for ODIC provider - [`d7abc99`](https://github.com/Drop-OSS/drop/commit/d7abc9976aa9378187fe9b263edae6faa8387d14) handle wellknown not being https - [`026dfe6`](https://github.com/Drop-OSS/drop/commit/026dfe6301bf3858cca3bacebfac2377a3928699) find session api progress - [`5573a12`](https://github.com/Drop-OSS/drop/commit/5573a1286d8fd8489529d2497993649105f683bf) fix windows build - [`a165088`](https://github.com/Drop-OSS/drop/commit/a165088cb180816f97fcf3865799f1d6e08c6f75) return session token on session ### 📊 Changes **18 files changed** (+709 additions, -114 deletions) <details> <summary>View changed files</summary> 📝 `.prettierignore` (+2 -0) 📝 `eslint.config.mjs` (+3 -0) 📝 `nuxt.config.ts` (+8 -7) 📝 `package.json` (+2 -1) 📝 `pnpm-lock.yaml` (+8 -3) 📝 `pnpm-workspace.yaml` (+2 -2) 📝 `server/api/v1/auth/odic/callback.get.ts` (+17 -4) ➕ `server/api/v1/auth/odic/logout.post.ts` (+46 -0) 📝 `server/api/v1/auth/passkey/finish.post.ts` (+3 -1) 📝 `server/api/v1/auth/signin/simple.post.ts` (+8 -11) 📝 `server/internal/auth/index.ts` (+1 -1) 📝 `server/internal/auth/oidc/index.ts` (+283 -48) 📝 `server/internal/config/sys-conf.ts` (+19 -2) 📝 `server/internal/session/cache.ts` (+52 -6) 📝 `server/internal/session/db.ts` (+109 -8) 📝 `server/internal/session/index.ts` (+68 -12) 📝 `server/internal/session/memory.ts` (+47 -6) 📝 `server/internal/session/types.d.ts` (+31 -2) </details> ### 📄 Description Let an ODIC provider sign out users. Also attempted to make the server more spec compliant by verifying responses and enforcing HTTPS for providers by default. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:06:36 -05:00
yindo closed this issue 2026-02-17 17:06:36 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop#299