Drop-OSS/drop
1
0
Fork 0
mirror of https://github.com/Drop-OSS/drop.git synced 2026-07-25 04:15:36 -04:00
Code Issues 77 Packages Projects Releases 10 Wiki Activity

[PR #323] [MERGED] Game specialisation #307

New Issue
Closed
opened 2026-02-17 17:06:37 -05:00 by yindo · 0 comments
yindo commented 2026-02-17 17:06:37 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop/pull/323
Author: @DecDuck
Created: 1/19/2026
Status: ✅ Merged
Merged: 1/23/2026
Merged by: @DecDuck

Base: develop ← Head: game-specialisation

📝 Commits (10+)

📊 Changes

46 files changed (+1164 additions, -347 deletions)

View changed files

📝 .vscode/settings.json (+1 -1)
📝 components/ExecutorWidget.vue (+1 -1)
📝 components/GameEditor/VersionConfig.vue (+3 -6)
📝 components/GameSearchResultWidget.vue (+6 -2)
📝 components/ImportVersionLaunchRow.vue (+60 -5)
📝 components/Modal/AddCompanyGame.vue (+3 -1)
📝 components/Modal/SelectLaunch.vue (+22 -22)
➕ components/Selector/FileExtension.vue (+118 -0)
📝 components/Selector/Game.vue (+4 -5)
📝 error.vue (+0 -5)
📝 nuxt.config.ts (+1 -0)
📝 package.json (+1 -0)
📝 pages/admin/library/[id]/import.vue (+105 -63)
📝 pages/admin/library/import.vue (+57 -1)
📝 pages/admin/library/index.vue (+5 -1)
📝 pnpm-lock.yaml (+32 -107)
➕ prisma/migrations/20260119070859_add_game_type/migration.sql (+17 -0)
➕ prisma/migrations/20260119123507_update_game_version/migration.sql (+64 -0)
➕ prisma/migrations/20260119132823_add_executor_suggestions/migration.sql (+14 -0)
➕ prisma/migrations/20260122002153_add_unimported_game_version/migration.sql (+27 -0)

...and 26 more files

📄 Description

Adds 3 types of game "specialisation":

  • Game: to be played
  • Executor: emulators
  • Redistributable: to be install

Under the hood, games are all the same object with the same schema. We enforce specialisation-specific options currently during import, so we may get corrupted state if changes are made without the necessary checks.

I think there is significant enough overlap in the required APIs and interfaces that it's worth it to just tag games rather than make them separate models, despite the relative unsafety with no type-safety when it comes to valid database objects.

Current specialisation differences:

  • Executor: launch configurations can have "executorSuggestions", which are file extensions to auto-guess valid commands for "Game"s
  • Game: launch configurations can have executors

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop/pull/323 **Author:** [@DecDuck](https://github.com/DecDuck) **Created:** 1/19/2026 **Status:** ✅ Merged **Merged:** 1/23/2026 **Merged by:** [@DecDuck](https://github.com/DecDuck) **Base:** `develop` ← **Head:** `game-specialisation` --- ### 📝 Commits (10+) - [`0669a5c`](https://github.com/Drop-OSS/drop/commit/0669a5c304e864ef25668a591f9c87414ef84c30) feat: game specialisation, auto-guess extensions - [`1ad6989`](https://github.com/Drop-OSS/drop/commit/1ad6989e55dd63ab499855173d64e046b73b8b07) fix: enforce specialisation specific schema at API level - [`0356de7`](https://github.com/Drop-OSS/drop/commit/0356de77c929e08930e151bc49375f80aed74990) fix: lint - [`93eeb50`](https://github.com/Drop-OSS/drop/commit/93eeb50bd540d16325abb8ddaaafe82cef4c4813) feat: partial work on depot endpoints - [`9ddcb7e`](https://github.com/Drop-OSS/drop/commit/9ddcb7e22d6ba61ca179d8bf1b5c95eb7393dece) feat: bump torrential - [`2eefc1e`](https://github.com/Drop-OSS/drop/commit/2eefc1e942440aaa5b7b5c775003ecee945cac41) Merge branch 'develop' of https://github.com/Drop-OSS/drop into game-specialisation - [`c5f2f18`](https://github.com/Drop-OSS/drop/commit/c5f2f18b6e06c855efd3e5961685a543d5929b8e) feat: dummy version creation for depot uploads - [`f03532f`](https://github.com/Drop-OSS/drop/commit/f03532f845a375b13d98f83201753f0d4166b222) fix: lint - [`8afe905`](https://github.com/Drop-OSS/drop/commit/8afe9057ee329c2bb44bff4a7ce589de295847d8) fix: types - [`e5b659a`](https://github.com/Drop-OSS/drop/commit/e5b659a6196760773436b887aba9f71623ec4fc4) fix: lint ### 📊 Changes **46 files changed** (+1164 additions, -347 deletions) <details> <summary>View changed files</summary> 📝 `.vscode/settings.json` (+1 -1) 📝 `components/ExecutorWidget.vue` (+1 -1) 📝 `components/GameEditor/VersionConfig.vue` (+3 -6) 📝 `components/GameSearchResultWidget.vue` (+6 -2) 📝 `components/ImportVersionLaunchRow.vue` (+60 -5) 📝 `components/Modal/AddCompanyGame.vue` (+3 -1) 📝 `components/Modal/SelectLaunch.vue` (+22 -22) ➕ `components/Selector/FileExtension.vue` (+118 -0) 📝 `components/Selector/Game.vue` (+4 -5) 📝 `error.vue` (+0 -5) 📝 `nuxt.config.ts` (+1 -0) 📝 `package.json` (+1 -0) 📝 `pages/admin/library/[id]/import.vue` (+105 -63) 📝 `pages/admin/library/import.vue` (+57 -1) 📝 `pages/admin/library/index.vue` (+5 -1) 📝 `pnpm-lock.yaml` (+32 -107) ➕ `prisma/migrations/20260119070859_add_game_type/migration.sql` (+17 -0) ➕ `prisma/migrations/20260119123507_update_game_version/migration.sql` (+64 -0) ➕ `prisma/migrations/20260119132823_add_executor_suggestions/migration.sql` (+14 -0) ➕ `prisma/migrations/20260122002153_add_unimported_game_version/migration.sql` (+27 -0) _...and 26 more files_ </details> ### 📄 Description Adds 3 types of game "specialisation": - Game: to be played - Executor: emulators - Redistributable: to be install Under the hood, games are all the same object with the same schema. We enforce specialisation-specific options currently **during import**, so we may get corrupted state if changes are made without the necessary checks. I think there is significant enough overlap in the required APIs and interfaces that it's worth it to just tag games rather than make them separate models, despite the relative unsafety with no type-safety when it comes to valid database objects. Current specialisation differences: - Executor: launch configurations can have "executorSuggestions", which are file extensions to auto-guess valid commands for "Game"s - Game: launch configurations can have executors --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-17 17:06:37 -05:00
yindo closed this issue 2026-02-17 17:06:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
duplicate
feature
feature
good first issue
needs-triage
pull-request
Mirrored from GitHub Pull Request
 qol
support
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/drop#307
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?