[PR #347] [CLOSED] Adds some rules to exclude invalid images #329

New Issue

2026-02-17T17:06:40-05:00

yindo commented

2026-02-17 17:06:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/Drop-OSS/drop/pull/347
Author: @Pacodastre
Created: 2/8/2026
Status: ❌ Closed

Base: develop ← Head: only-accept-valid-images-for-upload

📝 Commits (1)

3eaaf1c Adds some rules to exclude invalid images

📊 Changes

11 files changed (+116 additions, -32 deletions)

View changed files

📝 components/GameEditor/Metadata.vue (+14 -4)
📝 components/Modal/UploadFile.vue (+6 -1)
📝 components/NewsArticleCreateButton.vue (+6 -2)
📝 pnpm-lock.yaml (+5 -5)
📝 server/api/v1/admin/company/[id]/banner.post.ts (+17 -4)
📝 server/api/v1/admin/company/[id]/icon.post.ts (+12 -3)
📝 server/api/v1/admin/game/[id]/metadata.post.ts (+5 -3)
📝 server/api/v1/admin/game/image/index.post.ts (+4 -2)
📝 server/api/v1/admin/news/index.post.ts (+9 -7)
📝 server/api/v1/admin/settings/logo.post.ts (+9 -1)
➕ server/internal/mimetypes.ts (+29 -0)

📄 Description

I changed some statusMessage to message in the files I touched. Let me know if I shouldn't have done that.
It shows an error message when a file is not a valid image
I fixed a minor bug in the game logo upload. If an invalid image was selected, then saved. Upon reopening the modal to upload the logo, the image used to appear broken as it was trying to render the previous invalid image. This is fixed by not updating the logo if it's not valid.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Drop-OSS/drop/pull/347 **Author:** [@Pacodastre](https://github.com/Pacodastre) **Created:** 2/8/2026 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `only-accept-valid-images-for-upload` --- ### 📝 Commits (1) - [`3eaaf1c`](https://github.com/Drop-OSS/drop/commit/3eaaf1cce6b38740a358463b0508c9ae8658301c) Adds some rules to exclude invalid images ### 📊 Changes **11 files changed** (+116 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `components/GameEditor/Metadata.vue` (+14 -4) 📝 `components/Modal/UploadFile.vue` (+6 -1) 📝 `components/NewsArticleCreateButton.vue` (+6 -2) 📝 `pnpm-lock.yaml` (+5 -5) 📝 `server/api/v1/admin/company/[id]/banner.post.ts` (+17 -4) 📝 `server/api/v1/admin/company/[id]/icon.post.ts` (+12 -3) 📝 `server/api/v1/admin/game/[id]/metadata.post.ts` (+5 -3) 📝 `server/api/v1/admin/game/image/index.post.ts` (+4 -2) 📝 `server/api/v1/admin/news/index.post.ts` (+9 -7) 📝 `server/api/v1/admin/settings/logo.post.ts` (+9 -1) ➕ `server/internal/mimetypes.ts` (+29 -0) </details> ### 📄 Description I changed some `statusMessage` to `message` in the files I touched. Let me know if I shouldn't have done that. It shows an error message when a file is not a valid image I fixed a minor bug in the game logo upload. If an invalid image was selected, then saved. Upon reopening the modal to upload the logo, the image used to appear broken as it was trying to render the previous invalid image. This is fixed by not updating the logo if it's not valid. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-17 17:06:40 -05:00

yindo referenced this issue

2026-06-05 14:21:50 -04:00

[GH-ISSUE #329] Feature Request: Add dedicated "Edition" field to Game Metadata #164

yindo changed title from ~~[PR #347] Adds some rules to exclude invalid images~~ to [PR #347] [CLOSED] Adds some rules to exclude invalid images

2026-06-05 14:22:30 -04:00

yindo closed this issue

2026-06-05 14:22:31 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Drop-OSS/drop#329