Drop-OSS/droplet
1
0
Fork 0
mirror of https://github.com/Drop-OSS/droplet.git synced 2026-08-26 22:11:13 -04:00
Code Issues 2 Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #8] Exception/Panic Handling #6

New Issue
Closed
opened 2026-02-17 17:16:14 -05:00 by yindo · 2 comments
yindo commented 2026-02-17 17:16:14 -05:00
Owner
Copy Link
Copy Source

Originally created by @useless-bit on GitHub (Aug 24, 2025).
Original GitHub issue: https://github.com/Drop-OSS/droplet/issues/8

I noticed during testing that an exception/panic in the Rust code (https://github.com/Drop-OSS/droplet/issues/7) will restart the whole application.
A panic while importing multiple big (> 100 GB) versions in parallel will cancel all running tasks that are active.

Maybe it is possible to handle these in the context of the request that triggers it instead of the entire application.
Spring Boot for example will catch the exception in the request context and returns a HTTP 500 error by default. Other requests or background tasks are not affected by it and will continue normally.

Originally created by @useless-bit on GitHub (Aug 24, 2025). Original GitHub issue: https://github.com/Drop-OSS/droplet/issues/8 I noticed during testing that an exception/panic in the Rust code (https://github.com/Drop-OSS/droplet/issues/7) will restart the whole application. A panic while importing multiple big (> 100 GB) versions in parallel will cancel all running tasks that are active. Maybe it is possible to handle these in the context of the request that triggers it instead of the entire application. Spring Boot for example will catch the exception in the request context and returns a HTTP 500 error by default. Other requests or background tasks are not affected by it and will continue normally.
yindo closed this issue 2026-02-17 17:16:14 -05:00
yindo commented 2026-02-17 17:16:14 -05:00
Author
Owner
Copy Link
Copy Source

@DecDuck commented on GitHub (Aug 24, 2025):

We share an "handler object" between all of these for performance & caching reasons. I'm going to move this to droplet because a better solution would be to just not panic.

@DecDuck commented on GitHub (Aug 24, 2025): We share an "handler object" between all of these for performance & caching reasons. I'm going to move this to droplet because a better solution would be to just not panic.
yindo commented 2026-02-17 17:16:14 -05:00
Author
Owner
Copy Link
Copy Source

@DecDuck commented on GitHub (Aug 24, 2025):

Done in 0d01809fd0

@DecDuck commented on GitHub (Aug 24, 2025): Done in 0d01809fd002c09ac6da17cf4c768e6aac6b4e10
yindo changed title from Exception/Panic Handling to [GH-ISSUE #8] Exception/Panic Handling 2026-06-05 14:27:29 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drop-OSS/droplet#6
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?