From de449d2caa1925ea36da33ddc97693fe491877b7 Mon Sep 17 00:00:00 2001 From: MaranBr Date: Fri, 23 Jan 2026 00:23:02 +0100 Subject: [PATCH] [video_core] Fix missing draws caused by implicit render pass state (#3355) Some blit paths could be recorded while a render pass was still active, which is undefined behavior in Vulkan. Depending on driver behavior and timing, this could result in intermittent visual artifacts, incomplete frames being presented, or issues with capture paths. Explicitly request an outside render pass operation context before issuing blit commands, ensuring all rendering has fully completed before presentation or readback. This does not change intended rendering output, but fixes a class of synchronization and command buffer state issues. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3355 Reviewed-by: DraVee Co-authored-by: MaranBr Co-committed-by: MaranBr --- src/video_core/renderer_vulkan/renderer_vulkan.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/video_core/renderer_vulkan/renderer_vulkan.cpp b/src/video_core/renderer_vulkan/renderer_vulkan.cpp index 3b47570a7e..d1e607e75f 100644 --- a/src/video_core/renderer_vulkan/renderer_vulkan.cpp +++ b/src/video_core/renderer_vulkan/renderer_vulkan.cpp @@ -1,4 +1,4 @@ -// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project +// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project // SPDX-License-Identifier: GPL-3.0-or-later // SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project @@ -193,10 +193,13 @@ void RendererVulkan::Composite(std::span framebu RenderScreenshot(framebuffers); Frame* frame = present_manager.GetRenderFrame(); + + scheduler.RequestOutsideRenderPassOperationContext(); blit_swapchain.DrawToFrame(rasterizer, frame, framebuffers, render_window.GetFramebufferLayout(), swapchain.GetImageCount(), swapchain.GetImageViewFormat()); scheduler.Flush(*frame->render_ready); + present_manager.Present(frame); gpu.RendererFrameEndNotify(); @@ -303,6 +306,7 @@ void RendererVulkan::RenderAppletCaptureLayer( VideoCore::Capture::Layout, *applet_frame.image_view, CaptureFormat); } + scheduler.RequestOutsideRenderPassOperationContext(); blit_applet.DrawToFrame(rasterizer, &applet_frame, framebuffers, VideoCore::Capture::Layout, 1, CaptureFormat); }