Emulator-Archive/melonds-ds
1
0
Fork 0
mirror of https://github.com/JesseTG/melonds-ds.git synced 2024-11-23 06:29:46 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Validate the DSi NAND's no$gba footer

Browse Source 
- Fix #63
This commit is contained in:
Jesse Talavera 2024-06-17 19:19:40 -04:00
parent a29c41595a
commit d714a143a2
2 changed files with 53 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
src/libretro/config/constants.cpp
View File

@ -35,18 +35,63 @@ using std::nullopt;
using std::string;
using namespace melonDS;
// We verify the filesize of the NAND image and the presence of the no$gba footer (since melonDS needs it)
bool MelonDsDs::config::IsDsiNandImage(const retro::dirent &file) noexcept {
ZoneScopedN(TracyFunction);
ZoneText(file.path, strnlen(file.path, sizeof(file.path)));
// TODO: Validate the NoCash footer
if (!file.is_regular_file())
return false;
if (find(DSI_NAND_SIZES.begin(), DSI_NAND_SIZES.end(), file.size) == DSI_NAND_SIZES.end())
switch (file.size) {
case DSI_NAND_SIZES_NOFOOTER[0] + NOCASH_FOOTER_SIZE: // 240MB + no$gba footer
case DSI_NAND_SIZES_NOFOOTER[1] + NOCASH_FOOTER_SIZE: // 245.5MB + no$gba footer
case DSI_NAND_SIZES_NOFOOTER[0]: // 240MB
case DSI_NAND_SIZES_NOFOOTER[1]: // 245.5MB
break; // the size is good, let's look for the footer!
default:
return false;
}
RFILE* stream = filestream_open(file.path, RETRO_VFS_FILE_ACCESS_READ, RETRO_VFS_FILE_ACCESS_HINT_NONE);
if (!stream)
return false;
return true;
if (filestream_seek(stream, -static_cast<int64_t>(NOCASH_FOOTER_SIZE), RETRO_VFS_SEEK_POSITION_END) < 0) {
filestream_close(stream);
return false;
}
std::array<uint8_t , NOCASH_FOOTER_SIZE> footer;
if (filestream_read(stream, footer.data(), footer.size()) != NOCASH_FOOTER_SIZE) {
filestream_close(stream);
return false;
}
if (filestream_seek(stream, NOCASH_FOOTER_OFFSET, RETRO_VFS_SEEK_POSITION_START) < 0) {
filestream_close(stream);
return false;
}
std::array<uint8_t , NOCASH_FOOTER_SIZE> unusedArea;
if (filestream_read(stream, unusedArea.data(), unusedArea.size()) != NOCASH_FOOTER_SIZE) {
filestream_close(stream);
return false;
}
filestream_close(stream);
if (memcmp(footer.data(), NOCASH_FOOTER_MAGIC, NOCASH_FOOTER_MAGIC_SIZE) == 0) {
// If the no$gba footer is present at the end of the file and correctly starts with the magic bytes...
return true;
}
if (memcmp(unusedArea.data(), NOCASH_FOOTER_MAGIC, NOCASH_FOOTER_MAGIC_SIZE) == 0) {
// If the no$gba footer is present in a normally-unused section of the DSi NAND, and it starts with the magic bytes...
return true;
}
return false;
}
bool MelonDsDs::config::IsFirmwareImage(const retro::dirent& file, Firmware::FirmwareHeader& header) noexcept {

6
src/libretro/config/constants.hpp
View File

@ -241,7 +241,11 @@ namespace MelonDsDs::config {
static constexpr const char *const UPSIDE_DOWN = "rotate-180";
}
constexpr std::array<size_t, 2> DSI_NAND_SIZES = { 251658304, 257425472 };
constexpr size_t NOCASH_FOOTER_SIZE = 0x40;
constexpr size_t NOCASH_FOOTER_OFFSET = 0xFF800;
constexpr std::array<size_t, 2> DSI_NAND_SIZES_NOFOOTER = { 0xF000000, 0xF580000 }; // Taken from GBATek
constexpr const char *const NOCASH_FOOTER_MAGIC = "DSi eMMC CID/CPU";
constexpr size_t NOCASH_FOOTER_MAGIC_SIZE = 16;
constexpr std::array<size_t, 3> FIRMWARE_SIZES = { 131072, 262144, 524288 };
bool IsDsiNandImage(const retro::dirent &file) noexcept;