Emulator-Archive/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2025-02-19 21:52:45 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Add some texture loading safety checks

Browse Source 
I hit a spurious, non-reproducible debug assert in Archer McLean's Mercury.
Just want to rule out some bad code paths.
This commit is contained in:
Henrik Rydgård 2023-09-06 15:38:47 +02:00
parent a84f08e55e
commit 0aa67e5276
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
GPU/Common/TextureCacheCommon.cpp
View File

@ -2918,6 +2918,7 @@ bool TextureCacheCommon::PrepareBuildTexture(BuildTexturePlan &plan, TexCacheEnt
}
if (plan.isVideo || plan.depth != 1 || plan.decodeToClut8) {
plan.levelsToLoad = 1;
plan.maxPossibleLevels = 1;
} else {
plan.maxPossibleLevels = log2i(std::min(plan.createW, plan.createH)) + 1;

2
GPU/Vulkan/TextureCacheVulkan.cpp
View File

@ -442,6 +442,8 @@ void TextureCacheVulkan::BuildTexture(TexCacheEntry *const entry) {
dstFmt = VULKAN_CLUT8_FORMAT;
}
_dbg_assert_(plan.levelsToLoad <= plan.maxPossibleLevels);
// We don't generate mipmaps for 512x512 textures because they're almost exclusively used for menu backgrounds
// and similar, which don't really need it.
// Also, if using replacements, check that we really can generate mips for this format - that's not possible for compressed ones.